From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5FCDA0528; Fri, 17 Jul 2020 21:09:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E98821BEE6; Fri, 17 Jul 2020 21:09:19 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 23E861BEE1 for ; Fri, 17 Jul 2020 21:09:18 +0200 (CEST) IronPort-SDR: kitxMrzhNKq5RDi0/W/gyqCx/eGThpxb4m8DTsR/Hkik82dr0T4DQNiFbfTqjTbYFtP9MOdqFP SN+N0NfZ8J6g== X-IronPort-AV: E=McAfee;i="6000,8403,9685"; a="151029499" X-IronPort-AV: E=Sophos;i="5.75,364,1589266800"; d="scan'208";a="151029499" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2020 12:09:17 -0700 IronPort-SDR: 5uUhU+jWYEWkNLLofzJ+rHccx2Gj7X6tkNBQHIL2dgPXe4UWKqDufmrGBirkIwouJ3ik7PHZa+ CCp0TQdrnATw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,364,1589266800"; d="scan'208";a="270888945" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by fmsmga008.fm.intel.com with ESMTP; 17 Jul 2020 12:09:17 -0700 Received: from orsmsx151.amr.corp.intel.com (10.22.226.38) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 17 Jul 2020 12:09:17 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX151.amr.corp.intel.com (10.22.226.38) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 17 Jul 2020 12:09:16 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 17 Jul 2020 12:09:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jluvtWjcWMxyJcJI1Vny0s/I5r0L7J4tsa8n1xe0d4QfxHWEES9vBDFa/0ovfbNh+J13Z/AqbnDah/r4F6oOlpny/sLPbH0jMYjrgoEE4WKcwB4qRTn8EKo5rdqlUThCnYBApW9L5OSCuL4fPAqxPzVPgb0mgJclRk6guo70qLc+e6C/pwJ6ZXCsD9+YKZqPN+ECv+cxuRJ+Sb7wTvlCOJwvcBVYVzVJhGvaq5D3y8YsX3EV8LF1ZTMJJSG4VK1D+ZAhnrwD7jNeHFOlESMGnX2zJvDTfV+rtPfURq3Lv9A1NmHomTEYitkAU2FVnUMFdqBcHbMelOHv4cES1lpqEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b0nAooVRZxx1TtSeHW+Ky/RQ+w+uS+rgXiaFOJ9jN8Y=; b=gPozEI3LBaly5worasmIT8PqqhFevU7+6YIUYDkMGjFLfngbfYDfjeWx41SXnE2fURp4G8dcB/cW8qf++9fbgURFAVmXlhrdgo4xfItiy59zH51QjVqC90MDcH1oWpU5aSMra7NbROm4wDJFktAQKEJ8wxCdj7FCKeLXY/xnh1jLJcPM5bYiMIhqQkkyGea9cS/tjFQXOnxz7fFFZnTMRMTs90clfDMg9cZ99777XDWrMi97kWkWxHRsZDaJ2BlXhQOb2/1k7ZgoEIDhvAmBDVM4svsHJ3U65vsxNoVhuMVBEvlDs/POg+TIkS4i8Ls5+M3KcgLlUGMwSihiwkN0ZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b0nAooVRZxx1TtSeHW+Ky/RQ+w+uS+rgXiaFOJ9jN8Y=; b=FN2223+eYBSeOsDP7Zhi9dx/N4JXdtt6RzHDLZaNHbu55hm9EF34Gsflrvr7/agOgL167O66gR5xagEggG9T0gM4BqAAb+wsAd+fknQAbdSOb5bj5NgwxmkL2aracIwr1xqrtlGiroX6CUXR3epI9CRayAd1LBcYtV9AkV7M1yQ= Received: from SN6PR11MB3101.namprd11.prod.outlook.com (2603:10b6:805:d8::23) by SN6PR11MB3293.namprd11.prod.outlook.com (2603:10b6:805:be::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.24; Fri, 17 Jul 2020 19:09:13 +0000 Received: from SN6PR11MB3101.namprd11.prod.outlook.com ([fe80::ac58:2cf3:c611:9b0]) by SN6PR11MB3101.namprd11.prod.outlook.com ([fe80::ac58:2cf3:c611:9b0%3]) with mapi id 15.20.3174.026; Fri, 17 Jul 2020 19:09:13 +0000 From: "De Lara Guarch, Pablo" To: "Coyle, David" , "akhil.goyal@nxp.com" , "Doherty, Declan" , "Trahe, Fiona" CC: "dev@dpdk.org" , "Ryan, Brendan" , "O'loingsigh, Mairtin" Thread-Topic: [PATCH v1 2/2] crypto/aesni_mb: improve DOCSIS session creation Thread-Index: AQHWW4mzDwWLi4TQn06pPxnx+9PYq6kMI48Q Date: Fri, 17 Jul 2020 19:09:13 +0000 Message-ID: References: <20200716153218.65491-1-david.coyle@intel.com> <20200716153218.65491-3-david.coyle@intel.com> In-Reply-To: <20200716153218.65491-3-david.coyle@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.255.188.24] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2cb092e2-141f-45d9-d1d4-08d82a84e4b7 x-ms-traffictypediagnostic: SN6PR11MB3293: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:431; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gdB7R5R9DopfU93mi/HkB78M9giuX73VDs4hhLy7f6eHogBpBgdDOdt5KC9KZU579oRPIEhjSqT4EwnRFKXAXPs7c0ah4hEonXI1rtxarWs5Mv0LQmblhW+KgP+pJPpIKwSTOpmvjVPZ1eZ7mgmdFpWRN0VhwkRkJsX/i8rdotZI105Bd7rUWzIHX0rIevPX/9vfszghhQEMFXQCC7/Ab58qAEGN5GpuRodL+EtZrMzmkjRmod/qzvNnfZ306LIX0SPdKwZyNW5Uf0vLWXeAQNrMuQfwOjtOn/BJh8DTeutMsar1fI9Md20sk8yRgQRxHK7Z47Jm96qo23uEFEXCsA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3101.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(346002)(376002)(136003)(366004)(39860400002)(55236004)(55016002)(54906003)(53546011)(6506007)(83380400001)(2906002)(76116006)(8676002)(7696005)(8936002)(6636002)(316002)(478600001)(110136005)(186003)(66476007)(26005)(4744005)(9686003)(33656002)(64756008)(4326008)(66556008)(66446008)(107886003)(71200400001)(86362001)(52536014)(5660300002)(66946007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: uFd7c7eRk0Tb8QvzyGal8gAbWoJO4FJ9Z5QHHWnCut/3AijtydHG3r6MgKBv3m6teJGNL/JpYSD2KbTreJyk2VH4AYMA+5LxR7FIKch9peG1+vb1+zInRg7u7GQyn/fhU2KrbFt2czrr2F84PNhSKRHxKpjfmHSJkIMSaUBY5CGl7r0oO4JMEim/oxcs+etIXpteH+qabA+Ny3NuJRI6LfMqXazrRhARwWb9shMmG4iuqzTLzcqMl/MMh/1a/Hm2S9NiUP57kXokVcvgO9t6AtleFq3IWLF+7QnypGg44dxFYTHXyopUMEUvbH/f8lW2+243+oty8/FNKC0TAHwuCI5hIAsuRgBcTKiN9dajMVfe33zrft3CS9Z7ArK2QUj0KFS2XbaJkpneD4hJ4Pg3xQMi5zo2/ONeRjXBMHcXLclR84zOM/8+BKfILdrVMUgux5+qDadxIyi/aWobV91KsZCmrNAYFuFmbRoSfrcTHMQXa667Fp6T2FrbyxfKxiqN Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3101.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2cb092e2-141f-45d9-d1d4-08d82a84e4b7 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2020 19:09:13.2447 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XEzAtR1Z1pWQ9wD8t3z7sCxS3PFaeBtSiLi4sJHfZFir5N/koLzl5M54DqpO0bds5ZkcI1+x5mb9h6I1jRMGPazDSetHyjDTu6YHBlaaxfs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3293 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1 2/2] crypto/aesni_mb: improve DOCSIS session creation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi David, > -----Original Message----- > From: Coyle, David > Sent: Thursday, July 16, 2020 4:32 PM > To: akhil.goyal@nxp.com; Doherty, Declan ; De > Lara Guarch, Pablo ; Trahe, Fiona > > Cc: dev@dpdk.org; Ryan, Brendan ; O'loingsigh, > Mairtin ; Coyle, David > Subject: [PATCH v1 2/2] crypto/aesni_mb: improve DOCSIS session creation >=20 > This patch improves the DOCSIS session creation as follows: > - it validates the security action type as well as the protocol before > creating a session and now does this validation before allocating the > session from the mempool >=20 > Fixes: fda5216fba55 ("crypto/aesni_mb: support DOCSIS protocol") >=20 > Signed-off-by: David Coyle Nice, this is actually fixing a potential memory leak, so you could mention= this in the commit message/title. Apart from this: Acked-by: Pablo de Lara