From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7FA5A04BB; Tue, 6 Oct 2020 13:08:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DDC271023; Tue, 6 Oct 2020 13:08:49 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 31DFBA3 for ; Tue, 6 Oct 2020 13:08:48 +0200 (CEST) IronPort-SDR: 3pYkBsZhJww2vVeodL1hZFAIcf7McwuX5FPqeS037v5jCEUGJKYLILPizbS2uEXs8P39S0r/BK j7jkOOCZqWNw== X-IronPort-AV: E=McAfee;i="6000,8403,9765"; a="163676918" X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="163676918" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 04:08:46 -0700 IronPort-SDR: jwowrlFDIC4I+sK0asfnb+pskBibpqLN0lx30s8sLRD5w7RIiEHeFQtp183ou6m3g0YJGg1plL aFC1IVauTqog== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="460748674" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga004.jf.intel.com with ESMTP; 06 Oct 2020 04:08:45 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 6 Oct 2020 04:08:45 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 6 Oct 2020 04:08:44 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 6 Oct 2020 04:08:44 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 6 Oct 2020 04:08:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P+YfkxwTYrRngSuo+krhWMqJqio4eFav2tHRFHQ2m5TKxiuRGB9pezwNQfg7nkze4sciMg0psIB2EpPUD8dqrBqpFf+sRLHf3r53sutMSfOFeZEJRAYa2+jOVUjNjevLrf70nl+a9nPrYNz2wMVc+F6zp7Z3iBHKhmMkPfHqGwEMQmXX8iFedn2LMDaKqlVL3vPfQur8ENo0V3XqkdMKt1jpO+VxYiRLMmLurKCqhJUL38AMwYqB8iRnWF12jxVAnPEFSRzQdizpqE/TXTyI/Xu3FS6cE/M+Sr1PQdP7/UmI1gJvLExPnq+zYWl17nGxAagxDyyG06d9y2VFuJr2uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LW3xhY6MVRuqukUqUKoI2nPWiCuCZsG3pSwB+WFb80Y=; b=E6jMT4SVljh0KhOvr0zinxXJ0Amhh9fvP6P+vEcpsKyjRt4tpPwHmF5pbGUEbJ3UMK70pnYqHzMd/6lkyPK3WF7BfsQo/hoGgppYEjoKRdFn/H9xebd7jaacLbq7WstcdF0amUPIC2fQ7hfOJO9c+y3RiJ3hYoFNH/z0xNkKppmF24dWq/PxhbMUVl4rf9TL9zc4YsYpH0jf4DqnIEJrJvIRMmi6vWMhvKPtzB7ypois0uVG9JL9P1OhnWtyTmwV0GzpUPTrSdjVeM4w4st/kBueNHwV0sGqheGC0K9cqALcO/coqBI0aHvK/BB1o+d7GsSJ3Npbx6AA4iyyU7CMFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LW3xhY6MVRuqukUqUKoI2nPWiCuCZsG3pSwB+WFb80Y=; b=x3XUKQZOOxTS5uWNIZaNcqz0M/Wof7cQ3NnkU2qaJ3rhylt9+1za+ofe9WsjKNCnrX1dS85yzPEfdSWkgYzR1CaNrhpKMSzUYAMtecjWb4Vv9CVJTXFykhvQaLS9DnfSjPVp3vFWXqceTYIFd5KFf7rlLK8zzk9SX0YaP6Pc2Fw= Received: from SN6PR11MB3101.namprd11.prod.outlook.com (2603:10b6:805:d8::23) by SA2PR11MB4954.namprd11.prod.outlook.com (2603:10b6:806:11b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.34; Tue, 6 Oct 2020 11:08:41 +0000 Received: from SN6PR11MB3101.namprd11.prod.outlook.com ([fe80::65f0:fb5b:639d:a0be]) by SN6PR11MB3101.namprd11.prod.outlook.com ([fe80::65f0:fb5b:639d:a0be%6]) with mapi id 15.20.3433.044; Tue, 6 Oct 2020 11:08:41 +0000 From: "De Lara Guarch, Pablo" To: "Coyle, David" , "Doherty, Declan" CC: "dev@dpdk.org" , "akhil.goyal@nxp.com" Thread-Topic: [PATCH v1] crypto/aesni_mb: fix incorrect clearing of security session Thread-Index: AQHWm8UEA1h5JH3d+kCQvG7vbul6F6mKahqQ Date: Tue, 6 Oct 2020 11:08:41 +0000 Message-ID: References: <20201006094215.49882-1-david.coyle@intel.com> In-Reply-To: <20201006094215.49882-1-david.coyle@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.255.188.24] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ab3b788a-c8fa-4670-831b-08d869e82f2e x-ms-traffictypediagnostic: SA2PR11MB4954: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2887; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2MdnT/OErjO9rKdqOLgUNCwk9OA3MpJ1UJ8CwH5KBUfQUMgO5J96EIZLZ140s4l3NZOQGeNlLMS8ob/RV8u6Cnn0lN8Qw7TvEe25jiIvgPYe12iXVCFhDcWFCPkjRl+44OA1jOfz/8BE9wqsIh7QgNDSsiR1K/p1LDNys7M7javtqLR1xIkIsWmF/4T0QnR+LsGzhzPRjBpPmdcHH882gJAQLhbIOrItxeUBAgUS2PbY+WLVGBUSTjIIVXGuxZnHSov10I6oRd+hBSgOf+hThs7zYxy7+5eWaYuo0sPfOxgp3o8VwruRuivLVUolhkz2TYeL5VkJDtmiMHjGbNNEVQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3101.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(366004)(376002)(136003)(346002)(55016002)(76116006)(71200400001)(4326008)(54906003)(110136005)(8936002)(478600001)(9686003)(316002)(86362001)(8676002)(83380400001)(6506007)(66946007)(66476007)(4744005)(33656002)(15650500001)(55236004)(26005)(53546011)(66446008)(2906002)(66556008)(7696005)(64756008)(52536014)(186003)(5660300002)(6636002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: g5l+8VtUieIfmcF1VTFQ57u6MoBS99Gm7DWDyXXoWMOaXK0xbyPz2XRM5gfIuJlxKtEV/VwOXZhIS0d401S2n/hg6PG5rF5T02mTqsXEcvKhXkfAUy1dZq9M/kDsS0ZFDL8cWVJ8j//WW+9IE2SvgAZvULo8tI4GWSqcCO0Fyuq188EpXt6gS7Y0/SKvvIuGAbFNy4aBdYqZK6bhPqPRJM9+Dl+uZtCOG6wnGvnf7hdHAFNV+1rpNRaqc8bxmF1jl2pS/xVwhOaLdJjMBbJB94ICU/sibaz3nGKMKVxLznsY+nn/mRMVYURbzq2IqpBOAmfsufRNzTobRHzgsjkxBAOT+mYa8RTcpKFHf1AwehYwKRBqH9uTZWKoYm5rJTDXThgtSYst1PbignUk6R7NkwMFlojRIfNOCQl4LxL7jIOPh1+mJdyKmcDzNAWJapIaeFpiITDfmtEDyw6W4qUGLPxu1EI8QGYsJhrHSdbPdpwLxlkGBgu1x85CZ+07YOX/Znv3hGK0qLqP/MZrXd1mb3Pg+977x65SgHZGxMKXrvVeWNjhQ/SQ/ji0da+Rb53mfnrdGdVSGt2M/pDBWhIclhmY0iQlzlb/OM4eBOV2WDCO4B0XUfs9JSvGh91B5z9AZpyT+ymY4kFDISK4WzFS+A== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3101.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab3b788a-c8fa-4670-831b-08d869e82f2e X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2020 11:08:41.5702 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5fJCfBaKvLQDEdV15nA0MCj3O5qUkVsLdgrH2sS35yL4KF+KhA8VqyvyJA390TefJKV3ipK09NbGvPbCJS4PjPfwRdecPvdU8YNmw/WMPS0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4954 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1] crypto/aesni_mb: fix incorrect clearing of security session X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi David, > -----Original Message----- > From: Coyle, David > Sent: Tuesday, October 6, 2020 10:42 AM > To: De Lara Guarch, Pablo ; Doherty, Decl= an > > Cc: dev@dpdk.org; akhil.goyal@nxp.com; Coyle, David > > Subject: [PATCH v1] crypto/aesni_mb: fix incorrect clearing of security s= ession >=20 > When destroying a security session, the AESNI-MB PMD attempted to clear t= he > private aesni_mb session object to remove any key material. However, the > function aesni_mb_pmd_sec_sess_destroy() cleared the security session obj= ect > instead of the private session object. >=20 > This patch fixes this issue by now clearing the private session object. >=20 > Fixes: fda5216fba55 ("crypto/aesni_mb: support DOCSIS protocol") >=20 > Signed-off-by: David Coyle Patch looks good, but you need to CC stable, as this should be backported s= ince the issue was introduced in the previous release. So, add Cc: stable@dpdk.org after Fixes: fda... and send a v2. Apart from that, you can keep my ack: Acked-by: Pablo de Lara