From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 260B5A04BC; Fri, 9 Oct 2020 20:36:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9D2281BC29; Fri, 9 Oct 2020 20:36:07 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 1E6731BC23 for ; Fri, 9 Oct 2020 20:36:05 +0200 (CEST) IronPort-SDR: is/E6+0Rw7oG/NWDLhDzFQdnTTrNthitR0IJ7/tlsuamJTjtg891TtYi3PTJQv0JqRh/rqIkMl ZUkT3B+w0i5g== X-IronPort-AV: E=McAfee;i="6000,8403,9769"; a="165585305" X-IronPort-AV: E=Sophos;i="5.77,355,1596524400"; d="scan'208";a="165585305" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2020 11:36:04 -0700 IronPort-SDR: 6pvT4RUw6CCxoWs5jqk+76i78wuRQjAorp8o8kQ4tSZpvwevIPC3yY6ILLj+qQE+JJDJmk8lbe ioxsqxL4tayQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,355,1596524400"; d="scan'208";a="298400842" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP; 09 Oct 2020 11:36:03 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 9 Oct 2020 11:36:03 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 9 Oct 2020 11:36:02 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 9 Oct 2020 11:36:02 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 9 Oct 2020 11:36:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kx0rOuDzQNkF84fdC/3qte8qYzrSoAVMxi/FmKVvb/LuJBZgclrSD/I/3Qykuw0RtJ7Pe52A5wTBdbDCAvEqPM9j3mXPG983TksNeRmmyzBpqqIGSe6WO4S1AbwivIo3bHLZlTObKDBstxPgMvQsFyn3nRG0QlZPL2D6c3WpT9U5vC3jvtFA/GACBg6ksN4d43M2rinGsSdeY+F1Mp7mH2M4FmIEtZKclJovSo3zXxdy7fQOYq1uq7X2fbgcruA81VdScBNWo2STHbD+5uQs/uyGJexBD6FVDO4KoJY8Z9W9O5QTkeKu/puWUv2AZ7n8qd2c9yjprI2O6Ud62hzrAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ELV6CyMUgPzy3xY3j7KSAyGqUCeIIJHylOs64rAKlMA=; b=RkxATabdaVV9g7wMqYeaCMshlqDEPz3pmHDexT1apFk0eUiD0b9eyn+3bg/Jh20r6NXaFVI/iAEIiWczxTUjDAtgOyq/2Eb5XA4thff4MxL87yBLbiEHVZ3ycqMToDF4dscwZM43RhHTjho1/odrywdXdYNB7JpwZhrK341qJUb51MeyhmGZslc3DJcwMKGd/yOd1yAcDocI9UQA8/UbS2ueqYojpWMLJLRgD5hih1B1ItbJ5OKA/Er/RbLSldFRmjztbNvY1FURX0Q22m3HQTda7Go0WhBXPEa/m4/UAA2Qk0H+DD16wlgvcz0eqHIOJdglK6xcDXcZ00JYALl0zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ELV6CyMUgPzy3xY3j7KSAyGqUCeIIJHylOs64rAKlMA=; b=WzP2bX0ht7oHgfmCXK/b/SqLAZwtojF1moo6aZ7e1CgyWnErumDQ73S6NjBGxGRJrsSDWDXuwrROAPa5dFMIc3oSF1Vk4yXxbw8vfmdWfIHfjouPl+jakS8iXJPveDzcttEAneWg1Lq6+94Py5ZcXeYkcLx6hWwHqvsIMdYPY6U= Received: from SN6PR11MB3101.namprd11.prod.outlook.com (2603:10b6:805:d8::23) by SN6PR11MB3024.namprd11.prod.outlook.com (2603:10b6:805:d9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.25; Fri, 9 Oct 2020 18:35:59 +0000 Received: from SN6PR11MB3101.namprd11.prod.outlook.com ([fe80::65f0:fb5b:639d:a0be]) by SN6PR11MB3101.namprd11.prod.outlook.com ([fe80::65f0:fb5b:639d:a0be%6]) with mapi id 15.20.3433.046; Fri, 9 Oct 2020 18:35:58 +0000 From: "De Lara Guarch, Pablo" To: "O'loingsigh, Mairtin" , "Singh, Jasvinder" , "Richardson, Bruce" , "Ananyev, Konstantin" CC: "dev@dpdk.org" , "Ryan, Brendan" , "Coyle, David" Thread-Topic: [PATCH v5 0/2] net: add CRC run-time checks and AVX512/VPCLMULQDQ based CRC Thread-Index: AQHWnkN1khF+vxmfBEG679rdOR8X/amPmW6Q Date: Fri, 9 Oct 2020 18:35:58 +0000 Message-ID: References: <20201006162319.7981-1-mairtin.oloingsigh@intel.com> <20201009135045.8505-1-mairtin.oloingsigh@intel.com> In-Reply-To: <20201009135045.8505-1-mairtin.oloingsigh@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.255.188.24] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 44bb48f9-6ed4-4350-0f04-08d86c822aa4 x-ms-traffictypediagnostic: SN6PR11MB3024: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: akwTAJHCXQwg+YVCT3IBP8eIJQ64XI9AS8QykUJyGlCcD1sXFTr1R8CK9LryjJP7Jty7SFq2d4E1fXdH5PEPjVfmvazJahZeRNuEbUdWMX64C1suXREeIpdo3oe5/gZhoibsaNkBCzohsqlmWTrZsputNlHOCBMFVAX3AbsTWlM3H91Cn0S6BQMtfNUmwf8p9eewnoDSz/NGSlnIFTWoBk2VK2Nnouyj1JcXy7z6TXMZLOOk35/BjrtRknQRQvzbcTFlTl9E70fsrRNndbllJ+IAyx3KhIHKOsspE6PAUXMCaa9ICu2ZNT8BTA9GIGYLWencuUsgCUWD9lGOuUMl0Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3101.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(136003)(396003)(366004)(376002)(316002)(66476007)(66556008)(66446008)(66946007)(52536014)(86362001)(71200400001)(64756008)(5660300002)(33656002)(55016002)(478600001)(6636002)(83380400001)(6506007)(76116006)(4326008)(2906002)(55236004)(26005)(186003)(107886003)(53546011)(8936002)(54906003)(110136005)(8676002)(9686003)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: QutrWCeectKKoAGz2mbWp6LaiAUgwNbTgHzt4+ylrN6VlSAuvf817SFow5ccGoD2Imkvf3Twr/6o2D4rR8Am8i98LR8lcojXpSOP3yboaPag/L0cHmOGaa3UEfrTHkSfXImTc7ZUvHCJuE875JtiZ45qRy5gxODrcQCp0G3+mbdsLCn1S1RU2Zfom5pAsyw9N3mMPyN8NDhP5yZzS4AJyaOK4alvwM+HWdVS23mZKBscksfvkfUo5np3PjNH5UFhhFmmyGl1eKlgyh5EMIxH4gfmsWvg6FITsVGtainNYLkxYLr00ssYSE5GIMPxiaNAoVW8wDLCfIMSH65J3RoCc0xMveaKzTiF2HcCGb0sRIK6jD4yVEo2rtUEKi/qmQJ4ZMTUsTZET0f49vHOMi5F86EcnJeeb8ZJ4znx2GDoqOpa4z8cjULZ+U4Uq/6j94dNSBWihl/Z/eCnnvPHP4qZdfSAhD/OX04gLUq+wh1iD1BiBxbo5Pu5PmDPKUQwM/wPWeaYiDRUf3PVw2q3cr1YXV23cfKQnYF//4n02v8djEA982Vikk6soLFgHQOvv0hkhm/tvNxfR1nja/8VfD/TWSyUxDOwA/ttKPX0zcMNOkYyKRVl1RxlZGie65apVpX0tthfGaZpHEXo7RcbMqjOvQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3101.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44bb48f9-6ed4-4350-0f04-08d86c822aa4 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2020 18:35:58.8399 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ubRu5c/6cPiEYYHAnKGdINWelLas3q3Khjch4TMoZW88jbGdYDkQlC49Z+EvX5YSpJzgT6GU2ZCV7CWVYkuxB+OkANJw108r7ldvB91R7Tc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3024 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v5 0/2] net: add CRC run-time checks and AVX512/VPCLMULQDQ based CRC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: O'loingsigh, Mairtin > Sent: Friday, October 9, 2020 2:51 PM > To: Singh, Jasvinder ; Richardson, Bruce > ; De Lara Guarch, Pablo > ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Ryan, Brendan ; O'loingsigh, > Mairtin ; Coyle, David > Subject: [PATCH v5 0/2] net: add CRC run-time checks and > AVX512/VPCLMULQDQ based CRC >=20 > This patchset makes two significant enhancements to the CRC modules of th= e > rte_net library: >=20 > 1) Adds run-time selection of the optimal architecture-specific CRC path. > Previously the selection was solely made at compile-time, meaning it > could only be built and run on the same generation of CPU. Adding > run-time selection ability means this can be used from distro packages > and/or DPDK can be compiled on an older CPU and run on a newer CPU. > 2) Adds an optimized CRC implementation based on the AVX512 and > VPCLMULQDQ instruction sets. >=20 > For further details, please see the commit messages of the individual pat= ches. >=20 > v5: > * Tidied-up the ifdef checks for RTE_ARCH_* and compiler support of CRC > paths, as per review comments: > * All ifdef checks removed from API function definitions and moved into > helper functions. >=20 > v4: > * Fixed build issue when older version of meson is used (0.47.1). > * Addressed review comments: > * remove Intel copyright header from neon CRC file. > * tidy-up of register initialisation. >=20 > v3: > * Re-submitted v2 as encountered problems when originally submitting it. >=20 > v2: > * Added support for run-time selection of optimal architecture-specific > CRC, based on v1 review comment. > * Added full working AVX512/VPCLMULQDQ support for CRC32-Ethernet and > CRC16-CCITT. >=20 > v1: > * Initial version, with incomplete AVX512/VPCLMULQDQ support for > CRC32-Ethernet only. >=20 > Mairtin o Loingsigh (2): > net: add run-time architecture specific CRC selection > net: add support for AVX512/VPCLMULQDQ based CRC >=20 > app/test/test_crc.c | 11 +- > config/x86/meson.build | 6 +- > doc/guides/rel_notes/release_20_11.rst | 6 + > lib/librte_net/meson.build | 89 ++++- > lib/librte_net/net_crc.h | 45 +++ > lib/librte_net/net_crc_avx512.c | 423 ++++++++++++++++= ++++++ > lib/librte_net/{net_crc_neon.h =3D> net_crc_neon.c} | 26 +- > lib/librte_net/{net_crc_sse.h =3D> net_crc_sse.c} | 34 +- > lib/librte_net/rte_net_crc.c | 162 +++++++-- > lib/librte_net/rte_net_crc.h | 4 +- > 10 files changed, 722 insertions(+), 84 deletions(-) create mode 100644 > lib/librte_net/net_crc.h create mode 100644 lib/librte_net/net_crc_avx51= 2.c > rename lib/librte_net/{net_crc_neon.h =3D> net_crc_neon.c} (95%) rename > lib/librte_net/{net_crc_sse.h =3D> net_crc_sse.c} (94%) >=20 > -- > 2.12.3 Series-Reviewed-by: Pablo de Lara