Re: [dpdk-dev] [PATCH 0/3] Crypto test refactoring (second phase)

["De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>]

Hi Ruifeng,

> -----Original Message-----
> From: Ruifeng Wang <Ruifeng.Wang@arm.com>
> Sent: Thursday, April 16, 2020 9:29 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>; ravi1.kumar@amd.com; anoobj@marvell.com;
> Zhang, Roy Fan <roy.fan.zhang@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; tdu@semihalf.com; rnagadheeraj@marvell.com;
> adwivedi@marvell.com; g.singh@nxp.com; hemant.agrawal@nxp.com;
> jianjay.zhou@huawei.com
> Cc: dev@dpdk.org; Akhil.goyal@nxp.com; nd <nd@arm.com>
> Subject: RE: [PATCH 0/3] Crypto test refactoring (second phase)
> 
> 
> > -----Original Message-----
> > From: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > Sent: Wednesday, April 15, 2020 2:04 AM
> > To: declan.doherty@intel.com; ravi1.kumar@amd.com; Ruifeng Wang
> > <Ruifeng.Wang@arm.com>; anoobj@marvell.com; roy.fan.zhang@intel.com;
> > fiona.trahe@intel.com; tdu@semihalf.com; rnagadheeraj@marvell.com;
> > adwivedi@marvell.com; g.singh@nxp.com; hemant.agrawal@nxp.com;
> > jianjay.zhou@huawei.com
> > Cc: dev@dpdk.org; Akhil.goyal@nxp.com; Pablo de Lara
> > <pablo.de.lara.guarch@intel.com>
> > Subject: [PATCH 0/3] Crypto test refactoring (second phase)
> >
> > This patchset is the phase two of the crypto test refactoring effort.
> > It mainly focuses on removing the PMD bitmask used to select which
> > PMDs are used to run the tests against.
> > Instead, now all PMDs will run all test cases and the capability
> > checking will determine which ones are supported and therefore, are not
> skipped.
> >
> > Since there are tests cases that require sessionless support, a new
> > feature flag has been added, which reflects this support per PMD.
> >
> > I am CC'ing all PMD maintainers, asking for their collaboration to
> > test this patchset, as this might impact the testing of each PMD.
> >
> >
> > This patchset depends on:
> > (1) http://patches.dpdk.org/patch/68433/ (crypto/openssl: fix
> > out-of-place
> > encryption)
> > (2) http://patches.dpdk.org/patch/68434/ (cryptodev: add missing
> > feature
> > name)
> > (3) http://patches.dpdk.org/cover/68435/ (Crypto test refactoring
> > (first
> > phase))
> >
> > Pablo de Lara (3):
> >   cryptodev: add sessionless support feature flag
> >   test/crypto: check if device supports sessionless
> >   test/crypto: do not check for PMD in tests
> >
> There is one test case failure with crypto_armv8 after applying these patches.
> I will try to locate it.
> 
>   33) TestCase AES-128-CBC HMAC-SHA1 Decryption Digest Verify Sessionless
> PASS
>   34) TestCase NULL-CIPHER-NULL-AUTH encrypt & gen x8byte PASS
>   35) TestCase NULL-AUTH-NULL-CIPHER verify & decrypt x8byte PASS
>   36) TestCase NULL-CIPHER-NULL-AUTH encrypt & gen x8byte - OOP PASS
>   37) TestCase NULL-AUTH-NULL-CIPHER verify & decrypt x8byte - OOP PASS
>   38) TestCase NULL-CIPHER-NULL-AUTH encrypt & gen x4byte PASS
>   39) TestCase NULL-AUTH-NULL-CIPHER verify & decrypt x4byte PASS
>   40) TestCase NULL-CIPHER-NULL-AUTH encrypt & gen x4byte - OOP PASS
>   41) TestCase NULL-AUTH-NULL-CIPHER verify & decrypt x4byte - OOP PASS
>   42) TestCase NULL-CIPHER-NULL-AUTH encrypt & gen x1byte PASS
>   43) TestCase NULL-AUTH-NULL-CIPHER verify & decrypt x1byte PASS
>   44) TestCase NULL-CIPHER-NULL-AUTH encrypt & gen x1byte - OOP PASS
>   45) TestCase NULL-AUTH-NULL-CIPHER verify & decrypt x1byte - OOP PASS  +

These test cases shouldn't be run, as your PMD doesn't support NULL cipher/auth.
Have you merged the first phase of this refactoring work?
I just pushed new versions for both phases, as there were a few problems in the first ones:
http://patches.dpdk.org/cover/68677/
http://patches.dpdk.org/cover/68681/

Could you tried the new versions? (remember to also apply http://patches.dpdk.org/patch/68433/
and http://patches.dpdk.org/patch/68434/)

Thanks,
Pablo