From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48254A0563; Wed, 15 Apr 2020 11:09:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E06771D603; Wed, 15 Apr 2020 11:09:07 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 65E141D5AE for ; Wed, 15 Apr 2020 11:09:05 +0200 (CEST) IronPort-SDR: ykcYk2U2OHE/6RcqUzwSO74FBLz5LR6oDd6O6DWYYJlAr+QlBQ/l0gCWkDbRHcLF6tW/maq6/O 6iCecj3GTIVw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2020 02:09:04 -0700 IronPort-SDR: +/1WuJHszuOuzeIXX5tvTn6b+lsJo8MZc+4Icphl6upWUhpwPu6mUbaQhZIk9VcHrzO5mznCY6 xC8aMD9IxS2A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,386,1580803200"; d="scan'208";a="244053766" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by fmsmga007.fm.intel.com with ESMTP; 15 Apr 2020 02:09:04 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 15 Apr 2020 02:09:04 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 15 Apr 2020 02:09:03 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 15 Apr 2020 02:09:03 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 15 Apr 2020 02:09:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aRwGgKWzkFDolJP6PBXmtt1GEZI84EMEsNaxmufBK6E7o4cfK6uIibFTd001U2jQKoa3gqEun3HPdf6wmTWcfLAfbAKxI6ZFprG4L04gM03OBX3n7GsFLbu/G2R+E3D+ukQTvLl5C5s03cgyA98JATtsX0ytCYcf0p9Tg21pG55LUn5REI0w9PZfmsNpEooq6ufbEtF87DSblAFSxHKGQydwc8xwcOsroz3SQ8hb/H0w1QrNsjA1fVTV/e0wavQVCFkIKt1j24cS+arU9Fv+j9dSd5l5v7gL2eda0tZj3E8lwJEvWEVJ1WYnDIBnaLC3tZyjgV1vVciICRcOBCisNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j6e5UL+B4p+QXzjoVmkse2sLuR/RlIgTKHLRBdrKj14=; b=MeLes7QJwxfuE1Wt3Df8h9VyCJqApE1Lpt1+LwR8PGnGfjT0759DmiZ0L2Qg942Sr6sCdbUNkTPsmutSL6NMRrfq+n0Ts3fMO/3AtY1rUJ5zgpMo4YwxJt2bwxh84VWWuK/bvM+h8gE+7/ltYN4wTJhJkEpCT+8qYIkmUAgV4T9/bi/tau4ubTT0F8B5PoCEHGONOkDu7JTFGP6M6+3yYkSDBMhlLYtN7wmoift2uFjJWLFPrj+HaUl/Oj9paZ0h7cfifsmTm6VfsbnefI8aa34dZZnxC1kcxp3jV1mWUh6fNLOzV0lAzHl/KxMcn8rvrWrcxdxWWndR9EjH5yfvKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j6e5UL+B4p+QXzjoVmkse2sLuR/RlIgTKHLRBdrKj14=; b=uGXa3j+ZaNl3AigO66iiNxBXs6im92vsJmO1mxJr6V8iAj5cwZP9uD34GpnZ+hccU9l/iTNYOvVZpQO+8zLD4hPDFH2wdQS8FQ1KU05y2s0sLhoEsoVIS5leg0H+1+uNLJk3Cbpoq6ViLDpRMWVdis9rGkwZMmN1rZL/4k50wFQ= Received: from SN6PR11MB3101.namprd11.prod.outlook.com (2603:10b6:805:d8::23) by SN6PR11MB2751.namprd11.prod.outlook.com (2603:10b6:805:63::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15; Wed, 15 Apr 2020 09:08:56 +0000 Received: from SN6PR11MB3101.namprd11.prod.outlook.com ([fe80::7d0f:735a:8d8b:1d40]) by SN6PR11MB3101.namprd11.prod.outlook.com ([fe80::7d0f:735a:8d8b:1d40%7]) with mapi id 15.20.2900.028; Wed, 15 Apr 2020 09:08:56 +0000 From: "De Lara Guarch, Pablo" To: "Ananyev, Konstantin" , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "Doherty, Declan" Thread-Topic: [PATCH v2 1/2] crypto/aesni_mb: support CPU crypto Thread-Index: AQHWCdCUWgzayHNfAkS0zvgv+Co4Vah57jMg Date: Wed, 15 Apr 2020 09:08:56 +0000 Message-ID: References: <20200316132122.4283-1-konstantin.ananyev@intel.com> <20200403155553.22818-1-konstantin.ananyev@intel.com> <20200403155553.22818-2-konstantin.ananyev@intel.com> In-Reply-To: <20200403155553.22818-2-konstantin.ananyev@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=pablo.de.lara.guarch@intel.com; x-originating-ip: [109.255.188.24] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 064954ce-fdec-4d19-f807-08d7e11ca0ce x-ms-traffictypediagnostic: SN6PR11MB2751: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-forefront-prvs: 0374433C81 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3101.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(136003)(366004)(376002)(39860400002)(396003)(346002)(76116006)(8936002)(52536014)(64756008)(186003)(5660300002)(4326008)(7696005)(6506007)(86362001)(53546011)(55236004)(8676002)(33656002)(26005)(55016002)(81156014)(66946007)(54906003)(110136005)(71200400001)(107886003)(66446008)(66556008)(2906002)(316002)(9686003)(66476007)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: o+Qy3IaliBJzOOKcByov6sqyQ4uchhh7FZS1JRg74g0ITK3FAiKPKOVxrSBKbffbBSUjb90OxvESMgQsjXBV5M8B5wQEAaDRLWGY1x3PF9qPHs7Z7ULyuApmS4KeloNsztcZXjKimMHKv8Lk8J7K4qHPN1FXe4lJzrf0zItcrn0TdtLiaq9PJydN+3X5iaSUTUKbM601//xtaSoFNDYhKv7ni/W0lcgF3XgR1bLeWO4GAJGhevmupFGvhKXt9usmC0reV7zG+pOyuUFeK+mToM6QzIdn3sgRrkpdFfLhu7hSkKpIO/9cn6Ddvgib57SpgSTiYz/tvA7E8iPRn1u0uuSXg2vKe/ffIXOYkoywh5EXkZ3/dDm+rafokcqMBFRxyj0as0/YtqwP/9qBBmq0PEgeZAJZJYw1LbZU2psaZeaSIOlclI5KUrmbO98gEydX x-ms-exchange-antispam-messagedata: dqrtULEH1v7SjoX15eWbmAv8eKo5CMohlnwfplKwgEGH4p0wGSZUaDGEHcOJnW9gGFGcAPIwLdKjOmrbm996YKVR4ASZk942QP29Y+CMDWTkcKwAXriaVuB1y26przi14nl2cNUrh1R+y9RMa6PRJw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 064954ce-fdec-4d19-f807-08d7e11ca0ce X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2020 09:08:56.8507 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7FED1q+4vSHF335zxqimeeDtVkvkzDe9XNUU1XoorB6Xiehf0FCuzgTEBy8H6X3kVC2eS7XmtaUYXVYav22vOyU76sT++1v8AsXjVDxmPZk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2751 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 1/2] crypto/aesni_mb: support CPU crypto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Konstantin, Just a small comment. > -----Original Message----- > From: Ananyev, Konstantin > Sent: Friday, April 3, 2020 4:56 PM > To: dev@dpdk.org > Cc: akhil.goyal@nxp.com; De Lara Guarch, Pablo > ; Doherty, Declan > ; Ananyev, Konstantin > > Subject: [PATCH v2 1/2] crypto/aesni_mb: support CPU crypto >=20 > Add support for CPU crypto mode by introducing required handler. >=20 > Signed-off-by: Konstantin Ananyev > --- > doc/guides/cryptodevs/aesni_mb.rst | 3 + > doc/guides/cryptodevs/features/aesni_mb.ini | 1 + > .../crypto/aesni_mb/aesni_mb_pmd_private.h | 5 +- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 386 ++++++++++++++++-- > .../crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 2 + > 5 files changed, 363 insertions(+), 34 deletions(-) >=20 > diff --git a/doc/guides/cryptodevs/aesni_mb.rst > b/doc/guides/cryptodevs/aesni_mb.rst > index 465d20d88..02a0a499d 100644 > --- a/doc/guides/cryptodevs/aesni_mb.rst > +++ b/doc/guides/cryptodevs/aesni_mb.rst > @@ -12,6 +12,9 @@ support for utilizing Intel multi buffer library, see t= he white > paper >=20 > The AES-NI MB PMD has current only been tested on Fedora 21 64-bit with = gcc. >=20 > +The AES-NI GCM PMD supports synchronous mode of operation with > +``rte_cryptodev_sym_cpu_crypto_process`` function call. This should be AES-NI MB PMD. Also, this patch needs rebasing. Apart from this, rest looks good: Acked-by: Pablo de Lara