From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28199A0032; Wed, 11 May 2022 22:49:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1195E406B4; Wed, 11 May 2022 22:49:44 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id AD52840042 for <dev@dpdk.org>; Wed, 11 May 2022 22:49:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652302181; x=1683838181; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=W+8DvfbBqI5aDpY6KajqGD+m/wZUP+V6qLSKWueqW6w=; b=PzawrsBeO7DDHJC/sOBArPNRh1h1vS3wDy3JRcJT0sENvwJE6hIOGvEo qCtaceQf5GyfkOThycQsS+pXBZjItDISL2aWhm25Ic1jkqbU3l3qWCnOY ELB7si/u29wC6Qz3TJsb0chhIwO1brEhGREYq5MMuQt2RIwd26Rr8xC+E LgHLIZRr1j588Y2n/IEDB8+ocnn0RlLMaTkrzSj657vWEn2I047FzHaPL xThXrr8L5u3GzrMXGut5JrH8kMVDFr0sdqmG+q9CnqRBNIWtaC2MxZxJK XX3aXkWMBeeq6YhFu0tSkkwcFET7iNoTU8tC0maxcg8L8DLSM5Q3PgbTf w==; X-IronPort-AV: E=McAfee;i="6400,9594,10344"; a="356233918" X-IronPort-AV: E=Sophos;i="5.91,218,1647327600"; d="scan'208";a="356233918" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 13:49:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,218,1647327600"; d="scan'208";a="520669556" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga003.jf.intel.com with ESMTP; 11 May 2022 13:49:34 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 11 May 2022 13:49:33 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 11 May 2022 13:49:33 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 11 May 2022 13:49:33 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 11 May 2022 13:49:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GE7iR6Crj0cN/hepkrZSI3H17DdRshFvLsPgH1p12xnhM3y01KZ5pnmCavYd5PCnriDBPqoEa1MpKTsqUuqRJ8tFAJniF0j9scRboR21aysg9K8U6wz6maSooOyT9owcfgnfr7nPplbDFGrHtoHn/epc4f9MaLARoKObbFwUolcJnVFHA1Yk/lA90qi/r28hzIg4nKG1zrZWFOAAKR6mebDKU860KpPo1/+8S1aMy/N+wrJJelhF4KMwv0ParTzoj7i6VyPSpcu0ukDllQCXwF6AwuKtljsWXx8vNmdcUGYECIqlFA9httltegZYuJISXZlLaUZR1a8gv+tYojTAjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G0RWISSDmEreSUB8VcvIDuhaR2rPwIRqdBAmx2Tt87M=; b=MYVVIhuRAgefxhmhtS9gFil9ohZt6DvafW0+4uVQi7LFJZYRGwp0V344fCkVQNxF8RrlSTy27/4qDcngzW+hc89ERedtLn6Wdcm5jSF03gPuBfIyGlkRz28D9qeiDYrwH6EeZR3FuS1dmXn3jTWn98almB+rulIacrRLCPvF66NMvz4XMijy3myjOeMoEzrZW2axhtxg8bbjAbtED5iTDPRe2Q/gJuibCdu1n6lSt4K2vs89KE7PB8pQCKYqpSgUHTmdUsoF6gv60vF8exa/m8CYap1I1yOOGJul0awe+fnSYg5oSVp8FWe60A/RPfwtDktNxuay3PnJmmcSdcvP4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3103.namprd11.prod.outlook.com (2603:10b6:805:d7::13) by DS7PR11MB6269.namprd11.prod.outlook.com (2603:10b6:8:97::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Wed, 11 May 2022 20:49:31 +0000 Received: from SN6PR11MB3103.namprd11.prod.outlook.com ([fe80::94b8:2101:b64b:c5c7]) by SN6PR11MB3103.namprd11.prod.outlook.com ([fe80::94b8:2101:b64b:c5c7%3]) with mapi id 15.20.5227.023; Wed, 11 May 2022 20:49:31 +0000 From: "McDaniel, Timothy" <timothy.mcdaniel@intel.com> To: Thomas Monjalon <thomas@monjalon.net>, Tyler Retzlaff <roretzla@linux.microsoft.com> CC: "dev@dpdk.org" <dev@dpdk.org>, "Van Haaren, Harry" <harry.van.haaren@intel.com>, Jerin Jacob <jerinj@marvell.com>, "Wires, Kent" <kent.wires@intel.com>, "david.marchand@redhat.com" <david.marchand@redhat.com> Subject: RE: rte_bus_probe() does not exit on error Thread-Topic: rte_bus_probe() does not exit on error Thread-Index: AdheaZtQoMN5uFBYRNqhmkEborzgMwABZc+AABkU6YAAAMKcgAGobPhA Date: Wed, 11 May 2022 20:49:31 +0000 Message-ID: <SN6PR11MB3103584E6D1EA9EEB317972C9EC89@SN6PR11MB3103.namprd11.prod.outlook.com> References: <SN6PR11MB31031062362BEB41DE3D24F59EC19@SN6PR11MB3103.namprd11.prod.outlook.com> <10320642.NyiUUSuA9g@thomas> <20220503095239.GB5181@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <4331513.Mh6RI2rZIc@thomas> In-Reply-To: <4331513.Mh6RI2rZIc@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 422a89a4-8ea9-40ae-c9fb-08da338fbfc4 x-ms-traffictypediagnostic: DS7PR11MB6269:EE_ x-microsoft-antispam-prvs: <DS7PR11MB62697CFA2B90EEED424C34E99EC89@DS7PR11MB6269.namprd11.prod.outlook.com> x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /Ls0H8ntirKB0fWlSxOXy2z6hPmFCI22vG09Okq2b21RS+qaxZ5Iqy1bpPPsGzm4VXfiNbxUGeYK7hzPhHaTEqLGfqVfdOxGRp8X7H9whfkhURyPn13d11HuFmaU1x/Mknn2LLxnAzuBjwmrYRPoz6HZB00CMSYj7wjwb7yPpL4boyKnwpB8mrJQ+J34EZnC31UHBVrV3Va+95YSBze9wZ+0snHjT0/66ffkoxk3cIoT8iuwPfoNTvHa1egqXjQXnjAAQK42zs/6qmhXrTYN/dHFkGGvEqL/3TOgdIfunJceQJCbmOOAtxOJRFdxzaXECXa0XDYG3hwiH8eMa1wKjkgRNuT7RsU9N/UbNk6gFo67CtWH1IDBJrevaOoOWph1naNvlcimBh6pmItORTOLg35tTpE4PxY3vbisKyuRtdK37YNKUjodQHLLLH1tvgjCvsuFoCPHEA+aKtnSG93VBL9r8OJoGGoHthDvN+yxpunZ56jX3PvRFTAQWks60Sab83JPA24yGQ9BK64hxYeTdmZTHacJj7R/uC9t7bvdRYYktC+VSDyjOtQ0a7FdGIRdXiaWUcNEbIOBjVjWYt41TD25McMxip9I15t39VFtOU4jqcJNAunP4ZOjfBZif83HbcsFUkQv5WPSYaBPXv5PwcP6zC0MtAm6OkbKFDmrYhxc00cmefmX67UzqVmvY7HFBW7nb5uaEYMD8yXD+W3c3tlVKrNxy36LIdXDMGoFT6HaN3UqfTor9KEPavdn+MOyD+4Byj3ax0hVec2VA1mUkL5c57tLAUADTvdBhxEnnhg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3103.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38100700002)(52536014)(2906002)(966005)(38070700005)(8936002)(122000001)(82960400001)(71200400001)(7696005)(83380400001)(508600001)(33656002)(186003)(5660300002)(86362001)(9686003)(66556008)(66476007)(55016003)(66446008)(64756008)(8676002)(6506007)(4326008)(76116006)(53546011)(26005)(66946007)(54906003)(110136005)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yXYKdwgOfdMyySdglnTYTlXvwbxnV2oK0A4VcovyoWIJ6c3db82lz20r2q9E?= =?us-ascii?Q?iGKLE3wiARuDrvuDO7eOf5UZEMuWZ9UuvSQ2hTlly/UwfqNGwNzAUJkeY5yF?= =?us-ascii?Q?wGaV30lPWBIg8EbsxvPhhHmXs1s2G2rqTREtWBM3wv9VID7yrl7UZbLZls9d?= =?us-ascii?Q?i9t2CKUA5lcLXgXweTsiku5RIMShKvnL3l4jgEUt3h1eVr0/sWACv178gbrP?= =?us-ascii?Q?CwwZSnIP/l2fI92xdzjqeueh9wKn8dQ36zPgtB3oAPqSHg73sg438bJqJuhk?= =?us-ascii?Q?Mt/IUoWBuirx9zvE9/AZKd8DDdBk/MW9mRRlTg3iSUnidm4as+DwFzZ+2C7C?= =?us-ascii?Q?GahnRYHHCTG3WuVEuVpcXjAj1UQnxLEUrE0JXBNnlP/6nUEu/42XShxcbnFJ?= =?us-ascii?Q?gjtz1na2pTBUrV31FUvVwkI+jd5AOMtBHbDF9Jt+7H/Xn+DMZaqq2NNPzzWz?= =?us-ascii?Q?A3OW2q0RtlOX6mbso/sxNx/STExOepLJTkDi2u+Zb2mIcnB6w48M7SoCHZhn?= =?us-ascii?Q?+/yQ5tbfwB6Fz+QbcCjM3JDdxaOGZIGv/F/zpYqTAnv2c138xurdFKdV7v56?= =?us-ascii?Q?r1MTgRMn2t46QfGt9jEXlOOPtFrsSorhvU1yX592DRi2fgISQA0OQceaBAFi?= =?us-ascii?Q?lBdArE1p3Kqkqc7l4dIu9uACG6jxxy5WVnJuu5vgWNLpDA76IUSin+db0Brn?= =?us-ascii?Q?sUFXmyleVRiuxFyo8xWdkhqnJd/ofcPJTArd+k5kc8+npxlfYSCdWR0EujZO?= =?us-ascii?Q?Ey43Rq1Vw1xgTv8L3dNtakMrEhOJIiOpSrwBqLzCmRuIna9u5We7yDXlZwj+?= =?us-ascii?Q?7kbKTaTQbEUVKrIKC5T37YhmICqSnmj9qPKqNthOg2UQiSFhc3X3W1SN2iRT?= =?us-ascii?Q?SZiU68qJTymDw5WOB1MWTa+rVt6OJ1xZhJh0r/XOxHEe4u2taszcxhJLudt9?= =?us-ascii?Q?4LswoeQFdZ4c22Z+zLajFYKHyBMee9Ll2tsiG+dPIRxStAEf2B6hKS8jhRhZ?= =?us-ascii?Q?f9Hbn4N/31Dwg5QFg6Ct5ErmviiJei9Jb8OS/I21kIaKkekkhOPINVYuh/lZ?= =?us-ascii?Q?IcdadfOaziLS23kQ6Lwgil86EmYKOC+j64s8bvcIZyWjTNslTRV/Z/ECwJKm?= =?us-ascii?Q?+etuVO+i9mrYqaqQmbxTIObXI7Cnh3UKD8n4lKwEuLe7JSWi8T3/Yb+x1ln6?= =?us-ascii?Q?iIWNeQNYGzqF5HNfzclovYJhTBBoFEORhigsWH/8JJdNzqrFSbDM+Ya5dVIV?= =?us-ascii?Q?EPvJs7Cji0loouUJr2oGkE6t5Q7JHrrlh7k9Xb4KQTLVrKaI5rwHAs+J5GPg?= =?us-ascii?Q?xIAQobS2ptAopEuchIcvb/0mp/8z3fv6WKnvaUgpYfPYtaM+LVY1E1dLIxgx?= =?us-ascii?Q?VKYdPJF9p9V1XLdJKfmJbQhLe7KysswmPGmfsmVpTLxXrf29pApPn4am6t5O?= =?us-ascii?Q?1/IMtjxlRQp3bUQQ2UVmvSupVevnJ43o7KwmTDrjN22AbkK1ZrtlfoSW573p?= =?us-ascii?Q?bU/+SEP2spSCCY2CDG0kYs8tK57/tTxd3piXAhCQmOJ0kh/DTcnDhM6erTx6?= =?us-ascii?Q?8/6QK5GUaSlySno7HoOxXCTnIjV6baEFgTqW4WHy5hZQmv0ZApCsGYJCz9us?= =?us-ascii?Q?YTYzi4yKHOtc4pDELjeaW8a9gIVz2f5HxnsZ3GbbDISMJqtQgAJXlduggXI+?= =?us-ascii?Q?vs6016lLn9u/Q5iL8TTctYmsWMiTknA6lerXGcK2MEOMBlwxh6ViqcnV65py?= =?us-ascii?Q?PZkQeijF5RWM2tEEGoy1AadoGhPPKLI=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3103.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 422a89a4-8ea9-40ae-c9fb-08da338fbfc4 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2022 20:49:31.6875 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 00OcK4kpKQf+6F2Oo8hZtZrHqAnZJOPMoukAxdtpNMND7ER6rqBoRIvjfllHF8AjuNzHj+wlrqalAhCjOGiXw4DMH+j6Sv0UiBt30V1VTYQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6269 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Thanks for the reply, Thomas. For us, our request is to terminate if a com= mand line syntax error is detected. I understand that this would break backward= =20 compatibility, so perhaps we can look at addressing the issue at the next = appropriate release. Thanks, Tim > -----Original Message----- > From: Thomas Monjalon <thomas@monjalon.net> > Sent: Tuesday, May 3, 2022 5:14 AM > To: Tyler Retzlaff <roretzla@linux.microsoft.com> > Cc: McDaniel, Timothy <timothy.mcdaniel@intel.com>; dev@dpdk.org; Van > Haaren, Harry <harry.van.haaren@intel.com>; Jerin Jacob > <jerinj@marvell.com>; Wires, Kent <kent.wires@intel.com>; > david.marchand@redhat.com > Subject: Re: rte_bus_probe() does not exit on error >=20 > 03/05/2022 11:52, Tyler Retzlaff: > > On Mon, May 02, 2022 at 11:54:29PM +0200, Thomas Monjalon wrote: > > > Hello, > > > > > > 02/05/2022 23:20, McDaniel, Timothy: > > > > Hello DPDK community, > > > > > > > > I am following up on a question/comment that I submitted on April 1= 8, for > which > > > > I have not received any responses. See the original comment below f= or > context. > > > > > > > > Are there objections to modifying the behavior of rte_bus_probe() s= o that > it propagates > > > > any errors detected while processing the command line arguments? It > currently ignores > > > > errors and continues on, always returning success instead of any er= ror that > was returned > > > > by the probe function. > > > > > > You are suggesting to stop if probing of one device fails. > > > I am not sure it is a good idea, because sometimes we are OK > > > to proceed even if one device is missing. > > > > > > We could differentiate a fatal error like parsing syntax, > > > and "normal error" of a device which cannot be probed in some conditi= ons. > > > > a bit of a tangent but it would be nice if eal initialization wasn't > > coupled to bus/device enumeration at all and instead there was more > > control over bus/device enumeration where the application could choose = if > > it wants the error to be fatal or not .. after eal was initialized. >=20 > I agree with the idea. >=20 > > with it burried inside eal initialization the application has no contro= l > > over the policy to fail or not, also there are other peripherial > > problems that arise due to the composition e.g. event callbacks can't > > be registered until after probe from init has occurred and eal init > > is completed. > > > > it would be a huge compat break (i'm ignoring that) but so would > > failing eal init for reasons it does not currently fail. >=20 > Yes compatibility is a blocker. >=20 > A better idea would be to not use rte_eal_init() at all. > I am convinced we should split this function in multiple parts. > It would allow keeping compatibility with the legacy function > while allowing more flexibility with new functions. >=20 > You may be interested by this talk: > https://fast.dpdk.org/events/slides/DPDK-2018-09-Default.pdf >=20