Re: [dpdk-dev] [pull-request] next-eventdev 20.11 RC2

["McDaniel, Timothy" <timothy.mcdaniel@intel.com>]

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Monday, November 2, 2020 9:51 AM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Thomas Monjalon
> <thomas@monjalon.net>; McDaniel, Timothy <timothy.mcdaniel@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [pull-request] next-eventdev 20.11 RC2
> 
> On Mon, Nov 2, 2020 at 3:31 PM Jerin Jacob Kollanukkaran
> <jerinj@marvell.com> wrote:
> >
> > The following changes since commit
> 79d69c6dcf0debea38ac258d230e2f8c93e5ad12:
> >
> >   mbuf: remove seqn field (2020-10-31 22:14:44 +0100)
> >
> > are available in the Git repository at:
> >
> >   http://dpdk.org/git/next/dpdk-next-eventdev
> >
> > for you to fetch changes up to
> e06cd1ddfeac30b4926a52a69336b4f25a9cd209:
> >
> >   eventdev: check input parameter for dump op (2020-11-02 19:16:51 +0530)
> >
> > ----------------------------------------------------------------
> > David Marchand (1):
> >       eventdev: check input parameter for dump op
> 
> About this patch, could we squash some change in the dlb/dlb2 drivers?
> I guess Thomas could do it while pulling if nobody objects?
> 
> 
> diff --git a/drivers/event/dlb/dlb_xstats.c b/drivers/event/dlb/dlb_xstats.c
> index 89186d506e..5f4c590307 100644
> --- a/drivers/event/dlb/dlb_xstats.c
> +++ b/drivers/event/dlb/dlb_xstats.c
> @@ -921,11 +921,6 @@ dlb_eventdev_dump(struct rte_eventdev *dev, FILE *f)
>         struct dlb_hw_dev *handle;
>         int i;
> 
> -       if (f == NULL) {
> -               DLB_LOG_ERR("Invalid file pointer\n");
> -               return;
> -       }
> -
>         dlb = dlb_pmd_priv(dev);
> 
>         if (dlb == NULL) {
> diff --git a/drivers/event/dlb2/dlb2_xstats.c b/drivers/event/dlb2/dlb2_xstats.c
> index a274779fee..8c3c3cda94 100644
> --- a/drivers/event/dlb2/dlb2_xstats.c
> +++ b/drivers/event/dlb2/dlb2_xstats.c
> @@ -972,11 +972,6 @@ dlb2_eventdev_dump(struct rte_eventdev *dev, FILE
> *f)
>         struct dlb2_hw_dev *handle;
>         int i;
> 
> -       if (f == NULL) {
> -               DLB2_LOG_ERR("Invalid file pointer\n");
> -               return;
> -       }
> -
>         dlb2 = dlb2_pmd_priv(dev);
> 
>         if (dlb2 == NULL) {
> 
> 
> 
> --
> David Marchand

I am fine with Thomas pulling these changes in.

Thanks, Tim