From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D5D8A04DE; Fri, 30 Oct 2020 16:35:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ECF3BC9C6; Fri, 30 Oct 2020 16:35:22 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id E57A1C9B6 for ; Fri, 30 Oct 2020 16:35:20 +0100 (CET) IronPort-SDR: igo6Jjyfe8Cl9Y0lqj02yAyiECOfE3mAZk0i2UiBGsCORi20yX+HBRcVN8Q+iiXDJXaOEFna1G 06M/3PeFqjmQ== X-IronPort-AV: E=McAfee;i="6000,8403,9790"; a="156397113" X-IronPort-AV: E=Sophos;i="5.77,433,1596524400"; d="scan'208";a="156397113" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 08:35:18 -0700 IronPort-SDR: L17wpLLI0eoHZ7en9shPUwq0uoNwgodyHLbW1J8zXTCru/HSGAh3Em/+e67L/qbzumxFqBIIKM 6eQgQJ8BW/Sw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,433,1596524400"; d="scan'208";a="469558194" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga004.jf.intel.com with ESMTP; 30 Oct 2020 08:35:18 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 30 Oct 2020 08:35:18 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 30 Oct 2020 08:35:18 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 30 Oct 2020 08:35:18 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 30 Oct 2020 08:35:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nTi5jGUv9C+IXkhimVcoxeYyuGPLz1ABrJOcnxXgfoj4gARuf9LagH1Q+s+9DsXO67TDPovnJnbYqnGkoxg7PShTsjcv2MVgIGBfg/iPfIlX0tTHxgZuP+iQKVDvNiem4RdAyJigUriwV9/ESPhrdiDYJTyxytIa0sG+0bIq2qUlJPDzB67BXnAqSlhRKL8YUqDAB5NxXxBVHCxfmKPBo2w/cI1BvccEN2Kiy7GSAmzBPlFR6boUzG/0qYp2cDKhtPh+1lbME/cehD9yrMgrv3UaW/EhhVV7OqInYSEviwskNJt7BOr8+Gp41HLmQrmrnOjmmbfpRYLndIrT0KujWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3WnRk/3v03xgyO95w4iWrBJ1PdD+LIl5HTlf9glQ7pc=; b=dWQ5ksdcT7j3EEr5cNp5c0qBm+qzhEhkhGVGgBH2mjFkcpL9hb2afwxkaJz3nbbFrdoGOIL74eu8rSVugtx+ZOG2RQ7X25PnVZPiGLYpz80Iy1GhjbFZA9+bWF24ZrSoguX75KiKsRF7NIJkL/xqBtv+oCNSv1iFo3iJeqaAklA0C2IQyUkEc9h1aJEkKdHjP4874nw2PRw6hjvTfSRn7cdUfDAkIRhQYJII2JNJjcdqyt3qMqqT0o5h2MOJRcIaxkVGYCzmFW1JjRCJv5rjOjBN01R6KApNtCQWfePdNYbDcuXrhAXuW9d0QjwqpfZtQMB2ktHWbq3G5mduy25Zlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3WnRk/3v03xgyO95w4iWrBJ1PdD+LIl5HTlf9glQ7pc=; b=HSYFtNwFGUtzb5Jb00ZEldY5DoSdG7JRCm/r3ODtDdqewCuYwM1nBEj3P87zwI1n8BRy7pJrqXHdTwO/FuhkULmNutUu421pWW1pQ4xV++4vlnJ0kdhFLEcSOqIA8ZodTs8FXo2diCCAwvgrXx8kj/MNTGgZz3EsVbFKI+sQ38s= Received: from SN6PR11MB3103.namprd11.prod.outlook.com (2603:10b6:805:d7::13) by SA2PR11MB5145.namprd11.prod.outlook.com (2603:10b6:806:113::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Fri, 30 Oct 2020 15:35:17 +0000 Received: from SN6PR11MB3103.namprd11.prod.outlook.com ([fe80::e43b:59bb:161:8349]) by SN6PR11MB3103.namprd11.prod.outlook.com ([fe80::e43b:59bb:161:8349%3]) with mapi id 15.20.3499.029; Fri, 30 Oct 2020 15:35:17 +0000 From: "McDaniel, Timothy" To: Thomas Monjalon CC: "'dev@dpdk.org'" , "Carrillo, Erik G" , "Eads, Gage" , "Van Haaren, Harry" , "'jerinj@marvell.com'" , "'david.marchand@redhat.com'" Thread-Topic: [PATCH v5 00/23] Add DLB2 PMD Thread-Index: AQHWrr6/gG0IhuLnfEaWgT4f3kKGn6mwReaw Date: Fri, 30 Oct 2020 15:35:17 +0000 Message-ID: References: <1602958879-8558-2-git-send-email-timothy.mcdaniel@intel.com> <5348013.yrGTY7C4b0@thomas> In-Reply-To: <5348013.yrGTY7C4b0@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [162.251.9.49] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ae77e2f4-34ce-422f-6850-08d87ce9671e x-ms-traffictypediagnostic: SA2PR11MB5145: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QkGoeumdwWQTy/zTwpjUNcWDJ96MDztpw3FeoH9NjGSMYk1rOr5/GgMSKNrzqqNJrtISaebs5OkfIV4xNy5hUuaa4D4u1pCFAbL9BADncjJLtS7xBuLRbBnehJIdM0HX2+qWIpZNP6fxKCsyNk5vsCDdjgqLuxBHI++XeLem7B2+Wer6aFkUOgsObDok9gLwQt0qH9P1eNjpM4iBUyb0E8UB8liIF1YdNI1H0iHgLWzQkeFYLcXD+LViIRZWV2bNTGGtLlkDnjbl6wq994zptSKBZPZf8LwEqtyJYdJhkOwgUVjspqb+L4kVvVzluVuxj9SIZ49ro5AqxC7u4Ar5hg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3103.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(376002)(346002)(396003)(366004)(71200400001)(53546011)(6506007)(8676002)(26005)(86362001)(186003)(6916009)(33656002)(8936002)(55016002)(9686003)(66556008)(64756008)(478600001)(66446008)(4326008)(76116006)(66946007)(54906003)(66476007)(5660300002)(316002)(52536014)(7696005)(2906002)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 0Bnt9h1lPxonzaAVM9Xnky3YoZEI4lXBeTYISFuiZk7e9ZswNcnzTTEBaFmtxdcgnh+qBmWejhI9/TtMiwa6zCcdb+sIyuygWnOESRdKQReRN9G8Jn8hWzaSwTYnxbcgLneBsYn/yjIAZdu1bdhc6AsKptEMlqxnt1Q8tcDkwHPfuUDG4tDPG2rd8EF/cNzDntZx2MNjI7wNtiEbOuJhtLHpkkHrfRfwD1/D3TQX2EeHbgUrm/08AYpGPnOlyVR8OF5q3h/r4u/pxrWaH8Z49TvqakRIUjEah+hBpGMDadX6L/L/6XNmMOA20BEP/+jl59kfCvLfP16CFh00/2qQmtiTxZ2T6GzR1b/mt1F+jeNXAWd0f4YIe6uFvBwPlhXE3GTbjNcCQws00XFo3CmPx599Rh3C5k3vsKLNuY8x7RvN9UAMJvf3zP6J4DC/LicttMYjL9d5tKUWSv9vvIANy8uXUxMpYHwzA0OwnHUsLJQkjjEErLbB0m92qRW7LGc5h2CxJeDn2pLJ2C8F8tGt6kfwiJEUlF9ecCPr8gWNQgD8+RDYoy/ozdweSGVN3Ix4PoLUH3gTjynhsWRQql6OyHHlryVHA4K2sdQnqOagv2vK9tKAzCOqHP2ERi/ke88WHSY3l5OtmWYLDQz6ND1Oxg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3103.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae77e2f4-34ce-422f-6850-08d87ce9671e X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2020 15:35:17.1475 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1UQTPUlq/PO9rp+/Sq5o9uGq5hG8+vkdwwqrHytOsFN7kVjzRx6x6iRbVjH9qPTCGdx1HzcP/xHEOLtxXtxViSkrRN+9U01eBW4yXaLOjLs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5145 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v5 00/23] Add DLB2 PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Friday, October 30, 2020 8:15 AM > To: McDaniel, Timothy > Cc: 'dev@dpdk.org' ; Carrillo, Erik G > ; Eads, Gage ; Van Haaren= , > Harry ; 'jerinj@marvell.com' > ; 'david.marchand@redhat.com' > > Subject: Re: [PATCH v5 00/23] Add DLB2 PMD >=20 > 30/10/2020 12:58, McDaniel, Timothy: > > From: McDaniel, Timothy > > > From: Thomas Monjalon > > > > 30/10/2020 10:43, Timothy McDaniel: > > > > > - note that the code still uses its private byte-encoded versions= of > > > > > umonitor/umwait, rather than the new functions in the power > > > > > patch that are built on top of those intrinsics. This is intent= ional. > > > > > > > > Why? Now these intrinsics are available in the main branch. > > > > We should avoid duplicating such code. > > > > > > > > > > > > > > I had asked that the low level intrinsics (UMWAIT/UMONITOR) be split = out so > > > that DLB/DLB2 could use them instead of its own private byte-encoded > versions, > > > but instead we have these wrappers that call the low level intrinsics= . Those > > > wrappers > > > introduce additional overhead that is not required for DLB/DLB2. I ha= ve a > > > meeting with Ma Liang on Monday to discuss. > > > > I thought the ask of DLB was to just substitute the low level umwait/um= onitor > byte > > encoded instructions DLB has defined privately with similar byte-encode= d > instructions defined in the power > > patch. The power patch does not directly expose those, which is why I d= id not > update DLB/DLB2. > > The power patch does have the advantage of centralizing the race avoida= nce > > logic, which is a good thing for any PMD that wishes to take advantage = of > umwait/umonitor. >=20 > So you mean the overhead is a good thing? >=20 > > Sorry for the confusion. I just misunderstood what was being asked of D= LB in > regard to switching over.. That being said, > > I am willing to convert DLB/DLB2 to use rte_power_monitor(...) in a fu= ture > patch-set. >=20 > Why not now? >=20 > Indeed there is a confusion and it looks like a lot of novlang > to exit from the situation. > We'll wait a clear decision with facts. >=20 Hi Thomas, I have updated DLB and DLB2 to use rte_power_monitor(...), and those patche= s are ready if you are willing to accept them and the 3 power patches. For the sake of consistency, I see the benefit of using the power patch, ev= en if it is=20 slightly less efficient that the DLB-specific implementation that I current= ly have. We have already encountered an empty queue, so this is no longer fast path = for the PMD.