From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54123A04C1; Thu, 17 Sep 2020 23:26:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 169441D6AD; Thu, 17 Sep 2020 23:26:39 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 0BDB91C18E for ; Thu, 17 Sep 2020 23:26:36 +0200 (CEST) IronPort-SDR: +iOZWyEDDTYrqYjyt8LaRBLvyaaZo0W91ZNsb3zCiN+5CUk5Sy3+EMJ1Q7hGjAMZX/5h4Ov7sM GXNJsbMZmfMQ== X-IronPort-AV: E=McAfee;i="6000,8403,9747"; a="147484073" X-IronPort-AV: E=Sophos;i="5.77,272,1596524400"; d="scan'208";a="147484073" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2020 14:26:31 -0700 IronPort-SDR: QtAKpGh3gbZMQD1abXitcPvtI8MtVRD3H03eRgQI2U0LbCM5iFKdCNhXK98hOBm+RQ0JHbuYN7 Cv6fVThRR5YA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,272,1596524400"; d="scan'208";a="507895939" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP; 17 Sep 2020 14:26:31 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 17 Sep 2020 14:26:13 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 17 Sep 2020 14:26:12 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 17 Sep 2020 14:26:12 -0700 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.59) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 17 Sep 2020 14:26:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VxnuPhUyzI5sG0nvmyyLxRhpmxZt/yEoQVYcykWc1y0WmRUSvjZbB79+mKVwvCqo1y/b9mEXNKpijaUB5/Jyhnlb6v1xeJmcn0YmnNyCTC7keB0oCNt1R+gjEmJFQcrF39cU8Mpnt1djU7n+CTwHq0+y6KEjf118Vx58l0K6zjWbtlwvmEnBWfvnt3q+EGj2D13CWROTeKncXKqv7HWHJiWwrl4AzIrwBf+WW4WVR4D919OLq2gIv8WcHJiBfwB9KSd0CQUoumD1LBg6eQDZTT/JUHvC65EsU2Xyj6PaLnz5Cie7KXHrX6iKS6FB+npBW7Nf8fgAFHv0LXl5QJRKoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8qPauxByThTDov0UNJPnamnEkfDpRlGoSpW3bF+book=; b=ZfiebESaDjUpgHOQhSydXU6+ZEWnnZ9cTKZOgq3hNoBsscxVeVqx4cUvYNk6iJ347v5VHUWuMFJmdwpy+uePMYPC7yLgJNjfBi0vXmULnVZgGMDg+S7xx55W5/knJljai1g4Di5jMe9m4t6YXeU0YoHIdKx42GPgRkDEzJ9vAK7BVdbA7w6V+25h+nUirwxjEHgIRujUIV8pBmY7FdoOyQNHPigTo7svLgt7kV/7Jm2IXU9tfMXIWa1hOhtBFU1g1zxg9w8KCr6ixlhgFUU5MGvpgV2613cert171ZFf6Oy/3xUq27kXJ8KjFaV4efav6ZokwoDis8fdOND3Bri7gA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8qPauxByThTDov0UNJPnamnEkfDpRlGoSpW3bF+book=; b=Mo3fndo01kPO9sIeYteNHGght5758ns1aVaXmzn+RlWMcHzb+Q2UPt0NK7PVdt0j8GiwyEKMF2yVEejwCXWTOHtt3eTjDmR1cb9CnOM/AQ+WV8UAqXQsbFjeI5uY/ZaXppYNXvtYj/IkThLSkIfCZT+TFQ0/NuaoM1gor6IFUS8= Received: from SN6PR11MB3103.namprd11.prod.outlook.com (2603:10b6:805:d7::13) by SN6PR11MB2623.namprd11.prod.outlook.com (2603:10b6:805:5d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Thu, 17 Sep 2020 21:26:08 +0000 Received: from SN6PR11MB3103.namprd11.prod.outlook.com ([fe80::dd10:fbd6:99e9:52f4]) by SN6PR11MB3103.namprd11.prod.outlook.com ([fe80::dd10:fbd6:99e9:52f4%4]) with mapi id 15.20.3391.014; Thu, 17 Sep 2020 21:26:08 +0000 From: "McDaniel, Timothy" To: "Chen, Mike Ximing" CC: "dev@dpdk.org" , "Carrillo, Erik G" , "Eads, Gage" , "Van Haaren, Harry" , "jerinj@marvell.com" Thread-Topic: [dpdk-dev] [PATCH 07/22] event/dlb2: add xstats Thread-Index: AQHWiHqLTcxGINdRWEauHnwRu2CX/6ltVpiAgAAKLxA= Date: Thu, 17 Sep 2020 21:26:08 +0000 Message-ID: References: <1599855987-25976-1-git-send-email-timothy.mcdaniel@intel.com> <1599855987-25976-8-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [162.251.9.49] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ac8d663d-3964-4b59-e92c-08d85b504af9 x-ms-traffictypediagnostic: SN6PR11MB2623: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Yb6d3oqIthRUUfzkczHs6rYxKU/CFb4u8ryOqlORttu8Jtwb8U0XJCsG0EdybcCVSLb9RwEv+/Xtfpni8R4CFqCFlVIYU5LZ8utcYrRedk9DwZcc9SVIKlVRocb9LI+0ahT94Q1htuXNeobkHQ1oNj8sPv7oEljKBHoVRSeHCX0KBt4/AxfrdLD+2jUIXh+S8J8w9+gBz+CFQbv7rT0xw43Uf2N5cNt1QOUWYkH6HX3Zghy9JGytlprqSupLYS6UeFsBwt5mu444VgMr5dFPLkrBveNEZQygAJMuNlRsUQqxNJLvqg6FNN72ye+DcSy/azVbmTJ+J9AD+zCgzouFNJjd0ureN0fFAT2AbV6nWtKtoF6a+JPm3Gs+WvrPYPt+zkbPaUHleOhJuh6BsAGwWg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3103.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(346002)(136003)(376002)(396003)(366004)(64756008)(52536014)(186003)(66556008)(7696005)(6506007)(53546011)(478600001)(4326008)(26005)(2906002)(9686003)(6636002)(55016002)(966005)(316002)(6862004)(8676002)(66946007)(8936002)(66476007)(66446008)(86362001)(76116006)(83380400001)(54906003)(5660300002)(33656002)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: yw4MmcsWC524wUTuK9bqfX02nZk16jBudv8+GLSLBOKYt1LzWVuWZJ1LJYGdoo9rjsOZjxscsIjz/uCbZOp3UhSFluYZ5IUzswsJXC0KFl0A6kTMhe1Q5iW0uuzfba1/Cb13PrV8uWwLJAtVRobIc37fMeXRJsmaP5EykwbYp24SODZpSowJRmzc1brbmTJsxz8l3Wu8/dHEmzhLGCcFt+T8Iuc2lq2+JWx2nHkGEhKa9sqsfdETFCImNagCK7IprAkW7tqw37zhnemwaWtRIuckJUxPxfOgdRGvIKbp784UWODPB+xF7/PatKmVgrMSkBioAibFiGhgPhpCeQVQMeovUr3bqQDZTZgHfjmBzUTXwTX4U+1KfJWJdG2NsUmJik/XrzUBNKCG5py+5EFfsmRwyh7hm5BtrREG4RsnkFsVS2omqlpn8MFAf8cVNE8JCdfpRdES1YnA9mHkDv7SfTbX7M4vUmNlCKzuC3rWa5Q+oQC4hLa7XibPnFYBEYE9qBA2ZPnweIwieD8S25f3LxzxeA3YfxvsZe7BB3amM0Co/qONNH/2i9JdAGDrWgbtGgL8MkkY5cdE4RN7yuAyGP5Ci68xEwJt5jO9hM5Eip3YBMTIgncLnMyW7/Z+Q6GYF0B8s510zJyWNHBA/YkC+w== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3103.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac8d663d-3964-4b59-e92c-08d85b504af9 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Sep 2020 21:26:08.4239 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IQCUKUHjs7Vc7X3Ofy0IWmSxY6lQOOcWoWZ/pB9vPDYfYSLwYC1fYUXorOqplmdtmVs0Rt9+rB9dByM4jbmNggiSmU4C27Lq3cHLm1cZb24= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2623 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 07/22] event/dlb2: add xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Chen, Mike Ximing > Sent: Thursday, September 17, 2020 3:58 PM > To: McDaniel, Timothy > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gag= e > ; Van Haaren, Harry ; > jerinj@marvell.com > Subject: RE: [dpdk-dev] [PATCH 07/22] event/dlb2: add xstats >=20 > > > +dlb2_eventdev_dump(struct rte_eventdev *dev, FILE *f) { > > + struct dlb2_eventdev *dlb2; > > + struct dlb2_hw_dev *handle; > > + int i; > > + > > + if (!f) { > > + printf("Invalid file pointer\n"); > > + return; > > + } > > + > > + if (!dev) { > > + fprintf(f, "Invalid event device\n"); > > + return; > > + } > > + > > + dlb2 =3D dlb2_pmd_priv(dev); > > + > > + if (!dlb2) { > > + fprintf(f, "DLB2 Event device cannot be dumped!\n"); > > + return; > > + } > > + >=20 > Not sure if this is enforced. The DPDK coding style discourages using ! o= n > pointers ( see section 1. 8.1 at > https://doc.dpdk.org/guides/contributing/coding_style.html). >=20 I see !ptr used in many other dpdk components, and it is not flagged by che= ckpatch either.