DPDK patches and discussions
 help / color / mirror / Atom feed
From: "McDaniel, Timothy" <timothy.mcdaniel@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Carrillo, Erik G" <erik.g.carrillo@intel.com>,
	"Van Haaren, Harry" <harry.van.haaren@intel.com>,
	Jerin Jacob <jerinj@marvell.com>,
	Jerin Jacob <jerinjacobk@gmail.com>
Subject: Re: [dpdk-dev] [PATCH 1/1] event/dlb2: fix vector based dequeue
Date: Wed, 19 May 2021 15:23:24 +0000	[thread overview]
Message-ID: <SN6PR11MB3103A923505D0B1B18FC53BB9E2B9@SN6PR11MB3103.namprd11.prod.outlook.com> (raw)
In-Reply-To: <5671577.oRBYnC9OHh@thomas>

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, May 19, 2021 4:44 AM
> To: McDaniel, Timothy <timothy.mcdaniel@intel.com>
> Cc: dev@dpdk.org; Carrillo, Erik G <erik.g.carrillo@intel.com>; Van Haaren,
> Harry <harry.van.haaren@intel.com>; Jerin Jacob <jerinj@marvell.com>; Jerin
> Jacob <jerinjacobk@gmail.com>
> Subject: Re: [dpdk-dev] [PATCH 1/1] event/dlb2: fix vector based dequeue
> 
> 18/05/2021 17:01, Jerin Jacob:
> > On Wed, May 12, 2021 at 11:55 PM McDaniel, Timothy
> > <timothy.mcdaniel@intel.com> wrote:
> > >
> > > From: Timothy McDaniel <timothy.mcdaniel@intel.com>
> > >
> > > This commit fixes the following bugs in the vector based
> > > dequeue path:
> > > - extract hw sched type
> > > - update xstats
> > >
> > > The default mode of operation was also changed from vector
> > > optimized mode to scalar mode.
> > >
> > > Fixes: 000a7b8e7582 ("event/dlb2: optimize dequeue operation")
> > > Cc: timothy.mcdaniel@intel.com
> >
> > Removed this CC
> > >
> > > Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
> >
> > @Thomas Monjalon  Could you merge this patch as this is one only patch
> > for the final release from eventdev.
> > This patch is passing my sanity build tests.
> 
> This patch seems to change 3 unrelated things.
> This is bad for tracking changes.
> Please could you split?
> 

I will split and resubmit both this patch and the documentation patch.

Thanks,
Tim


  reply	other threads:[~2021-05-19 15:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12 18:24 McDaniel, Timothy
2021-05-18 15:01 ` Jerin Jacob
2021-05-19  9:44   ` Thomas Monjalon
2021-05-19 15:23     ` McDaniel, Timothy [this message]
2021-05-20 16:11 ` [dpdk-dev] [PATCH] event/dlb2: fix extraction of HW scheduling type Timothy McDaniel
2021-05-20 16:12 ` [dpdk-dev] [PATCH] event/dlb2: make scalar mode dequeue the default Timothy McDaniel
2021-05-20 16:13 ` [dpdk-dev] [PATCH] event/dlb2: remove references to deferred scheduling Timothy McDaniel
2021-05-20 18:08 ` [dpdk-dev] [PATCH v2] event/dlb2: make scalar mode dequeue the default Timothy McDaniel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB3103A923505D0B1B18FC53BB9E2B9@SN6PR11MB3103.namprd11.prod.outlook.com \
    --to=timothy.mcdaniel@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=erik.g.carrillo@intel.com \
    --cc=harry.van.haaren@intel.com \
    --cc=jerinj@marvell.com \
    --cc=jerinjacobk@gmail.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).