From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E05FA04DC; Tue, 20 Oct 2020 17:44:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5D1F0BCC6; Tue, 20 Oct 2020 17:44:22 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 2C9E8BB96 for ; Tue, 20 Oct 2020 17:44:18 +0200 (CEST) IronPort-SDR: A8c1Mfd8SQwVyJXzYScy9g1fsCzrz2xW6B+oYTa2O4kXgI0b9OnjZpN4+GBHCfxlHaWmpHqPM8 qTV2nj5J9zoA== X-IronPort-AV: E=McAfee;i="6000,8403,9779"; a="231425580" X-IronPort-AV: E=Sophos;i="5.77,397,1596524400"; d="scan'208";a="231425580" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2020 08:44:16 -0700 IronPort-SDR: 2K7Lgwtuc6UqkSUDR0noaEPPiuu0UWQwfbUQ72HUzJqM5x7pPqQBZE3XSPKXniOpi+tybydNHj WQmwHqpoNP+w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,397,1596524400"; d="scan'208";a="359213848" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 20 Oct 2020 08:44:15 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 20 Oct 2020 08:44:15 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 20 Oct 2020 08:44:15 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.58) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 20 Oct 2020 08:44:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A+4te+Y1Gu4WyhEJylXZUxlP6dTzGDFjuX1oguwu02TRwPTntS27BZwSNZ/gjE9ajYZkKFshnj4AfplfHXcI3tnBix/ahEjdfpZTDtXtbr0aw1Wnt7IjOnIpzblAvK/dgvgO39hJcpeVV++RRbhwN8pdUkKWGZEutN4bMrxAfZml8kOGhakxi29Zt5z7Sd03q7afFPzXe5A/xSnwBYFNLEAh/qISbmIHF/bi+a/X2A2jBv7319hJh8qmjoMex+ggcNSMvM2OV+LeLQ93rk8oRxftRGXB1npkG2Qq0uNr8RM8pjAbBxfQSleh7bSn6F05Z/GV8zlpMdwZ0JXeiySgPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YT+bMNX7BGE4NQ0bK88SyFoJpLpgB6HSfZ7G9rIZgsQ=; b=mId9/RCU63S1Pn8EkjP+T7Kf1sGmky+v5/3o+lypmgjXoMAfpywn4wZFDWYh1d5KA/CPimwsSzLmKLWfoypPDg5NjStBeQwJfw+kwoAvTHQKdYTd0bctoW8B4p2lNqd3MhvyezEYLr40RrG0jJCaJl/cksKJG6+RtZdQ+Unk0mFWTBiwaroldASk1xTaIhgn7aEuOoaX5EqHigcb3S3m9j2GEpPyoEdTR6q0keYqm51KXh5n2rS52nusX5ZUYLnT6hu9oTYQB4fy67tx0+A1PjyquhPPYF/dXJkyZaZK08o03mWrtE9XPBqv5qJF2jvc5vsMxwOCOxlSDSdRyVOcXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YT+bMNX7BGE4NQ0bK88SyFoJpLpgB6HSfZ7G9rIZgsQ=; b=OHURcGpcWLuPzjG44hqh545uXjPXvnNlwCmTlnNbGQpK5ZdCgDs+WCWEc5n1B8+NKOJ8uH3Z9zgUmNBJGQgSbUxdHQSKVjAxA3fHDuIfqao7aFIKsKlFy3U6GAmq0DBNiAwptKOlf4zU+isN18QgV7H85shQxjQQzJpIA+6zUs8= Received: from SN6PR11MB3103.namprd11.prod.outlook.com (2603:10b6:805:d7::13) by SN6PR11MB3485.namprd11.prod.outlook.com (2603:10b6:805:b7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.28; Tue, 20 Oct 2020 15:43:45 +0000 Received: from SN6PR11MB3103.namprd11.prod.outlook.com ([fe80::41fb:70e6:6102:a616]) by SN6PR11MB3103.namprd11.prod.outlook.com ([fe80::41fb:70e6:6102:a616%7]) with mapi id 15.20.3477.028; Tue, 20 Oct 2020 15:43:45 +0000 From: "McDaniel, Timothy" To: "Richardson, Bruce" CC: Jerin Jacob , "Mcnamara, John" , "Kovacevic, Marko" , Ray Kinsella , Neil Horman , dpdk-dev , "Carrillo, Erik G" , "Eads, Gage" , "Van Haaren, Harry" , Jerin Jacob , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentation and meson build infrastructure Thread-Index: AQHWpSuei/E6j1Yiyk6N717ECjYmz6memryAgAICegCAAAWMgIAAAexQ Date: Tue, 20 Oct 2020 15:43:45 +0000 Message-ID: References: <1599855987-25976-2-git-send-email-timothy.mcdaniel@intel.com> <1602958879-8558-1-git-send-email-timothy.mcdaniel@intel.com> <1602958879-8558-2-git-send-email-timothy.mcdaniel@intel.com> <20201019083337.GA649@bricha3-MOBL.ger.corp.intel.com> <20201020153451.GI558@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20201020153451.GI558@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [162.251.9.49] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 399d28f1-b05d-47c5-7b95-08d8750eedd4 x-ms-traffictypediagnostic: SN6PR11MB3485: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iDJEl8wzCWp4NKYkgDg3LV+2nebNKz6TE2a/O41Ty7x2rj0clmxmZR88XRJBLk1JI+hY8jzErlMP2T2bPZMX+nv2wNelAmHzCvJpsWVDCyp/M8XbJS9A9JYSrXRyZv+lGY82QlMPUNFH/iRIEI/6v0jj51WFNws8rLKqSRHvVoKh0QX48kEMznRNakMaYsQdB8qFcNuSdMBw4XUZvRZuBu794EKfWwn9zWczg9V550eMArPguFoJjcXIr+IZXSZG4K0ZIHloyRWvSUNWWw5wxnUEGwpJb99NTmIc/ObopEWzcs7ULJPYtAlGqfzQAogC x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3103.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(396003)(346002)(136003)(39860400002)(316002)(76116006)(55016002)(52536014)(7696005)(8936002)(54906003)(478600001)(5660300002)(9686003)(83380400001)(2906002)(33656002)(71200400001)(186003)(26005)(66946007)(66556008)(66476007)(6636002)(64756008)(66446008)(86362001)(53546011)(8676002)(6506007)(6862004)(4326008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 7JYw3xR/Iyx+OWgyeRPq4ohwnIyeMKuuQfDYoHEqEvgzqcCEvEiqyQvQDzvJAPVTcdypM+SXnl4XYObO23mqBVhCWlHOVoowza67nj5jZTEg/FqtbFBqBYd+t3axOKFEQUckk0sHYwgPyCZWzHhlq23OkdyO8M6L8DAYmBFNbP8MeiFrnz7FgRh9Ic2S6eN9CMzijK6T9lvWer3fnMJb25C05W0bpCtdWPYdydrjfsMrAteypz7vgDo4iSvwcKzRtefkA+7jVi/r3+k7ErR+sGYYSXuErt7pta40DdzIN3ThA2qYdw56A06PCBMvckSW3VunhbP5m8arnZisTALFwRvibN5Pflje2SYVTYcwRwp+UMDUrGbnWvYoq1relV97bbC84dIaKVrtDw4GCCck/VK1ZT8XwjAvwVIFaPvIAINtOsFf7QU1mJXKjaAtVkoXzozSXZvXkq5WIOL3w0baFOBkHgMYh7JYJ625y3gMi1ji5rvwDWf2Oq9AuiQazQ5L7xL5fagV80k9UqYa56Z3XokjaAtLp7LivO5e11U6dYAFcDeqHtXwOKYJ5EAoNEFxO/0G8DH/jsBwMQHRqrueKmfsPv4+cNb/j3+ot/x0+yvhfOIJc/V6X0PD4Bjjxh+VXRX0ubJCPhGmhkU6jUglXA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3103.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 399d28f1-b05d-47c5-7b95-08d8750eedd4 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2020 15:43:45.1683 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gcf/CVIdGnMo4Zcalwfwu8bnNrvo0EeWsyChn+wvLDyhr0rXQVsGnEAYxNSY5gVDxedmWmd6Ba3J17KSNy3oDovJSB7pHnSnmlOr++3gX4U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3485 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentation and meson build infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Bruce Richardson > Sent: Tuesday, October 20, 2020 10:35 AM > To: McDaniel, Timothy > Cc: Jerin Jacob ; Mcnamara, John > ; Kovacevic, Marko > ; Ray Kinsella ; Neil Horman > ; dpdk-dev ; Carrillo, Erik G > ; Eads, Gage ; Van Haaren= , > Harry ; Jerin Jacob ; > Thomas Monjalon > Subject: Re: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentation an= d > meson build infrastructure >=20 > On Tue, Oct 20, 2020 at 04:17:13PM +0100, McDaniel, Timothy wrote: > > > > > > > -----Original Message----- > > > From: Bruce Richardson > > > Sent: Monday, October 19, 2020 3:34 AM > > > To: Jerin Jacob > > > Cc: McDaniel, Timothy ; Mcnamara, John > > > ; Kovacevic, Marko > > > ; Ray Kinsella ; Neil > Horman > > > ; dpdk-dev ; Carrillo, Erik G > > > ; Eads, Gage ; Van > Haaren, > > > Harry ; Jerin Jacob ; > > > Thomas Monjalon > > > Subject: Re: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentatio= n > and > > > meson build infrastructure > > > > > > On Sun, Oct 18, 2020 at 02:18:32PM +0530, Jerin Jacob wrote: > > > > On Sat, Oct 17, 2020 at 11:50 PM Timothy McDaniel > > > > wrote: > > > > > > > > > > Adds the meson build infrastructure, which includes > > > > > compile-time constants in rte_config.h. DLB2 is > > > > > only supported on Linux X86 platforms at this time. > > > > > > > > > > Signed-off-by: Timothy McDaniel > > > > > Reviewed-by: Gage Eads > > > > > --- > > > > > config/rte_config.h | 7 + > > > > > doc/guides/eventdevs/dlb2.rst | 330 > ++++++++++++++++++++++ > > > > > doc/guides/eventdevs/index.rst | 1 + > > > > > drivers/event/dlb2/meson.build | 7 + > > > > > drivers/event/dlb2/rte_pmd_dlb2_event_version.map | 3 + > > > > > drivers/event/meson.build | 3 + > > > > > 6 files changed, 351 insertions(+) > > > > > create mode 100644 doc/guides/eventdevs/dlb2.rst > > > > > create mode 100644 drivers/event/dlb2/meson.build > > > > > create mode 100644 > drivers/event/dlb2/rte_pmd_dlb2_event_version.map > > > > > > > > > > diff --git a/config/rte_config.h b/config/rte_config.h > > > > > index 0bae630..fd1b3c3 100644 > > > > > --- a/config/rte_config.h > > > > > +++ b/config/rte_config.h > > > > > @@ -131,4 +131,11 @@ > > > > > /* QEDE PMD defines */ > > > > > #define RTE_LIBRTE_QEDE_FW "" > > > > > > > > > > +/* DLB2 defines */ > > > > > +#define RTE_LIBRTE_PMD_DLB2_POLL_INTERVAL 1000 > > > > > +#define RTE_LIBRTE_PMD_DLB2_UMWAIT_CTL_STATE 0 > > > > > +#undef RTE_LIBRTE_PMD_DLB2_QUELL_STATS > > > > > +#define RTE_LIBRTE_PMD_DLB2_SW_CREDIT_QUANTA 32 > > > > > +#define RTE_PMD_DLB2_DEFAULT_DEPTH_THRESH 256 > > > > > > > > We are going way with GLOBAL compile time options for drivers. > > > > I think, we should move to driver-specific folder not pollute top > > > > level config file. > > > > @Richardson, Bruce @Thomas Monjalon Thoughts? > > > > > > > Yes, we do need a better way to pass driver-specific build config opt= ions. > > > How likely is it that the user may want to tweak these values? If it'= s not > > > likely having them just as regular defines in the driver folder may b= e > > > better, though they are not particularly problematic in rte_config.h = given > > > the number of other values already there. > > > > > > > > > > > > + > > > > > > > > --- a/drivers/event/meson.build > > > > > +++ b/drivers/event/meson.build > > > > > @@ -10,6 +10,9 @@ if not (toolchain =3D=3D 'gcc' and > > > cc.version().version_compare('<4.8.6') and > > > > > dpdk_conf.has('RTE_ARCH_ARM64')) > > > > > drivers +=3D 'octeontx' > > > > > endif > > > > > +if (dpdk_conf.has('RTE_ARCH_X86_64') and is_linux) > > > > > + drivers +=3D 'dlb2' > > > > > +endif > > > > > > > > Please add the message in "Content Skipped" section, > > > > Reference: grep "reason" in drivers/vdpa/mlx5/meson.build > > > > > > > > > > The octeontx case is also wrong in this file, IMHO. Rather than check= ing > > > things in the event level and adding things to the list, the list sho= uld > > > just be static. If something should be optionally compiled, then chec= k the > > > conditions in the driver meson.build file itself and add "build=3Dfal= se" to > > > disable, setting "reason" to the cause of it being disabled. This kee= ps all > > > the logic about a driver in the other file, rather than someone havin= g to > > > look in multiple places for why something is or isn't getting built > > > properly. > > > > > > Regards, > > > /Bruce > > > > Due to time constraints, I would prefer to take these issues up in a fu= ture > release. > > > I'm not suggesting you need to fix the existing octeon case, but it's eas= y > enough to add dlb2 to the existing list and add : >=20 > if not dpdk_conf.has('RTE_ARCH_X86_64') or not is_linux > build =3D false > reason =3D "..." > endif >=20 > to the dlb2 meson.build file. >=20 > Regards, > /Bruce Very well. I used the existing event/meson.build and conditional inclusion= of the octeon driver as my guide for conditionally including DLB and DLB2. It's easy enough to = change, so I will do it.