From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B08E6A04DE; Fri, 30 Oct 2020 12:58:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5857BC866; Fri, 30 Oct 2020 12:58:48 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id C3C05C844 for ; Fri, 30 Oct 2020 12:58:45 +0100 (CET) IronPort-SDR: R8KqFl/basI6qdvRELpQ/mQvvfOH4ZZ2NrKrWTMaTRsdg1BPfeXxK5iLi2W2TcJEKZRtgcObNB Bq4V6B8LvG+A== X-IronPort-AV: E=McAfee;i="6000,8403,9789"; a="253303966" X-IronPort-AV: E=Sophos;i="5.77,433,1596524400"; d="scan'208";a="253303966" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 04:58:43 -0700 IronPort-SDR: /HGtQ8sxU5KImx0TaSO8ry5NURU7JCAFcmR/kdwLaYzuEQwO4HQZRYrfK5liCWOzUsmW212JOS JKN7DknOp6Jw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,433,1596524400"; d="scan'208";a="324057879" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga006.jf.intel.com with ESMTP; 30 Oct 2020 04:58:43 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 30 Oct 2020 04:58:43 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 30 Oct 2020 04:58:42 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 30 Oct 2020 04:58:42 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 30 Oct 2020 04:58:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VIGxfXBcMsnSEot2FdBG2ILesNCiy+da+PjULI/5sgMFK/R8EinHa13jleZYBT4CSrqVbpUzPOoGFLrSsqPkwZP0sLfW2PqA4MCMAEdiLINqjR8AdSLVuN6IGXbd99UuljfXxpsr2q16mw5sZ+RH0W+npAvcGmWBAjWqNP/HzbsMXCGn8Rg1DuBPZ+/I1tVW+h3x4BoWKY70E1qTj5Id0uieQ0h9FaGnLH5Rdm6aHK9MOouENjvw+8NF/um4OKoAImlMtTYjF7VHAqG1i22R7FIlnUVrUvQZdgFKMSbXG5700Kv0mfDy9IT/mS7nEcLGFvv05EFUDsFUVPYXAn2+BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9P0JlZD1TeAHfQzSwPjGoxXuQBRRofH9qIgfZCrqikU=; b=cerFIZY4ooCb32LWF6o2N2RgTATPBFMRvNZMDYlYBXFjDXcDQy/UuG6Au04fAmbWgzYWM50MmbXGcciq6P6z/3X4/b71iIm1O7rgbkBD5UDxVsWZxX0O3XMZJxKscTb1a4BbRe8xCKogM5Q5jsK4XsWg8Fr7R9562v+/asMPgxx9LtF0+Nf+o8Qm0u4FhDZPoyzrJNPwzIqi+EOBGd1X2xPcGZgE76hRgEyJJKGBrektFO0xnFsGoWOl4udPsyAb8N63Bfj0PE0HpV/xIgyxIASmOD2woBpqK59yEkXF1anQz10AktcQPUbO+xgeoLEagQZjWD6eNUKrtdTBsgU5DA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9P0JlZD1TeAHfQzSwPjGoxXuQBRRofH9qIgfZCrqikU=; b=BPLHYnOJDxDanYkXKQKFdATl/mIZi4gXJjRua2gSJbQJYX1djdfR0e4OrMm+/yBlHTrbqbmkBBPHUpN6RokDaDJFjx1zG+d2R18+Ho2QKIwNbFcOShISBmdOalHcmEKY+KMzuEDW0RbpsJRzJJkhb6qUeXbULDhGcQjAvHt7oVs= Received: from SN6PR11MB3103.namprd11.prod.outlook.com (2603:10b6:805:d7::13) by SN6PR11MB3341.namprd11.prod.outlook.com (2603:10b6:805:bc::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.27; Fri, 30 Oct 2020 11:58:41 +0000 Received: from SN6PR11MB3103.namprd11.prod.outlook.com ([fe80::e43b:59bb:161:8349]) by SN6PR11MB3103.namprd11.prod.outlook.com ([fe80::e43b:59bb:161:8349%3]) with mapi id 15.20.3499.029; Fri, 30 Oct 2020 11:58:41 +0000 From: "McDaniel, Timothy" To: 'Thomas Monjalon' CC: "'dev@dpdk.org'" , "Carrillo, Erik G" , "Eads, Gage" , "Van Haaren, Harry" , "'jerinj@marvell.com'" , "'david.marchand@redhat.com'" Thread-Topic: [PATCH v5 00/23] Add DLB2 PMD Thread-Index: AQHWrqOyO/va3ZFfcUaVCyeZzLweQqmv7KbggAAavZA= Date: Fri, 30 Oct 2020 11:58:41 +0000 Message-ID: References: <1602958879-8558-2-git-send-email-timothy.mcdaniel@intel.com> <1604051021-26699-1-git-send-email-timothy.mcdaniel@intel.com> <3010612.HaWdak5MLs@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [162.251.9.49] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d6f11891-12bb-41bb-6c94-08d87ccb2543 x-ms-traffictypediagnostic: SN6PR11MB3341: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VewKFzctm3Af4zgmDA/ga19pL87dcqnK+/1qjAjk4L0hxMPLTgib9fZ3MdqxRkKi3ha+TvG+c7eyWGkjBZcBcGl8RUWgajguq9adow5YmKt7RnrnBXHR5r5hrveNXMonBO85TenFXHX5lZZIreb+AmLjTHULeuj9CMo8+C8PXJWNKKYomKvY2lqRmmuy1YnEbfNId6K9gRHA+dU8G81KCpuMMbciF9gS3xZgFegFoIp/hGHkoNeEBQCFwBbLKZa+76plMq8YqsQqPLrHyMAC07xWuZkesUhkCdL3u9SEFDWEJPgQ1nWQ/EvzFL8S795VWOgMRJj32aIRXVym03N25w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3103.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(39860400002)(346002)(376002)(396003)(52536014)(54906003)(6916009)(5660300002)(64756008)(8676002)(66476007)(4326008)(55016002)(66556008)(2906002)(66946007)(66446008)(316002)(86362001)(7696005)(76116006)(8936002)(6506007)(53546011)(33656002)(186003)(26005)(2940100002)(83380400001)(71200400001)(478600001)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 0ZQbw0NN8W1fbua3W0ZY3z/myJF1I7youCqIEOV5DH3jfBqWak5M50nBFxHquqNly6/tAOWCECt+5LqoKSj4Z63/oj7quS38KwflOPSPZnwd02CgHjKxIqay6ERwKWRrpzDWQjcfPdYVsLVwRt1mh5i48XQhNbtX8qg9suvKgHBWJNVw+rZiGGv6TuThAGjbo2HzTD0nZDL/l3ttPFCUjtlDEq3wiGdKuYXaWYwUCU03oEmfEjXUK7wTiIXIvuXn0K4Pv3/pwORUYPZbuwmPXt6/92mwDSBk367YM2A8dRvg0IfBYxZlGsiwiuSWTRwLmp0P63x/evjtyI4vH/f02Q3TV9UvoHGlad9qVOfTiC2AY1v5X+wKWUZy3ODvhvSnecGXwSoIuCj3hAAmI8LxnVZ8km/kIUu1l23dghinpbfrYrLmWb4Nr8afhTLzP70p8IGjI54GX1uTTmjsGKEjjeMK0Wjpy1umQTwhXu5sOZKrT5rJwLfSfsG5mC/wcFEzTNRuNQWtEfW+t4XXe9RrIkKHLQgY2IW2jN9v6rwvdgdtgEJmPYOAUNYNAfKDSxDfCTEE6kX1SR5MaLE+2GTfww7rdGe6STi/2BPCYZJPeRwSvWy3Ky5lxxvHzJ4XZGKPRXQ2cqGQNcPTE69AjyBmCA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3103.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6f11891-12bb-41bb-6c94-08d87ccb2543 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2020 11:58:41.6647 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VBBX5dQ1NWYKG8rXP/++PbiSTVGvQXpviqAstl7qpvmEEUVrEBlGIV0pVBbolmLV2AkkhDO27oiFQpTEOhYHqAEWvDYyFh1bjW6QoyK1gvw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3341 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v5 00/23] Add DLB2 PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: McDaniel, Timothy > Sent: Friday, October 30, 2020 5:17 AM > To: Thomas Monjalon > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gag= e > ; Van Haaren, Harry ; > jerinj@marvell.com; david.marchand@redhat.com > Subject: RE: [PATCH v5 00/23] Add DLB2 PMD >=20 > > -----Original Message----- > > From: Thomas Monjalon > > Sent: Friday, October 30, 2020 5:02 AM > > To: McDaniel, Timothy > > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, G= age > > ; Van Haaren, Harry ; > > jerinj@marvell.com; david.marchand@redhat.com > > Subject: Re: [PATCH v5 00/23] Add DLB2 PMD > > > > 30/10/2020 10:43, Timothy McDaniel: > > > - note that the code still uses its private byte-encoded versions of > > > umonitor/umwait, rather than the new functions in the power > > > patch that are built on top of those intrinsics. This is intentiona= l. > > > > Why? Now these intrinsics are available in the main branch. > > We should avoid duplicating such code. > > > > >=20 > I had asked that the low level intrinsics (UMWAIT/UMONITOR) be split out = so > that DLB/DLB2 could use them instead of its own private byte-encoded vers= ions, > but instead we have these wrappers that call the low level intrinsics. Th= ose > wrappers > introduce additional overhead that is not required for DLB/DLB2. I have a > meeting with Ma Liang on Monday to discuss. I thought the ask of DLB was to just substitute the low level umwait/umonit= or byte encoded instructions DLB has defined privately with similar byte-encoded in= structions defined in the power patch. The power patch does not directly expose those, which is why I did n= ot update DLB/DLB2. The power patch does have the advantage of centralizing the race avoidance logic, which is a good thing for any PMD that wishes to take advantage of u= mwait/umonitor. =20 Sorry for the confusion. I just misunderstood what was being asked of DLB i= n regard to switching over.. That being said,=20 I am willing to convert DLB/DLB2 to use rte_power_monitor(...) in a future= patch-set. Thanks, Tim