DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
	"Jerin Jacob Kollanukkaran" <jerinj@marvell.com>,
	"Carrillo, Erik G" <erik.g.carrillo@intel.com>,
	"Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>,
	"McDaniel, Timothy" <timothy.mcdaniel@intel.com>,
	"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
	"Van Haaren, Harry" <harry.van.haaren@intel.com>,
	mattias.ronnblom <mattias.ronnblom@ericsson.com>,
	"Ma, Liang J" <liang.j.ma@intel.com>,
	Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5 2/8] eventdev: introduce event vector Rx capability
Date: Thu, 25 Mar 2021 09:50:12 +0000
Message-ID: <SN6PR11MB31175B99312B46B4C1187C70FD629@SN6PR11MB3117.namprd11.prod.outlook.com> (raw)
In-Reply-To: <PH0PR18MB40864F2CCA3306B31C2D26F9DE629@PH0PR18MB4086.namprd18.prod.outlook.com>

> -----Original Message-----
> From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> Sent: Thursday, March 25, 2021 2:54 PM
> To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Carrillo, Erik G
> <erik.g.carrillo@intel.com>; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; McDaniel, Timothy
> <timothy.mcdaniel@intel.com>; hemant.agrawal@nxp.com; Van Haaren, Harry <harry.van.haaren@intel.com>; mattias.ronnblom
> <mattias.ronnblom@ericsson.com>; Ma, Liang J <liang.j.ma@intel.com>; Ray Kinsella <mdr@ashroe.eu>; Neil Horman
> <nhorman@tuxdriver.com>
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v5 2/8] eventdev: introduce event vector Rx capability
> 
> >> From: pbhagavatula@marvell.com <pbhagavatula@marvell.com>
> >> Sent: Wednesday, March 24, 2021 10:35 AM
> >> To: jerinj@marvell.com; Jayatheerthan, Jay
> ><jay.jayatheerthan@intel.com>; Carrillo, Erik G
> ><erik.g.carrillo@intel.com>; Gujjar,
> >> Abhinandan S <abhinandan.gujjar@intel.com>; McDaniel, Timothy
> ><timothy.mcdaniel@intel.com>; hemant.agrawal@nxp.com; Van
> >> Haaren, Harry <harry.van.haaren@intel.com>; mattias.ronnblom
> ><mattias.ronnblom@ericsson.com>; Ma, Liang J
> >> <liang.j.ma@intel.com>; Ray Kinsella <mdr@ashroe.eu>; Neil Horman
> ><nhorman@tuxdriver.com>
> >> Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@marvell.com>
> >> Subject: [dpdk-dev] [PATCH v5 2/8] eventdev: introduce event vector
> >Rx capability
> >>
> >> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >>
> >> Introduce event ethernet Rx adapter event vector capability.
> >>
> >> If an event eth Rx adapter has the capability of
> >> RTE_EVENT_ETH_RX_ADAPTER_CAP_EVENT_VECTOR then a given Rx
> >queue
> >> can be configured to enable event vectorization by passing the
> >> flag RTE_EVENT_ETH_RX_ADAPTER_QUEUE_EVENT_VECTOR to
> >> rte_event_eth_rx_adapter_queue_conf::rx_queue_flags while
> >configuring
> >> Rx adapter through rte_event_eth_rx_adapter_queue_add().
> >>
> >> The max vector size, vector timeout define the vector size and
> >> mempool used for allocating vector event are configured through
> >> rte_event_eth_rx_adapter_queue_add. The element size of the
> >element
> >> in the vector pool should be equal to
> >>     sizeof(struct rte_event_vector) + (vector_sz * sizeof(uintptr_t))
> >>
> >> Application can use `rte_event_vector_pool_create` to create the
> >> vector mempool used for
> >> rte_event_eth_rx_adapter_queue_conf::vector_mp.
> >>
> >> The Rx adapter would be responsible for vectorizing the mbufs
> >> based on the flow, the vector limits configured by the application
> >> and add the vector event of mbufs to the event queue set via
> >> rte_event_eth_rx_adapter_queue_conf::ev::queue_id.
> >> It should also mark rte_event_vector::union_valid and fill
> >> rte_event_vector::port, rte_event_vector::queue.
> >>
> >> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >> Acked-by: Jerin Jacob <jerinj@marvell.com>
> >> ---
> >>  .../prog_guide/event_ethernet_rx_adapter.rst  |  38 ++++++
> >>  lib/librte_eventdev/eventdev_pmd.h            |  53 ++++++++
> >>  .../rte_event_eth_rx_adapter.c                | 114 ++++++++++++++++++
> >>  .../rte_event_eth_rx_adapter.h                | 105 ++++++++++++++++
> >>  lib/librte_eventdev/rte_eventdev.h            |  30 ++++-
> >>  lib/librte_eventdev/version.map               |   2 +
> >>  6 files changed, 340 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
> >b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
> >> index cb44ce0e4..5eefef355 100644
> >> --- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
> >> +++ b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
> >> @@ -186,3 +186,41 @@ the event buffer fill level is low. The
> >>  ``rte_event_eth_rx_adapter_cb_register()`` function allow the
> >application
> >>  to register a callback that selects which packets to enqueue to the
> >event
> >>  device.
> >> +
> >> +Rx event vectorization
> >> +~~~~~~~~~~~~~~~~~~~~~~
> >> +
> >> +The event devices, ethernet device pairs which support the capability
> >> +``RTE_EVENT_ETH_RX_ADAPTER_CAP_EVENT_VECTOR`` can
> >aggregate packets based on
> >> +flow characteristics and generate a ``rte_event`` containing
> >``rte_event_vector``
> >> +whose event type is either ``RTE_EVENT_TYPE_ETHDEV_VECTOR`` or
> >> +``RTE_EVENT_TYPE_ETH_RX_ADAPTER_VECTOR``.
> >> +The aggregation size and timeout are configurable at a queue level
> >and the
> >> +maximum, minimum vector sizes and timeouts vary based on the
> >device capability
> >> +and can be queried using
> >``rte_event_eth_rx_adapter_vector_limits_get``.
> >> +The Rx adapter additionally might include useful data such as
> >ethernet device
> >> +port and queue identifier in the ``rte_event_vector::port`` and
> >> +``rte_event_vector::queue`` and mark
> >``rte_event_vector::attr_valid`` as true.
> >> +
> >> +A loop processing ``rte_event_vector`` containing mbufs is shown
> >below.
> >> +
> >> +.. code-block:: c
> >> +
> >> +        event = rte_event_dequeue_burst(event_dev, event_port,
> >&event,
> >> +                                        1, 0);
> >> +        if (!event)
> >> +                continue;
> >> +
> >> +        switch (ev.event_type) {
> >> +        case RTE_EVENT_TYPE_ETH_RX_ADAPTER_VECTOR:
> >> +        case RTE_EVENT_TYPE_ETHDEV_VECTOR:
> >> +                struct rte_mbufs **mbufs;
> >> +
> >> +                mbufs = (struct rte_mbufs **)ev[i].vec->mbufs;
> >> +                for (i = 0; i < ev.vec->nb_elem; i++) {
> >> +                        /* Process each mbuf. */
> >> +                }
> >> +        break;
> >> +        case ...
> >> +        ...
> >> +        }
> >> diff --git a/lib/librte_eventdev/eventdev_pmd.h
> >b/lib/librte_eventdev/eventdev_pmd.h
> >> index 7eb9a7739..9297f1433 100644
> >> --- a/lib/librte_eventdev/eventdev_pmd.h
> >> +++ b/lib/librte_eventdev/eventdev_pmd.h
> >> @@ -645,6 +645,53 @@ typedef int
> >(*eventdev_eth_rx_adapter_stats_reset)
> >>   */
> >>  typedef int (*eventdev_selftest)(void);
> >>
> >> +struct rte_event_eth_rx_adapter_vector_limits;
> >> +/**
> >> + * Get event vector limits for a given event, ethernet device pair.
> >> + *
> >> + * @param dev
> >> + *   Event device pointer
> >> + *
> >> + * @param eth_dev
> >> + *   Ethernet device pointer
> >> + *
> >> + * @param[out] limits
> >> + *   Pointer to the limits structure to be filled.
> >> + *
> >> + * @return
> >> + *   - 0: Success.
> >> + *   - <0: Error code returned by the driver function.
> >> + */
> >> +typedef int (*eventdev_eth_rx_adapter_vector_limits_get_t)(
> >> +	const struct rte_eventdev *dev, const struct rte_eth_dev
> >*eth_dev,
> >> +	struct rte_event_eth_rx_adapter_vector_limits *limits);
> >> +
> >> +struct rte_event_eth_rx_adapter_event_vector_config;
> >> +/**
> >> + * Enable event vector on an given Rx queue of a ethernet devices
> >belonging to
> >> + * the Rx adapter.
> >> + *
> >> + * @param dev
> >> + *   Event device pointer
> >> + *
> >> + * @param eth_dev
> >> + *   Ethernet device pointer
> >> + *
> >> + * @param rx_queue_id
> >> + *   The Rx queue identifier
> >> + *
> >> + * @param config
> >> + *   Pointer to the event vector configuration structure.
> >> + *
> >> + * @return
> >> + *   - 0: Success.
> >> + *   - <0: Error code returned by the driver function.
> >> + */
> >> +typedef int (*eventdev_eth_rx_adapter_event_vector_config_t)(
> >> +	const struct rte_eventdev *dev, const struct rte_eth_dev
> >*eth_dev,
> >> +	int32_t rx_queue_id,
> >> +	const struct rte_event_eth_rx_adapter_event_vector_config
> >*config);
> >> +
> >>  typedef uint32_t rte_event_pmd_selftest_seqn_t;
> >>  extern int rte_event_pmd_selftest_seqn_dynfield_offset;
> >>
> >> @@ -1067,6 +1114,12 @@ struct rte_eventdev_ops {
> >>  	/**< Get ethernet Rx stats */
> >>  	eventdev_eth_rx_adapter_stats_reset
> >eth_rx_adapter_stats_reset;
> >>  	/**< Reset ethernet Rx stats */
> >> +	eventdev_eth_rx_adapter_vector_limits_get_t
> >> +		eth_rx_adapter_vector_limits_get;
> >> +	/**< Get event vector limits for the Rx adapter */
> >> +	eventdev_eth_rx_adapter_event_vector_config_t
> >> +		eth_rx_adapter_event_vector_config;
> >> +	/**< Configure Rx adapter with event vector */
> >>
> >>  	eventdev_timer_adapter_caps_get_t timer_adapter_caps_get;
> >>  	/**< Get timer adapter capabilities */
> >> diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> >b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> >> index d8c635e99..ac8ba5bf0 100644
> >> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> >> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> >> @@ -2263,6 +2263,120 @@
> >rte_event_eth_rx_adapter_queue_del(uint8_t id, uint16_t eth_dev_id,
> >>  	return ret;
> >>  }
> >>
> >> +int
> >> +rte_event_eth_rx_adapter_queue_event_vector_config(
> >> +	uint8_t id, uint16_t eth_dev_id, int32_t rx_queue_id,
> >> +	struct rte_event_eth_rx_adapter_event_vector_config *config)
> >> +{
> >> +	struct rte_event_eth_rx_adapter_vector_limits limits;
> >> +	struct rte_event_eth_rx_adapter *rx_adapter;
> >> +	struct rte_eventdev *dev;
> >> +	uint32_t cap;
> >> +	int ret;
> >> +
> >> +	RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(id, -
> >EINVAL);
> >> +	RTE_ETH_VALID_PORTID_OR_ERR_RET(eth_dev_id, -EINVAL);
> >> +
> >> +	rx_adapter = rxa_id_to_adapter(id);
> >> +	if ((rx_adapter == NULL) || (config == NULL))
> >> +		return -EINVAL;
> >> +
> >> +	dev = &rte_eventdevs[rx_adapter->eventdev_id];
> >> +	ret = rte_event_eth_rx_adapter_caps_get(rx_adapter-
> >>eventdev_id,
> >> +						eth_dev_id, &cap);
> >> +	if (ret) {
> >> +		RTE_EDEV_LOG_ERR("Failed to get adapter caps edev
> >%" PRIu8
> >> +				 "eth port %" PRIu16,
> >> +				 id, eth_dev_id);
> >> +		return ret;
> >> +	}
> >> +
> >> +	if (!(cap &
> >RTE_EVENT_ETH_RX_ADAPTER_CAP_EVENT_VECTOR)) {
> >> +		RTE_EDEV_LOG_ERR("Event vectorization is not
> >supported,"
> >> +				 " eth port: %" PRIu16 " adapter id: %"
> >PRIu8,
> >> +				 eth_dev_id, id);
> >> +		return -EINVAL;
> >> +	}
> >> +
> >> +	ret = rte_event_eth_rx_adapter_vector_limits_get(
> >> +		rx_adapter->eventdev_id, eth_dev_id, &limits);
> >> +	if (ret) {
> >> +		RTE_EDEV_LOG_ERR("Failed to get vector limits edev
> >%" PRIu8
> >> +				 "eth port %" PRIu16,
> >> +				 rx_adapter->eventdev_id, eth_dev_id);
> >> +		return ret;
> >> +	}
> >> +
> >> +	if (config->vector_sz < limits.min_sz ||
> >> +	    config->vector_sz > limits.max_sz ||
> >> +	    config->vector_timeout_ns < limits.min_timeout_ns ||
> >> +	    config->vector_timeout_ns > limits.max_timeout_ns ||
> >> +	    config->vector_mp == NULL) {
> >> +		RTE_EDEV_LOG_ERR("Invalid event vector
> >configuration,"
> >> +				 " eth port: %" PRIu16 " adapter id: %"
> >PRIu8,
> >> +				 eth_dev_id, id);
> >> +		return -EINVAL;
> >> +	}
> >> +	if (config->vector_mp->elt_size <
> >> +	    (sizeof(struct rte_event_vector) +
> >> +	     (sizeof(uintptr_t) * config->vector_sz))) {
> >> +		RTE_EDEV_LOG_ERR("Invalid event vector
> >configuration,"
> >> +				 " eth port: %" PRIu16 " adapter id: %"
> >PRIu8,
> >> +				 eth_dev_id, id);
> >> +		return -EINVAL;
> >> +	}
> >> +
> >> +	if (cap &
> >RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT) {
> >> +		RTE_FUNC_PTR_OR_ERR_RET(
> >> +			*dev->dev_ops-
> >>eth_rx_adapter_event_vector_config,
> >> +			-ENOTSUP);
> >> +		ret = dev->dev_ops-
> >>eth_rx_adapter_event_vector_config(
> >> +			dev, &rte_eth_devices[eth_dev_id],
> >rx_queue_id, config);
> >> +	} else {
> >> +		ret = -ENOTSUP;
> >> +	}
> >
> >Trying to understand why non-INTERNAL_PORT based event device
> >implementation returns ENOTSUP. Do you foresee any issues if such a
> >device implements this function?
> >
> 
> I just didn't want to move the implementation here as this patch is only
> Intended for spec.
> The implementation for non-INTERNAL_PORT is in 4/8

Makes sense. Thanks!

> 
> >> +
> >> +	return ret;
> >> +}
> >> +
> >> +int
> >> +rte_event_eth_rx_adapter_vector_limits_get(
> >> +	uint8_t dev_id, uint16_t eth_port_id,
> >> +	struct rte_event_eth_rx_adapter_vector_limits *limits)
> >> +{
> >> +	struct rte_eventdev *dev;
> >> +	uint32_t cap;
> >> +	int ret;
> >> +
> >> +	RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);
> >> +	RTE_ETH_VALID_PORTID_OR_ERR_RET(eth_port_id, -EINVAL);
> >> +
> >> +	if (limits == NULL)
> >> +		return -EINVAL;
> >> +
> >> +	dev = &rte_eventdevs[dev_id];
> >> +
> >> +	ret = rte_event_eth_rx_adapter_caps_get(dev_id, eth_port_id,
> >&cap);
> >> +	if (ret) {
> >> +		RTE_EDEV_LOG_ERR("Failed to get adapter caps edev
> >%" PRIu8
> >> +				 "eth port %" PRIu16,
> >> +				 dev_id, eth_port_id);
> >> +		return ret;
> >> +	}
> >> +
> >> +	if (cap &
> >RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT) {
> >> +		RTE_FUNC_PTR_OR_ERR_RET(
> >> +			*dev->dev_ops-
> >>eth_rx_adapter_vector_limits_get,
> >> +			-ENOTSUP);
> >> +		ret = dev->dev_ops-
> >>eth_rx_adapter_vector_limits_get(
> >> +			dev, &rte_eth_devices[eth_port_id], limits);
> >> +	} else {
> >> +		ret = -ENOTSUP;
> >> +	}
> >> +
> >
> >Same here.
> >
> >> +	return ret;
> >> +}
> >> +
> >>  int
> >>  rte_event_eth_rx_adapter_start(uint8_t id)
> >>  {
> >> diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> >b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> >> index 21bb1e54c..7407cde00 100644
> >> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> >> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> >> @@ -92,6 +92,10 @@ extern "C" {
> >>  /**< This flag indicates the flow identifier is valid
> >>   * @see rte_event_eth_rx_adapter_queue_conf::rx_queue_flags
> >>   */
> >> +#define RTE_EVENT_ETH_RX_ADAPTER_QUEUE_EVENT_VECTOR
> >	0x2
> >> +/**< This flag indicates that mbufs arriving on the queue need to be
> >vectorized
> >> + * @see rte_event_eth_rx_adapter_queue_conf::rx_queue_flags
> >> + */
> >>
> >>  /**
> >>   * Adapter configuration structure that the adapter configuration
> >callback
> >> @@ -169,6 +173,36 @@ struct
> >rte_event_eth_rx_adapter_queue_conf {
> >>  	 */
> >>  };
> >>
> >> +struct rte_event_eth_rx_adapter_event_vector_config {
> >> +	uint16_t vector_sz;
> >> +	/**<
> >> +	 * Indicates the maximum number for mbufs to combine and
> >form a vector.
> >> +	 * Should be within
> >> +	 * @see
> >rte_event_eth_rx_adapter_vector_limits::min_vector_sz
> >> +	 * @see
> >rte_event_eth_rx_adapter_vector_limits::max_vector_sz
> >> +	 * Valid when
> >RTE_EVENT_ETH_RX_ADAPTER_QUEUE_EVENT_VECTOR flag is set in
> >> +	 * @see
> >rte_event_eth_rx_adapter_queue_conf::rx_queue_flags
> >> +	 */
> >> +	uint64_t vector_timeout_ns;
> >> +	/**<
> >> +	 * Indicates the maximum number of nanoseconds to wait for
> >receiving
> >> +	 * mbufs. Should be within vectorization limits of the
> >> +	 * adapter
> >> +	 * @see
> >rte_event_eth_rx_adapter_vector_limits::min_vector_ns
> >> +	 * @see
> >rte_event_eth_rx_adapter_vector_limits::max_vector_ns
> >> +	 * Valid when
> >RTE_EVENT_ETH_RX_ADAPTER_QUEUE_EVENT_VECTOR flag is set in
> >> +	 * @see
> >rte_event_eth_rx_adapter_queue_conf::rx_queue_flags
> >> +	 */
> >> +	struct rte_mempool *vector_mp;
> >> +	/**<
> >> +	 * Indicates the mempool that should be used for allocating
> >> +	 * rte_event_vector container.
> >> +	 * Should be created by using `rte_event_vector_pool_create`.
> >> +	 * Valid when
> >RTE_EVENT_ETH_RX_ADAPTER_QUEUE_EVENT_VECTOR flag is set in
> >> +	 * @see
> >rte_event_eth_rx_adapter_queue_conf::rx_queue_flags.
> >> +	 */
> >> +};
> >> +
> >>  /**
> >>   * A structure used to retrieve statistics for an eth rx adapter
> >instance.
> >>   */
> >> @@ -199,6 +233,32 @@ struct rte_event_eth_rx_adapter_stats {
> >>  	/**< Received packet count for interrupt mode Rx queues */
> >>  };
> >>
> >> +/**
> >> + * A structure used to retrieve eth rx adapter vector limits.
> >> + */
> >> +struct rte_event_eth_rx_adapter_vector_limits {
> >> +	uint16_t min_sz;
> >> +	/**< Minimum vector limit configurable.
> >> +	 * @see
> >rte_event_eth_rx_adapter_event_vector_config::vector_sz
> >> +	 */
> >> +	uint16_t max_sz;
> >> +	/**< Maximum vector limit configurable.
> >> +	 * @see
> >rte_event_eth_rx_adapter_event_vector_config::vector_sz
> >> +	 */
> >> +	uint8_t log2_sz;
> >> +	/**< True if the size configured should be in log2.
> >> +	 * @see
> >rte_event_eth_rx_adapter_event_vector_config::vector_sz
> >> +	 */
> >> +	uint64_t min_timeout_ns;
> >> +	/**< Minimum vector timeout configurable.
> >> +	 * @see
> >rte_event_eth_rx_adapter_event_vector_config::vector_timeout_ns
> >> +	 */
> >> +	uint64_t max_timeout_ns;
> >> +	/**< Maximum vector timeout configurable.
> >> +	 * @see
> >rte_event_eth_rx_adapter_event_vector_config::vector_timeout_ns
> >> +	 */
> >> +};
> >> +
> >>  /**
> >>   *
> >>   * Callback function invoked by the SW adapter before it continues
> >> @@ -467,6 +527,51 @@ int
> >rte_event_eth_rx_adapter_cb_register(uint8_t id, uint16_t eth_dev_id,
> >>
> >rte_event_eth_rx_adapter_cb_fn cb_fn,
> >>  					 void *cb_arg);
> >>
> >> +/**
> >> + * Retrieve vector limits for a given event dev and eth dev pair.
> >> + * @see rte_event_eth_rx_adapter_vector_limits
> >> + *
> >> + * @param dev_id
> >> + *  Event device identifier.
> >> + * @param eth_port_id
> >> + *  Port identifier of the ethernet device.
> >> + * @param [out] limits
> >> + *  A pointer to rte_event_eth_rx_adapter_vector_limits structure
> >that has to
> >> + * be filled.
> >> + *
> >> + * @return
> >> + *  - 0: Success.
> >> + *  - <0: Error code on failure.
> >> + */
> >> +__rte_experimental
> >> +int rte_event_eth_rx_adapter_vector_limits_get(
> >> +	uint8_t dev_id, uint16_t eth_port_id,
> >> +	struct rte_event_eth_rx_adapter_vector_limits *limits);
> >> +
> >> +/**
> >> + * Configure event vectorization for a given ethernet device queue,
> >that has
> >> + * been added to a event eth Rx adapter.
> >> + *
> >> + * @param id
> >> + *  The identifier of the ethernet Rx event adapter.
> >> + *
> >> + * @param eth_dev_id
> >> + *  The identifier of the ethernet device.
> >> + *
> >> + * @param rx_queue_id
> >> + *  Ethernet device receive queue index.
> >> + *  If rx_queue_id is -1, then all Rx queues configured for the
> >ethernet device
> >> + *  are configured with event vectorization.
> >> + *
> >> + * @return
> >> + *  - 0: Success, Receive queue configured correctly.
> >> + *  - <0: Error code on failure.
> >> + */
> >> +__rte_experimental
> >> +int rte_event_eth_rx_adapter_queue_event_vector_config(
> >> +	uint8_t id, uint16_t eth_dev_id, int32_t rx_queue_id,
> >> +	struct rte_event_eth_rx_adapter_event_vector_config
> >*config);
> >> +
> >>  #ifdef __cplusplus
> >>  }
> >>  #endif
> >> diff --git a/lib/librte_eventdev/rte_eventdev.h
> >b/lib/librte_eventdev/rte_eventdev.h
> >> index aa4dd3959..678338247 100644
> >> --- a/lib/librte_eventdev/rte_eventdev.h
> >> +++ b/lib/librte_eventdev/rte_eventdev.h
> >> @@ -919,10 +919,28 @@ rte_event_dev_close(uint8_t dev_id);
> >>   * Event vector structure.
> >>   */
> >>  struct rte_event_vector {
> >> -	uint64_t nb_elem : 16;
> >> +	uint16_t nb_elem;
> >>  	/**< Number of elements in this event vector. */
> >> -	uint64_t rsvd : 48;
> >> +	uint16_t rsvd : 15;
> >>  	/**< Reserved for future use */
> >> +	uint16_t attr_valid : 1;
> >> +	/**< Indicates that the below union attributes have valid
> >information.
> >> +	 */
> >> +	union {
> >> +		/* Used by Rx adapter.
> >> +		 * Indicates that all the elements in this vector belong to
> >the
> >> +		 * same port and queue pair when originating from Rx
> >adapter,
> >> +		 * valid only when event type is ETHDEV_VECTOR or
> >> +		 * ETH_RX_ADAPTER_VECTOR.
> >> +		 */
> >> +		struct {
> >> +			uint16_t port;
> >> +			/* Ethernet device port id. */
> >> +			uint16_t queue;
> >> +			/* Ethernet device queue id. */
> >> +		};
> >> +	};
> >> +	/**< Union to hold common attributes of the vector array. */
> >>  	uint64_t impl_opaque;
> >>  	/**< Implementation specific opaque value.
> >>  	 * An implementation may use this field to hold implementation
> >specific
> >> @@ -1025,8 +1043,14 @@ struct rte_event_vector {
> >>   *		// Classify and handle event.
> >>   *	}
> >>   */
> >> +#define RTE_EVENT_TYPE_ETHDEV_VECTOR
> >\
> >> +	(RTE_EVENT_TYPE_VECTOR | RTE_EVENT_TYPE_ETHDEV)
> >> +/**< The event vector generated from ethdev subsystem */
> >>  #define RTE_EVENT_TYPE_CPU_VECTOR (RTE_EVENT_TYPE_VECTOR
> >| RTE_EVENT_TYPE_CPU)
> >>  /**< The event vector generated from cpu for pipelining. */
> >> +#define RTE_EVENT_TYPE_ETH_RX_ADAPTER_VECTOR
> >\
> >> +	(RTE_EVENT_TYPE_VECTOR |
> >RTE_EVENT_TYPE_ETH_RX_ADAPTER)
> >> +/**< The event vector generated from eth Rx adapter. */
> >>
> >>  #define RTE_EVENT_TYPE_MAX              0x10
> >>  /**< Maximum number of event types */
> >> @@ -1171,6 +1195,8 @@ struct rte_event {
> >>   * @see struct rte_event_eth_rx_adapter_queue_conf::ev
> >>   * @see struct
> >rte_event_eth_rx_adapter_queue_conf::rx_queue_flags
> >>   */
> >> +#define RTE_EVENT_ETH_RX_ADAPTER_CAP_EVENT_VECTOR
> >	0x8
> >> +/**< Adapter supports event vectorization per ethdev. */
> >>
> >>  /**
> >>   * Retrieve the event device's ethdev Rx adapter capabilities for the
> >> diff --git a/lib/librte_eventdev/version.map
> >b/lib/librte_eventdev/version.map
> >> index a070ef56e..902df0ae3 100644
> >> --- a/lib/librte_eventdev/version.map
> >> +++ b/lib/librte_eventdev/version.map
> >> @@ -141,6 +141,8 @@ EXPERIMENTAL {
> >>
> >>  	#added in 21.05
> >>  	rte_event_vector_pool_create;
> >> +	rte_event_eth_rx_adapter_vector_limits_get;
> >> +	rte_event_eth_rx_adapter_queue_event_vector_config;
> >>  };
> >>
> >>  INTERNAL {
> >> --
> >> 2.17.1
> >
> >More of informational queries.
> >
> >Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com>


  reply	other threads:[~2021-03-25  9:50 UTC|newest]

Thread overview: 144+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-20 22:09 [dpdk-dev] [PATCH 0/7] Introduce event vectorization pbhagavatula
2021-02-20 22:09 ` [dpdk-dev] [PATCH 1/7] eventdev: introduce event vector capability pbhagavatula
2021-03-08 16:49   ` Jerin Jacob
2021-02-20 22:09 ` [dpdk-dev] [PATCH 2/7] eventdev: introduce event vector Rx capability pbhagavatula
2021-03-08 17:07   ` Jerin Jacob
2021-02-20 22:09 ` [dpdk-dev] [PATCH 3/7] eventdev: introduce event vector Tx capability pbhagavatula
2021-03-08 17:09   ` Jerin Jacob
2021-02-20 22:09 ` [dpdk-dev] [PATCH 4/7] eventdev: add Rx adapter event vector support pbhagavatula
2021-03-08 17:27   ` Jerin Jacob
2021-03-16 10:41     ` Jayatheerthan, Jay
2021-02-20 22:09 ` [dpdk-dev] [PATCH 5/7] eventdev: add Tx " pbhagavatula
2021-02-20 22:09 ` [dpdk-dev] [PATCH 6/7] app/eventdev: add event vector mode in pipeline test pbhagavatula
2021-02-20 22:09 ` [dpdk-dev] [PATCH 7/7] eventdev: fix ABI breakage due to event vector pbhagavatula
2021-03-08 18:44   ` Jerin Jacob
2021-03-12 14:28     ` David Marchand
2021-03-16  5:54       ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2021-03-15 10:01     ` [dpdk-dev] " Kinsella, Ray
2021-03-08 16:41 ` [dpdk-dev] [PATCH 0/7] Introduce event vectorization Jerin Jacob
2021-03-16 15:48 ` [dpdk-dev] [PATCH v2 0/8] " pbhagavatula
2021-03-16 15:48   ` [dpdk-dev] [PATCH v2 1/8] eventdev: introduce event vector capability pbhagavatula
2021-03-16 17:48     ` Jerin Jacob
2021-03-16 19:17       ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2021-03-16 15:48   ` [dpdk-dev] [PATCH v2 2/8] eventdev: introduce event vector Rx capability pbhagavatula
2021-03-16 15:48   ` [dpdk-dev] [PATCH v2 3/8] eventdev: introduce event vector Tx capability pbhagavatula
2021-03-16 15:48   ` [dpdk-dev] [PATCH v2 4/8] eventdev: add Rx adapter event vector support pbhagavatula
2021-03-16 15:48   ` [dpdk-dev] [PATCH v2 5/8] eventdev: add Tx " pbhagavatula
2021-03-16 15:48   ` [dpdk-dev] [PATCH v2 6/8] app/eventdev: add event vector mode in pipeline test pbhagavatula
2021-03-16 15:48   ` [dpdk-dev] [PATCH v2 7/8] doc: announce event Rx adapter config changes pbhagavatula
2021-03-16 15:48   ` [dpdk-dev] [dpdk-dev v21.11] [PATCH v2 8/8] eventdev: simplify Rx adapter event vector config pbhagavatula
2021-03-16 20:01   ` [dpdk-dev] [PATCH v3 0/8] Introduce event vectorization pbhagavatula
2021-03-16 20:01     ` [dpdk-dev] [PATCH v3 1/8] eventdev: introduce event vector capability pbhagavatula
2021-03-18  6:19       ` Jayatheerthan, Jay
2021-03-18  6:23         ` Pavan Nikhilesh Bhagavatula
2021-03-16 20:01     ` [dpdk-dev] [PATCH v3 2/8] eventdev: introduce event vector Rx capability pbhagavatula
2021-03-16 20:01     ` [dpdk-dev] [PATCH v3 3/8] eventdev: introduce event vector Tx capability pbhagavatula
2021-03-16 20:01     ` [dpdk-dev] [PATCH v3 4/8] eventdev: add Rx adapter event vector support pbhagavatula
2021-03-16 20:01     ` [dpdk-dev] [PATCH v3 5/8] eventdev: add Tx " pbhagavatula
2021-03-16 20:01     ` [dpdk-dev] [PATCH v3 6/8] app/eventdev: add event vector mode in pipeline test pbhagavatula
2021-03-16 20:01     ` [dpdk-dev] [PATCH v3 7/8] doc: announce event Rx adapter config changes pbhagavatula
2021-03-16 20:01     ` [dpdk-dev] [dpdk-dev v21.11] [PATCH v3 8/8] eventdev: simplify Rx adapter event vector config pbhagavatula
2021-03-19 20:57     ` [dpdk-dev] [PATCH v4 0/8] Introduce event vectorization pbhagavatula
2021-03-19 20:57       ` [dpdk-dev] [PATCH v4 1/8] eventdev: introduce event vector capability pbhagavatula
2021-03-22  9:06         ` Kinsella, Ray
2021-03-22  9:10           ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2021-03-23 11:12         ` [dpdk-dev] " Jerin Jacob
2021-03-19 20:57       ` [dpdk-dev] [PATCH v4 2/8] eventdev: introduce event vector Rx capability pbhagavatula
2021-03-22  9:12         ` Kinsella, Ray
2021-03-22 10:07           ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2021-03-22 11:07             ` Kinsella, Ray
2021-03-23 16:56         ` [dpdk-dev] " Jerin Jacob
2021-03-19 20:57       ` [dpdk-dev] [PATCH v4 3/8] eventdev: introduce event vector Tx capability pbhagavatula
2021-03-19 20:57       ` [dpdk-dev] [PATCH v4 4/8] eventdev: add Rx adapter event vector support pbhagavatula
2021-03-23 18:30         ` Jerin Jacob
2021-03-19 20:57       ` [dpdk-dev] [PATCH v4 5/8] eventdev: add Tx " pbhagavatula
2021-03-19 20:57       ` [dpdk-dev] [PATCH v4 6/8] app/eventdev: add event vector mode in pipeline test pbhagavatula
2021-03-23 18:39         ` Jerin Jacob
2021-03-19 20:57       ` [dpdk-dev] [PATCH v4 7/8] doc: announce event Rx adapter config changes pbhagavatula
2021-03-19 20:57       ` [dpdk-dev] [dpdk-dev v21.11] [PATCH v4 8/8] eventdev: simplify Rx adapter event vector config pbhagavatula
2021-03-23 18:44       ` [dpdk-dev] [PATCH v4 0/8] Introduce event vectorization Jerin Jacob
2021-03-24  5:05       ` [dpdk-dev] [PATCH v5 " pbhagavatula
2021-03-24  5:05         ` [dpdk-dev] [PATCH v5 1/8] eventdev: introduce event vector capability pbhagavatula
2021-03-24  6:48           ` Jayatheerthan, Jay
2021-03-24 18:20             ` Pavan Nikhilesh Bhagavatula
2021-03-24  9:16           ` Kinsella, Ray
2021-03-24  5:05         ` [dpdk-dev] [PATCH v5 2/8] eventdev: introduce event vector Rx capability pbhagavatula
2021-03-24  9:15           ` Kinsella, Ray
2021-03-25  8:15           ` Jayatheerthan, Jay
2021-03-25  9:24             ` Pavan Nikhilesh Bhagavatula
2021-03-25  9:50               ` Jayatheerthan, Jay [this message]
2021-03-24  5:05         ` [dpdk-dev] [PATCH v5 3/8] eventdev: introduce event vector Tx capability pbhagavatula
2021-03-25  8:16           ` Jayatheerthan, Jay
2021-03-24  5:05         ` [dpdk-dev] [PATCH v5 4/8] eventdev: add Rx adapter event vector support pbhagavatula
2021-03-25 10:37           ` Jayatheerthan, Jay
2021-03-25 13:14             ` Pavan Nikhilesh Bhagavatula
2021-03-26  6:26               ` Jayatheerthan, Jay
2021-03-26  9:00                 ` Pavan Nikhilesh Bhagavatula
2021-03-24  5:05         ` [dpdk-dev] [PATCH v5 5/8] eventdev: add Tx " pbhagavatula
2021-03-25 11:44           ` Jayatheerthan, Jay
2021-03-24  5:05         ` [dpdk-dev] [PATCH v5 6/8] app/eventdev: add event vector mode in pipeline test pbhagavatula
2021-03-24  5:05         ` [dpdk-dev] [PATCH v5 7/8] doc: announce event Rx adapter config changes pbhagavatula
2021-03-24  9:16           ` Kinsella, Ray
2021-03-24  5:05         ` [dpdk-dev] [dpdk-dev v21.11] [PATCH v5 8/8] eventdev: simplify Rx adapter event vector config pbhagavatula
2021-03-25 12:27           ` Jayatheerthan, Jay
2021-03-25 13:55             ` Pavan Nikhilesh Bhagavatula
2021-03-26  7:09               ` Jayatheerthan, Jay
2021-03-26  9:44                 ` Pavan Nikhilesh Bhagavatula
2021-03-24  5:39         ` [dpdk-dev] [PATCH v5 0/8] Introduce event vectorization Jayatheerthan, Jay
2021-03-24  6:44           ` Pavan Nikhilesh Bhagavatula
2021-03-24  8:10             ` Jayatheerthan, Jay
2021-03-24 19:28         ` [dpdk-dev] [PATCH v6 " pbhagavatula
2021-03-24 19:28           ` [dpdk-dev] [PATCH v6 1/8] eventdev: introduce event vector capability pbhagavatula
2021-03-24 19:28           ` [dpdk-dev] [PATCH v6 2/8] eventdev: introduce event vector Rx capability pbhagavatula
2021-03-24 19:28           ` [dpdk-dev] [PATCH v6 3/8] eventdev: introduce event vector Tx capability pbhagavatula
2021-03-24 19:28           ` [dpdk-dev] [PATCH v6 4/8] eventdev: add Rx adapter event vector support pbhagavatula
2021-03-24 19:28           ` [dpdk-dev] [PATCH v6 5/8] eventdev: add Tx " pbhagavatula
2021-03-24 19:28           ` [dpdk-dev] [PATCH v6 6/8] app/eventdev: add event vector mode in pipeline test pbhagavatula
2021-03-24 19:28           ` [dpdk-dev] [PATCH v6 7/8] doc: announce event Rx adapter config changes pbhagavatula
2021-03-24 19:28           ` [dpdk-dev] [dpdk-dev v21.11] [PATCH v6 8/8] eventdev: simplify Rx adapter event vector config pbhagavatula
2021-03-25 17:10           ` [dpdk-dev] [PATCH v7 0/8] Introduce event vectorization pbhagavatula
2021-03-25 17:10             ` [dpdk-dev] [PATCH v7 1/8] eventdev: introduce event vector capability pbhagavatula
2021-03-25 17:10             ` [dpdk-dev] [PATCH v7 2/8] eventdev: introduce event vector Rx capability pbhagavatula
2021-03-25 17:10             ` [dpdk-dev] [PATCH v7 3/8] eventdev: introduce event vector Tx capability pbhagavatula
2021-03-25 17:10             ` [dpdk-dev] [PATCH v7 4/8] eventdev: add Rx adapter event vector support pbhagavatula
2021-03-25 17:10             ` [dpdk-dev] [PATCH v7 5/8] eventdev: add Tx " pbhagavatula
2021-03-25 17:10             ` [dpdk-dev] [PATCH v7 6/8] app/eventdev: add event vector mode in pipeline test pbhagavatula
2021-03-25 17:10             ` [dpdk-dev] [PATCH v7 7/8] doc: announce event Rx adapter config changes pbhagavatula
2021-03-25 17:10             ` [dpdk-dev] [dpdk-dev v21.11] [PATCH v7 8/8] eventdev: simplify Rx adapter event vector config pbhagavatula
2021-03-26 14:08             ` [dpdk-dev] [PATCH v8 0/8] Introduce event vectorization pbhagavatula
2021-03-26 14:08               ` [dpdk-dev] [PATCH v8 1/8] eventdev: introduce event vector capability pbhagavatula
2021-03-27 12:07                 ` Jayatheerthan, Jay
2021-03-26 14:08               ` [dpdk-dev] [PATCH v8 2/8] eventdev: introduce event vector Rx capability pbhagavatula
2021-03-26 14:08               ` [dpdk-dev] [PATCH v8 3/8] eventdev: introduce event vector Tx capability pbhagavatula
2021-03-26 14:08               ` [dpdk-dev] [PATCH v8 4/8] eventdev: add Rx adapter event vector support pbhagavatula
2021-03-28  8:18                 ` Jerin Jacob
2021-03-29  6:09                   ` Jayatheerthan, Jay
2021-03-26 14:08               ` [dpdk-dev] [PATCH v8 5/8] eventdev: add Tx " pbhagavatula
2021-03-26 14:08               ` [dpdk-dev] [PATCH v8 6/8] app/eventdev: add event vector mode in pipeline test pbhagavatula
2021-03-26 14:08               ` [dpdk-dev] [PATCH v8 7/8] doc: announce event Rx adapter config changes pbhagavatula
2021-03-26 14:43                 ` Jerin Jacob
2021-03-27 12:07                   ` Jayatheerthan, Jay
2021-03-26 14:08               ` [dpdk-dev] [dpdk-dev v21.11] [PATCH v8 8/8] eventdev: simplify Rx adapter event vector config pbhagavatula
2021-03-30  8:22               ` [dpdk-dev] [PATCH v9 0/8] Introduce event vectorization pbhagavatula
2021-03-30  8:22                 ` [dpdk-dev] [PATCH v9 1/8] eventdev: introduce event vector capability pbhagavatula
2021-03-30  8:22                 ` [dpdk-dev] [PATCH v9 2/8] eventdev: introduce event vector Rx capability pbhagavatula
2021-03-30  8:22                 ` [dpdk-dev] [PATCH v9 3/8] eventdev: introduce event vector Tx capability pbhagavatula
2021-03-30  8:22                 ` [dpdk-dev] [PATCH v9 4/8] eventdev: add Rx adapter event vector support pbhagavatula
2021-03-31  6:35                   ` Jayatheerthan, Jay
2021-03-31  6:40                     ` Pavan Nikhilesh Bhagavatula
2021-03-31  6:55                       ` Jayatheerthan, Jay
2021-03-30  8:22                 ` [dpdk-dev] [PATCH v9 5/8] eventdev: add Tx " pbhagavatula
2021-03-30  8:22                 ` [dpdk-dev] [PATCH v9 6/8] app/eventdev: add event vector mode in pipeline test pbhagavatula
2021-03-30  8:22                 ` [dpdk-dev] [PATCH v9 7/8] doc: announce event Rx adapter config changes pbhagavatula
2021-03-30  8:22                 ` [dpdk-dev] [dpdk-dev v21.11] [PATCH v9 8/8] eventdev: simplify Rx adapter event vector config pbhagavatula
2021-03-31  6:55                   ` Jayatheerthan, Jay
2021-03-31  9:29                 ` [dpdk-dev] [PATCH v10 0/8] Introduce event vectorization pbhagavatula
2021-03-31  9:29                   ` [dpdk-dev] [PATCH v10 1/8] eventdev: introduce event vector capability pbhagavatula
2021-03-31  9:29                   ` [dpdk-dev] [PATCH v10 2/8] eventdev: introduce event vector Rx capability pbhagavatula
2021-03-31  9:29                   ` [dpdk-dev] [PATCH v10 3/8] eventdev: introduce event vector Tx capability pbhagavatula
2021-03-31  9:29                   ` [dpdk-dev] [PATCH v10 4/8] eventdev: add Rx adapter event vector support pbhagavatula
2021-03-31  9:29                   ` [dpdk-dev] [PATCH v10 5/8] eventdev: add Tx " pbhagavatula
2021-03-31  9:30                   ` [dpdk-dev] [PATCH v10 6/8] app/eventdev: add event vector mode in pipeline test pbhagavatula
2021-03-31  9:30                   ` [dpdk-dev] [PATCH v10 7/8] doc: announce event Rx adapter config changes pbhagavatula
2021-03-31  9:30                   ` [dpdk-dev] [dpdk-dev v21.11] [PATCH v10 8/8] eventdev: simplify Rx adapter event vector config pbhagavatula
2021-04-03  9:44                   ` [dpdk-dev] [PATCH v10 0/8] Introduce event vectorization Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB31175B99312B46B4C1187C70FD629@SN6PR11MB3117.namprd11.prod.outlook.com \
    --to=jay.jayatheerthan@intel.com \
    --cc=abhinandan.gujjar@intel.com \
    --cc=dev@dpdk.org \
    --cc=erik.g.carrillo@intel.com \
    --cc=harry.van.haaren@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerinj@marvell.com \
    --cc=liang.j.ma@intel.com \
    --cc=mattias.ronnblom@ericsson.com \
    --cc=mdr@ashroe.eu \
    --cc=nhorman@tuxdriver.com \
    --cc=pbhagavatula@marvell.com \
    --cc=timothy.mcdaniel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git