From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C91DA0A02; Thu, 25 Mar 2021 10:50:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1D2FE4067B; Thu, 25 Mar 2021 10:50:19 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 42B9440147 for ; Thu, 25 Mar 2021 10:50:17 +0100 (CET) IronPort-SDR: gN+BBFxtAM2JMHdlp5nBtn7vRr87XOlL3LJ6lQE5KC1zC+9pSe/63PIYqvx6gUpaCzuGj0MRWy il6T5qtLGd2Q== X-IronPort-AV: E=McAfee;i="6000,8403,9933"; a="187592000" X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="187592000" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 02:50:16 -0700 IronPort-SDR: 0Qxm+ZPEnf7Jdm3dccNh9YnM9cMMUDKYKbUsKr8yLLUMIeCdjmN/TZy+1pNBlrUynpslXpzAvc jYY0oozHhaHw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="593716911" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga005.jf.intel.com with ESMTP; 25 Mar 2021 02:50:15 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 25 Mar 2021 02:50:14 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 25 Mar 2021 02:50:14 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 25 Mar 2021 02:50:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bt5wAP2DBhLbfNreNR1o5LvelccNBUMlM2+UdrMwITeauvf70st1VaUJ4rKH2SGMkTIiJUBWvIorGYXhUowzZYHJmL6ZAw/Xv4jvav76BakgaHakHiX/MSkr2hapEnna+IqxMZTHFU6RZalxRkNs3OoPmccb3ShePmFJs/CeUXFhC2d0LG2OdiDV34updFv01mv3fjuI1Ps/H6y3znkfWZIc3+TFPD9+48+gm1UyWGLVVk1Tv2aJ0/t8taz6wG0HqufzHAhlLVUMJoWBUqRU5YeSSilWhkz0bQn4eK7KklQwzaA6CnS7NIRCgYrklRkg7YdCAfeGMIHeJN8rSebGyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SZyC9iVyIX8fWc1yHbcrC1H4CzAsCwusMxf0UbUFEHY=; b=TJoEXC/Cmj3MoS2KElshV20QYqvIdFdoYEDrtq9CQeT9pJSWlKv6XwI2am6NgNdDwHdCKsP+oOvzSa6G5h0QPQJc8Z7w1Hpv77BBAQg4SrT5KXHd75AuIVORfy06qB6XPlCL5Rgzo9sZKUWmXVUfDoO/YBJ0GMmy1lyiTfqJ6Oe0/+frPYmRsN4/3TST+mHxzFy71KjTUOnyhBVknXmpvpofDbzykpRCJHlIh7vOhiVFwww3ARxwmS5NxfKzaUDxOlXsTew3Rpqew1Q2sVtfQmI55/VoGIxAO6bJ3Y0htwLt2WXWa+2VbeKiDoQYE+vq0HbQ77rs0i8ULn9/RFzpgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SZyC9iVyIX8fWc1yHbcrC1H4CzAsCwusMxf0UbUFEHY=; b=WZjArTcSj64NlXcx8kBnzCaiyA7zsE9KDHRKaflFtv/LJi5eBCA9TgoSTPohmxKMgXDujNDl/EhcyK1QwGOlZ7iz1q42HL6yvXvl9Mnpz5dNNEmg1y0MijCHLstz+iy0kRd8eRC26lmBPt2kxjPs84CrtSeICik2vIBMIp6kY9k= Received: from SN6PR11MB3117.namprd11.prod.outlook.com (2603:10b6:805:d7::32) by SA2PR11MB4969.namprd11.prod.outlook.com (2603:10b6:806:111::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Thu, 25 Mar 2021 09:50:12 +0000 Received: from SN6PR11MB3117.namprd11.prod.outlook.com ([fe80::4579:2bc0:3dc8:8b37]) by SN6PR11MB3117.namprd11.prod.outlook.com ([fe80::4579:2bc0:3dc8:8b37%5]) with mapi id 15.20.3977.026; Thu, 25 Mar 2021 09:50:12 +0000 From: "Jayatheerthan, Jay" To: Pavan Nikhilesh Bhagavatula , "Jerin Jacob Kollanukkaran" , "Carrillo, Erik G" , "Gujjar, Abhinandan S" , "McDaniel, Timothy" , "hemant.agrawal@nxp.com" , "Van Haaren, Harry" , mattias.ronnblom , "Ma, Liang J" , Ray Kinsella , Neil Horman CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v5 2/8] eventdev: introduce event vector Rx capability Thread-Index: AQHXIGtsvT811S10QE+bomkBYnneq6qS4ZKwgAGO3YCAAAcXQA== Date: Thu, 25 Mar 2021 09:50:12 +0000 Message-ID: References: <20210319205718.1436-1-pbhagavatula@marvell.com> <20210324050525.4489-1-pbhagavatula@marvell.com> <20210324050525.4489-3-pbhagavatula@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [136.185.187.198] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8028dd68-a03c-4459-1081-08d8ef736243 x-ms-traffictypediagnostic: SA2PR11MB4969: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BJrtI3tUBLiCDdZ39YfV2VNM/bYmHhNRqcyZD2Dd+ttWk9uoCi1xEIkPHGgmpo0lgh/gYyj534JEEHWr9Cqh7rg+POQGrt0jnpndGcTpXuxwoCjxkxcb4X7DMux//pyIJL0fgZV0TP0+5dNsPun+s1tMC2LHRT0YTxAgN4PRR+dA09RXL1RnFLXmh8GSWiGQH1LMfEgwLb7yg7unNJQVWBmjZXtf7r6tNAjOStsBDkLFEjkaD6osWHIl9e+G+mfEiz8wBF3WMjHZunzDLe30JtfsJfCFl4RGEaq4z3m+cy70L9eS0NprqEoK7x7/RKdL6dqV7nvdZAYcQAQJmQFDRRvDwwvxjnTdVwFmUsdhNifgBLoKOExME7McQV3veAJG/7hL29LXHr2MKO5VNz9oAd2fMDxs51ejSe1toyKy8/iU3f4kMs8PYzIQTdr45HBuKObf6UTlz34W4OSuxlCD1a46ud1qgHJOR8WOJRsMBwVijmZBS05FUzSSyVuW8/NK+ua1LjHf4JZwU0E8WsSG2Z6RM7akKGfvZOyJYB6OK5cW8QdeQJeUI9op2anS0AXgZLby2zz/FFj70mVsGWeteduFIMt1tqDGiiWq8UNh2AVg58eYEr7aLh1i3F3Dr2xrREABE+bFAmla8ZU4ngXLqpEDyPKIdedSol7P3Ob4VMn/FUouKRpM66ey41lhAPwh x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3117.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(346002)(396003)(366004)(376002)(136003)(2906002)(110136005)(5660300002)(6506007)(316002)(478600001)(55016002)(9686003)(66556008)(83380400001)(64756008)(38100700001)(66446008)(8676002)(33656002)(4326008)(7696005)(8936002)(71200400001)(30864003)(76116006)(921005)(186003)(86362001)(66476007)(52536014)(26005)(53546011)(66946007)(579004); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?/4ipX15RXK3lELLtQBAX4/om5GzATWaeNl2TmEe9D1lqUc55WRRzrZBOcJSf?= =?us-ascii?Q?eujJaEUzjyDaQXaCFcd8tvQKnQI93ydZVcSwCF6QuC895jPKd7j6W+HsEhU9?= =?us-ascii?Q?vAdSv7cT72gKumut1SldMROyRRCuPXDMeMUWuqdVykzYjEzE/Qy/UsvFEscM?= =?us-ascii?Q?Z67QGDnGiyuOwMYuFSrkqCIe132pZ5jCKSBrt2wYtDqrci9vckJi49fD9cHh?= =?us-ascii?Q?uMug+IRsUnZrcaH5IxI0AmExeDOotfAHGF2dM2bfRWr6K1vrW8C7b2HtVFML?= =?us-ascii?Q?DQZNzWEWNfAtOivx2DZrAjesCgnxlk06umyNhLfc8rrsbPt01G8cT01fA2gv?= =?us-ascii?Q?Mjp3ptTjAu5D5x9C9qJtRHc28b8v9jrJAR6AxjUc9MtQHp52DGJSMO2wcFIB?= =?us-ascii?Q?fN90I+SPV7EdyUmShyltU0sPwIoQoQ0SzCxgBeE+vlIAdwU+5fjSpenKDkUy?= =?us-ascii?Q?K4qGARsal//0ZlK68eEb1mLYnQprFP63WaNJyXVmF2zycyu32IS1ItDvH8M2?= =?us-ascii?Q?3MZWCju8zPCfjBxMFH7QQ3ySt8WVEE6Cpn5S3++HfARd8K48YWrUwYeXHzSP?= =?us-ascii?Q?dksJdgqsCZx00WB9wtRa1XuDw2VrREDTDKpKEv87Deb9lfZ8iZQEeoInlWHq?= =?us-ascii?Q?Ixvfp1Eq8nWzPV/4T6jg/Z/Gyzn6uLaKiSApvB4PSY0F6vDbcfj77hSjBjBr?= =?us-ascii?Q?VqSL1yQBf0cwnYqydAJ38CbrG6WYwNx8j6SKwOHtCb0p3z2vDR1ei0OJUXNO?= =?us-ascii?Q?5/qP4JS7pN20e48RJFocQFfDgmGCfak7X38VzdL1zffZUx3OikhOHwiTPKkP?= =?us-ascii?Q?ExYBV/ksJPnRu4EtytzmVCS8aiEcUb6KhKXqmh7epb25a1dk5CvZhqyGl5po?= =?us-ascii?Q?kbZc1oZGx1QteicJwZulhnAU7geehdb/euXFqzTskNRky1X075GnTAtrAvL1?= =?us-ascii?Q?UP7xvjURLZr4R14cPBYdxin07/Fy18xb2V0vCDHnp91tiqFrmP3Mtu04cEbR?= =?us-ascii?Q?zExG6gbnuICPGW0ceLqgeAXtxKHB3OJi5ywnjCCB2fxrji0egDK2bRr/pz7W?= =?us-ascii?Q?zOOgjAwAuJPp4Vvu42mcuPQdpUQYacnvVJbL1At+A1K2PbKc8PwGt8bDS+pl?= =?us-ascii?Q?uvwzn0wyy3YaQVXsanFsOnnuxe610e2T8s1vqugPzl7h+BR1Eb9fyxD4jRjh?= =?us-ascii?Q?Yz5Zr4W5/oranaV0HHED+1N+xAFBqeQDo4UPBi+BS3UM1M4QPcvhQfOyFxAg?= =?us-ascii?Q?EujtQdXHl+yCK9N8SKz/+vUjsjbEdinA8aIdIY6BKt1vGMg/vKKHdHXyvYmq?= =?us-ascii?Q?e9h4S5Jcdvaqj2FgQj3njkb7?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3117.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8028dd68-a03c-4459-1081-08d8ef736243 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2021 09:50:12.0435 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CpjQdmPFaOYWjJVY2zwL0UyynBjZbeVI2yI5nbIUu7/Yvy8ylT1be10X488Ur8IM6+Hz+9mP0XHD58v/rSWWJBQQqfggiwFhPvBnGgPieLE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4969 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v5 2/8] eventdev: introduce event vector Rx capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Pavan Nikhilesh Bhagavatula > Sent: Thursday, March 25, 2021 2:54 PM > To: Jayatheerthan, Jay ; Jerin Jacob Kollanu= kkaran ; Carrillo, Erik G > ; Gujjar, Abhinandan S ; McDaniel, Timothy > ; hemant.agrawal@nxp.com; Van Haaren, Harry <= harry.van.haaren@intel.com>; mattias.ronnblom > ; Ma, Liang J ; Ray = Kinsella ; Neil Horman > > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v5 2/8] eventdev: introduce event vector R= x capability >=20 > >> From: pbhagavatula@marvell.com > >> Sent: Wednesday, March 24, 2021 10:35 AM > >> To: jerinj@marvell.com; Jayatheerthan, Jay > >; Carrillo, Erik G > >; Gujjar, > >> Abhinandan S ; McDaniel, Timothy > >; hemant.agrawal@nxp.com; Van > >> Haaren, Harry ; mattias.ronnblom > >; Ma, Liang J > >> ; Ray Kinsella ; Neil Horman > > > >> Cc: dev@dpdk.org; Pavan Nikhilesh > >> Subject: [dpdk-dev] [PATCH v5 2/8] eventdev: introduce event vector > >Rx capability > >> > >> From: Pavan Nikhilesh > >> > >> Introduce event ethernet Rx adapter event vector capability. > >> > >> If an event eth Rx adapter has the capability of > >> RTE_EVENT_ETH_RX_ADAPTER_CAP_EVENT_VECTOR then a given Rx > >queue > >> can be configured to enable event vectorization by passing the > >> flag RTE_EVENT_ETH_RX_ADAPTER_QUEUE_EVENT_VECTOR to > >> rte_event_eth_rx_adapter_queue_conf::rx_queue_flags while > >configuring > >> Rx adapter through rte_event_eth_rx_adapter_queue_add(). > >> > >> The max vector size, vector timeout define the vector size and > >> mempool used for allocating vector event are configured through > >> rte_event_eth_rx_adapter_queue_add. The element size of the > >element > >> in the vector pool should be equal to > >> sizeof(struct rte_event_vector) + (vector_sz * sizeof(uintptr_t)) > >> > >> Application can use `rte_event_vector_pool_create` to create the > >> vector mempool used for > >> rte_event_eth_rx_adapter_queue_conf::vector_mp. > >> > >> The Rx adapter would be responsible for vectorizing the mbufs > >> based on the flow, the vector limits configured by the application > >> and add the vector event of mbufs to the event queue set via > >> rte_event_eth_rx_adapter_queue_conf::ev::queue_id. > >> It should also mark rte_event_vector::union_valid and fill > >> rte_event_vector::port, rte_event_vector::queue. > >> > >> Signed-off-by: Pavan Nikhilesh > >> Acked-by: Jerin Jacob > >> --- > >> .../prog_guide/event_ethernet_rx_adapter.rst | 38 ++++++ > >> lib/librte_eventdev/eventdev_pmd.h | 53 ++++++++ > >> .../rte_event_eth_rx_adapter.c | 114 +++++++++++++++++= + > >> .../rte_event_eth_rx_adapter.h | 105 ++++++++++++++++ > >> lib/librte_eventdev/rte_eventdev.h | 30 ++++- > >> lib/librte_eventdev/version.map | 2 + > >> 6 files changed, 340 insertions(+), 2 deletions(-) > >> > >> diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > >b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > >> index cb44ce0e4..5eefef355 100644 > >> --- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > >> +++ b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > >> @@ -186,3 +186,41 @@ the event buffer fill level is low. The > >> ``rte_event_eth_rx_adapter_cb_register()`` function allow the > >application > >> to register a callback that selects which packets to enqueue to the > >event > >> device. > >> + > >> +Rx event vectorization > >> +~~~~~~~~~~~~~~~~~~~~~~ > >> + > >> +The event devices, ethernet device pairs which support the capability > >> +``RTE_EVENT_ETH_RX_ADAPTER_CAP_EVENT_VECTOR`` can > >aggregate packets based on > >> +flow characteristics and generate a ``rte_event`` containing > >``rte_event_vector`` > >> +whose event type is either ``RTE_EVENT_TYPE_ETHDEV_VECTOR`` or > >> +``RTE_EVENT_TYPE_ETH_RX_ADAPTER_VECTOR``. > >> +The aggregation size and timeout are configurable at a queue level > >and the > >> +maximum, minimum vector sizes and timeouts vary based on the > >device capability > >> +and can be queried using > >``rte_event_eth_rx_adapter_vector_limits_get``. > >> +The Rx adapter additionally might include useful data such as > >ethernet device > >> +port and queue identifier in the ``rte_event_vector::port`` and > >> +``rte_event_vector::queue`` and mark > >``rte_event_vector::attr_valid`` as true. > >> + > >> +A loop processing ``rte_event_vector`` containing mbufs is shown > >below. > >> + > >> +.. code-block:: c > >> + > >> + event =3D rte_event_dequeue_burst(event_dev, event_port, > >&event, > >> + 1, 0); > >> + if (!event) > >> + continue; > >> + > >> + switch (ev.event_type) { > >> + case RTE_EVENT_TYPE_ETH_RX_ADAPTER_VECTOR: > >> + case RTE_EVENT_TYPE_ETHDEV_VECTOR: > >> + struct rte_mbufs **mbufs; > >> + > >> + mbufs =3D (struct rte_mbufs **)ev[i].vec->mbufs; > >> + for (i =3D 0; i < ev.vec->nb_elem; i++) { > >> + /* Process each mbuf. */ > >> + } > >> + break; > >> + case ... > >> + ... > >> + } > >> diff --git a/lib/librte_eventdev/eventdev_pmd.h > >b/lib/librte_eventdev/eventdev_pmd.h > >> index 7eb9a7739..9297f1433 100644 > >> --- a/lib/librte_eventdev/eventdev_pmd.h > >> +++ b/lib/librte_eventdev/eventdev_pmd.h > >> @@ -645,6 +645,53 @@ typedef int > >(*eventdev_eth_rx_adapter_stats_reset) > >> */ > >> typedef int (*eventdev_selftest)(void); > >> > >> +struct rte_event_eth_rx_adapter_vector_limits; > >> +/** > >> + * Get event vector limits for a given event, ethernet device pair. > >> + * > >> + * @param dev > >> + * Event device pointer > >> + * > >> + * @param eth_dev > >> + * Ethernet device pointer > >> + * > >> + * @param[out] limits > >> + * Pointer to the limits structure to be filled. > >> + * > >> + * @return > >> + * - 0: Success. > >> + * - <0: Error code returned by the driver function. > >> + */ > >> +typedef int (*eventdev_eth_rx_adapter_vector_limits_get_t)( > >> + const struct rte_eventdev *dev, const struct rte_eth_dev > >*eth_dev, > >> + struct rte_event_eth_rx_adapter_vector_limits *limits); > >> + > >> +struct rte_event_eth_rx_adapter_event_vector_config; > >> +/** > >> + * Enable event vector on an given Rx queue of a ethernet devices > >belonging to > >> + * the Rx adapter. > >> + * > >> + * @param dev > >> + * Event device pointer > >> + * > >> + * @param eth_dev > >> + * Ethernet device pointer > >> + * > >> + * @param rx_queue_id > >> + * The Rx queue identifier > >> + * > >> + * @param config > >> + * Pointer to the event vector configuration structure. > >> + * > >> + * @return > >> + * - 0: Success. > >> + * - <0: Error code returned by the driver function. > >> + */ > >> +typedef int (*eventdev_eth_rx_adapter_event_vector_config_t)( > >> + const struct rte_eventdev *dev, const struct rte_eth_dev > >*eth_dev, > >> + int32_t rx_queue_id, > >> + const struct rte_event_eth_rx_adapter_event_vector_config > >*config); > >> + > >> typedef uint32_t rte_event_pmd_selftest_seqn_t; > >> extern int rte_event_pmd_selftest_seqn_dynfield_offset; > >> > >> @@ -1067,6 +1114,12 @@ struct rte_eventdev_ops { > >> /**< Get ethernet Rx stats */ > >> eventdev_eth_rx_adapter_stats_reset > >eth_rx_adapter_stats_reset; > >> /**< Reset ethernet Rx stats */ > >> + eventdev_eth_rx_adapter_vector_limits_get_t > >> + eth_rx_adapter_vector_limits_get; > >> + /**< Get event vector limits for the Rx adapter */ > >> + eventdev_eth_rx_adapter_event_vector_config_t > >> + eth_rx_adapter_event_vector_config; > >> + /**< Configure Rx adapter with event vector */ > >> > >> eventdev_timer_adapter_caps_get_t timer_adapter_caps_get; > >> /**< Get timer adapter capabilities */ > >> diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c > >b/lib/librte_eventdev/rte_event_eth_rx_adapter.c > >> index d8c635e99..ac8ba5bf0 100644 > >> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c > >> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c > >> @@ -2263,6 +2263,120 @@ > >rte_event_eth_rx_adapter_queue_del(uint8_t id, uint16_t eth_dev_id, > >> return ret; > >> } > >> > >> +int > >> +rte_event_eth_rx_adapter_queue_event_vector_config( > >> + uint8_t id, uint16_t eth_dev_id, int32_t rx_queue_id, > >> + struct rte_event_eth_rx_adapter_event_vector_config *config) > >> +{ > >> + struct rte_event_eth_rx_adapter_vector_limits limits; > >> + struct rte_event_eth_rx_adapter *rx_adapter; > >> + struct rte_eventdev *dev; > >> + uint32_t cap; > >> + int ret; > >> + > >> + RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(id, - > >EINVAL); > >> + RTE_ETH_VALID_PORTID_OR_ERR_RET(eth_dev_id, -EINVAL); > >> + > >> + rx_adapter =3D rxa_id_to_adapter(id); > >> + if ((rx_adapter =3D=3D NULL) || (config =3D=3D NULL)) > >> + return -EINVAL; > >> + > >> + dev =3D &rte_eventdevs[rx_adapter->eventdev_id]; > >> + ret =3D rte_event_eth_rx_adapter_caps_get(rx_adapter- > >>eventdev_id, > >> + eth_dev_id, &cap); > >> + if (ret) { > >> + RTE_EDEV_LOG_ERR("Failed to get adapter caps edev > >%" PRIu8 > >> + "eth port %" PRIu16, > >> + id, eth_dev_id); > >> + return ret; > >> + } > >> + > >> + if (!(cap & > >RTE_EVENT_ETH_RX_ADAPTER_CAP_EVENT_VECTOR)) { > >> + RTE_EDEV_LOG_ERR("Event vectorization is not > >supported," > >> + " eth port: %" PRIu16 " adapter id: %" > >PRIu8, > >> + eth_dev_id, id); > >> + return -EINVAL; > >> + } > >> + > >> + ret =3D rte_event_eth_rx_adapter_vector_limits_get( > >> + rx_adapter->eventdev_id, eth_dev_id, &limits); > >> + if (ret) { > >> + RTE_EDEV_LOG_ERR("Failed to get vector limits edev > >%" PRIu8 > >> + "eth port %" PRIu16, > >> + rx_adapter->eventdev_id, eth_dev_id); > >> + return ret; > >> + } > >> + > >> + if (config->vector_sz < limits.min_sz || > >> + config->vector_sz > limits.max_sz || > >> + config->vector_timeout_ns < limits.min_timeout_ns || > >> + config->vector_timeout_ns > limits.max_timeout_ns || > >> + config->vector_mp =3D=3D NULL) { > >> + RTE_EDEV_LOG_ERR("Invalid event vector > >configuration," > >> + " eth port: %" PRIu16 " adapter id: %" > >PRIu8, > >> + eth_dev_id, id); > >> + return -EINVAL; > >> + } > >> + if (config->vector_mp->elt_size < > >> + (sizeof(struct rte_event_vector) + > >> + (sizeof(uintptr_t) * config->vector_sz))) { > >> + RTE_EDEV_LOG_ERR("Invalid event vector > >configuration," > >> + " eth port: %" PRIu16 " adapter id: %" > >PRIu8, > >> + eth_dev_id, id); > >> + return -EINVAL; > >> + } > >> + > >> + if (cap & > >RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT) { > >> + RTE_FUNC_PTR_OR_ERR_RET( > >> + *dev->dev_ops- > >>eth_rx_adapter_event_vector_config, > >> + -ENOTSUP); > >> + ret =3D dev->dev_ops- > >>eth_rx_adapter_event_vector_config( > >> + dev, &rte_eth_devices[eth_dev_id], > >rx_queue_id, config); > >> + } else { > >> + ret =3D -ENOTSUP; > >> + } > > > >Trying to understand why non-INTERNAL_PORT based event device > >implementation returns ENOTSUP. Do you foresee any issues if such a > >device implements this function? > > >=20 > I just didn't want to move the implementation here as this patch is only > Intended for spec. > The implementation for non-INTERNAL_PORT is in 4/8 Makes sense. Thanks! >=20 > >> + > >> + return ret; > >> +} > >> + > >> +int > >> +rte_event_eth_rx_adapter_vector_limits_get( > >> + uint8_t dev_id, uint16_t eth_port_id, > >> + struct rte_event_eth_rx_adapter_vector_limits *limits) > >> +{ > >> + struct rte_eventdev *dev; > >> + uint32_t cap; > >> + int ret; > >> + > >> + RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); > >> + RTE_ETH_VALID_PORTID_OR_ERR_RET(eth_port_id, -EINVAL); > >> + > >> + if (limits =3D=3D NULL) > >> + return -EINVAL; > >> + > >> + dev =3D &rte_eventdevs[dev_id]; > >> + > >> + ret =3D rte_event_eth_rx_adapter_caps_get(dev_id, eth_port_id, > >&cap); > >> + if (ret) { > >> + RTE_EDEV_LOG_ERR("Failed to get adapter caps edev > >%" PRIu8 > >> + "eth port %" PRIu16, > >> + dev_id, eth_port_id); > >> + return ret; > >> + } > >> + > >> + if (cap & > >RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT) { > >> + RTE_FUNC_PTR_OR_ERR_RET( > >> + *dev->dev_ops- > >>eth_rx_adapter_vector_limits_get, > >> + -ENOTSUP); > >> + ret =3D dev->dev_ops- > >>eth_rx_adapter_vector_limits_get( > >> + dev, &rte_eth_devices[eth_port_id], limits); > >> + } else { > >> + ret =3D -ENOTSUP; > >> + } > >> + > > > >Same here. > > > >> + return ret; > >> +} > >> + > >> int > >> rte_event_eth_rx_adapter_start(uint8_t id) > >> { > >> diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.h > >b/lib/librte_eventdev/rte_event_eth_rx_adapter.h > >> index 21bb1e54c..7407cde00 100644 > >> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.h > >> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.h > >> @@ -92,6 +92,10 @@ extern "C" { > >> /**< This flag indicates the flow identifier is valid > >> * @see rte_event_eth_rx_adapter_queue_conf::rx_queue_flags > >> */ > >> +#define RTE_EVENT_ETH_RX_ADAPTER_QUEUE_EVENT_VECTOR > > 0x2 > >> +/**< This flag indicates that mbufs arriving on the queue need to be > >vectorized > >> + * @see rte_event_eth_rx_adapter_queue_conf::rx_queue_flags > >> + */ > >> > >> /** > >> * Adapter configuration structure that the adapter configuration > >callback > >> @@ -169,6 +173,36 @@ struct > >rte_event_eth_rx_adapter_queue_conf { > >> */ > >> }; > >> > >> +struct rte_event_eth_rx_adapter_event_vector_config { > >> + uint16_t vector_sz; > >> + /**< > >> + * Indicates the maximum number for mbufs to combine and > >form a vector. > >> + * Should be within > >> + * @see > >rte_event_eth_rx_adapter_vector_limits::min_vector_sz > >> + * @see > >rte_event_eth_rx_adapter_vector_limits::max_vector_sz > >> + * Valid when > >RTE_EVENT_ETH_RX_ADAPTER_QUEUE_EVENT_VECTOR flag is set in > >> + * @see > >rte_event_eth_rx_adapter_queue_conf::rx_queue_flags > >> + */ > >> + uint64_t vector_timeout_ns; > >> + /**< > >> + * Indicates the maximum number of nanoseconds to wait for > >receiving > >> + * mbufs. Should be within vectorization limits of the > >> + * adapter > >> + * @see > >rte_event_eth_rx_adapter_vector_limits::min_vector_ns > >> + * @see > >rte_event_eth_rx_adapter_vector_limits::max_vector_ns > >> + * Valid when > >RTE_EVENT_ETH_RX_ADAPTER_QUEUE_EVENT_VECTOR flag is set in > >> + * @see > >rte_event_eth_rx_adapter_queue_conf::rx_queue_flags > >> + */ > >> + struct rte_mempool *vector_mp; > >> + /**< > >> + * Indicates the mempool that should be used for allocating > >> + * rte_event_vector container. > >> + * Should be created by using `rte_event_vector_pool_create`. > >> + * Valid when > >RTE_EVENT_ETH_RX_ADAPTER_QUEUE_EVENT_VECTOR flag is set in > >> + * @see > >rte_event_eth_rx_adapter_queue_conf::rx_queue_flags. > >> + */ > >> +}; > >> + > >> /** > >> * A structure used to retrieve statistics for an eth rx adapter > >instance. > >> */ > >> @@ -199,6 +233,32 @@ struct rte_event_eth_rx_adapter_stats { > >> /**< Received packet count for interrupt mode Rx queues */ > >> }; > >> > >> +/** > >> + * A structure used to retrieve eth rx adapter vector limits. > >> + */ > >> +struct rte_event_eth_rx_adapter_vector_limits { > >> + uint16_t min_sz; > >> + /**< Minimum vector limit configurable. > >> + * @see > >rte_event_eth_rx_adapter_event_vector_config::vector_sz > >> + */ > >> + uint16_t max_sz; > >> + /**< Maximum vector limit configurable. > >> + * @see > >rte_event_eth_rx_adapter_event_vector_config::vector_sz > >> + */ > >> + uint8_t log2_sz; > >> + /**< True if the size configured should be in log2. > >> + * @see > >rte_event_eth_rx_adapter_event_vector_config::vector_sz > >> + */ > >> + uint64_t min_timeout_ns; > >> + /**< Minimum vector timeout configurable. > >> + * @see > >rte_event_eth_rx_adapter_event_vector_config::vector_timeout_ns > >> + */ > >> + uint64_t max_timeout_ns; > >> + /**< Maximum vector timeout configurable. > >> + * @see > >rte_event_eth_rx_adapter_event_vector_config::vector_timeout_ns > >> + */ > >> +}; > >> + > >> /** > >> * > >> * Callback function invoked by the SW adapter before it continues > >> @@ -467,6 +527,51 @@ int > >rte_event_eth_rx_adapter_cb_register(uint8_t id, uint16_t eth_dev_id, > >> > >rte_event_eth_rx_adapter_cb_fn cb_fn, > >> void *cb_arg); > >> > >> +/** > >> + * Retrieve vector limits for a given event dev and eth dev pair. > >> + * @see rte_event_eth_rx_adapter_vector_limits > >> + * > >> + * @param dev_id > >> + * Event device identifier. > >> + * @param eth_port_id > >> + * Port identifier of the ethernet device. > >> + * @param [out] limits > >> + * A pointer to rte_event_eth_rx_adapter_vector_limits structure > >that has to > >> + * be filled. > >> + * > >> + * @return > >> + * - 0: Success. > >> + * - <0: Error code on failure. > >> + */ > >> +__rte_experimental > >> +int rte_event_eth_rx_adapter_vector_limits_get( > >> + uint8_t dev_id, uint16_t eth_port_id, > >> + struct rte_event_eth_rx_adapter_vector_limits *limits); > >> + > >> +/** > >> + * Configure event vectorization for a given ethernet device queue, > >that has > >> + * been added to a event eth Rx adapter. > >> + * > >> + * @param id > >> + * The identifier of the ethernet Rx event adapter. > >> + * > >> + * @param eth_dev_id > >> + * The identifier of the ethernet device. > >> + * > >> + * @param rx_queue_id > >> + * Ethernet device receive queue index. > >> + * If rx_queue_id is -1, then all Rx queues configured for the > >ethernet device > >> + * are configured with event vectorization. > >> + * > >> + * @return > >> + * - 0: Success, Receive queue configured correctly. > >> + * - <0: Error code on failure. > >> + */ > >> +__rte_experimental > >> +int rte_event_eth_rx_adapter_queue_event_vector_config( > >> + uint8_t id, uint16_t eth_dev_id, int32_t rx_queue_id, > >> + struct rte_event_eth_rx_adapter_event_vector_config > >*config); > >> + > >> #ifdef __cplusplus > >> } > >> #endif > >> diff --git a/lib/librte_eventdev/rte_eventdev.h > >b/lib/librte_eventdev/rte_eventdev.h > >> index aa4dd3959..678338247 100644 > >> --- a/lib/librte_eventdev/rte_eventdev.h > >> +++ b/lib/librte_eventdev/rte_eventdev.h > >> @@ -919,10 +919,28 @@ rte_event_dev_close(uint8_t dev_id); > >> * Event vector structure. > >> */ > >> struct rte_event_vector { > >> - uint64_t nb_elem : 16; > >> + uint16_t nb_elem; > >> /**< Number of elements in this event vector. */ > >> - uint64_t rsvd : 48; > >> + uint16_t rsvd : 15; > >> /**< Reserved for future use */ > >> + uint16_t attr_valid : 1; > >> + /**< Indicates that the below union attributes have valid > >information. > >> + */ > >> + union { > >> + /* Used by Rx adapter. > >> + * Indicates that all the elements in this vector belong to > >the > >> + * same port and queue pair when originating from Rx > >adapter, > >> + * valid only when event type is ETHDEV_VECTOR or > >> + * ETH_RX_ADAPTER_VECTOR. > >> + */ > >> + struct { > >> + uint16_t port; > >> + /* Ethernet device port id. */ > >> + uint16_t queue; > >> + /* Ethernet device queue id. */ > >> + }; > >> + }; > >> + /**< Union to hold common attributes of the vector array. */ > >> uint64_t impl_opaque; > >> /**< Implementation specific opaque value. > >> * An implementation may use this field to hold implementation > >specific > >> @@ -1025,8 +1043,14 @@ struct rte_event_vector { > >> * // Classify and handle event. > >> * } > >> */ > >> +#define RTE_EVENT_TYPE_ETHDEV_VECTOR > >\ > >> + (RTE_EVENT_TYPE_VECTOR | RTE_EVENT_TYPE_ETHDEV) > >> +/**< The event vector generated from ethdev subsystem */ > >> #define RTE_EVENT_TYPE_CPU_VECTOR (RTE_EVENT_TYPE_VECTOR > >| RTE_EVENT_TYPE_CPU) > >> /**< The event vector generated from cpu for pipelining. */ > >> +#define RTE_EVENT_TYPE_ETH_RX_ADAPTER_VECTOR > >\ > >> + (RTE_EVENT_TYPE_VECTOR | > >RTE_EVENT_TYPE_ETH_RX_ADAPTER) > >> +/**< The event vector generated from eth Rx adapter. */ > >> > >> #define RTE_EVENT_TYPE_MAX 0x10 > >> /**< Maximum number of event types */ > >> @@ -1171,6 +1195,8 @@ struct rte_event { > >> * @see struct rte_event_eth_rx_adapter_queue_conf::ev > >> * @see struct > >rte_event_eth_rx_adapter_queue_conf::rx_queue_flags > >> */ > >> +#define RTE_EVENT_ETH_RX_ADAPTER_CAP_EVENT_VECTOR > > 0x8 > >> +/**< Adapter supports event vectorization per ethdev. */ > >> > >> /** > >> * Retrieve the event device's ethdev Rx adapter capabilities for the > >> diff --git a/lib/librte_eventdev/version.map > >b/lib/librte_eventdev/version.map > >> index a070ef56e..902df0ae3 100644 > >> --- a/lib/librte_eventdev/version.map > >> +++ b/lib/librte_eventdev/version.map > >> @@ -141,6 +141,8 @@ EXPERIMENTAL { > >> > >> #added in 21.05 > >> rte_event_vector_pool_create; > >> + rte_event_eth_rx_adapter_vector_limits_get; > >> + rte_event_eth_rx_adapter_queue_event_vector_config; > >> }; > >> > >> INTERNAL { > >> -- > >> 2.17.1 > > > >More of informational queries. > > > >Acked-by: Jay Jayatheerthan