From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF6D5A00C4; Tue, 26 Jul 2022 18:21:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 654BB40E25; Tue, 26 Jul 2022 18:21:44 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 8501B40E0F for ; Tue, 26 Jul 2022 18:21:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658852502; x=1690388502; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=R892yL8p0b3l9v+fvN4fCj4X38gAMgAlStgFlKqlGm8=; b=MhNzJhQO0CFoWtMI56dXyM3YSWTPnjoi1a6CcUucDh2dADiJfwEYj8Xm oRrVPsTqvAWVUAEewZ8Kawyce3gLX1ZkqS5YUB+/38B21HgWAjQvHzR47 1Ygn7Ubms0TD+DIAOmbK14lPYpeHZgAHqhVT4GpuBmnJiCwRIULohHiKz WzkEkYIkWF+mE/kH7Fq1inEMwwGtqOmhv4IPu59Afr+92A0LnKzrdP9zI 2P6N53ST/X2FEfuAhvTAlHMcFU9Mt0r9MIt7ivbHbNPTUNEJ0X17b3J3X qkVW4yD8YluDvadZLdSMpXjzu15uQPmLSpZCj1qhQMuztGCg/DnouJsbD Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10420"; a="274867078" X-IronPort-AV: E=Sophos;i="5.93,194,1654585200"; d="scan'208";a="274867078" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2022 09:21:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,194,1654585200"; d="scan'208";a="927396226" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 26 Jul 2022 09:21:18 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 26 Jul 2022 09:21:18 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 26 Jul 2022 09:21:17 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Tue, 26 Jul 2022 09:21:17 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Tue, 26 Jul 2022 09:21:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ju6nf79fS3ofYvvEE+zsBK0fQMip2SmgrQD30NzNuDj6tjLIeUWQV/ogiYIFx1VUChLmrOFowkMJHa1mkTu4eu2eeTmMs/Fip7mzjJr6JqXa9JoDXRElTah/6xNTmYaC5jdpl7SZ+9MEP/8d63+BCWyZuRHc9mLKC/3H9BBH+Th0C3i2yXMVsyoipybWhWTeOKrWbgVcvwQ27aoqlrxsS8p1mnpZvv514HnFbhtUZCN/B/ALl8sUSHyp674UxG8uShiTfdhSNmyTgyAF9UC/D2zPVinfZhOMFwTzq6S8t+hE6g63oCKrgFfp9wxVBB3AoPSYzUw2lW3riY2mB083HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WXW2trXPv5FUEbXYNs9ykeV11VVkH1As7yP3FLkIWmY=; b=dg7TAjpQkb33T8M3YrTA/HUadWjykUcoeuYom3e84N1r3BVBigK3+JtM/gRvP8sd3CfaXSj+fFncbCJXX/0DFNHmFzjHvC5K/8e6EXsU1E3GW4G/UeyLqv606x4wJaP8a05g50kK/mf6Ikrk/JZJf6hJ8enpChhog4JP9Mx5EnUMkmiOaYalnHWUCUx2kiC1UvZMoWvK9ooibV0BiIoZtIWIbylX+L6dbTGH3oj7+NZdN2ez3CR8pztBPYgnABJBi0Zj2B70w7rrP0ZAepv2RRfbIKZbEorAFNaysZP8YOZT+mpcmNhTUyhg/hdiBSKclFhvx1N5r6zLdld8Ar03vA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3119.namprd11.prod.outlook.com (2603:10b6:805:cc::10) by DM5PR11MB1513.namprd11.prod.outlook.com (2603:10b6:4:9::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Tue, 26 Jul 2022 16:21:16 +0000 Received: from SN6PR11MB3119.namprd11.prod.outlook.com ([fe80::91c0:b34f:ee48:788c]) by SN6PR11MB3119.namprd11.prod.outlook.com ([fe80::91c0:b34f:ee48:788c%6]) with mapi id 15.20.5458.025; Tue, 26 Jul 2022 16:21:16 +0000 From: "Kearney, Tadhg" To: "Richardson, Bruce" CC: "dev@dpdk.org" , "Hunt, David" , "Burakov, Anatoly" , "Pattan, Reshma" Subject: RE: [PATCH v2 1/3] power: add uncore API to power library Thread-Topic: [PATCH v2 1/3] power: add uncore API to power library Thread-Index: AQHYlsHowqFOzPs1GkiNQElGWNocea2HeNeAgAEaoYCACECgcA== Date: Tue, 26 Jul 2022 16:21:16 +0000 Message-ID: References: <20220713140706.4143705-1-tadhg.kearney@intel.com> <20220713140706.4143705-2-tadhg.kearney@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 67c5714d-45b0-48cc-6071-08da6f22dd83 x-ms-traffictypediagnostic: DM5PR11MB1513:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: s9LNPCzmgVOhjWcIFffs/BKtoSd+x34vAps3RGdvYhnd+tBJydyhrIef6YkYKkEnvzBdBjWYA6fApGPyK4LpZqiJKb9ZHYM90shq3tnrG5MbLR7JZNpAUC1qj8d+ARaPjz7dcgTrns2TRbeo+6RUUyq0INRR0sMP7p4kBBf8zr5Nx1J40ibKgnZHNdP8PrZG4kt0VosRO3Q9Q2KEw9ewSimv3rq30ewL/ToMW6zqNoD0EeMgiFb69+VIj6II9qxHKpI+Yy9mOjDyHYU3Lq4H+jlEMp/0DPSb09nxsbi2BtsMLpal7Hh2s+qov5oVK1aMd2Qv7PjgC+DoezTUgMkx4AHm5mCQ+8UcU3ClkxOikuojdp6Szzps8C6F40ZbnK5iia4ViXEJxE7JMGaSg+dNXIsDjhYILyYj+eHFDsoiUZOOs4ADdbgZuc2MpvKTHj6V+MDB/dzhB8dfHcAqO/MXVgDHq1am1IOU8l6/csfTKBWr50qAASbT89xeF9dZ8UmOet2PE9IptzaHOaYJekm5enf+c4NYJTk0C66tEf7JJGpOMALop+CsCsF1E3kmlgRoWcD6DO6TrgXeR56C3ALq8vBNlD01kPBTDFp2Qpet2HSGuthPygiWM9Wg0Rg4clmz9pA0G3gm/aehCE46hN2RpWzeKtnTvKNTJF8gvt2NRWUqClGFv/yiTMaPHP+sL0SjsxulAOiOLRabrGypC0piDxYmaTX7TftigolqdZKC54dFVFk7dPSYg05XfpsTEyL9SmYCoo0GzHh7ilmyEvvqB61/fIqfx9Hl9ZL7DNGKH546WlCb3/Alj+Jw40uhR7/x x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3119.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(136003)(396003)(376002)(346002)(39860400002)(26005)(9686003)(82960400001)(38070700005)(64756008)(66946007)(71200400001)(4326008)(122000001)(8676002)(66476007)(66446008)(38100700002)(66556008)(76116006)(33656002)(41300700001)(7696005)(6506007)(2906002)(5660300002)(186003)(478600001)(6862004)(86362001)(83380400001)(8936002)(107886003)(316002)(55016003)(6636002)(54906003)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0mkN9H11Yeqt7Z7+iU+5LzYfqCl9NtEV3X5YUPpeYg3teDhk2BaBr6ptYBGx?= =?us-ascii?Q?PgsWaYKn8aJvJHfW5m02NE0cXFFgOnmVYXar+E8CtLYqtRzP8vKsYRL9M8++?= =?us-ascii?Q?y/iNOdsXL2Rlv+I55vOuXIudG9h9k7fbpcSosB1BhELr0Rj7U0mTM6R+P+yy?= =?us-ascii?Q?cRJnwIgyMmLKH3jfaLRZvBW9xtILxovS0mik4zj/rLGyMC5qu7FEsRQGphHg?= =?us-ascii?Q?V24p1K0M/QTdJjH4gACoUEL1pdCxh4k3Hd2WRcpGuk8/0O90ExLK/qpnI2Fu?= =?us-ascii?Q?pa9wunO7Sma672YuXPJCRMucZWbEPFHCKSk9uwOpec9X4ldRZrVl8f0y6CtG?= =?us-ascii?Q?pr9Vsm4dsqdP+VHQxtT6/lhKfpPOC7xSDEtssTTwoycncenk0nqaQaubeIvH?= =?us-ascii?Q?+6t23FCqBU87P4d/Zv4BvRvHpHHdbXgrv6lRSOJHVlM5udoICehzfWiVnyYK?= =?us-ascii?Q?yt+mXu90HG//MrD9xqE15YZ4itAB8DB1cQIgtaBT1sOtnywRne+NMVycoSS8?= =?us-ascii?Q?UVRCMEd392rGYo9shxJa7c9QuJwV6lTOc8PZJ982q1cjlmupB5htXrdc0hKa?= =?us-ascii?Q?VmuZl93gPKANN0N1kw+/SYf/OeD/SivBuo5RxQMun9kQ975GN557Dce7HYZ2?= =?us-ascii?Q?A7S7fMEj+mBVvtiLYbo/kaEV7uOYpLO79ixDLu3IwKsdraLF3w7hLdLQua6b?= =?us-ascii?Q?N0quZKt4ZuXxbcoQZrMGagGwk7LTSJ9zoTwkoHpQPntH2ZvybygygEY3/Zze?= =?us-ascii?Q?Ir5kpDTkWWeoeC/js/IctDKjI51JCw4yX1qdHulA9KswIJSJuCKYK9Ci2kqc?= =?us-ascii?Q?cdwOQhkQb3/tPlKxQaro218R3iaffMpJPMi9XFEIgmfvUckcHTDDOW0KlwcI?= =?us-ascii?Q?DfX1FN2KCoRSg+SRNf2QL1jCH61NAJmwWXBMD7Chq1nU6SZxxaeH9hVtCLbp?= =?us-ascii?Q?C4hXKxd7OW+6FM2b6xgBcQKMaYZITt+qdm3GtQsSYRmpok8wX6g69Uyu1VEs?= =?us-ascii?Q?v0Nhj+R9FRO7XfbMA6+zpvuvDBVyHsgB4YBbDlxC6ryOj3h1Ksrw/aZNQzc7?= =?us-ascii?Q?kKC5fNKaM4VbtiDE1DDEPZZyVcWwY/TQYHgYSzXFXJT6n5KEoPkAekLBE2mP?= =?us-ascii?Q?hQksKReAWQqCwmzuSjQKgcYoOpe9IFhLYw3pVWdQx6DJC1mtt7PRXlH1APnA?= =?us-ascii?Q?D6SJiPty0wvy9f9AGr4bWOJZdOhuJdPV78eGqD9nf8zjWL0TANeu/zoPlEme?= =?us-ascii?Q?1v9qdimH+trrUY9fWnQuvBqbRtrW1TJwOh6WxvWPawnL3e7ZcKNSwDzPv5tC?= =?us-ascii?Q?1UaSDoZJomUFDeDmhWH6tH5eFi4sP2GPzcqHuxNYedRiyIVasje42hz+DKhx?= =?us-ascii?Q?1YuzAaxcsD3mEPZpx9uAhNk8qxJVAPJ9i2TodRxf7FHwGnzeqi86yvVlyFs5?= =?us-ascii?Q?Ljp4/AoqF4phxoQfYx0z3ngld66/NUum7pKiNzhIR5C2pUYRVAixvb5VeYB7?= =?us-ascii?Q?7AvX0XUd1tvd/bgNB4YnIQ6Qws4tFqIfpJauM3DZ+jufehcIfq6nbD3YPQG+?= =?us-ascii?Q?4jTr4klVi7fZArO9NyhfG9tFoavTrq7WFz93UwJA?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3119.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67c5714d-45b0-48cc-6071-08da6f22dd83 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2022 16:21:16.2136 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wUzGOtJr3qRx2Ki22DnEksAyep1ujNiBGCAuZXjbsQscr1iC91CsLrZ/Q+wVErSxq2Tr9ngvglEFxh5ElaDk1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1513 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Richardson, Bruce *snip* > > > +dpdk_conf.set('RTE_MAX_NUMA_DIE', 1) > > > +dpdk_conf.set('RTE_MAX_UNCORE_FREQS', 32) > > > > Check if these flags should be added to other platforms. > > >=20 > I think we need some explanation as to what these values are for, and how > they should be set for various platforms. Kernel does support sysfs uncore interface, as in below:=20 "To control uncore frequency, a sysfs interface is provided in the director= y: /sys/devices/system/cpu/intel_uncore_frequency/. There is one directory for each package and die combination as the scope of= uncore scaling control is per die in multiple die/package SoCs or per pack= age for single die per package SoCs. The name represents the scope of contr= ol. For example: 'package_00_die_00' is for package id 0 and die 0."=20 The macros 'RTE_MAX_NUMA_DIE' and 'RTE_MAX_UNCORE_FREQS' were first introdu= ced as we needed to impose limits on cpu die number and how many uncore fre= quencies would be allowed for a system. > Are they always these values, or No, they differ from system to system. > should they be determined programmatically at build time? Retrieving information about die and number of uncore frequencies is not po= ssible as we do not have a direct interface in Linux which would give this = information. With all this, better to remove these macros altogether from config path an= d instead figure out number of dies during run time, by iterating through p= ackage and die files from the sysfs file 'package_*_die_*', for systems that support sysfs uncore path. We would then give error with= systems that do not contain sysfs uncore path. Regards, Tadhg =20