From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85467A0032; Thu, 14 Jul 2022 16:56:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 18B5A42B7E; Thu, 14 Jul 2022 16:56:57 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 70B5B42B74 for ; Thu, 14 Jul 2022 16:56:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657810615; x=1689346615; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=g0DqCM5fPOxhyU5T/uezx+TTplYZ6suuYUGjqX9CLRg=; b=bvCdTXWkR8hVVAbwX0njjkSpmvZCrNEGdwvmrq5giPn8g6gk9S/57J/s NJarLjUV1ffI+ZQlImQNpMU+/ODzPRVSFq2Asikql7dXKejO6Wud13l+W 0O8xYgDf4jqhEOZIbNAAzDch7BqbosnGC5ujAFCaruTqVQCjydMlnYKkZ yCatTKMWrQtGpw6dQy4R+km+/nspUMRTnlNPjxYYm1nyHfH3GMGIhl1pz HTyX77+TiRlHrFCcVGCsJ1hPITMd1A9segnmbUq8dS2h8SqT0AlZ3eDdm JC/IpfdjNk2ghRAK3hZs0mY7Mj6UPQ7oNNW0ciWp5fjzlkbJFBCS6Jk2o g==; X-IronPort-AV: E=McAfee;i="6400,9594,10408"; a="371846101" X-IronPort-AV: E=Sophos;i="5.92,271,1650956400"; d="scan'208";a="371846101" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2022 07:56:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,271,1650956400"; d="scan'208";a="923098617" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga005.fm.intel.com with ESMTP; 14 Jul 2022 07:56:31 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 14 Jul 2022 07:56:31 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 14 Jul 2022 07:56:31 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 14 Jul 2022 07:56:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O5m7Z/gRN+ZipeRL+XyPqb/PmPKitK2Pqwy0LRWeo3Jnhdhg8FTCk+4idcuszKTqNkWvsz2pKA87vJxkxS85xGnvJH/IEjsahxR/SFYZLcGiPiFI1/jD/00eUykwmwaDWP2MhIr7R2bc63HZEAJdatvbgWtQzt7yNaVdPsmNfbfrDDRtbs7WyqnIqIS2JiysM9heRnODlzYLN7fAaMfFsgL6TD0Zz9htTomMo9Y9YCPSq7Cjo5rAgJn3I1yelOZlNVvAg09OTKLG3m/tSTDes5EwZKFEEDzwTxrQxSl649gD+mhRNt6BFce95KmUYOcwmdGNh5/JWLp+qG/khq4/dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PWxdrxm2NLHxsuXvTHZ1GToebvDmtxDT4Aj1vORYa7U=; b=DA2zZeeA4Ar2oprCRtN8mI9OnRZgs3L8S8f9RmT7+aFmHgDsS0B0+ADU0RXxU4efxy37I2V3JGuRrdRDNXa8V3itJMUNfdWiRm/56BysvWwE2OpuiPhZ+eHntIrL0CRNexHrOZcRkegmyjZ3qOy042VvE+SNBVpJrvvrlI90TFsGn2iSDD8vbg/JiPNX0qEyc9LTT7PfdQQRko8gRRdW51CMXsjJun8mn813ZQ1cX4/+EZqmLXsxRdZ+rAabydllk7F2ynO465MHvS+03kZeIx8gGFn2KJTC6ODB2OkrwLcS1BHuhoNRwhr1KgoPRcSXTi5OFxQAKbrkYDDc9Bahbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3119.namprd11.prod.outlook.com (2603:10b6:805:cc::10) by MWHPR11MB0016.namprd11.prod.outlook.com (2603:10b6:301:63::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Thu, 14 Jul 2022 14:56:29 +0000 Received: from SN6PR11MB3119.namprd11.prod.outlook.com ([fe80::91c0:b34f:ee48:788c]) by SN6PR11MB3119.namprd11.prod.outlook.com ([fe80::91c0:b34f:ee48:788c%6]) with mapi id 15.20.5417.026; Thu, 14 Jul 2022 14:56:29 +0000 From: "Kearney, Tadhg" To: Stephen Hemminger CC: "dev@dpdk.org" , "Burakov, Anatoly" , "Pattan, Reshma" , "Hunt, David" Subject: RE: [PATCH v1 1/4] power: add uncore api to power library Thread-Topic: [PATCH v1 1/4] power: add uncore api to power library Thread-Index: AQHYlUKSEgpAI7b+XUCI55bDYnjffq15XkuAgASXbrA= Date: Thu, 14 Jul 2022 14:56:29 +0000 Message-ID: References: <20220711162300.3308684-1-tadhg.kearney@intel.com> <20220711162300.3308684-2-tadhg.kearney@intel.com> <20220711093645.1ce3118c@hermes.local> In-Reply-To: <20220711093645.1ce3118c@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5bc66591-c9ad-4920-1c09-08da65a90866 x-ms-traffictypediagnostic: MWHPR11MB0016:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tsufRfrUnoDgVsTFXJfO96CCpJ3OvDWeD4FzUQhhGK/2uE3yB1dkUdz9s3nQWb7U3ZYPVKbpwAeTpUUHMgi/37v6mlUpRIcimJahmvQWj0V77x9pluXu9NoJVpzudioCYu6rUsjehrucUIHUfiEHV7RW2u0uxbMNARUQxTeheHgQmqL9Pm4FpGCo0b4QfhpW2cY/KIHiiDyvpHvBvnOzRnJ2Q7BqYALezxn2F4gTePPnio8U1iGMZAW2xWbFNSjJbyuD+sTMYjPcxtNxYzNPVxuOWqg3KnJafG1v9gs4JFPkgYu3EBUqbr28PUw9IPrZRIMsCfMNnmHd4sB23j/PeSklQu4tr0ukD/JYBD6Aq8eEWhBE1KgNplHYTRPpDXiRocg69ZJ+C5vgyWHoFZgAot0LGhvxNnUob9+Ay2xD+P7o0IrSCYc6khp6q646moyxvuJ9PEw43kln+sTQyF9Czm8k/6wQe4v6YfrvslC+cDmi/jmQMbFDjd7XQ08tdnx/aV0fB+K/VyogEZnI+P2uLSnu8nu3j5ekVaEMnzz4G/zTILlG0InZ5ztzqc33AkFKEFTI35DBkGM0UKMuY5QInB1OkOCkp5bhODQoiOZ5Ri5TE3SIBJCjEQJaEYoH4CocxKDsmCTLqWFfQBuhk70AfvqRYb5FYqe9HRY8w0ThTgKOhhGdPAHCMval16ND/WCO4CTfiZ3Hqll3N7pjhPXwWe5y4j5KNRN5o2nUQWruXF7Frul3aiLyyf4B2zMI5R7SPxUu6yE/VcsYn9xYmrIHt/PUOKC4qmRif5S6YwCfYNkNeFbX6MqPN5wbN7Vn5gUd x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3119.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(136003)(39860400002)(346002)(376002)(366004)(33656002)(66446008)(66476007)(38100700002)(66556008)(64756008)(52536014)(8676002)(76116006)(55016003)(4326008)(6916009)(86362001)(66946007)(8936002)(38070700005)(54906003)(316002)(41300700001)(82960400001)(5660300002)(2906002)(107886003)(9686003)(7696005)(6506007)(186003)(26005)(122000001)(53546011)(4744005)(71200400001)(478600001)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?f52uJ1yEz4v+lbrZ9Yv4kUbx9YCrDCzC1EYFP92U8ot6jJWcjbYxC9KqNnjq?= =?us-ascii?Q?5OsPsJdjANorkGhRkihj82FoQ/u9tDKdqSQOZn5qhTWU78HomAjLo6l8K0dp?= =?us-ascii?Q?2EI19DNiCxlSOzr8cPnTIOiwPP4kLzNj74SWoqm5aYVBdVRF8iQIOWsaHo25?= =?us-ascii?Q?qm9042V2zv/y00wN9s+GXv0Yj2x9VsRJ1MllviCjXwoK5i6GPDadZkaSsiyc?= =?us-ascii?Q?IaWbxcT+wwwLA55DoaJu/28ZjMWMSKNK/qDbL6xx0l3ypsurzYmTSPedr0xv?= =?us-ascii?Q?q7/isMeuSd7TERYM4PeS3gPc+rstOO250JIJ1YJIlk7fIcEBYujCo3vCQ1tw?= =?us-ascii?Q?BtDzQApbbpcIUY/RhLvRC4DbqvWs/NmkSEpAbd1dA8pa+vcikaTJN0I1OKjx?= =?us-ascii?Q?YXvYroOJ0L34S3ohnU1+qHZSYGkHRnhu24iMlo2BCw5WDNNWxTNy7f/cPwik?= =?us-ascii?Q?yFSLPZMMNkSLdLYZ7X9bvCLY6aTRV+kqvTfrjHyNA536LmGqnhOtqUQXz8lW?= =?us-ascii?Q?xJRVkF9nm7m/LtxVuRhfQmporIPHEPoU5gKexv96b0ac79weviXizbilkMXA?= =?us-ascii?Q?rYdvWXH0UrTmv6YwKtPXu5zTnUUVS2FnoHfCN0NxJUzGgQRzICHzI3f0iQ04?= =?us-ascii?Q?bNdCW6cgZ0Ot8odrsFKgswm3yHFN94dqKLasb9PZGC0BSEbZob1CQCGeuwac?= =?us-ascii?Q?H4BAy5jP8vWUVW9wz6l1a/522/cLD660jJeYhKdoQqf928iqoTQ7ijTvl5MV?= =?us-ascii?Q?3CSrspiv+SAIhO/7c0VNV0lgVgRyqb5WV+DCVyHV1xa0tAPS3hsrDIT0oIfW?= =?us-ascii?Q?yLsxrCYU2ypWJzufr2UJc5W8wQm5bV6FjJCymYfDw8NY69WfMyyw7QTKtaik?= =?us-ascii?Q?+CDUjKKkNjyr/FmyVC7Do6xvdlDMbphYlJgG1zS7P1K4iK8ROW5iiJtm3peN?= =?us-ascii?Q?wz4xwlrlXAQCSiU5SnAGPdD3MXIRkNRhRi4x5ut5hQ1mqOcuvuSMazgUDY6G?= =?us-ascii?Q?oG9i/QPavfs22ba/pxo+4rtdvwlAD+9aoRsgblSwwS3d4B9ceO/pMC+yozls?= =?us-ascii?Q?3608EI2oQ2RgmzgONdT99y6e3ZKHdEH37qTJe0B0q7R2zI92HEkdWb23jvXt?= =?us-ascii?Q?Ey12Q87WqcIIZDR/EvWcfdZtC4Ks6se+cA3+CP+4vXBWgTTbhkqR2vH2S2s9?= =?us-ascii?Q?nroRvRUxIKPfRXawLNvN6fjQ6ysQX85uMaOSHwSwOTxzC7GpDCl46W/IaDIG?= =?us-ascii?Q?sVvzsJl8jNa19O+IzoMK0Cm3M0BAnx84BD3w5CfJV++hFspG4RFhWE09eYcH?= =?us-ascii?Q?slTW/vsvLZJ1NMIWZZqBVhn16mqQ3+FsTvpShQ19Ot5xIAMWU57qrssRWg5R?= =?us-ascii?Q?VqqM21gXfO3QkkhqA7J4KnvIZ5L78r9lrmYHxYnDQCdV0KKa6twReSAkFxCh?= =?us-ascii?Q?SlXsGbTmdKMhmO9jod3lLiy/Vxm51LaxoXvUgAlZQs+mV7t0bYg/t7Mpq79E?= =?us-ascii?Q?R7BWz9Mj/wRhhCG0HHk1RyG/xahrOSxqp1gCAbpxKHtncTPlxnzQRobsbbXH?= =?us-ascii?Q?yzRthHsl5KMJm6C1X5o096AfOqD/xjxku+Cg7/Z6?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3119.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5bc66591-c9ad-4920-1c09-08da65a90866 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2022 14:56:29.0978 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: P6NaYi5PDyZBfsV6OPDQo2tili2t0zuZTVZawr2dU8pqskcNVNKdNsoHiiPPeDx/OIp/Ly+2tNFvE/hEu1ZmgA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0016 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Monday 11 July 2022 17:37 > To: Kearney, Tadhg > Cc: dev@dpdk.org; dave.hunt@intel.com; Burakov, Anatoly > ; Pattan, Reshma > Subject: Re: [PATCH v1 1/4] power: add uncore api to power library >=20 > On Mon, 11 Jul 2022 16:22:57 +0000 > tadhgkearney wrote: >=20 > > + FILE *f_cur_min; /**< FD of scaling_min */ > > + FILE *f_cur_max; /**< FD of scaling_max */ > > + FILE *f_base_min; /**< FD of initial min */ > > + FILE *f_base_max; /**< FD of initial max */ >=20 > Do you need to hold these extra FD's open? > Also wasteful to use stdio for simple control sysfs like this. Hi Stephen, No these extra FD's don't need to be kept open, will remove their usage for= v3. What do you mean exactly by using stdio; are you suggesting to not make use= of flush() calls, or more broadly avoid stdio altogether? Thanks, Tadhg