From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DF64423F4; Tue, 17 Jan 2023 00:28:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0AED400D4; Tue, 17 Jan 2023 00:28:09 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 757AE40042 for ; Tue, 17 Jan 2023 00:28:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673911688; x=1705447688; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Ou928ZhdteIIoUHLiGa05It3bFEC9Ok2iFrzQ3Ypp8g=; b=k3d+4NEP+nm68uKahS2yi1tslllgecnwrUgNlvAaOk2dwLyRWYlCyox6 GcVn2E/nMG2h0iIq5BFQ0EeQGCX9Oc+nRrHcSrsbdPobfx9iuISMmmTHm D73yAAHpNzAz1Tl+EHGoTfTYeLxv4XuOi5qqhKeV75TKXLP5B2GnjL2QW K8o03/IPagvigq6If5LvqM1/nwhfB3Q8vbWOk3lQnFkwNIxEtEkEWhf7i 6Wo91fQxd4iKaFa0JuH7dcjF1JYQU9F/OU49/eGJhc1A02/ZlDLRjEXvX xClMdCbowofS9qAgBqAP8VBzlBeACMfyKNDb4tK/Bs+csdvmZePvzd3oK g==; X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="410811027" X-IronPort-AV: E=Sophos;i="5.97,222,1669104000"; d="scan'208";a="410811027" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2023 15:28:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="832972755" X-IronPort-AV: E=Sophos;i="5.97,222,1669104000"; d="scan'208";a="832972755" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 16 Jan 2023 15:28:07 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 16 Jan 2023 15:28:06 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 16 Jan 2023 15:28:06 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.44) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 16 Jan 2023 15:28:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=einX3eG5aoxHTf3iX7m1ecckjw21VPaulUgwfw5wL38f91d+17IqNLSPZWTH4UyErslqJdHtLYQDiEY7O84z6pd8+zez8DxOoddml9ccJZ5A7EWf8aTvNEox4Ru2DKA4yK9fUoZmzE+ZXNvw8uGhsem9owGhTIiSNa+gIYiuaq3DL/qxAalKY12IuwzQaMx4F3AdmOLF9Glp3zAIjgGy3XpEsA9gk6m2MjeaRBLCsVLnT7sHbpzHHjageW3OZV8H8DTzODKWAVFbppJiTUHf3nKxSc6nO/pRMdJxicKWqSYxdJQwOj0z42U/SZYc2RXoxwBIUzuP86mt3DJs7mJ5HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y4wRCI6c3gs4UxK8901mv7hkWvXB2jyipjSezm/pGGo=; b=jFiiHGKHRvTfGmwm2kUIOfowtlfxmLGkrWsJoXwDIdxc8UvKutoYkjsScucwVdEBCwFxaMb3eWNPAOILP7EMFu+K8WmOKyNos+UQ+sPKejr6nrxZ0lZ7Xh0zEfj+bap2wXtIYIvU/YaPpqRiUsVcvv6T+yZGjZZJMd2iQVWO7spClAlQbynLEmQlPmdrdh1Uxaqg+MUlIswYE8SLj+ofLSvANFZUA8TfoZoEspV9b9QO+opZqYf5g41eQTJhzuB0LduzSXi7XV+FkTLzCxGRwOlArqCW0Ql3NZ02rUUlYV+6KjoArpy4pPlQ/cKlmOx11zD5TIHfRSulsF/77bK9Gg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3408.namprd11.prod.outlook.com (2603:10b6:805:bc::22) by SA0PR11MB4685.namprd11.prod.outlook.com (2603:10b6:806:9e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.23; Mon, 16 Jan 2023 23:28:05 +0000 Received: from SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::15e3:7ae1:b586:649a]) by SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::15e3:7ae1:b586:649a%3]) with mapi id 15.20.5986.023; Mon, 16 Jan 2023 23:28:05 +0000 From: "Ji, Kai" To: Stephen Hemminger , "dev@dpdk.org" CC: "De Lara Guarch, Pablo" , "Power, Ciara" Subject: RE: [PATCH] ipsec: remove unneccessary null check Thread-Topic: [PATCH] ipsec: remove unneccessary null check Thread-Index: AQHZJ38WtJ1pxTY4sUSFRqHQ6FvJ866htUtQ Date: Mon, 16 Jan 2023 23:28:04 +0000 Message-ID: References: <20230113184426.68063-1-stephen@networkplumber.org> In-Reply-To: <20230113184426.68063-1-stephen@networkplumber.org> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3408:EE_|SA0PR11MB4685:EE_ x-ms-office365-filtering-correlation-id: 9ce04634-51ac-463d-2b67-08daf8195106 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HBjeuPOWSC+BDVwlcwnFFjOZ+DdPLq2ZdwEGdkAG7CSyFLr0ObtkmiNIUYutP+ravTXzXS+Qjt4ncn32O0VoQoZCHZFdiwhkxh/+NrtEcrUmlRCSzpe0IJJdVimVFLuHqUdYvqtNOrGS0reUxGGR4CJJom6ALNtdVNwft99YDaW8YIIACuzE+CcRr+rdb6hSRVy3OM6gNT2AFnEkM+GkboE0MbJ0aG+cceWvNCp+Ey//+faN2tffJyPw9mbYJixaF0v7NiQk5CmkazLUWMJ7ik/n1vkOj6b+kY1ep316CHU/JJQU1vNqW7ZBP5ubzbs/FVxd9BkYomxYg67JtCZaLS1Y6hcKvC9aplI69OiCZhCMPFo3VQz3IWXwszeuZnPuzdHTw7c7Px1ZHnp/xYlWDAS7CNnpKVWPJhBQ7AGYE0aOYHlbNobFH5ZRgJTyAreV7HmU90AmP/9Oha9zrnM+RDEc7CoNeKz1A6uMaaL/WGVxQx15Mux8QHPOE8rtCQ/JwB0z0CzO+8xok4q378ufs4qmjL6N1ubKoi7LutEMqmUMRPuF100O7Ge5+U6evwDsqcGqIZ2cD0xyfBsls6LAuFPb5MkfPeDlQVHDFB31Buvgume2LNBfFxGLWbbHdZwqMInhkgSUAsEzxw7FkHGX33GQjKMvpH00AyyfnJyOn+YhLMWaTT9tSzJpl1dgZa7N7iPxDuEg7YBk4ICK4AxDaQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3408.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(346002)(396003)(376002)(39860400002)(136003)(451199015)(38100700002)(82960400001)(38070700005)(33656002)(55016003)(86362001)(66556008)(9686003)(66446008)(66946007)(4326008)(26005)(66476007)(64756008)(8676002)(186003)(54906003)(478600001)(76116006)(7696005)(71200400001)(110136005)(53546011)(83380400001)(122000001)(316002)(6506007)(52536014)(8936002)(41300700001)(107886003)(5660300002)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kWQkSIDFWjV1VahmuX1FHsRRmiZVia45SQE5APk3xk4cbH9tiynrIe6RGYKR?= =?us-ascii?Q?J6eDSgLxNrVNjfvZoouhhK9qEI2kJUCqnQGBeNYiKeRMpjTrX2ncopeippfM?= =?us-ascii?Q?ymA3Ji1LpQ0C457sGHguTNZKVuow5MmlyASNVSAYLTWEYhxQrmqR7lx1yuxV?= =?us-ascii?Q?gI79z+nVuj9evFjPyJK09PpF4n0WYzrhipCQ1ibvO8Il3+YkZVkUx8+n4lAe?= =?us-ascii?Q?QLqx+I9+7UKo3+viESg/5tdwS73bVRNFA77FlQx/ExOTTYwmCZbajix3T7JR?= =?us-ascii?Q?a1hasD+B6NU05KH2Xhg5uzU2hOr8AXMtD6stGVujbxVU0LEUq46tRdhcLqyI?= =?us-ascii?Q?bOh7oSTCncORt16G7WmydmUfxONZYg+v/zO/sHKBV8Nk7K0uTZRbr4mwVYbu?= =?us-ascii?Q?wT4rLgUtxDZ+/MgQZuo4DI7hNwW0M9HqFlNOWchpdLr5ht1fRBR5xXGRYwz6?= =?us-ascii?Q?sBBrt83jBCEAl5uKG98U//kdVEEd3Ocrcxtn4u2qqPMld/AlIFhmMlJqBBrq?= =?us-ascii?Q?yBY6VXgDmLJ79cY4yBO4HYQZ8IBkKE0/rvPqvqGj2BVZJNmDeGfHv/5Zy3Dy?= =?us-ascii?Q?TK7xAOLNOrEoFzfJxTZh6aVjvSR9qae4gZmyZgIJvnXTh5f/3efUQhh5H9VQ?= =?us-ascii?Q?Q+J5frCTifX9Hc84UGu5LN0ll/pTKCsD6BNMtudVKsE+ZOdRoetBjkCWtIWe?= =?us-ascii?Q?GxKLNr/4n78xaec+HbYcdS8ITOccqmHwiN1pP02hqWENeRQ7sMMW6+SFAv7v?= =?us-ascii?Q?HURLjdhm6rR6mKQBAV8Ha4A4IDt+2HdXzSON2jM3dxrekHoKMez6pSVZ2Jew?= =?us-ascii?Q?tGdffTc9g/tbeG+1+pjzIhsvQ9SBHBHhf3etnPDK97ZSoceuwPEI0d2i7WQv?= =?us-ascii?Q?ZdH4tVmlBnrn+9+PslCRlZevJxbZZyIX9GlBBLDTjgU8AOdOaMFQkNbhwgER?= =?us-ascii?Q?Tve1oUgYacY7Gm1dqJxGOMoMqOsNxe25gNHMzce6NvC9T7xz/fh5lKyWUU3y?= =?us-ascii?Q?4X1fPzORUEE0Ou1nENXPAUWem8GY1KjBMruO7mvOcoxwQtjxdzzzsPT5Q8/N?= =?us-ascii?Q?H95ViEitdjfLVWBY4v2MVN0NFPI9nO0eOhAQGQzkqFsVAbDjqqQ2K1xBLxAz?= =?us-ascii?Q?bo25d9og4YsF9lSK0uSXRspXorQDywAewjoBHrae4c8x1zflPudKQylv+y9G?= =?us-ascii?Q?zKM9cpURr4zyjkEyAanzVyIHAl8Azcu/jHQGSBfEuw5Bi8Jn6glaU1pgA8Zs?= =?us-ascii?Q?IiiG4rWrJX0QY9OL1CTb/3zY5yUFU2I7s3ynG/CLABQV6BPedNPvCiEBQV46?= =?us-ascii?Q?ZipnigrFeZpYXZedi6J0SMbd4BHBt5FUGbnh6RPOEM1AFIHA374kyVkyf1wu?= =?us-ascii?Q?7MwnvaYJJnK4VdzkPA/LqUGEoMo5yFkqdPqZ92YcxXpsdgjXq9BPm6oBra7r?= =?us-ascii?Q?UtNKNExXopDxqNtdoM9ZiFmQX3KnyzishC8R5Attt6RNb1J57xiX+0qS2CNA?= =?us-ascii?Q?rvXsq7KcnoxD1z3+EBHc5CCEsSuwbu9kj7yFTbfiM2IE52yitSXlhtOfFMQg?= =?us-ascii?Q?Cc01JNryajYkhoJs4UI=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3408.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ce04634-51ac-463d-2b67-08daf8195106 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2023 23:28:04.3263 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: h8wOne3b98DTX+j2z4IGX5Ny15mFJa+L9vrj7bpZZqwntAmyptTYrecu9DwSU9S2q8JmaQnKOnS6jY+bi5M1VQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4685 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Kai Ji > -----Original Message----- > From: Stephen Hemminger > Sent: Friday, January 13, 2023 6:44 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Ji, Kai > ; De Lara Guarch, Pablo ; > Power, Ciara > Subject: [PATCH] ipsec: remove unneccessary null check >=20 > The function rte_ring_free() accepts NULL as vaild input like free() and > other functions. >=20 > Found with null_free_check.cocci. >=20 > Fixes: 16d6ebb65d59 ("crypto/ipsec_mb: fix null checks") > Cc: kai.ji@intel.com > Signed-off-by: Stephen Hemminger > --- > drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) >=20 > diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c > b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c > index 71e02cd0513d..3e52f9567401 100644 > --- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c > +++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c > @@ -139,15 +139,12 @@ int > ipsec_mb_qp_release(struct rte_cryptodev *dev, uint16_t qp_id) { > struct ipsec_mb_qp *qp =3D dev->data->queue_pairs[qp_id]; > - struct rte_ring *r =3D NULL; >=20 > if (!qp) > return 0; >=20 > if (rte_eal_process_type() =3D=3D RTE_PROC_PRIMARY) { > - r =3D rte_ring_lookup(qp->name); > - if (r) > - rte_ring_free(r); > + rte_ring_free(rte_ring_lookup(qp->name)); >=20 > #if IMB_VERSION(1, 1, 0) > IMB_VERSION_NUM > if (qp->mb_mgr) > -- > 2.39.0