From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81081A0543; Thu, 22 Sep 2022 16:06:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 71BE940156; Thu, 22 Sep 2022 16:06:33 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 207BF400D7 for ; Thu, 22 Sep 2022 16:06:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663855591; x=1695391591; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=u3fJstybVUaNFz1pUvvUac9PYMshDAE/0DRGfFvZt24=; b=cyAFDgUddElZGw3YLq288cFjD0vvXe9M9q3uzKzk8OXDi25mu/W1qlGt HzhpzdUN8xPM35RMxkP/sZRxERP+qykkxzldvyprok1R5SVeJ/dzX24C4 PQG9XJFUihtThMWDKcGLg8j/f1kjY26b4N4tWzeKivGEVo3ZDGrhBUV8E 0c6NbGkG+o2O1YtRbGFL94H66Nt2NrwEca3R1UmUWBFLSwf3U2LgWpOOC xfsXTTsz5gz65I4TTDa6OtOjSpH+yye85spcKmp8VfbBw27bYrr8M2n/y Bej+uPqZR0JEbiGA3O8woYDzJlLVsAsZzhJmjyivrltgH2auSikadTrVz A==; X-IronPort-AV: E=McAfee;i="6500,9779,10478"; a="299020524" X-IronPort-AV: E=Sophos;i="5.93,335,1654585200"; d="scan'208";a="299020524" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2022 07:06:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,335,1654585200"; d="scan'208";a="650531529" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP; 22 Sep 2022 07:06:27 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 22 Sep 2022 07:06:27 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 22 Sep 2022 07:06:26 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 22 Sep 2022 07:06:26 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 22 Sep 2022 07:06:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aCLPkbdY287gHgOb1dlmfUZ+XbXi8Ee4ae+MR7+CfEW8CHRD/ewBgcBBz1F5F83D47CUwWVCunQVVGDci7QHQ+Swc5cOVuPiTiw56Veg+WRgeSlHbpCoSHwedrIM/SAD9Vn1MNf2s1EgYYLkyN3+3X6qRo4eiXMMZt6zwECkNz2ZKaoNUuog4DhpyQ8vETaK+YqK/52eODij52XlSMyLiZDkMFOwOEU4965OetTfG27THpf0Ay+HIiMO0EDiuuizSW8M5otbzVDC46h5ENMafTyJNbsGZbQkBtQbh9nR0PXGzRZfvmu8s9OBnnDI/rEeGtKKmDx+QeJxf2WnZZqPog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u3fJstybVUaNFz1pUvvUac9PYMshDAE/0DRGfFvZt24=; b=RQkRGkTWGAniLOZA0oWSfhEmM0BbZCpAJGp8mK8c/R6rtjai27DhserKwbOFkMwOjLrLwSMcdZlok/w1KkORWeRo12pw4qatQi9DGkJETjJFkMgWGWOXZMfwzrH855dNYUMvuLBXZ0CoyTPVkmenOeqc3B5bQDl9awrcXB2Z723xxpVNud/XUosXMxOf332vSFvROE1iMw1R5eSris0G1hjjLacfdzWZQoNAA/2c+8VU+70EajwnGiMxK+A3Z/rUXTixu1lbjLAcck/tSH/xAr7zlE4A0D07jyRXKv9xgSn8oF8hjB55vuWhiyGdKQhqlxIzwPDxdOfYs1ZFuT9vLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3408.namprd11.prod.outlook.com (2603:10b6:805:bc::22) by SA1PR11MB6735.namprd11.prod.outlook.com (2603:10b6:806:25e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Thu, 22 Sep 2022 14:06:25 +0000 Received: from SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::2d82:b7c0:6b4:8a4f]) by SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::2d82:b7c0:6b4:8a4f%6]) with mapi id 15.20.5654.019; Thu, 22 Sep 2022 14:06:25 +0000 From: "Ji, Kai" To: Akhil Goyal , "dev@dpdk.org" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , "vattunuru@marvell.com" , "ferruh.yigit@xilinx.com" , "andrew.rybchenko@oktetlabs.ru" , "konstantin.v.ananyev@yandex.ru" , "jiawenwu@trustnetic.com" , "yisen.zhuang@huawei.com" , "irusskikh@marvell.com" , "jerinj@marvell.com" , "adwivedi@marvell.com" , "maxime.coquelin@redhat.com" , "chandu@amd.com" , "ruifeng.wang@arm.com" , "ajit.khaparde@broadcom.com" , "anoobj@marvell.com" , "De Lara Guarch, Pablo" , "matan@nvidia.com" , "g.singh@nxp.com" , "Yang, Qiming" , "Wu, Wenjun1" , "jianwang@trustnetic.com" , "Wu, Jingjing" , "Xing, Beilei" , "ndabilpuram@marvell.com" , "Zhang, Roy Fan" Subject: RE: [PATCH v2 1/6] cryptodev: rework session framework Thread-Topic: [PATCH v2 1/6] cryptodev: rework session framework Thread-Index: AQHYzct5yelUvtudFUS8h/ItKek9Iq3rfU9Q Date: Thu, 22 Sep 2022 14:06:24 +0000 Message-ID: References: <20220829160645.378406-1-roy.fan.zhang@intel.com> <20220921150258.2061702-1-gakhil@marvell.com> <20220921150258.2061702-2-gakhil@marvell.com> In-Reply-To: <20220921150258.2061702-2-gakhil@marvell.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3408:EE_|SA1PR11MB6735:EE_ x-ms-office365-filtering-correlation-id: 22022322-f7fe-447e-5b1d-08da9ca3a2b7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FyHk0V5w9wII68d0tTUeO1wnZAvasWTV+j1hN8WViWOoE9ExymPues+tmIVB3DKIjOIcohviNHPAgMlmgzj89ZXagobsZJNLsMVpoA0U4UsjhG+0m4Tbod2Gu017LCv5MA6wzNVLL43OT2CRxxeTmulOAzXKMj5dCz+7CBR5+4eh4b9qMhYaFrmXUEg1HnkhKcW2gOkSE8Sf+z4f+D22Yb27Gu5Fw1G6WczKMixg49bYiEd+zflwasZvZtQ+pQRh6hbLbzBTTRI7+3cRpk4n5ge00gyAL+wZgZmXcNGz5x54LBoTuB4V2/OgPXP4GdLVqjiOuy55mN7zCCh1M4/Rr6tmW0KNPGXEsS2mXqg3kacteywG31FEU0WSzsJqdoC94sVcHJO425X2r3ZY5nICr0t7vx9BmIFMBqi7cxePF8Y7W4bVOt+eOVr+X7aTkaMdlM2sLAEYzehvtjAR+e4kEz2xUhVUA4GfkzAjr4vT9R6ZcB/LB+XCymU0x706G8mJ3H0/Cg1rWvm1JLGl5gXLrri4INWCpVrVeMngWR0AZ4L0Ulk78dM/kTH99sYjP/aC7/7Saq+0cJpo7cNNaTRR2a8T0g1ISHrNv0q2JwG0c5/elHchpeyefaAlulPIxSy/sAAqchgRnEeFVSxCi1kKmGmewZLqFN+HAhLtpX74lthSKusenvUKz25SN0nui+su0p9fRinO1GNI6w4NYQ/hAu7HetA/6MJMnQlw8+1PgZJlJahHusMD+7/r1q08r+bZ0rZqqks1nZMohAOBx5/P8FqGGchlrhttOlva9DOYkfE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3408.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(39860400002)(376002)(366004)(136003)(346002)(451199015)(52536014)(9686003)(6506007)(7696005)(26005)(53546011)(38070700005)(38100700002)(82960400001)(5660300002)(478600001)(7416002)(2906002)(66446008)(122000001)(66476007)(86362001)(33656002)(66946007)(66556008)(8936002)(83380400001)(71200400001)(107886003)(41300700001)(55016003)(64756008)(186003)(316002)(4326008)(54906003)(110136005)(76116006)(8676002)(23180200003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HhUMS1SEt6D5y2ewRP1BHYEvqkshsCYZsEgGwYIXkK98ENHC3ueX001OQNda?= =?us-ascii?Q?KVBmtiwSsbHKbPI0AT1S8Xk4j5vZHXFps9GXpJuIYukhq02z8jxYl6ykMUGc?= =?us-ascii?Q?h27ao0hMKXN5kSwxmo+hPShPKV6Rs/pyBFT+ot5gYrkyOTD8N0GHAf+SpKae?= =?us-ascii?Q?/VqG+OVUab4DH3CLONUXzxURRVy/FLcGyPLlnFBPHATiNDamn5pYpezRppxd?= =?us-ascii?Q?NqWuo66uzu25+MDHR9o1wda8oeZVRJe13kwpCmSa/UOPfb5SEz8zr3msXh98?= =?us-ascii?Q?uRpZtctwEhQuXNEaxTaFUD+9P1gsra7WhCT3vTgIC0fr7odZS95PATUQfHW1?= =?us-ascii?Q?d5bsn11HRWe6/zex7O2kVgS3Q7dK6HgdcIxidL4TGbYmSSnrw6BkTq1S+Alf?= =?us-ascii?Q?P/6cA8LgLBZo2qlciCyrBdjhG+P6rpU2lRnCfC6N1Nykfg5qt7PUc5pjvn7Q?= =?us-ascii?Q?AVUpSQ8DM3kc3qYZVSXEl7us3Vib6loZYERaPB5Kqd+sa9jDDEhHwdIMGtaZ?= =?us-ascii?Q?zoSAqNDuC/Gw3g6RqMADZGfBP5BrDerygtUktAydh1tZodpGie+2xewBG7a8?= =?us-ascii?Q?Lh1ah38zF+LOnPmeoeMbtFrwRgSpDq7Jlomr8+C1Cu1noPUbqCatRbvy6U5z?= =?us-ascii?Q?x30J9i5XzBHOAtQcdelrccWeuU/dCRBtVP8lm9alYbDcPPU0SHCkxS1NgNKc?= =?us-ascii?Q?IFvIwOtS+l6gCCwbiHmtX03rIBScnmzSKrTBI7BZ1jTMoRjH7PG6f+/CxfDj?= =?us-ascii?Q?2OKbgOaJ33ls/dA9r2ksvIPQsvtBkI/jhv3/+v5FRBrhoLIk+QfqB8480Sof?= =?us-ascii?Q?zHPqkZMT8M/D9b5jzbNI1MNA6cErZFIsmJ2gsytpLIkFwUVxfIshdkkqzFk6?= =?us-ascii?Q?KiASvJ+oR2EZY/yq07a1vPbPQ5hu2X3KzBNxrKWpBl5mtKjnwOqPoILNTA5j?= =?us-ascii?Q?Ka+fltv3alx8CeqZmIJN96MKOnYk64ZqpZjwLTufGMIS6sNWhfgXJeFmON2m?= =?us-ascii?Q?YU2GjIiYWWyNiQqBykrCpJNoeGCOMlK0SwDuxudurY4Q33nMDz/sIpPtmu0v?= =?us-ascii?Q?iQxRr5f66DFREdNP/7Cd8QLC6PDDYx+0sOuzFcvQzqCgTNBQ+qwTCqpHrtmw?= =?us-ascii?Q?8L/bhkKix8k3uYQPfblXzW0Wzqn5qsE7kFRfq3w4AXj1Ew8ACX4+7Jq2SCm0?= =?us-ascii?Q?43V25XtYAA9My/etVM/92vk9ioALs9e1XstUGhpBca/aZ8roQ6zDcqD3zK8d?= =?us-ascii?Q?YT4cyzTVmbqQx9QmGPU1di8eKC2dcXbQ2hnEqmP6Z9jNGuSqUk6s5pNFOHOV?= =?us-ascii?Q?W46j6Kw5d9HUHaC/wy7ZBo7ZeDftpK6vK3Fe7qv0m082dy8DtbT66LSBuAuP?= =?us-ascii?Q?xiYVSEfFWvxIZqv0mImlO/dqAGffAlD0myFf/JV07fuNGAHSuPRxnB/dI8Ub?= =?us-ascii?Q?9FjJu66AvvXJJFCsenJvlsL/j7QihuaQWATiGfXrE4B9BQq4l7pp4DqgW5Gn?= =?us-ascii?Q?Hb6F49CdTaJODdLF/sK6x9frIITyLzw60TrM/4UktjIdWn4euR9pPFE6Bfqj?= =?us-ascii?Q?Kp2CNQkmi7a9/Gh1AAEMIbF5ccit6jJtiAlYmNdx?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3408.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 22022322-f7fe-447e-5b1d-08da9ca3a2b7 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2022 14:06:24.9717 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: y7Am7wF2BtUmuOtllNxf6spsu7cTZC6MrJXMA8MNjFTiGQwYgelRIQdFoPq5Typ7xGkqfVsCoAMuJ+e+h/Klrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6735 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Kai Ji > -----Original Message----- > From: Akhil Goyal > Sent: Wednesday, September 21, 2022 4:03 PM > To: dev@dpdk.org > Cc: thomas@monjalon.net; david.marchand@redhat.com; > hemant.agrawal@nxp.com; vattunuru@marvell.com; > ferruh.yigit@xilinx.com; andrew.rybchenko@oktetlabs.ru; > konstantin.v.ananyev@yandex.ru; jiawenwu@trustnetic.com; > yisen.zhuang@huawei.com; irusskikh@marvell.com; jerinj@marvell.com; > adwivedi@marvell.com; maxime.coquelin@redhat.com; chandu@amd.com; > ruifeng.wang@arm.com; ajit.khaparde@broadcom.com; > anoobj@marvell.com; De Lara Guarch, Pablo > ; matan@nvidia.com; g.singh@nxp.com; > Yang, Qiming ; Wu, Wenjun1 > ; jianwang@trustnetic.com; Wu, Jingjing > ; Xing, Beilei ; > ndabilpuram@marvell.com; Akhil Goyal ; Zhang, Roy > Fan > Subject: [PATCH v2 1/6] cryptodev: rework session framework >=20 > As per current design, rte_cryptodev_sym_session_create() and > rte_cryptodev_sym_session_init() use separate mempool objects > for a single session. > And structure rte_cryptodev_sym_session is not directly used > by the application, it may cause ABI breakage if the structure > is modified in future. >=20 > To address these two issues, the rte_cryptodev_sym_session_create > will take one mempool object that the session and session private > data are virtually/physically contiguous, and initializes both > fields. The API rte_cryptodev_sym_session_init is removed. >=20 > rte_cryptodev_sym_session_create will now return an opaque session > pointer which will be used by the app and other APIs. >=20 > In data path, opaque session pointer is attached to rte_crypto_op > and the PMD can call an internal library API to get the session > private data pointer based on the driver id. >=20 > Note: currently single session may be used by different device > drivers, given it is initialized by them. After the change the > session created by one device driver cannot be used or > reinitialized by another driver. >=20 > Signed-off-by: Akhil Goyal > Signed-off-by: Fan Zhang > ---