DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Ji, Kai" <kai.ji@intel.com>
To: Akhil Goyal <gakhil@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Ashwin Sekhar Thalakalath Kottilveetil <asekhar@marvell.com>,
	Anoob Joseph <anoobj@marvell.com>
Subject: RE: [EXT] [dpdk-dev v1] crypto/qat: add in libcrypto version check
Date: Tue, 26 Jul 2022 11:57:33 +0000	[thread overview]
Message-ID: <SN6PR11MB340894BC6AD1213227AA75AA81949@SN6PR11MB3408.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CO6PR18MB44840E342C9CB85BCECC5F14D8949@CO6PR18MB4484.namprd18.prod.outlook.com>

Thanks akhil,

V2 here: http://patchwork.dpdk.org/project/dpdk/patch/20220726115608.84140-1-kai.ji@intel.com/

Regards

Kai 

> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Tuesday, July 26, 2022 11:14 AM
> To: Ji, Kai <kai.ji@intel.com>; dev@dpdk.org
> Cc: Ashwin Sekhar Thalakalath Kottilveetil <asekhar@marvell.com>; Anoob
> Joseph <anoobj@marvell.com>
> Subject: RE: [EXT] [dpdk-dev v1] crypto/qat: add in libcrypto version check
> 
> Hi Kai,
> 
> This is a fix for compilation when openssl 1.1 is used to build QAT.
> Can you update the title to
> Crypto/qat: fix build with OpenSSL 1.1
> 
> > This patch add in libcrypto version check before enable libipsec-mb
> > for QAT. The inter-ipsec-mb lib for partial hash and AES cacluation
> > should only be enabled when both OpensSSL 3.0 and IPSec_MB 1.2.0 are
> > installed on the system.
> 
> Spell check on description.
> 
> >
> > Signed-off-by: Kai Ji <kai.ji@intel.com>
> > ---
> >  drivers/common/qat/meson.build | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/common/qat/meson.build
> > b/drivers/common/qat/meson.build index 245c0fbe61..8247bdd017 100644
> > --- a/drivers/common/qat/meson.build
> > +++ b/drivers/common/qat/meson.build
> > @@ -37,7 +37,9 @@ endif
> >
> >  IMB_required_ver = '1.2.0'
> >  libipsecmb = cc.find_library('IPSec_MB', required: false) -if
> > libipsecmb.found()
> > +libcrypto_3 = dependency('libcrypto', required: false,
> > +    method: 'pkg-config', version : '>=3.0.0') if libipsecmb.found()
> > +and libcrypto_3.found()
> >      # version comes with quotes, so we split based on " and take the middle
> >      imb_ver = cc.get_define('IMB_VERSION_STR',
> >          prefix : '#include<intel-ipsec-mb.h>').split('"')[1]
> > --
> > 2.17.1


      reply	other threads:[~2022-07-26 11:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-26  9:59 Kai Ji
2022-07-26 10:05 ` [dpdk-dev v2] " Kai Ji
2022-07-26 11:56   ` [dpdk-dev v2] Crypto/qat: fix build with OpenSSL 1.1 Kai Ji
2022-08-04 13:09     ` [EXT] " Akhil Goyal
2022-07-26 10:14 ` [EXT] [dpdk-dev v1] crypto/qat: add in libcrypto version check Akhil Goyal
2022-07-26 11:57   ` Ji, Kai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB340894BC6AD1213227AA75AA81949@SN6PR11MB3408.namprd11.prod.outlook.com \
    --to=kai.ji@intel.com \
    --cc=anoobj@marvell.com \
    --cc=asekhar@marvell.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).