From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45AE542DD8; Wed, 5 Jul 2023 15:57:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D59E4406B5; Wed, 5 Jul 2023 15:57:06 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 7B2444021F for ; Wed, 5 Jul 2023 15:57:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688565424; x=1720101424; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=azlDXBbxo44syX51fdBC054m3t4LTLaKV26FHjP0BHg=; b=G837+bkOEAknSmc5DWnT9MgYleS8O3tEXbD2KcCekJazY1USIpQ+sD7d 7h0y4zc4uOFZ2eCfTcRLlu9Z3XqijUStVcA3LWqOTma3pcngWIWnP7Dkx IQEGMi+ufTMFPJpb8MS6oKbekrDRUiQgZmIazvqrEODodXLSmh+Ym9MUT Vu3T2Y9tFr/rNSWtkF1VZ51yUTjz68scjM+z94FS6rrSQYvEei4wDHjwC sWYC34d4YRfzaYa3UPIepDlvMOw+oMEZNGvnzFicQptIpHmeQe9juBRyz DGw5AmG81AVdBXoLXfwuD/+FS8nv/EGTz9tbzd5zqYutaoQxRaLP/yIrF g==; X-IronPort-AV: E=McAfee;i="6600,9927,10762"; a="360821078" X-IronPort-AV: E=Sophos;i="6.01,183,1684825200"; d="scan'208,217";a="360821078" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2023 06:57:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10762"; a="893208683" X-IronPort-AV: E=Sophos;i="6.01,183,1684825200"; d="scan'208,217";a="893208683" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga005.jf.intel.com with ESMTP; 05 Jul 2023 06:57:02 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 5 Jul 2023 06:57:02 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 5 Jul 2023 06:57:02 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Wed, 5 Jul 2023 06:57:02 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Wed, 5 Jul 2023 06:57:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZEAGL5HIEtEko05zPbMAjnRmhG/OQ/aEpMtlHocGWX7HAKGNaOOgBJHU8kmxr1LpUPdOIOGWUDGk6jYX/aOqhkj+Ehq052OCQWKXyKs6l1Nnfob0QERtU4BPM7NpRMaqwim0YGs0CiX8deztn0ojQrxPp4tue+6EBdrp8zNtvi9snJXiTJ/mT5xtf9GLq0d4m23jY/r24QjJoUpODqFfOskmRHk2/nY1BKuBbchl7OYRQ9ivYMSyGzENMqvVzF5xHJBT2l9mdesNWNFeQPcLpiPTTzJR63lN83nF++9PQ25cCvR25gB6KfRJ41dcUz6J9mIRh1UDIfP0t6N4CLe0TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oovyOCOY0+tfOBvmnanoZzWcP9VpL9BLvz4n1ALEsnM=; b=apgwWVuWdlDJzhgkG0gMnPJn/Rs51x9mwtLDAeS6kuMl1xJSJrfS4q91qHYTDwMzmEN/6MR1M/VOZWwDFJj4lED5DI1A2FCa05pUJPU0mTQtfTBpWhhV4rQ/B9AfohuA1SIpz7xaNZIOhbuZJ+dUksoNtLOZX75LNRntW8s6DZf/qNJZFQCCliNqike5hHaY6PEybl+QJH8okFO2qsMfSVcWIEz3IvG/91FuL+d0D7ktMWUH6sFpGpnApDfjBQuC3u8oRxGF4tVHz5Wvo48m5ZsQ0wfA9df8SvF0/ePYHY7HRXjPgjav/7Mac/l6ZvBizgpO0CJk/XQkVKTz4em4Xg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3408.namprd11.prod.outlook.com (2603:10b6:805:bc::22) by IA1PR11MB7809.namprd11.prod.outlook.com (2603:10b6:208:3f2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Wed, 5 Jul 2023 13:57:00 +0000 Received: from SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::121a:92cb:2f78:e53d]) by SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::121a:92cb:2f78:e53d%5]) with mapi id 15.20.6544.024; Wed, 5 Jul 2023 13:56:59 +0000 From: "Ji, Kai" To: "Power, Ciara" , "dev@dpdk.org" CC: "O'Donovan, Saoirse" Subject: Re: [PATCH] crypto/qat: fix legacy sm4 ecb capability Thread-Topic: [PATCH] crypto/qat: fix legacy sm4 ecb capability Thread-Index: AQHZr0QJBQQ2s7KzIUq3tdK18tdy9K+rMod6 Date: Wed, 5 Jul 2023 13:56:59 +0000 Message-ID: References: <20230705132311.1146176-1-ciara.power@intel.com> In-Reply-To: <20230705132311.1146176-1-ciara.power@intel.com> Accept-Language: en-GB, en-US, en-IE Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3408:EE_|IA1PR11MB7809:EE_ x-ms-office365-filtering-correlation-id: 73e39ff9-dd37-44a9-9913-08db7d5fb3c6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zVJ5t13TlVgx5ErX6Ae86HdiLkgUiwcme+dmg+K0dvdSIfJmEClbl8D5YJqoHpe3RaQP01DoD3oYz+Le1U2vYiMmYjUdArKKiCBtw0c2qEKe0f/FpPlhUntGEDWwLiyqrHdTXhAOdwc5i5n/+e3LLm0KptErAoQKWD0HnKEyyw+zvX/dbkSiHl3tl3yaP3FEkBx1K4F9M0FjYkx/EvoopVqicRNT+nOm+am4WDKMFzKbrzJLFCejVgS5RDyCGPs+u7N9jCxQyjpG149IGp64lZopzkMrVmO62rE9+8NA62FLvebuDU+8pQ+eQnC2G0Qqjlvi0t5KJy5YBPFNp+l/3ZNLX87CkIdLaHRUf5Lf1+KyMTTrUzRbN+9CXZfc4m414Wmf3q4l2rRNNV00EfxddfzgdZ6XjPJkw+Jd8ctXyF/qUL85lerfnjvQxh55NY8LVf3fj3gl5m8ba+jW0+juUon9rQSZtYKR8zGmWVZJYba9DhqT0wWvk0adhUu3H2olsvzRS4D5hhIUCLP4tE/3jxxEWVcU1K9xcU1M/1efdU0sK7trm28pe/Gif5gRWHQltXIw0U4TeqW9TW6P1k/3nSiPnSbejrHakmAoH+bHke8qjhlrAqH5W1+EHrjR1Lsd x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3408.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(39860400002)(366004)(396003)(136003)(376002)(451199021)(186003)(41300700001)(7696005)(38100700002)(107886003)(82960400001)(53546011)(71200400001)(26005)(6506007)(122000001)(83380400001)(9686003)(55016003)(38070700005)(86362001)(110136005)(478600001)(316002)(2906002)(66556008)(66946007)(64756008)(76116006)(66476007)(4326008)(8936002)(8676002)(66446008)(91956017)(33656002)(19627405001)(52536014)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MOhrzWpG16HrlpKJPwXyHo6niqMXYOYiCbWIKLFQfkr+CM7gqiMAkV/VL5yD?= =?us-ascii?Q?uFibKoVmbX15nzwZVotTGWC8JDZbNrtAYbMHsKB/2sAWFLVSkD7RNRxc+xWC?= =?us-ascii?Q?jq2uvtwwgsoLW7J043aW/Muk+V3XPnBS+/WAPhI76jeZNR3HscDL9camv4z6?= =?us-ascii?Q?SW7gHJgGabIYr/pHCPTUwB4DjRf+1qmROEDXbMfAfAPinL7aC0Rw9jk1RNiF?= =?us-ascii?Q?veWu7O/lTmm/U6i0lZeDZHYuDxzNUtJSd7ABmF13miDyZ8I/xi/1sZ5Ckf2I?= =?us-ascii?Q?g8t/uvAeTrKalRhpdXKYEeXxfV4uHG+frcpd975ZYL8sTXT5l8n3fReq3j7/?= =?us-ascii?Q?bcW8TUxs0q3MvUqAua00z/8+AthnoTmNmydflURlTBzSC/1jTcN7USmuEFi3?= =?us-ascii?Q?1Zr24i0vgjoxF/h7XiWJV/g6yqtl0JeYmmMngZFNFkUQRBYJknpiXimu8PqJ?= =?us-ascii?Q?vGPCRbQWMglkkHhdkKyjJkDuqcpmL1PiW0BwXyoI/VqsdqIFQ1z5XnR6Zzi7?= =?us-ascii?Q?7JWvAwdW+MWJ/itHkrb43rcCZYKbZA9GP3Xjz2HpIobv8HiXdottFegqMQip?= =?us-ascii?Q?y+82umnV1Q4/ZYsO5dQWjiiSnR2gRYsHCyAlPnZaNjtAKXSdR/niriy0KcJm?= =?us-ascii?Q?/YJ9jIbJWy6uuPTKu0Hhlrf8gXLcc1LP+VlyLukEZ404FJkjTn02GXuQyhJB?= =?us-ascii?Q?XJRCRPdERmK63REmzyIXEX0HoYco54wYbI0tjGM7BIBKO7UGnSVfyrHftmnN?= =?us-ascii?Q?SvY683QylMVPxCzzZWQvgnK5Od1e/oKNvBo31O54F+e9izk277ybFk8e8qvO?= =?us-ascii?Q?zVAxuT93AGhwwCGJgtYBCplY/IV8awduDpWVqBqVSQwlFriYSs9rx5UeGbQW?= =?us-ascii?Q?ICElP+zdZmM04s7FT/bhthVR25Rw2H02Nnt37ayzyMmS4NM4Q0To7Q1kkGtO?= =?us-ascii?Q?GvTizqY678mBt/+gtndQMqkljHg7B/1gEpu8grXgyZfkS9SEAb+8v4UAFtJ3?= =?us-ascii?Q?6C+W13/ZTndbfkgjNrWGqZhO2zYy2Rkj0yyrxUdROzGg6PY5MR9HAYfYZX5z?= =?us-ascii?Q?nFD7YM+0W1aQPCNm1IErfUUdV97b8yfO1EvWugtjrGlfh1CV9DYfBL8VjyIg?= =?us-ascii?Q?38Qxuat4Oif/+6S1grmjKpw5lWRm4yQKFMphBDw+cGXJXd00MHztN2NKJx1t?= =?us-ascii?Q?074gtMrDpG/sq6OlvgatO5A9b86MB8sLaZy3w62UX+S4oEB1pAdHN6glp+hy?= =?us-ascii?Q?i3u6zLcN0jCGp6sixuFztfhVpbH4vMRTixxmVXC5Uce4RvfOAvVeIq1+9A1V?= =?us-ascii?Q?lAl3ZJFk0BgY6hja2fzLNk1riQM/Ilu3sYpaYMRubK40GO1nvTDmFXROdJkZ?= =?us-ascii?Q?fmNCtSlLaw1qzd2KTAnsgCdi0Lpqb2cRzFVCNRytfIvfTJVHnjbxnr3D2ap5?= =?us-ascii?Q?+erYCINe+uaOx4QCLnOnYO+huMVq9lpHKscj1oaQ59WR0l09HNq5qabrZsS9?= =?us-ascii?Q?CIThmKl87fLZJOcUNGCU60qrGHSBDLqKTdqLTw85QUKl/hn5XLP61uPl+QYO?= =?us-ascii?Q?ttuby9vaJoEHa8uFRnA=3D?= Content-Type: multipart/alternative; boundary="_000_SN6PR11MB340897039ABDEF116CF18BCD812FASN6PR11MB3408namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3408.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73e39ff9-dd37-44a9-9913-08db7d5fb3c6 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jul 2023 13:56:59.4356 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8wX50QeEkP3CzgEYRf135kShuV1aTX248/9hjCvyALnGia+RcIe/AxCE3MPuKEgChKLD343Kcf6oHWS6GltRPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7809 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_SN6PR11MB340897039ABDEF116CF18BCD812FASN6PR11MB3408namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Acked-by: Kai Ji > ________________________________ From: Power, Ciara Sent: 05 July 2023 14:23 To: dev@dpdk.org Cc: Ji, Kai ; O'Donovan, Saoirse ; Power, Ciara Subject: [PATCH] crypto/qat: fix legacy sm4 ecb capability Following the deprecation of insecure algorithms in QAT, SM4-ECB should be included as legacy, to be disabled by default. Fixes: cffb726b7797 ("crypto/qat: enable insecure algorithms") Signed-off-by: Ciara Power --- drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c b/drivers/crypto/= qat/dev/qat_crypto_pmd_gen3.c index bc71665a50..d25e1b2f3a 100644 --- a/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c +++ b/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c @@ -46,6 +46,9 @@ static struct rte_cryptodev_capabilities qat_sym_crypto_l= egacy_caps_gen3[] =3D { QAT_SYM_PLAIN_AUTH_CAP(SHA3_224, CAP_SET(block_size, 144), CAP_RNG(digest_size, 28, 28, 0)), + QAT_SYM_CIPHER_CAP(SM4_ECB, + CAP_SET(block_size, 16), + CAP_RNG(key_size, 16, 16, 0), CAP_RNG(iv_size, 0, 0, 0)) }; static struct rte_cryptodev_capabilities qat_sym_crypto_caps_gen3[] =3D { @@ -147,9 +150,6 @@ static struct rte_cryptodev_capabilities qat_sym_crypto= _caps_gen3[] =3D { CAP_RNG(key_size, 32, 32, 0), CAP_RNG(digest_size, 16, 16, 0), CAP_RNG(aad_size, 0, 240, 1), CAP_RNG(iv_size, 12, 12, 0))= , - QAT_SYM_CIPHER_CAP(SM4_ECB, - CAP_SET(block_size, 16), - CAP_RNG(key_size, 16, 16, 0), CAP_RNG(iv_size, 0, 0, 0)), QAT_SYM_CIPHER_CAP(SM4_CBC, CAP_SET(block_size, 16), CAP_RNG(key_size, 16, 16, 0), CAP_RNG(iv_size, 16, 16, 0))= , -- 2.25.1 --_000_SN6PR11MB340897039ABDEF116CF18BCD812FASN6PR11MB3408namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Acked-by: Kai Ji <kai.ji@intel.com>
From: Power, Ciara <ciar= a.power@intel.com>
Sent: 05 July 2023 14:23
To: dev@dpdk.org <dev@dpdk.org>
Cc: Ji, Kai <kai.ji@intel.com>; O'Donovan, Saoirse <saoirse= .odonovan@intel.com>; Power, Ciara <ciara.power@intel.com>
Subject: [PATCH] crypto/qat: fix legacy sm4 ecb capability
 
Following the deprecation of insecure algorithms i= n QAT,
SM4-ECB should be included as legacy, to be disabled by default.

Fixes: cffb726b7797 ("crypto/qat: enable insecure algorithms")
Signed-off-by: Ciara Power <ciara.power@intel.com>
---
 drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c b/drivers/crypto/= qat/dev/qat_crypto_pmd_gen3.c
index bc71665a50..d25e1b2f3a 100644
--- a/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c
+++ b/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c
@@ -46,6 +46,9 @@ static struct rte_cryptodev_capabilities qat_sym_crypto_l= egacy_caps_gen3[] =3D {
         QAT_SYM_PLAIN_AUTH_CAP(SHA= 3_224,
            &nb= sp;    CAP_SET(block_size, 144),
            &nb= sp;    CAP_RNG(digest_size, 28, 28, 0)),
+       QAT_SYM_CIPHER_CAP(SM4_ECB,
+            &n= bsp;  CAP_SET(block_size, 16),
+            &n= bsp;  CAP_RNG(key_size, 16, 16, 0), CAP_RNG(iv_size, 0, 0, 0))
 };
 
 static struct rte_cryptodev_capabilities qat_sym_crypto_caps_gen3[] = =3D {
@@ -147,9 +150,6 @@ static struct rte_cryptodev_capabilities qat_sym_crypto= _caps_gen3[] =3D {
            &nb= sp;    CAP_RNG(key_size, 32, 32, 0),
            &nb= sp;    CAP_RNG(digest_size, 16, 16, 0),
            &nb= sp;    CAP_RNG(aad_size, 0, 240, 1), CAP_RNG(iv_size, 12, 12= , 0)),
-       QAT_SYM_CIPHER_CAP(SM4_ECB,
-            &n= bsp;  CAP_SET(block_size, 16),
-            &n= bsp;  CAP_RNG(key_size, 16, 16, 0), CAP_RNG(iv_size, 0, 0, 0)),
         QAT_SYM_CIPHER_CAP(SM4_CBC= ,
            &nb= sp;    CAP_SET(block_size, 16),
            &nb= sp;    CAP_RNG(key_size, 16, 16, 0), CAP_RNG(iv_size, 16, 16= , 0)),
--
2.25.1

--_000_SN6PR11MB340897039ABDEF116CF18BCD812FASN6PR11MB3408namp_--