From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C0B9A00C2; Tue, 27 Sep 2022 13:03:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 81F2F41133; Tue, 27 Sep 2022 13:03:40 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 5D34D410D0 for ; Tue, 27 Sep 2022 13:03:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664276618; x=1695812618; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=UKZ1x0WNQkcF/JRpXCGWzMM34yCSfureoN/aI+1qHZE=; b=enHX4Bs/uiV9cQucyouftiV5VLTUVYZ47jL3oLLcXzu2CzTOqr6mmEm8 tCo9IoLq9A1E0pufM83C5vwJRbtXrRp+tOCtiEqIiaNsuCG/95b4E37F/ HDV9uu1eykIh2O4l9Vjy4Si9V5i8S+31ioAAoSrKmfWzzgpqoMJkGSRRk 3EHZ9sf4NP+nFghuHyFOLWlAncUr6lnmzB61iFWyB2NVQON0QsMq6U9tT 3FnY8cyd4NV8ShskmRaYInuvSzYgpZAlKoBUvH+qV/ZWnI38xdT4KvqjT rcCO/WAe50pgYua6PApORQ+B7l+OzeEmQYpXxSjH7mUVMPN3kxMyqwzX+ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10482"; a="365328330" X-IronPort-AV: E=Sophos;i="5.93,349,1654585200"; d="scan'208";a="365328330" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2022 04:03:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10482"; a="763835657" X-IronPort-AV: E=Sophos;i="5.93,349,1654585200"; d="scan'208";a="763835657" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 27 Sep 2022 04:03:36 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 27 Sep 2022 04:03:36 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 27 Sep 2022 04:03:36 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 27 Sep 2022 04:03:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a8jS1gjkieF40upZI+mLsP91qwuy+z2Q7uIohgfXnw32hpeVxZzgbjvQXlOGcbhvYb8KTOTP6W2EHrzr1A93y8Q/yRwdYz9uGUdFzFWLBJQT0trS6JRyiLg9rnlaT4ANmEowdiJ+MUEb4ahtvVZenm7ko5UAZAdxtYBGEsf2fZ4ewgBsctPfAuS4K4S1cm2p22MvsG/8+oNNx/B/nsA1gTFqml31Y9q1qIfSamFVMA8ZrgIGcusgqCPlGpSuIsOvzV+soW5dvsdqkIuv8lqqo+ueeIoFIu7jUbfj6MCz80l5wMRG0aGm+jA6hx5M9CrcDOd9KOIVE3mMmU4RN91Y2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lrI6IMu+jaLcYLvHUx4boMRbOncjDOIj7HHg48Ps3CE=; b=GUxWm5XBWBxsrXdLJ3B0WlwgQrbPHtWjFKvMzxSi2vNU7omYw7xbZZek143qMs89cOaZVDNCfjGmm8sRkIZ6EWnQCpLKpHGFbKL/ZTn5pb4ojKVXlxqFsB5B5SX3q5Hir8ZOIzQyNJLK57p2IHFk6BuwxRiDo+2VCP9pUjA3h+gd9ilX2H/Gyl8tl33CXHePFqmdU48FYq1ZbCGEEi3rWncCwT291ZuySqqIi/8brAKWD1/TvAZSYPjIknwyu7jMWegOCqlwWinglLOOot8PlXAH8s9CD4VlE/aU8elvoy0Pg1pSAveSlRjimkUeyag949DWB+TobBpbPBBLgit+LA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3408.namprd11.prod.outlook.com (2603:10b6:805:bc::22) by DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.22; Tue, 27 Sep 2022 11:03:33 +0000 Received: from SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::2d82:b7c0:6b4:8a4f]) by SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::2d82:b7c0:6b4:8a4f%6]) with mapi id 15.20.5654.025; Tue, 27 Sep 2022 11:03:33 +0000 From: "Ji, Kai" To: Akhil Goyal , "dev@dpdk.org" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , "vattunuru@marvell.com" , "ferruh.yigit@xilinx.com" , "andrew.rybchenko@oktetlabs.ru" , "konstantin.v.ananyev@yandex.ru" , "jiawenwu@trustnetic.com" , "yisen.zhuang@huawei.com" , "irusskikh@marvell.com" , "jerinj@marvell.com" , "adwivedi@marvell.com" , "maxime.coquelin@redhat.com" , "chandu@amd.com" , "ruifeng.wang@arm.com" , "ajit.khaparde@broadcom.com" , "anoobj@marvell.com" , "De Lara Guarch, Pablo" , "matan@nvidia.com" , "g.singh@nxp.com" , "Yang, Qiming" , "Wu, Wenjun1" , "jianwang@trustnetic.com" , "Wu, Jingjing" , "Xing, Beilei" , "ndabilpuram@marvell.com" , "Zhang, Roy Fan" , "Coyle, David" , "O'Sullivan, Kevin" Subject: RE: [PATCH v4 2/6] crypto/scheduler: use unified session Thread-Topic: [PATCH v4 2/6] crypto/scheduler: use unified session Thread-Index: AQHY0dxqWEfxPXEs00GY/qNO711yUa3zHX3Q Date: Tue, 27 Sep 2022 11:03:33 +0000 Message-ID: References: <20220924163542.4159562-1-gakhil@marvell.com> <20220926191424.1069668-1-gakhil@marvell.com> <20220926191424.1069668-3-gakhil@marvell.com> In-Reply-To: <20220926191424.1069668-3-gakhil@marvell.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3408:EE_|DM4PR11MB5994:EE_ x-ms-office365-filtering-correlation-id: be47ac1e-1559-4f07-3e0d-08daa077eb19 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: h9gJooQO1zwQDykzIvay9N+ZSDVaFltH6vwHBSucgQDYMvVBm8HQahVAOdBYINjhEBYg8v5l/wgp7U5InOhicErxNYH8nfmqJdi97Cg+khtiMlzll0JJHMJAShfHhwTSqB6JhPBioVxNcVLMbSgcGbIMyKbF/ceFc2Eh1d11I2QjIoytfO7G5McP0l5EkowtQ5eodIlWAZogDF0jDv4txQStJFnSXHXr9O+eSz4MMppXGiunwAKIXmXmxvXGMBT5uW9quRy3ufGMZxKngfbEdFXzTwm/YJ+ziHtfVFiS2XJuhwvEYMnIdrnrTrKNMnWZRdJdhu8AH2la/ckHgqJlK7UN5GJq0ugZz9Uw1DeICLKwyo9ymD+zpdTtQP9DRHDTzTLhNbsdXwQUDwA3zGy0YSnuZrZzoOJXI58HBU/41ru3+leLDUb5Nmlwu82hM0aKeIZOW903hsnRo/967oWRfNi7IQNJ6V1cKeKD8hHnAYlsDmbsO9zYmZXxwiX1lnFmuFYVf4KFdqhjqKaTSUy/09Dp5yG/ltNaQzYpHO/G78gtp/+Xqfgo8ngOXeNwmFXhMr8pcZVF5468DFk+mXBNGsMmUbrla8XXISXOAaPkme66mYiO7DiTxQNbyfvPlgfdryjzka/W/VbMqJhW816e6MULPYTCSAKP1jSuET+HJuvTaOQmA8C+qsgHEwF7SgnSv2pE6JJ3ssnWF9f9ttyY+sgywyEbHtpx/56jv/GrkX0pRSxs9uEEUPELOAMxxxCDOe7ftnW49/hpgNW1NEKIm+5X0verlmhFh8/mBQV4MhQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3408.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(39860400002)(346002)(376002)(396003)(136003)(451199015)(66476007)(66446008)(7416002)(316002)(52536014)(66556008)(8936002)(64756008)(41300700001)(55016003)(4326008)(5660300002)(107886003)(110136005)(66946007)(86362001)(71200400001)(9686003)(7696005)(478600001)(54906003)(53546011)(6506007)(26005)(83380400001)(186003)(76116006)(8676002)(38100700002)(82960400001)(33656002)(38070700005)(122000001)(40140700001)(2906002)(23180200003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mjXYSE8F4R+n+rY7EkmeVfYzkh20uKuQRwui11kxkjS6shGMUZMSZ1EiGRsd?= =?us-ascii?Q?HzkIPUMYU7KNsh2pNLtBsYzeedPQKFhgorDyYnRzqFXTmgXqTX6QkMvSFWW0?= =?us-ascii?Q?143XdY6rsVbh+KNMrQNDtfmSse+8Xu86B1B7/TCWIY9P0OREXnpI/n64abFI?= =?us-ascii?Q?SQqdJ6HIgHG86W//mpyp7kuIJHnSJ1srF91jgzjfnK1okjA1HnDWinS62K7K?= =?us-ascii?Q?utOdn7LKtG0y1Uyq6MP7+tynxY94rsWYxDOeNcx+9B1VJPzJkCMGZzsaFcgj?= =?us-ascii?Q?9dWFWfRJe8Jr8KfpBNecym5m+sIr5YAhbL5vGScXawfrRSu8fNUfdBZhjc4x?= =?us-ascii?Q?tbWU1e2FqIqvWTkOovvGWn4BNRZEj/C/mpbO6fN6hPnpv+WIibLkVt6YwQZk?= =?us-ascii?Q?aRrW51l1PiHooVH6JP1GN1d+ZFVlQu30gSKZSl6M4cRHsxthn4KDs3z4qc4E?= =?us-ascii?Q?UBEeDvmAvaQXWsPr40zzNVVBxZ2GH3h5GfWUUk+mbkQx4AZ3cxEWN2V0LZ4K?= =?us-ascii?Q?EQ/2Iymaq3iaaovaZ6EmBRlRiTlIXkItYn3trV3NC/kBlSUL/ZWW5+9qqHRL?= =?us-ascii?Q?deTAXtJ0QfF6RW+w2LjsGmVU4ZnFIA9VmnWfiDPqsMB12hYvbVqWEBdIqTX5?= =?us-ascii?Q?LTfkj60RZQiHCXOGnpS9apvs128LfojKrpIFTT1bhejkakEbmnCmINxgpp7N?= =?us-ascii?Q?9Bz95aBiGZ6mR/oY4Hg9kYTS/TgXWrH2DcV2Ggz/wslZdwPB+ZSaeMIDAuc8?= =?us-ascii?Q?CBgxHnp605DdFpCbXZpKbnKXcCJvE/wtjfhymdpCJH0Qx5kR9BNuCfTf5iku?= =?us-ascii?Q?fory99WRzCS1Hum7KJNe7AtENgbPQhxuIabyCTL3wv+fi5z11cQQp4mxwgqq?= =?us-ascii?Q?V6myVGGWy8qUJGMwA/czRjYcdOMboKvwBwVDJjhbTt2wcGhzoJcp3kAoL0J+?= =?us-ascii?Q?OfmvhGhZcoJu07a0mkt1tC0r7gCL47cotZHtrjMRreWNU1IKMZyRv2Vr6oVk?= =?us-ascii?Q?kDdc+coOC9ohvgHNA9fjG/0WB01oiwloV2/F6M2JDBFemZFHMdIhxlvtjCOe?= =?us-ascii?Q?g44Wr4O9MHHjDG3RTZS8DKHHMK/bz4bbXBDlfhczCCYW9gY+8eTjBAXBIrk6?= =?us-ascii?Q?+CJvelnMB1zFw+l+gI3/hEnW3a8avlrJgfDyffGiAyOAlvvcLOJGMXGAtsWk?= =?us-ascii?Q?JB4DnBUbMkhzHDMEPtAVhnr6PABcpTskMdXddeGB+2+KJ9Qfy/G6moM1C0KL?= =?us-ascii?Q?m2oBCwlV04/z0XytFYbtuhXwrl2lF0YArStu6r/Za8eJ99F6tvIeZ0U7Dv4Y?= =?us-ascii?Q?lzqPScZyiMpFj0GTg4/JCOWSX80/yT6xxY3nydSTp0oOFcTaeZrlqBQ0FMe+?= =?us-ascii?Q?E8AYw7rQzJyGUywS4MDGyAw4zIXul38WYy7Xc7Kudt6iGn1fpGBtxsOaTbRz?= =?us-ascii?Q?7mrDwO7m5NO/TBtAp2X3Bq06s+VbUPo6W2qeKLksXDhfhtvmv2B1QAhU+CGZ?= =?us-ascii?Q?xBK4ncqfYL8FA6J5s531G81EXoaWqNZwh6YE42oH15ee8ARRepwVhTlPuqBA?= =?us-ascii?Q?UhPcUn92H6lwyrna4ls=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3408.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: be47ac1e-1559-4f07-3e0d-08daa077eb19 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2022 11:03:33.1730 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kFJTuTy2Z5cMUh+2GRGxHf++B5MuzAP5U5GokoBrxdyoOHwchpReFOcgCvdJ8W9p/c0hFSU+csEfrk7sNbVxug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5994 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Have the sym sessions changes been tested with the dpdk-test-crypto-perf to= ol ?=20 root@silpixa00401033:build# ./app/dpdk-test-crypto-perf -l 3,4 --socket-mem= 4096,0 -a 0000:33:01.0,qat_sym_cipher_crc_enable=3D1 --vdev crypto_aesni_m= b1 --vdev "crypto_scheduler,worker=3Dcrypto_aesni_mb1,worker=3D0000:33:01.0= _qat_sym,mode=3Dpacket-size-distr,ordering=3Ddisable,mode_param=3Dthreshold= :64" -n 6 --force-max-simd-bitwidth=3D512 -- --ptest throughput --silent --= total-ops 3000000 --burst-sz 32 --buffer-sz 105,277,1301 --imix 15,10,75 -= -devtype crypto_scheduler --optype cipher-only --cipher-algo aes-docsisbpi = --cipher-iv-sz 16 --cipher-op encrypt --cipher-key-sz 16 --docsis-hdr-sz 17 EAL: Detected CPU lcores: 128 EAL: Detected NUMA nodes: 2 EAL: Detected static linkage of DPDK EAL: Multi-process socket /var/run/dpdk/rte/mp_socket EAL: Selected IOVA mode 'PA' EAL: VFIO support initialized EAL: Using IOMMU type 1 (Type 1) EAL: Probe PCI driver: qat (8086:37c9) device: 0000:33:01.0 (socket 0) CRYPTODEV: Creating cryptodev 0000:33:01.0_qat_sym CRYPTODEV: Initialisation parameters - name: 0000:33:01.0_qat_sym,socket id= : 0, max queue pairs: 0 CRYPTODEV: Creating cryptodev 0000:33:01.0_qat_asym CRYPTODEV: Initialisation parameters - name: 0000:33:01.0_qat_asym,socket i= d: 0, max queue pairs: 0 CRYPTODEV: Creating cryptodev crypto_aesni_mb1 CRYPTODEV: Initialisation parameters - name: crypto_aesni_mb1,socket id: 0,= max queue pairs: 8 ipsec_mb_create() line 152: IPSec Multi-buffer library version used: 1.2.0 CRYPTODEV: Creating cryptodev crypto_scheduler CRYPTODEV: Initialisation parameters - name: crypto_scheduler,socket id: 0,= max queue pairs: 8 cryptodev_scheduler_create() line 138: Scheduling mode =3D packet-size-di= str PMD: Sched mode param (threshold =3D 64) cryptodev_scheduler_create() line 193: Packet ordering =3D disable scheduler_attach_init_worker() line 45: Scheduler crypto_scheduler attached= worker 0000:33:01.0_qat_sym scheduler_attach_init_worker() line 45: Scheduler crypto_scheduler attached= worker crypto_aesni_mb1 Allocated pool "sess_mp_0" on socket 0 USER1: Test run constructor failed=20 > -----Original Message----- > From: Akhil Goyal > Sent: Monday, September 26, 2022 8:14 PM > To: dev@dpdk.org > Cc: thomas@monjalon.net; david.marchand@redhat.com; > hemant.agrawal@nxp.com; vattunuru@marvell.com; > ferruh.yigit@xilinx.com; andrew.rybchenko@oktetlabs.ru; > konstantin.v.ananyev@yandex.ru; jiawenwu@trustnetic.com; > yisen.zhuang@huawei.com; irusskikh@marvell.com; jerinj@marvell.com; > adwivedi@marvell.com; maxime.coquelin@redhat.com; chandu@amd.com; > ruifeng.wang@arm.com; ajit.khaparde@broadcom.com; > anoobj@marvell.com; De Lara Guarch, Pablo > ; matan@nvidia.com; g.singh@nxp.com; > Yang, Qiming ; Wu, Wenjun1 > ; jianwang@trustnetic.com; Wu, Jingjing > ; Xing, Beilei ; > ndabilpuram@marvell.com; Zhang, Roy Fan ; > Akhil Goyal ; Ji, Kai ; Coyle, Davi= d > ; O'Sullivan, Kevin > Subject: [PATCH v4 2/6] crypto/scheduler: use unified session >=20 > From: Fan Zhang >=20 > This patch updates the scheduler PMD to use unified session data structur= e. > Previously thanks to the private session array in cryptodev sym session t= here > are no necessary change needed for scheduler PMD other than the way ops > are enqueued/dequeued. The patch inherits the same design in the original > session data structure to the scheduler PMD so the cryptodev sym session > can be as a linear buffer for both session header and driver private data= . >=20 > With the change there are inevitable extra cost on both memory > (64 bytes per session per driver type) and cycle count (set the correct s= ession > for each cop based on the worker before enqueue, and retrieve the origina= l > session after dequeue). >=20 > Signed-off-by: Fan Zhang > Signed-off-by: Akhil Goyal > Acked-by: Kai Ji > Tested-by: Gagandeep Singh > Tested-by: David Coyle > Tested-by: Kevin O'Sullivan > ---