From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B94942CC8; Thu, 15 Jun 2023 18:46:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B79D40EE3; Thu, 15 Jun 2023 18:46:27 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 5D59540A8B for ; Thu, 15 Jun 2023 18:46:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686847585; x=1718383585; h=from:to:subject:date:message-id:references:in-reply-to: mime-version; bh=2MQudtN+d247IydE0Jj16Pu+jPX4i/V/ateqASTWzIk=; b=W/lQ2seb6o6sSf4V0awCbnLlcRbpCKuZj+daR8FaUq3J87Tv1T14eBvg OCXu7mRz605W7pFnG+MhL7PgthMexWwxo7fDsU7kGI8CcgHk6xpUjhcYh Fyz6zx3lQa91Kqkmixej/fr47ANTCaULJMKs/Lr+Fym62xDTtreeQcgte wLniNgRzK9YjIsqBhChaj+9vdS8a8TvX8o4bMmz5S8Ng7TEegR+ZN0NY1 qwqZ3trniEAikECFCNqPRV4Kg4wPTEsBfmffa8Ay4KUStz4CuaOfa+vHE qLtAwnb7OeT5JO1D80busJ99wln5O4Y6bV9F5H3Oc0xO6dCbW02y/A+1H Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10742"; a="339318452" X-IronPort-AV: E=Sophos;i="6.00,245,1681196400"; d="scan'208,217";a="339318452" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2023 09:46:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10742"; a="662858739" X-IronPort-AV: E=Sophos;i="6.00,245,1681196400"; d="scan'208,217";a="662858739" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga003.jf.intel.com with ESMTP; 15 Jun 2023 09:46:00 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 15 Jun 2023 09:46:00 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 15 Jun 2023 09:46:00 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 15 Jun 2023 09:45:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IdINGBcs0kfabwYWdVxFjoNjk9+JxvTrWbwJesF1lybpsKyn/v/HuE7wVAP4qN/EVpaafWn0ozst5JMXqIvaCyvQaTJd1fnUxohEm10zGIPBQbquOF71qt9Td3hG2Fu0yLMaDvsrhVnSqnWqghvHSoJFVZV5qwqJm4zf6LF/PAUhGwxnMnP8A9Qwq1DrHzOednI7xMRAzWYTfD4uIKlZo1yP8VfEDlnFjxrMgqNOgL+ZA2nLlJLVDyEj9iKk5MAh/QQuQhiwU0JNmO8nhMNHqZTd+dZXrp0ZeiBrPba/VQLNKH9Y88bZElEl1riUsyjTjWL/j2qPF+Uz/Irug7NPew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2MQudtN+d247IydE0Jj16Pu+jPX4i/V/ateqASTWzIk=; b=ecQs1agMV2ZLXVT/M+FYjkgM6qrg2rDo2rBmjOJ1a5899dIx+YhxQdOhTd7C6GgenifaV7C/sSKuc5ZjUwc9odQghNihLIjonBFkRTqln5v0dMSD8d4BtZ3ETCz6+sSbaMipAMrWIAktxN9pni8vX68PIEd5lUIHtjdtaB8HCTN+foI/4CYe22V5Tzuy3OybFHqnD+9/bj4j5J/fdTMOTj/mFa8UKL9Tdxs+wEfmU6aW7F9g7YVhjF9sB+224c981QdGTD5N0qCKXvPzEL7NuSd5l3oAf3H1JP0Xp9PhPde1dWw5W0q5dTDV0GMx8AJVmJOy4BwsDA0fEV2wgotFbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3408.namprd11.prod.outlook.com (2603:10b6:805:bc::22) by PH0PR11MB5641.namprd11.prod.outlook.com (2603:10b6:510:d6::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.25; Thu, 15 Jun 2023 16:45:56 +0000 Received: from SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::121a:92cb:2f78:e53d]) by SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::121a:92cb:2f78:e53d%5]) with mapi id 15.20.6477.037; Thu, 15 Jun 2023 16:45:58 +0000 From: "Ji, Kai" To: Akhil Goyal , "Leung, Michael" , "dev@dpdk.org" Subject: Re: [EXT] [PATCH] crypto/openssl: add aes-xts support Thread-Topic: [EXT] [PATCH] crypto/openssl: add aes-xts support Thread-Index: AQHZckr7Nw4LRzs/sEqLQpK9QscF/q+K/bIAgAAAUICAAW6ihw== Date: Thu, 15 Jun 2023 16:45:57 +0000 Message-ID: References: <20230418230947.240459-1-michael.leung@bloombase.com> In-Reply-To: Accept-Language: en-GB, en-US, en-IE Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3408:EE_|PH0PR11MB5641:EE_ x-ms-office365-filtering-correlation-id: 593dd0b9-c6d9-4ead-b02c-08db6dbffe71 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 19Avtep6bzwXAUYTRu+7RfF4EU0Tt/00uyHErveKlC1mJt0Dp/fi4Ecvt9tiNg+ZOXYPYv46MHkOMrt2AZoxTM1IRNWo36qYNQ14YXWpdxuscCgxikVUf62ZmF5dVdapHmf5DgTY2c9bLe7Bs+gSwcOsc51BmppTdoWvG9qjT70ueE4cSC2xWPQMjK7wKHU62UacUSWeJCikVpZPsy27RBhAUT9OrNiuRal+tjFA+h4ICKY5X/DEyHJOk27Qf7+yShSJT0zMZFUR3YG4e8UtdblXxRfDNKxeTNQDvddCkTBTJCNblpQPQuWiai/NwvbBo1MJB1RCg+r/ILGjXb4cJpk9glENBswXBrAdN7VE/GloquDjXewkv5eZq8KOgJfbx4BlS77aOZ9OvFScpqXRcYW/xOiyHZbsfYoIkflJztNB+Vu6N2QyHp2YNMj53f06DKy9Mw6+NfQR1XW+fkTQMXqxP1hGrA76WNS5sJ5zaGz1EWliNfA4tY0WxgRiASPuv8bsLxAc5fhBwouBbStVrt0dPW8T8SmD40qIQKixni4iIQfy+3CTKK8YNlzO8ykgVsziV3sSf80TtdFYhIH/KfYp5hzJdqORBvcXUsKJe3nwieeo7oIJZqBVIp6OtHxG x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3408.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(346002)(136003)(39860400002)(366004)(396003)(451199021)(52536014)(5660300002)(82960400001)(38100700002)(122000001)(53546011)(83380400001)(6506007)(186003)(2906002)(4744005)(26005)(9686003)(38070700005)(478600001)(55016003)(66446008)(64756008)(66556008)(66946007)(66476007)(316002)(33656002)(71200400001)(8936002)(8676002)(41300700001)(7696005)(86362001)(76116006)(91956017)(19627405001)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IGXDxaahdOuLgY1dezOzMnwjlq5XxcCRXO+WUpXyAEiqvRpmyeFKjKmz//LL?= =?us-ascii?Q?Ugez7V8GChif/2TcKRqWWMS5zAp0BfrgXCYmtCxeqfThSoAK7MOAfHAQdnyr?= =?us-ascii?Q?L8qnBUfPcND6qPNOIRKLhKeavVxlr2sdqsfxh4k80FlGzHwb1IJy+coE6ZVQ?= =?us-ascii?Q?9K+nrxUkmrJ0miRlAaY6/NUjrxQO/Yyp9ax4LX10+oPHPzeIPP8op/PGzBx9?= =?us-ascii?Q?G6setVH0CZZyWDqM0c7cXVt6Ag3vUZTrR70uycRcRtV7CmI4SElNhygdKurW?= =?us-ascii?Q?IJhEMJsNsZtRZv9ieAIBPGN6+Uprw30kOKcBDnd8MQwetBJ/Ta7lYJwis8N1?= =?us-ascii?Q?Fr2MzvnOOuP5RLJvqRyvgOo6VDoOzJoT4bA9DwKMMuh79eosNiuNOIPr6MrW?= =?us-ascii?Q?c7qGWsOa8Eli1v32P/yw7YvPwqPD/Fw5P2bI9Sh4T6gkl2GUkjzbacAdeeKG?= =?us-ascii?Q?k5waM+mu4oHN1S9Lhm4Y/seAR+LA6WcT03FNwMWuYKfkzuwlbT5ToklBxw0u?= =?us-ascii?Q?hedSl4MGBjyGTxe68aQ9DztE3eTuIAgRRy997galV1iojBh0AHiKPX0bGPwe?= =?us-ascii?Q?R2jAgIu0Ly4upaU6ntGP3j6K73KiAc60YDiVN5R5qXAiqO+PlOMHg0T+iQch?= =?us-ascii?Q?x/dDj7xAhU85XolEa54BUDsk2hX24RvZ220ekVbuW100bVca8zbQ2ChVg/FD?= =?us-ascii?Q?nErQkFU08lDU+PPT8BI9Cq6FI4i0d4FEYqg3F6rFeECYlcb1Ll5ckjQbRCxa?= =?us-ascii?Q?7GviHegMBzFg21SXiHuxO3o9FyzHY0hucChA35ptQz6uQrXoaDjNePtT7npm?= =?us-ascii?Q?DtkAzmob8f+RssVUyYzFTpDJU1TEDAeWbOP+v8L2bWvk7TVTWO6qlFuOyRTM?= =?us-ascii?Q?E/c7HmJnfn5XtPcmnudALk2qQPafP02F5VoHXYvnkxDBjCRIAJkMGLV9JKv0?= =?us-ascii?Q?8f1wDvwfriE+dYlHM3nWnsb+TxRJHFJU2F7ytK3HwWg325RBeGsMpZ5POy1u?= =?us-ascii?Q?3vY4/bIlehIrjIyVI1rpxarWSHtCy4WPUnufX4ZxV2+mF73OoKBPtPgGn2Yt?= =?us-ascii?Q?0sFND4eCu74g0lobKDASQqzqg8Gatz1ssjurV6DpRG1Z3rtl69U9Te+WPJuI?= =?us-ascii?Q?wa4ydNl+2LJ/ZGxtMfzb2gneJq8MfuKYewq4NrkpWULTAODv+bcz9Z5v03Jq?= =?us-ascii?Q?7wWIIOLXcFcHduXKxncrC0E9/BvyVHG6MxzGOhxfg2wBNuuwmy3dtxYaXYqD?= =?us-ascii?Q?pDcUHaBnStnjdZZ8IzSsdltmZP4eDrMezYHpKcTYF5F8zaVU8IwBW5u2COwB?= =?us-ascii?Q?hNHPYLqgbk+0HfM/MH1lCxD+/MdOMTnF68RDvqqqQP5HhUX3Je9Eyd8VcRYg?= =?us-ascii?Q?buMTUExsbD2pPzp8sKeN2MiECVxjCObJmXt6BEZJdIiRhlHgCrWYw1UGnJii?= =?us-ascii?Q?y1KGteeyuCXH8tmRbLfNanV4hdMMIxXXWns1ZzsPuyKC/JMgCa4rgtujwse9?= =?us-ascii?Q?pYJFmbgAGbSD2VEmixbz2br2wom48hpyJNh3EvGa5zsxHibR2e5mrhpdtNTV?= =?us-ascii?Q?wWTNrgDr1+THG85Mgd4=3D?= Content-Type: multipart/alternative; boundary="_000_SN6PR11MB3408B24B837C9F6DDAB892CC815BASN6PR11MB3408namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3408.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 593dd0b9-c6d9-4ead-b02c-08db6dbffe71 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2023 16:45:57.8011 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MeMSEsg7q5jorDaClq518tYiVA4QCa25ODXW1O3ACEqslvZng9xM8qJTFprOXCDQYFdScUEHhlYGEA2ymKPRww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5641 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_SN6PR11MB3408B24B837C9F6DDAB892CC815BASN6PR11MB3408namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Please take time to address Akhill's comments. Acked-by: Kai Ji > ________________________________ From: Akhil Goyal Sent: 14 June 2023 19:51 To: Leung, Michael ; dev@dpdk.org ; Ji, Kai Subject: RE: [EXT] [PATCH] crypto/openssl: add aes-xts support ++Kai for review. > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, June 15, 2023 12:21 AM > To: Michael Leung ; dev@dpdk.org > Subject: RE: [EXT] [PATCH] crypto/openssl: add aes-xts support > > > Add aes-128-xts and aes-256-xts support for crypto openssl pmd. As xts = mode > > we got 2 key, the key length is multiplied by two, i.e. 32 and 64. > > > > Signed-off-by: Michael Leung > > --- > Fix checkpatch issues > Also update doc/guides/cryptodevs/features/openssl.ini --_000_SN6PR11MB3408B24B837C9F6DDAB892CC815BASN6PR11MB3408namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Please take time to address Akhill's comments.

Acked-by: Kai Ji <kai.ji@intel.com>


From: Akhil Goyal <gakhi= l@marvell.com>
Sent: 14 June 2023 19:51
To: Leung, Michael <michael.leung@bloombase.com>; dev@dpdk.org= <dev@dpdk.org>; Ji, Kai <kai.ji@intel.com>
Subject: RE: [EXT] [PATCH] crypto/openssl: add aes-xts support
 
++Kai for review.

> -----Original Message-----
> From: Akhil Goyal
> Sent: Thursday, June 15, 2023 12:21 AM
> To: Michael Leung <michael.leung@bloombase.com>; dev@dpdk.org > Subject: RE: [EXT] [PATCH] crypto/openssl: add aes-xts support
>
> > Add aes-128-xts and aes-256-xts support for crypto openssl pmd. A= s xts mode
> > we got 2 key, the key length is multiplied by two, i.e. 32 and 64= .
> >
> > Signed-off-by: Michael Leung <michael.leung@bloombase.com><= br> > > ---
> Fix checkpatch issues
> Also update doc/guides/cryptodevs/features/openssl.ini

--_000_SN6PR11MB3408B24B837C9F6DDAB892CC815BASN6PR11MB3408namp_--