DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Ji, Kai" <kai.ji@intel.com>
To: "Power, Ciara" <ciara.power@intel.com>,
	"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"pablo.de.lara.guarch@intel.con" <pablo.de.lara.guarch@intel.con>
Subject: RE: [PATCH] crypto/ipsec-mb: fix qp setup for secondary process
Date: Fri, 4 Nov 2022 10:51:35 +0000	[thread overview]
Message-ID: <SN6PR11MB3408BB2854FF6FD6A99A09F6813B9@SN6PR11MB3408.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221104094246.347024-1-ciara.power@intel.com>

Acked-by: Kai Ji <kai.ji@intel.com>

> -----Original Message-----
> From: Power, Ciara <ciara.power@intel.com>
> Sent: Friday, November 4, 2022 9:43 AM
> To: Ji, Kai <kai.ji@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; pablo.de.lara.guarch@intel.con; Power, Ciara
> <ciara.power@intel.com>
> Subject: [PATCH] crypto/ipsec-mb: fix qp setup for secondary process
> 
> If a secondary process is using a queue pair that has been setup by the primary
> process, we need to reset mb_mgr pointers.
> This commit removes an error return in this case, allowing secondary to do the
> remaining setup for the existing qp.
> 
> Fixes: b35848bc01f6 ("crypto/ipsec_mb: add multi-process IPC request handler")
> Cc: kai.ji@intel.com
> 
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> ---
>  drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
> b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
> index bf18d692bd..62be68a917 100644
> --- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
> +++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
> @@ -273,9 +273,6 @@ ipsec_mb_qp_setup(struct rte_cryptodev *dev, uint16_t
> qp_id,
>  			return ipsec_mb_secondary_qp_op(dev->data->dev_id,
> qp_id,
>  						qp_conf, socket_id,
> 	RTE_IPSEC_MB_MP_REQ_QP_SET);
>  		}
> -
> -		IPSEC_MB_LOG(ERR, "Queue pair already setup'ed.");
> -		return -EINVAL;
>  	} else {
>  		/* Free memory prior to re-allocation if needed. */
>  		if (dev->data->queue_pairs[qp_id] != NULL)
> --
> 2.25.1


  reply	other threads:[~2022-11-04 10:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-04  9:42 Ciara Power
2022-11-04 10:51 ` Ji, Kai [this message]
2022-11-07  4:45   ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB3408BB2854FF6FD6A99A09F6813B9@SN6PR11MB3408.namprd11.prod.outlook.com \
    --to=kai.ji@intel.com \
    --cc=ciara.power@intel.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=pablo.de.lara.guarch@intel.con \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).