From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02DD1423B5; Thu, 12 Jan 2023 11:32:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6A9E40156; Thu, 12 Jan 2023 11:32:38 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id D9050400EF for ; Thu, 12 Jan 2023 11:32:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673519557; x=1705055557; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=9L3NBS3vkfdnlk08Yxja1WL8rpzs9EesiOGmqZ6PHMM=; b=UKa+NDkMHbBdAgg+n3/Xj7pUklp2TGbQUTQ8JMWisCWdmpgOTMCmU++w UKqUXHqThu0WpteYdNyFAKLgRLdTiED3gEYwTg72Zp6py8/IgMABJXeyb 3+MjuE75syzh4N3B4dPUeCxcigdGtkkfJz1g3UI0JnOP5pcqflEgPZxgf 7XQJWUNqhMBV1uG40421u919YLVg3AXy3r4xMA0Wko9VUy7IMb8sEbpCe pbFxxct5j3L/QyfDTXrpzaXTBIib6IuaGlzXJqI2w29NE5kL7U9EiNvSY qmiMeZ2LEaEW8zo4lWJoXAvvoxJfUZfim93fa5wsHBSivbo2s/CrJqhfZ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="323728482" X-IronPort-AV: E=Sophos;i="5.96,319,1665471600"; d="scan'208";a="323728482" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2023 02:32:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="635332963" X-IronPort-AV: E=Sophos;i="5.96,319,1665471600"; d="scan'208";a="635332963" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 12 Jan 2023 02:32:35 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 12 Jan 2023 02:32:35 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 12 Jan 2023 02:32:35 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.107) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 12 Jan 2023 02:32:34 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jN4+VSbQjOyB0PGhyczwdo2Y7fCe+p6idiIHFxqQJG4uKFwIhkJUrAK8bcNjnw1ORi0MGx3xleXHodoPGzCOhQbnLPJENcEfTOYinbYMekZN+OJ41MjNxV/rsnKTf4WaymhLGOzaDj2nwuZUpxeNHnoH0kL4JotHBRcZWhBVILCeUTlIMrbolRffd4fI1V3b9ZLNDrtJJE+xrZIspEyHe9nHMQom35AwPLT+WA61zetzMYQjpICt8GHP9yMzbtSbG0a/sueT3Mi/PaEXeEVht91DCvlpvFVjq7gZO4UaCzk4xPSTK2mEATayhQUWLQdxkIJvzk33eUYzb6Q1Q+M10A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MczhN4EYy1mrBZLeSC9vYzXEmCnZD2ji35Zwol+VlUM=; b=YW3/eKpDqSk18BSafS1p4Tw432UaS4gBYN7xG23A3VaYIv84bu5m1ChKWgvEiceFw8sbq52L2pLnG1PG8UOAlAilDKzNnNFlLQP/AzPnqpzEebCEIj0ug3CDPkgAdjD+9i9i6T7zx7D0AmxLTg9SjC8Rnp/aNzpsCjol7viBWLut5PXBNs7vwXVY+l/+2NbVwEMaXdmaEGq3qYc5Avx+Yv4ce+R/ehJwRqmLjFtCMYiTbNCDemeJhWL+ZqFf5xcEmToPRuNQViwFVM/HHo3kBnkBkluyX8K2Fg8XCqWVMUycKStnzIp2m7XEE07ex/ugqqgOumZWJa+pfnEt99fGfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3408.namprd11.prod.outlook.com (2603:10b6:805:bc::22) by SN7PR11MB8067.namprd11.prod.outlook.com (2603:10b6:806:2e8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 10:32:28 +0000 Received: from SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::fa0b:251d:e9b2:b3a1]) by SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::fa0b:251d:e9b2:b3a1%2]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 10:32:27 +0000 From: "Ji, Kai" To: Thomas Monjalon , "De Lara Guarch, Pablo" , Akhil Goyal CC: "dev@dpdk.org" , Tyler Retzlaff , "dev@dpdk.org" , David Marchand , "Dooley, Brian" , "Power, Ciara" , "Mcnamara, John" Subject: RE: [PATCH] crypto/qat: fix build Thread-Topic: [PATCH] crypto/qat: fix build Thread-Index: AQHZJhNc1d7dHsQ3tkqOetRP2w4mSa6ak1yQ Date: Thu, 12 Jan 2023 10:32:27 +0000 Message-ID: References: <20221230210728.86920-1-thomas@monjalon.net> <13467772.uLZWGnKmhe@thomas> <9337009.CDJkKcVGEf@thomas> In-Reply-To: <9337009.CDJkKcVGEf@thomas> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3408:EE_|SN7PR11MB8067:EE_ x-ms-office365-filtering-correlation-id: 6f814172-4b58-47f9-eb84-08daf4884d64 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wE96ds211V+96CGs8rDucKFUuBUbJwQuNv31cqgipHFPVMuLE0SMpB+iWJ82cJxTgMgoAUNsf0PZcyuf3bBNvM1RBizXNo/m5W7YWbt8RjtaESSUS4pf0LmTk+cvL18Q2J0H72l5v5yGIxZMhrAbFkTi9xq0uvyfVUg8lwyI/b0qtyFETKxYdpOjgoYUCpqhHVYzB160hFH3nGcRFj0mt0APg4irkaXaTo9d+3bXy4XujMBHA5F6BGLOBE8DwMEHbWZBitfjMenapvfHXiFMVyniqNhrEWGoG9DBNvQuD2uVm1gZWfAW4i/yTkbpceWuN1WsC8DL4IIH1xDV/rDuuyutzyBsFkxe9dkHuPA/XEJti1x2fJel730Cp6aLSIlqLyaCqf8nC1yRjeSEXV84MEOpCFC8+m2duDufJJ2lEy86XiHZRoz0AcMMZplUZZUNjtSkukWSbQ+TVHkHdYtxHbXwsuNkNJ1X1M4Qd766vxdWvemKAgdhrNZs3lTtPgdqUaPiR/MPas7XGcMGDIi+Is2R01y8iFSJJPj74pb2MipFHQPSv6PcAd9QM69Bo788OLBMn5F1kGQM0UHXBdVZh5RFmSq4aEWy2MaQOGwZB0oNgt/wfuTIUv52r6lDEFggEkHrqLON/V5yE2WzL+Z67UBK18Qo0h95oseheSqvG4Dz9BfWFxtV6+jgR73/ahmmGl8kpk17s0E9uA7q3uNSaA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3408.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(39860400002)(396003)(346002)(136003)(376002)(451199015)(53546011)(2906002)(71200400001)(6506007)(107886003)(7696005)(26005)(478600001)(9686003)(186003)(55016003)(8676002)(83380400001)(110136005)(66446008)(66946007)(76116006)(64756008)(54906003)(316002)(66556008)(66476007)(4326008)(41300700001)(33656002)(82960400001)(122000001)(38100700002)(52536014)(38070700005)(86362001)(8936002)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kPhie1RJ21uoePHykoWUzDkVzjFNYwYpFNQ4vLoOQ8i6oOaioV2z7RdwRuc+?= =?us-ascii?Q?HCeDrKOtesUwvrtJsUg9jypG+dGb0eWRL8vnYGKkBFWJ6PrmptMNTJm2MhD1?= =?us-ascii?Q?+2lCkvfjiF7SNfas7JIvidxb6YBFTxjNeWTsPQRFxsxqk+E825vXKhsW3M7H?= =?us-ascii?Q?85lg/veusAKA0yCre7RwWki9fF/tjAQvHMaqiaXwSGxtHRIrIHA9Vi6ci4Eb?= =?us-ascii?Q?nwPITT/oUg3Qd3OhaRjy7MZaiNeIvO+YFpS2UfZc2EK2/qXifyYZvV/NAn4N?= =?us-ascii?Q?+S3mNI6FYXKKoAxDj2TTGIZY3rAdo+IJBoqjD1ZVZ8YmjsuJ8GKVt239qWuN?= =?us-ascii?Q?Z6SuTHer/s6Dt3OYpJ7ghARh+puqF2O5BKD+N50FfsaGHi/rbsioH0ERta/I?= =?us-ascii?Q?LxTXf63gUEmjzzP2lrgc2xmLMVE4Cy5gk8NgHAkpvQxOAaYCbmgFvTvza0Rr?= =?us-ascii?Q?YusMl/bfPp+RA7oT1VITfXtKmx47oFDzbJqiS5BryBs0nFoFR8FlqAO04T81?= =?us-ascii?Q?yuFYqbs3mGqNWScLVj7oG0WJU5PO2oIGUncCucdclMdbuebbM/Jpqn0QaXCY?= =?us-ascii?Q?ZjMgMkMRbSF9hr1nHlQVz+r2N8xDdzx817T9Edm1FJMfSFXvAw1C9iQgn8qb?= =?us-ascii?Q?Dy1hYWLeBeV1/C3s/WG444P2DerpvWXK18OItiCPnn126qercZ+pNFQ/UPhm?= =?us-ascii?Q?oc5v8nIucMH83G6hcs67ub7j0lctAX1nxyKdBkkPWQoYLfbxKklq9pBpzZag?= =?us-ascii?Q?QJHMxAPlrrorGoiXbXloWqOu5y3qfCx0Z7Ymr2Z3tFq79dm5S+M6uChasT10?= =?us-ascii?Q?X3Pz/CMAIdq0TrMQK1AmifWq5USBFb7/YZbhgm5+zSpBZWZpgAXGIyPt6GcI?= =?us-ascii?Q?qT8YXdZKfa458kl0gNcRx18aLAwBpHf9hAqSENgFmLvIiZk36K6Uv+rz+D2Q?= =?us-ascii?Q?NBOjim/8fG0NUVwtxKnAR4YhZsklf8Ei/YSz42nW6kpS+ohoSh4kHZvUPXTH?= =?us-ascii?Q?xj9Lz7f63pOt9qlzfUlNVVf82AMyttY00Rx0iIkBynWTmPCLiMwzsnDBu3Iv?= =?us-ascii?Q?1vs9Y4QE+bF70/+FpB+rDXE7fn2X86nF+vA2bIqs8ejr3UAOBAODM8YH8G3/?= =?us-ascii?Q?4y/T9dpJMS34mP1kAlkw32UHK0Kl1NzGVQvS07mA4/X2d9DBWcZRAp29SaET?= =?us-ascii?Q?9hPQpWdTlhKD20j64FRraw5AW6xLEKVK0Wf4jgnrdHtgZI7HoJXR28yOVaD8?= =?us-ascii?Q?NHBT8B7aIayolbCY5kYwlqy+FUeflQhWhDqmdN7B+y0OBRzHus8qzo3qgyD4?= =?us-ascii?Q?4B9vKydpKvyChEA409jYrweCwwzbEJvH/wO+YRmL8ue8fyAqMTqmkK3MaePM?= =?us-ascii?Q?8GNx7OWxFTC8RIcfRttYptjP4zf/PDdXuCEvhcHkecsdrwS6O3aENeVH9o54?= =?us-ascii?Q?pD1YBkz9AzPX03fOZC5o6WsWDvfVWTSazoyzN2bxQGU2ImK2q/9W40LUqr+t?= =?us-ascii?Q?t5FaNcCrI5/TRCVdia7gKQP5tp+Eczpa4HfKCYskPMdcNMQW8blwr7V/LgbV?= =?us-ascii?Q?UrNw7BFprqpXUAawdew=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3408.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f814172-4b58-47f9-eb84-08daf4884d64 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 10:32:27.7223 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jAVtiFgfNTxcJif2TwolkWQnRDalSsZwsuNOkequBu9EWnOvqNk0KiCS6ybz/9cRNIO5s1btSLIx58pCFUAW+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB8067 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Ok, a long story short, this issue should only occurred when RTE_QAT_LIBIPS= ECMB is enabled. It was intend to remove Openssl lib dependency in QAT replaced with ipsec_m= b lib, but the work was partially done due to limitation of ipsec_mb by the= time (FIPS certification) I'm happy with current fix and please cc: stable@dpdk.org The fully removal of Openssl dependency is already ongoing, I will take a n= ote to fix this properly Regards Kai > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, January 11, 2023 11:21 PM > To: Ji, Kai ; De Lara Guarch, Pablo > ; Akhil Goyal > Cc: dev@dpdk.org; Tyler Retzlaff ; > dev@dpdk.org; David Marchand ; Dooley, Brian > ; Power, Ciara ; Mcnamara, > John > Subject: Re: [PATCH] crypto/qat: fix build >=20 > Waiting for an answer here. > The commit log is not supposed to stay like this with questions. >=20 >=20 > 11/01/2023 10:03, Thomas Monjalon: > > 04/01/2023 12:56, Akhil Goyal: > > > > On Fri, Dec 30, 2022 at 10:07:28PM +0100, Thomas Monjalon wrote: > > > > > When trying to compile on a fresh system, I hit this error: > > > > > > > > > > intel-ipsec-mb.h:333: error: "AES_BLOCK_SIZE" redefined > > > > > 333 | #define AES_BLOCK_SIZE IMB_AES_BLOCK_SIZE > > > > > In file included from drivers/crypto/qat/qat_sym_session.c:8: > > > > > /usr/include/openssl/aes.h:26: previous definition > > > > > 26 | # define AES_BLOCK_SIZE 16 > > > > > > > > > > I don't know why it was not seen before. > > > > > Is it because of a change in intel-ipsec-mb.h or in OpenSSL? > > > > > > > > > > Signed-off-by: Thomas Monjalon > > > > > --- > > > > > > > > owners of intel-ipsec-mb.h should guard against the namespace > > > > conflict... > > > > > > > > Acked-by: Tyler Retzlaff > > > > > > Applied to dpdk-next-crypto >=20 > If there is no better fix, we should at least add Cc: stable@dpdk.org > assuming it could be reproduced with an older DPDK. >=20 > > > > > > Thanks. > > > > I'm concerned to have no answer from Pablo and Kai. > > It is real design problem. Is there any plan to have a protected > namespace? >=20 >=20