DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Ji, Kai" <kai.ji@intel.com>
To: Akhil Goyal <gakhil@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>
Subject: RE: [EXT] [dpdk-dev v5] crypto/openssl: openssl 3.0 support on sym crypto routine
Date: Thu, 24 Feb 2022 23:13:27 +0000	[thread overview]
Message-ID: <SN6PR11MB3408F6C62456DBA9185773FB813D9@SN6PR11MB3408.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CO6PR18MB44843676166A4C2E1E7D611DD83D9@CO6PR18MB4484.namprd18.prod.outlook.com>

Hi Akhil,

This patch was intend to support Openssl 3.0 on symmetric crypto algorithms only, where the deprecated APIs, compile warnings and failing test cases were fixed.
All the asymmetric crypto related issues stay untreated and will be fixed in the next patch. 

Regards

Kai 

> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Thursday, February 24, 2022 7:03 PM
> To: Ji, Kai <kai.ji@intel.com>; dev@dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Subject: RE: [EXT] [dpdk-dev v5] crypto/openssl: openssl 3.0 support on sym
> crypto routine
> 
> > This patch update the symmetric EVP routine in crypto openssl pmd to
> > adopt openssl 3.0 library.
> >
> > Signed-off-by: Kai Ji <kai.ji@intel.com>
> >
> > v5:
> > - checkpatch fix
> >
> > v4:
> > - code comments addressed
> >
> > v3:
> > - rebase to 22.03-RC1
> > - enable openssl 3.0 lagacy library of DES
> > - remove local ctx in combined op as EVP_CIPHER_CTX_copy refuse copy
> > without
> >   a valid dup function pointer.
> >
> > v2:
> > - minor code fix
> >
> > ---
> Openssl driver is not getting compiled with openssl3.0 Are you ignoring the
> warnings?
> 
> 
>       |  ^~
> In file included from ../drivers/crypto/openssl/openssl_pmd_private.h:12,
>                  from ../drivers/crypto/openssl/rte_openssl_pmd.c:16:
> /usr/local/include/openssl/dh.h:223:27: note: declared here
>   223 | OSSL_DEPRECATEDIN_3_0 int DH_generate_key(DH *dh);
>       |                           ^~~~~~~~~~~~~~~
> ../drivers/crypto/openssl/rte_openssl_pmd.c: In function
> 'process_openssl_rsa_op':
> ../drivers/crypto/openssl/rte_openssl_pmd.c:2068:3: error:
> 'RSA_public_encrypt' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-
> declarations]
>  2068 |   ret = RSA_public_encrypt(op->rsa.message.length,
>       |   ^~~
> In file included from ../drivers/crypto/openssl/openssl_pmd_private.h:11,
>                  from ../drivers/crypto/openssl/rte_openssl_pmd.c:16:
> /usr/local/include/openssl/rsa.h:282:5: note: declared here
>   282 | int RSA_public_encrypt(int flen, const unsigned char *from, unsigned char
> *to,
>       |     ^~~~~~~~~~~~~~~~~~
> ../drivers/crypto/openssl/rte_openssl_pmd.c:2081:3: error:
> 'RSA_private_decrypt' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-
> declarations]
>  2081 |   ret = RSA_private_decrypt(op->rsa.cipher.length,
>       |   ^~~
> In file included from ../drivers/crypto/openssl/openssl_pmd_private.h:11,
>                  from ../drivers/crypto/openssl/rte_openssl_pmd.c:16:
> /usr/local/include/openssl/rsa.h:291:5: note: declared here
>   291 | int RSA_private_decrypt(int flen, const unsigned char *from, unsigned
> char *to,
>       |     ^~~~~~~~~~~~~~~~~~~
> ../drivers/crypto/openssl/rte_openssl_pmd.c:2091:3: error:
> 'RSA_private_encrypt' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-
> declarations]
>  2091 |   ret = RSA_private_encrypt(op->rsa.message.length,
>       |   ^~~
> In file included from ../drivers/crypto/openssl/openssl_pmd_private.h:11,
>                  from ../drivers/crypto/openssl/rte_openssl_pmd.c:16:
> /usr/local/include/openssl/rsa.h:285:5: note: declared here
>   285 | int RSA_private_encrypt(int flen, const unsigned char *from, unsigned
> char *to,
>       |     ^~~~~~~~~~~~~~~~~~~
> ../drivers/crypto/openssl/rte_openssl_pmd.c:2107:3: error:
> 'RSA_public_decrypt' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-
> declarations]
>  2107 |   ret = RSA_public_decrypt(op->rsa.sign.length,
>       |   ^~~
> In file included from ../drivers/crypto/openssl/openssl_pmd_private.h:11,
>                  from ../drivers/crypto/openssl/rte_openssl_pmd.c:16:
> /usr/local/include/openssl/rsa.h:288:5: note: declared here
>   288 | int RSA_public_decrypt(int flen, const unsigned char *from, unsigned char
> *to,
>       |     ^~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> ninja: build stopped: subcommand failed.

  reply	other threads:[~2022-02-24 23:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-04 17:57 [dpdk-dev v1] crypto/openssl: openssl EVP MAC routine api update Kai Ji
2022-02-07 15:24 ` [dpdk-dev v2] crypto/openssl: openssl 3.0 support on sym MAC routine Kai Ji
2022-02-07 15:40   ` Zhang, Roy Fan
2022-02-17 17:45   ` [dpdk-dev v3] crypto/openssl: openssl 3.0 support on sym crypto routine Kai Ji
2022-02-17 18:01     ` [EXT] " Akhil Goyal
2022-02-18  9:44     ` [dpdk-dev v4] " Kai Ji
2022-02-18 11:51       ` [dpdk-dev v5] " Kai Ji
2022-02-18 13:41         ` Zhang, Roy Fan
2022-02-24 19:02         ` [EXT] " Akhil Goyal
2022-02-24 23:13           ` Ji, Kai [this message]
2022-02-25  3:55             ` Akhil Goyal
2022-02-25 10:19               ` Ji, Kai
2022-02-25 10:39                 ` Akhil Goyal
2022-02-25 11:19                   ` Ji, Kai
2022-02-25 13:51                   ` Zhang, Roy Fan
2022-02-28  5:35                     ` Namburu, Chandu-babu
2022-02-25 15:13         ` [dpdk-dev v6] " Kai Ji
2022-02-25 17:35           ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB3408F6C62456DBA9185773FB813D9@SN6PR11MB3408.namprd11.prod.outlook.com \
    --to=kai.ji@intel.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=roy.fan.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).