From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52E28A034C; Fri, 25 Feb 2022 00:13:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C6B0940688; Fri, 25 Feb 2022 00:13:34 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 6BFBE40141 for ; Fri, 25 Feb 2022 00:13:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645744412; x=1677280412; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ARiuZVtKDRJLAgKdZjpAYjHNbaVqzlf+CLZN53VaCPo=; b=C3F1fGgzKhcxaeh8GYq5ct4626G2B+w38rnz15QZgC6tRbIPDq5VhlXW Yh4KPhHEqvLHzS2HuBFjtqrmMjh+/laWp+4wRO/ywOzu2kHTZbFaS9NzO Scq9ZxXfaCutKATxYV1hrxSBqlXr9U+g3Rffr1VEZGLy6rBwV5PRwyJ8x 9Rg8XMPkXpRHoyMo8j2/nIjLwVewjzIedwhKbzsW+sRS7iLcBgu1owdOX UxrzKeYmAiAGHji7BFF06l2LoWgrWID0wihXwYrokGX3icmI5skNhTUHO fY3s6ipMS2C3mXhZsc+iWSV4u3Y8XTugBDjmwxJ3a9VQwhMoyUkvPK5C/ A==; X-IronPort-AV: E=McAfee;i="6200,9189,10268"; a="252102789" X-IronPort-AV: E=Sophos;i="5.90,134,1643702400"; d="scan'208";a="252102789" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2022 15:13:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,134,1643702400"; d="scan'208";a="548984427" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga008.jf.intel.com with ESMTP; 24 Feb 2022 15:13:30 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 24 Feb 2022 15:13:30 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 24 Feb 2022 15:13:30 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 24 Feb 2022 15:13:30 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 24 Feb 2022 15:13:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bJAwQjES4EmzKNAx4/ECcVN/PnDHj6wgU9HrF/E2CFt1hAFAJOCd19N//anUTcntWrJtdRaYSu3IuDWfDxxQ/CgevP+o/AssuQjK2zyf7llazFKc/86Rtg0NXnC8f/AF03aWJzyDQyXcHEtK8z8d8Bw+HmtTLnlNMDMRStBhxAfpWNAYJDPEYVBjNGhUflSpn6My+9FwNgx32jCo458ka5JNiWQCaPgLPdjs5BtmSr83443vuRHiIlGDEbSpwsDnFiwN83zb+cqzM2bbgCaQsGmLtCSwK/6jP72M3BlsJnICqhHuFEYhcAQB3+z4EARUODlAyFz+5O93Cw/iM2IyyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1WuJIQuqHeAWm8j7H8Yp2rvl+xy3WPrSJ36R2XUX/S0=; b=APIxzqJ9jUwf5/BRyrY+3bYjirbPMzYBQ54OqpFYpMQ+MMm5v8XsPX6SS2LxrZ8t8+LG587y3JWPyz4ylNPeLP4NCzf6o3MsQ3zViiYIfDaOWu4rRye9YrUb53JYneccOVAWDsZLQoCujCPUcT1Pw25JwYugg+RIGzsp0ZM0CIuNrcBVrNg9SY2c4vEinPZgMVxcay3Q/mB9x+5lunBZjH6b0I0tPmdBEwOI2xCqS3qamV1pXfDD55EFQOmnDTv3NffOOxfG4W4s7qCmcBQMFuIV+y0WpsQgpP6w2mnVHRaTJUgbp1gK+/uPfmInEYtKXE9+p6bYVqpxYMb6J4BiyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3408.namprd11.prod.outlook.com (2603:10b6:805:bc::22) by MN2PR11MB4047.namprd11.prod.outlook.com (2603:10b6:208:13a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.24; Thu, 24 Feb 2022 23:13:27 +0000 Received: from SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::d8d3:b244:30ec:f6c9]) by SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::d8d3:b244:30ec:f6c9%5]) with mapi id 15.20.5017.025; Thu, 24 Feb 2022 23:13:27 +0000 From: "Ji, Kai" To: Akhil Goyal , "dev@dpdk.org" CC: "Zhang, Roy Fan" Subject: RE: [EXT] [dpdk-dev v5] crypto/openssl: openssl 3.0 support on sym crypto routine Thread-Topic: [EXT] [dpdk-dev v5] crypto/openssl: openssl 3.0 support on sym crypto routine Thread-Index: AQHYJL3fVxDXIXAC+E6Y+aJkEzg096yjGKsAgABCUwA= Date: Thu, 24 Feb 2022 23:13:27 +0000 Message-ID: References: <20220218094408.49290-1-kai.ji@intel.com> <20220218115124.57745-1-kai.ji@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 86c2d7e3-e63a-470d-7d22-08d9f7eb43e6 x-ms-traffictypediagnostic: MN2PR11MB4047:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KirPHwI/jVAcINd5cBVq4j5hBxJEO1HWZuu/fINGJw/pxOWf4IefigJBQOal69MfuFbyVDjRRuStr062gkAO0NL1jg6EQkOC4gdRUMFqJWQQ2/alNv7hHRDfSNN7Y78ZY5r6lhVKUeeafM/qUSMeaWa2+/svHIx/3fGDdIvWXuIKZYxvV3WsMj4qe4nF5Ncub1g42cJw1JIYshvuqfRImMFV9wgEgBu6dJBXqUhZS7d5CU3WRX67o6J7xOrvvftSowWbkxUA/N6c4gVVK0mixACRa49UZcD56OvKu6EFwVQ4uWdfcFr7Bnyl0H1xztSF8W468zk3Dbbx8ft0nOAq//VHVdTgdzLDctGa0bUM6q73B6IjS80ceYe8H3XdzI9CAv2vcCAy3HF11Eo+QyXoZAwJzKRssSJsnpOkdtJ2J396URa7DW2ODh94Rw+caVnKJV8sGmgTeU0BD0oZOEPvMKYl3fb42NuC1n1XDJTdTWk3AYtGuMjBYSIrXn8s3+TlXDlBlxlNDS9XVjkTMRf5c4TAZWGij2Br+CnBCwlXmg8zuI9k9NUdWt1DB6KiPnj2qAZMvS+av9yCOTR6SRMDBlYUJ+xEWauOiD7pPA+SROLaAnVCx17iTUReIo35rbgW4AuyWv56q+20ICnuG8mPhLi9oiHOzo9sFon9zt6ml2Mf/eJMvKqhHjBsn+TNbTfn6rFAeAoFoUJMPGAOZJQgfg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3408.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(9686003)(8936002)(508600001)(107886003)(4326008)(5660300002)(71200400001)(66476007)(66556008)(8676002)(64756008)(66446008)(38070700005)(55016003)(2906002)(7696005)(82960400001)(316002)(110136005)(53546011)(52536014)(33656002)(66946007)(6506007)(38100700002)(83380400001)(122000001)(76116006)(26005)(186003)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mTG8YavOBMXTYxmNXnaioP3hpBtExtdX3CMnzQx0ykgeSrscNWBuhf3F7ajg?= =?us-ascii?Q?blylD4wOrf6v7xqygpk5mfBYTaaYrvcbZ0OCWPgN8A6x1kPHSNVJQJsMZ929?= =?us-ascii?Q?6I018moKLwab7AF+EuhEg20VIZEk8NHcNL2YLX7BwDKk5tdWXxWRC+ZlNyxB?= =?us-ascii?Q?v6VbPS6NPOMMvVI8gQTAS1a5qiO3sHMeHqjxxQc3MdPz2vAw9+81azb5uhsa?= =?us-ascii?Q?+jM7iDa+16UBXfZrzOt0U49zwc8tAHlkYEd6RPk6791JwK8p8nBZmqfZYXFD?= =?us-ascii?Q?VnPWLt2pcVJOCYH4SLylnZyJM82UdSxFLqDVBt61uN+8uPyvE0NDF25sEcRz?= =?us-ascii?Q?wfxpLhfNCjIPggmFK4AY9Yn6yhRt0lVCKQhcP23osqymxOLCo/p1maex4zR4?= =?us-ascii?Q?Kl3Ry9yc4F2tOvS9IFB113L5DrxzbY0gBKd46s7oTYswFXk73gYAxQMdRZRH?= =?us-ascii?Q?nNKqSo0Ackm5lMghMn2O023ZX1e7DMPcfKtNHAtHk9xIZJcN73iveB+5fPTI?= =?us-ascii?Q?PyrCMS5EMFac4TplfRiyb+gMKX9cFOWkvjBCyBPAIzj+39BdMDA39ZdK3DnW?= =?us-ascii?Q?9oYFQskNKnfonNVvHiNKeZu3ShyEyo74rE4BSZ6IWfWhU5T1Hu1cjNfGUnO1?= =?us-ascii?Q?HS1jCQLsGg+UhV/8KNXTVa+3kDeg7jdV6nxJPAL+P3LTRWWRf8kRDNFOg7pT?= =?us-ascii?Q?mdbmx09Rd3T/KGowsgdpD+Dzpd1cr8a88FFGzMgUi0uzTvM8bLggqlEzkVkg?= =?us-ascii?Q?j2Hj32+IA475eLs3hU46xT7JeWK8FtOAXiOaifJC34ceRoXEH0J14/BhPUuJ?= =?us-ascii?Q?/4bPglZ4q5MbY2HIFYDvNOhbFd8St890Hr8X2rhelZ7lPcxslN70VMpRqel+?= =?us-ascii?Q?TgTm0Ayb2/hJLqGOkwT4/YrqTSmJZlT325II6/eP/cC4FoOLrlzbGlS7NdW1?= =?us-ascii?Q?0X6A/VAb6UuTFYprIkF426geJHLJP4w6A/kXYhWHhWqUQZ8PGK+gs9fw1RZt?= =?us-ascii?Q?c9FVbB4v8JvADo1x0H28VtBWBSpoAlYJAPdhmHPz7jTQ/Y2T8j4KEtkgLHDW?= =?us-ascii?Q?gvDJLFtM5s54aLdYhKEeNf5dqHpvIwltBSFtRJnQigXkNZKKYS8EhHwTcssQ?= =?us-ascii?Q?QRsq6TXpn/LHxJdm9pyESidCKEmjMWXWOY3+9cXHVlrNWnE+girVfFo8MhLh?= =?us-ascii?Q?UuthddkGEpA9DbXUlE+WKP1/BnLKpwRO4vDqP1SU7jx8oE/NjcFdXiFD0FOf?= =?us-ascii?Q?p9tpxuPs9IBbj1w1C+YRYOsFT6IgzfQIQ5/lLCckRHP61r3DqZrFxDWTvBfN?= =?us-ascii?Q?GKHxzSdDjc1IfZYMlmwKrKErS9tS5wACY1hnoWlswpIzDvoJO+VuFMZXCiKl?= =?us-ascii?Q?5rDwEqBU56hL8hw+Ku4+9p9aOTYOvbcDaiD2ruAN0NwO/5fHQD4VUNtg3IDH?= =?us-ascii?Q?Wy054FhUCMsLL/oYlsib1Eb4T7U0dHQJgVmNSpoWlOEcHQxIZsVEbCvgBWGQ?= =?us-ascii?Q?46U4Ln6ECCFl/2RAuZla6+ClB6w4b10/JVgZz4Mzkn1JcrZTaGnHxs7Smg3U?= =?us-ascii?Q?LIn8FxBaDcQzjxvz4n1EK8xs8gu8SQkvMDJG6FeY+njSvpDEwODkqGqIyzUC?= =?us-ascii?Q?TduQVXwRjTh7eEkOiJ/lwSU=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3408.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86c2d7e3-e63a-470d-7d22-08d9f7eb43e6 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2022 23:13:27.5690 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2EKra3jWt8XzB9GL/j7lbFrKbH/mcaTtQZzgmINeNPP3HmCr05zqK0GA43DWe9LWAD5Tt7SoCajxDXupEgrshg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4047 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Akhil, This patch was intend to support Openssl 3.0 on symmetric crypto algorithms= only, where the deprecated APIs, compile warnings and failing test cases w= ere fixed. All the asymmetric crypto related issues stay untreated and will be fixed i= n the next patch.=20 Regards Kai=20 > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, February 24, 2022 7:03 PM > To: Ji, Kai ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [dpdk-dev v5] crypto/openssl: openssl 3.0 support on s= ym > crypto routine >=20 > > This patch update the symmetric EVP routine in crypto openssl pmd to > > adopt openssl 3.0 library. > > > > Signed-off-by: Kai Ji > > > > v5: > > - checkpatch fix > > > > v4: > > - code comments addressed > > > > v3: > > - rebase to 22.03-RC1 > > - enable openssl 3.0 lagacy library of DES > > - remove local ctx in combined op as EVP_CIPHER_CTX_copy refuse copy > > without > > a valid dup function pointer. > > > > v2: > > - minor code fix > > > > --- > Openssl driver is not getting compiled with openssl3.0 Are you ignoring t= he > warnings? >=20 >=20 > | ^~ > In file included from ../drivers/crypto/openssl/openssl_pmd_private.h:12, > from ../drivers/crypto/openssl/rte_openssl_pmd.c:16: > /usr/local/include/openssl/dh.h:223:27: note: declared here > 223 | OSSL_DEPRECATEDIN_3_0 int DH_generate_key(DH *dh); > | ^~~~~~~~~~~~~~~ > ../drivers/crypto/openssl/rte_openssl_pmd.c: In function > 'process_openssl_rsa_op': > ../drivers/crypto/openssl/rte_openssl_pmd.c:2068:3: error: > 'RSA_public_encrypt' is deprecated: Since OpenSSL 3.0 [-Werror=3Ddeprecat= ed- > declarations] > 2068 | ret =3D RSA_public_encrypt(op->rsa.message.length, > | ^~~ > In file included from ../drivers/crypto/openssl/openssl_pmd_private.h:11, > from ../drivers/crypto/openssl/rte_openssl_pmd.c:16: > /usr/local/include/openssl/rsa.h:282:5: note: declared here > 282 | int RSA_public_encrypt(int flen, const unsigned char *from, unsig= ned char > *to, > | ^~~~~~~~~~~~~~~~~~ > ../drivers/crypto/openssl/rte_openssl_pmd.c:2081:3: error: > 'RSA_private_decrypt' is deprecated: Since OpenSSL 3.0 [-Werror=3Ddepreca= ted- > declarations] > 2081 | ret =3D RSA_private_decrypt(op->rsa.cipher.length, > | ^~~ > In file included from ../drivers/crypto/openssl/openssl_pmd_private.h:11, > from ../drivers/crypto/openssl/rte_openssl_pmd.c:16: > /usr/local/include/openssl/rsa.h:291:5: note: declared here > 291 | int RSA_private_decrypt(int flen, const unsigned char *from, unsi= gned > char *to, > | ^~~~~~~~~~~~~~~~~~~ > ../drivers/crypto/openssl/rte_openssl_pmd.c:2091:3: error: > 'RSA_private_encrypt' is deprecated: Since OpenSSL 3.0 [-Werror=3Ddepreca= ted- > declarations] > 2091 | ret =3D RSA_private_encrypt(op->rsa.message.length, > | ^~~ > In file included from ../drivers/crypto/openssl/openssl_pmd_private.h:11, > from ../drivers/crypto/openssl/rte_openssl_pmd.c:16: > /usr/local/include/openssl/rsa.h:285:5: note: declared here > 285 | int RSA_private_encrypt(int flen, const unsigned char *from, unsi= gned > char *to, > | ^~~~~~~~~~~~~~~~~~~ > ../drivers/crypto/openssl/rte_openssl_pmd.c:2107:3: error: > 'RSA_public_decrypt' is deprecated: Since OpenSSL 3.0 [-Werror=3Ddeprecat= ed- > declarations] > 2107 | ret =3D RSA_public_decrypt(op->rsa.sign.length, > | ^~~ > In file included from ../drivers/crypto/openssl/openssl_pmd_private.h:11, > from ../drivers/crypto/openssl/rte_openssl_pmd.c:16: > /usr/local/include/openssl/rsa.h:288:5: note: declared here > 288 | int RSA_public_decrypt(int flen, const unsigned char *from, unsig= ned char > *to, > | ^~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > ninja: build stopped: subcommand failed.