From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 116DF429D0; Mon, 24 Apr 2023 05:00:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 03B8842C76; Mon, 24 Apr 2023 05:00:19 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 2B510410DE; Mon, 24 Apr 2023 05:00:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682305217; x=1713841217; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=uzULTU+wS3qgE+XHsE8LKOfnz3hd8MTOn2JtyexP/0o=; b=j85MBY3AM2DulDXhtGWlL05/hduX2uxB9+9JiS2HTg8PmPMUC0e52We1 I0Mhdeza/DsB89hEdhcgTn/kpK95YVGXkPpgz+mNM3e/zvk5mFlBcDmR9 Sva973WzmcnABRJkvmPJ4+drNzQdBtoKUSK2HSxaSEm/jXOG7ccQ8tyZ4 dUh7O4mvgkYxS6KdyKfiS9rJdYDSDfvB4FZUrSjDMvlvCnD8eK1vjqQfm WG1IxopAWiJDvSh5tK+DMCjJ6p6OFQ/BfMI97eATmKZXWmWKRpyZxff10 RvPsbtFV0JUhaSPdcL7Snbi4+TKmtLzqmv+nzCUaJkK28ijVE1SMZCXN5 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10689"; a="348256272" X-IronPort-AV: E=Sophos;i="5.99,221,1677571200"; d="scan'208";a="348256272" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2023 20:00:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10689"; a="723427918" X-IronPort-AV: E=Sophos;i="5.99,221,1677571200"; d="scan'208";a="723427918" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga008.jf.intel.com with ESMTP; 23 Apr 2023 20:00:15 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 23 Apr 2023 20:00:15 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Sun, 23 Apr 2023 20:00:15 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.107) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Sun, 23 Apr 2023 20:00:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oR5vEJnYK44QIsuo68mLv1EY3s9xLlSdtYLplAs6+qpbyV5gnJJ/9MKlPH8nwwRkS4BrGNFtLMwKdj0QK9ve6mjBZvX8EQACz9XuppPuHQEkx1O8BKNjpeUbuw/xX0wxiOXwkG2tK2znBHI9VA6UyKJXv3rONJJvfZfcitqZujvalCPmQY3VrYh4iHt66qvIuF7Gu+b7aistdZaff/0v5JUJGfj6osRkgf4i/cENj6I3ph6fDSpP9iA+XKU/2Ozir/5ytnDjlpqK/cbXKF7swbbgG7pc2lJkLzsg56lObrcPnN+8K9lVVMQu23bpSI2ogXldSmDiffjX5shYZ6ljFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K9PG4Cv0qtCHjAeNUr2e78c/hsnCB77pBFjRV/S9o48=; b=V9hxHXoAuxQpzEsWIcrNvyjZaBDdFlOhP7qQIJ3dYoSsxLrAZrW8wa9uuY7oZAHHb5P68auSaXjaB97lbr2JijfxppqcknEo+De/Z0FzEHgK/4ez+V+H01442uhW5ZzZ/G6Z/bZ+q23Wuj/UaG0LM1u9ur1tSXfYmaTklPT0DDRur6CRecw8LhP+asmErOmRkCWQrhpvIFK2lBbkkF8XMvBiImH5v6mIMA4EVPLW3nfRASavWyXl2wdvQlT7IfUE70zq7vHiamk4KNMtWQpFQLpPxhcpei9aIVzLETc4/V7B5JPxx4y1lpsO/jIbM7Ei6YBd+Yt+s0lLm1G2K+iP5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by PH0PR11MB5143.namprd11.prod.outlook.com (2603:10b6:510:3f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.32; Mon, 24 Apr 2023 03:00:14 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::2d7a:a878:7bed:bb11]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::2d7a:a878:7bed:bb11%4]) with mapi id 15.20.6319.032; Mon, 24 Apr 2023 03:00:14 +0000 From: "Xia, Chenbo" To: Maxime Coquelin , "dev@dpdk.org" , "david.marchand@redhat.com" , "mkp@redhat.com" , "fbl@redhat.com" , "jasowang@redhat.com" , "Liang, Cunming" , "Xie, Yongji" , "echaudro@redhat.com" , "eperezma@redhat.com" , "amorenoz@redhat.com" CC: "stable@dpdk.org" Subject: RE: [RFC 06/27] vhost: don't dump unneeded pages with IOTLB Thread-Topic: [RFC 06/27] vhost: don't dump unneeded pages with IOTLB Thread-Index: AQHZY+eQbyt/GTv+qk2926yCVBSgI6856e5w Date: Mon, 24 Apr 2023 03:00:13 +0000 Message-ID: References: <20230331154259.1447831-1-maxime.coquelin@redhat.com> <20230331154259.1447831-7-maxime.coquelin@redhat.com> In-Reply-To: <20230331154259.1447831-7-maxime.coquelin@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|PH0PR11MB5143:EE_ x-ms-office365-filtering-correlation-id: a6555240-2fd9-4d97-3b18-08db44700684 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MwJXjHQqYMBUvtK1N8plXKq5aBtqAa0DipXbBy6aUIi+k9dFZKGjNSV25OZmiSvleTIcF+HYMjIZV1G2aZYp9MjNjKk8+Y5sBWiHouyoZNAGjbt4iZJBadiK5tz7zFduPhk3LRSjGvpfkLGIhc/3c10e/yyxQOCQS7+9zGv1QU5SGLYI9ROpYYFiSu7tqaQlIbxGnuR+tzG1L4IlJJALwVICpDXiz0jrr0Ef9sD6MWRGaFonH5B2tJwzthSfS5kjOvmIs1rr5RpNh01sv2dqJRDxB/RaT518Ey4hbtHBjURGKyjZgsClaNBk2sJH8f9XLmollytH4PtvTIVAhpY9Es/mEhVT2zpwv1pclCFPble6e6wwgHkqNjl8EdBjeQ01643MFr7OmhrTs7IW2fV0LEY4vW5lwkwOX+9CYZcVJ24xtg0lcsp8KEH7IK9s4Ya1HMVEshAdELS+ESSCj49h3pxCaMsAcG8QHxrkgMHnBTpm7ztba2hmjuhpRBj8zfSHnh2B0N9b3bBJ/R32BtRT2qfHd4+DlnicsHbrw5bDW1xix9lDeuP2xV0O7YGMpDrVFxRpNzSJ6epKstbsoN+ie4v2ciqCrXJxZqFKlhWh6xZLiccigfHPYEWeqZyqhXiQN85iw8wanQCGWRi+uCcMuQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(346002)(366004)(39860400002)(136003)(396003)(451199021)(38100700002)(122000001)(921005)(82960400001)(9686003)(53546011)(83380400001)(6506007)(26005)(55016003)(186003)(33656002)(7416002)(2906002)(8676002)(8936002)(52536014)(5660300002)(7696005)(478600001)(71200400001)(38070700005)(110136005)(316002)(4326008)(66446008)(66556008)(76116006)(64756008)(41300700001)(66946007)(86362001)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?C5GnvhgILveASmR/leaCCZJlWPldOLMfOXmt3KDWbPMmmDz0/d/5mP73pn2A?= =?us-ascii?Q?ZVPfPYod1KkpsB8tBDCMOMiTzGsfx1sLQ7uizMINaks8MXmwnvLYYccXq6bk?= =?us-ascii?Q?32aCPw+1hkiqyXuSPgsRljt6A3y8LTxq6YGeZ7O9qszGPghzh5f/3fML64j+?= =?us-ascii?Q?L1/1jUaMNnx1dDtSA1lazqq72c94rPXCXCDK7NdHlmoS9DqcXRstSKrf5O4K?= =?us-ascii?Q?d9zMuu8aDXpdYtrLiefZXSDG57LvjaHMeJ6u9k4Co/QC9EH+9CQZ0+jwOqDL?= =?us-ascii?Q?Wfpw/r8pKKBkAEISWYaqr5V2NTACGW89j8WmD7WvfEp8V6Js7uj0ASAVoQkE?= =?us-ascii?Q?PWGqGyQ4VoB8NE2kuyU0ercwmja3rictE4ZTArdixlz0SW2bXFz1cO8fA+4Q?= =?us-ascii?Q?lmAUGxj9GAnYXKW7N6XGyvV99kmXXH9dyLZyTE4a9FDBaH6g9lqDrlYmTNcO?= =?us-ascii?Q?omLe28E5OqoUTjJ01cldxDXf4uizEen764Cgx/e0b16/nOfzj82yFOFBfLdP?= =?us-ascii?Q?GNJvPsiRI1/rVR5ddqQSARuRUn0W+mHNHtxk601F1OxNSzkoncnPvI6ZRMOI?= =?us-ascii?Q?5R4FJ9ouDTyTjCmYhvgGYjk0zOM4fn8hxtrV9SEY2+8GqCNj2XrKfF0bpwdj?= =?us-ascii?Q?ju6or5g/CHc/7uJU9IxOGeGbcGt5mhSSMXXqQcfhVgvusNrSglESKkuES0w/?= =?us-ascii?Q?Mjwh1Bd0GNWyf2ye9GLyAHDYHxaJ4RPP1qIyYwHJtKFpuKwGhbcVlvcMhXBz?= =?us-ascii?Q?bd2FTAnNSyleWeGViRBsyW4Xuzja3dSTsg0bK/cOC9mDqb9DmKxsvFgydvSC?= =?us-ascii?Q?vAaKjMPSUZDQ4DBPR/CEDRoXl9B7PrEFagnIyjelyLtyHcJoyzQH1BaTCr/H?= =?us-ascii?Q?a/aR4ZpCGtw9kBzZjoVMwt86ZacNTNHP6Dc7lk/JV4SKFOv6DOFoO/de9z6l?= =?us-ascii?Q?26J2uTHIyb3ArEb1M357Rp3Lc5DB/30TTUVxE58vjkHP57/fHhFm6wb7TO11?= =?us-ascii?Q?0Ff1HrRD9pg0L+NxSZP5YJTOcszwhX3y/RPHv19E4CP+Xm2iaNPHRBYBm6DG?= =?us-ascii?Q?Ct7XIekJ2xA05zUfaKQXLw5zOyUSpx/qRP2LiYVtkutBYrS4OL4JDnzuCAs2?= =?us-ascii?Q?ILF1iG40eqvqaCNs7G/QtHEkQaV9I3CKA0uelgZY5nsnXNRL7NXLLBXb1Bzv?= =?us-ascii?Q?MglTibxE5JBX3t0y7IqnmJ1R9UjkuB8yIyDXsOKgVTpWqr9K+NiwTR8NDlzE?= =?us-ascii?Q?JmRBZmcDgxYi5Papyvmc8bnIaL/1u9ZaqWYeWdJ74nu2XQ573hNLW1hGr4Al?= =?us-ascii?Q?nhC88DgesCT3ngD/nmFk3lk5t7LkXbFlBC8Wd8KFuGBr1jbRY1fwZZGwHL1o?= =?us-ascii?Q?XO8Wi7eQyT+UYTElZ1tyC4+eGpu1ffUpxWpy6DQj5wa7mD84ch4CLRBEE9OU?= =?us-ascii?Q?PJHxLojiindK2cNqyxohVu2OixP99c1A+TRCImRVMYMjR8WMIwyNVq/rpLmF?= =?us-ascii?Q?wvb17pYgqsJXfV25sH8tAHD+8OG7KRpIn/Eh6KtXa+mMGnDH2MScFPVHo0OB?= =?us-ascii?Q?p6grw9bbvWDVWgqAnG8R4nSZCvpxBewba4RxfMM0?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a6555240-2fd9-4d97-3b18-08db44700684 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2023 03:00:13.8894 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OxheasUkiWGtfVe8DvCtYE3VkM1wiujPuQ7U7BDb5g7OEtggj9M85QaNSsL45rRaOaeirZTxm7IwFj93AUM5Zg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5143 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Maxime Coquelin > Sent: Friday, March 31, 2023 11:43 PM > To: dev@dpdk.org; david.marchand@redhat.com; Xia, Chenbo > ; mkp@redhat.com; fbl@redhat.com; > jasowang@redhat.com; Liang, Cunming ; Xie, Yongj= i > ; echaudro@redhat.com; eperezma@redhat.com; > amorenoz@redhat.com > Cc: Maxime Coquelin ; stable@dpdk.org > Subject: [RFC 06/27] vhost: don't dump unneeded pages with IOTLB >=20 > On IOTLB entry removal, previous fixes took care of not > marking pages shared with other IOTLB entries as DONTDUMP. >=20 > However, if an IOTLB entry is spanned on multiple pages, > the other pages were kept as DODUMP while they might not > have been shared with other entries, increasing needlessly > the coredump size. >=20 > This patch addresses this issue by excluding only the > shared pages from madvise's DONTDUMP. >=20 > Fixes: dea092d0addb ("vhost: fix madvise arguments alignment") > Cc: stable@dpdk.org >=20 > Signed-off-by: Maxime Coquelin > --- > lib/vhost/iotlb.c | 21 ++++++++++++++------- > 1 file changed, 14 insertions(+), 7 deletions(-) >=20 > diff --git a/lib/vhost/iotlb.c b/lib/vhost/iotlb.c > index d919f74704..f598c0a8c4 100644 > --- a/lib/vhost/iotlb.c > +++ b/lib/vhost/iotlb.c > @@ -54,16 +54,23 @@ static void > vhost_user_iotlb_clear_dump(struct virtio_net *dev, struct > vhost_iotlb_entry *node, > struct vhost_iotlb_entry *prev, struct vhost_iotlb_entry *next) > { > - uint64_t align; > + uint64_t align, start, end; > + > + start =3D node->uaddr; > + end =3D node->uaddr + node->size; >=20 > align =3D hua_to_alignment(dev->mem, (void *)(uintptr_t)node->uaddr); >=20 > - /* Don't disable coredump if the previous node is in the same page > */ > - if (!vhost_user_iotlb_share_page(prev, node, align)) { > - /* Don't disable coredump if the next node is in the same page > */ > - if (!vhost_user_iotlb_share_page(node, next, align)) > - mem_set_dump((void *)(uintptr_t)node->uaddr, node->size, > false, align); > - } > + /* Skip first page if shared with previous entry. */ > + if (vhost_user_iotlb_share_page(prev, node, align)) > + start =3D RTE_ALIGN_CEIL(start, align); > + > + /* Skip last page if shared with next entry. */ > + if (vhost_user_iotlb_share_page(node, next, align)) > + end =3D RTE_ALIGN_FLOOR(end, align); > + > + if (end > start) > + mem_set_dump((void *)(uintptr_t)start, end - start, false, > align); > } >=20 > static struct vhost_iotlb_entry * > -- > 2.39.2 Reviewed-by: Chenbo Xia =20