From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5ECDA0547; Wed, 12 Oct 2022 10:12:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C6DF242E70; Wed, 12 Oct 2022 10:12:31 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id C067F42E70 for ; Wed, 12 Oct 2022 10:12:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665562349; x=1697098349; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ffYQ+fxAxPFI3dZ2rE+c6+oyTzS/2G31Hh7aZlF7TFM=; b=aSsWUMWzaROy9SxWxXk/yYAlmGvaarLjLscr4xRnx7dnqlAtXQMvc6Jc gEaL2VZEyYNwzn+JRBcChjlPinNW/im27rHGbEwGWusp5MO5A1bsz+FVq x9syoblZbIG2V/mO9NPWPBoLtdkLlFIFCUzYNv6x6VU/cNKYGdphJqVhq e9buzAAlUwOJ2rpR9UdWr8hbD8G/oVCNjRUZhOoFOxCP+q+bdZDNld0vJ +BYyz2Jht2zXNctnoxc0Cz10GsbTBvkhsbzFDuMlxn5HwGQMfWX7Mn2XO Dp/Ba7VczIUU/r29+YUJE7buP42PEhBOcgqbuEWzuRJgnHjLXNVIkgvME A==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="366731229" X-IronPort-AV: E=Sophos;i="5.95,178,1661842800"; d="scan'208";a="366731229" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2022 01:12:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="659847212" X-IronPort-AV: E=Sophos;i="5.95,178,1661842800"; d="scan'208";a="659847212" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP; 12 Oct 2022 01:12:28 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 12 Oct 2022 01:12:28 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 12 Oct 2022 01:12:28 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 12 Oct 2022 01:12:28 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 12 Oct 2022 01:12:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BBI3IVMlGabpKCxa50VEk/aPqpN4uBQNu3qxDSMyqtEZuq0Jyn3XcBQsgBgXSVPiaNcQ84dakO7RdRrrDJee39mmYtmHNAu8HCkCav/vLSfMSPgAtdCEshUI898N+ZklYnm5S4u5i1aesGAPS5Z8ZCxiTO+bJg6D7x6ISzRqfjlUbBstNcqv9c5h1kLo1IgrxBoa941x/d6TkvTT7EPw7EoLfLuhpdjr4WqviVkeHAyNGmgn+nnk8T1gv5n9QJDpafvrDK19Cj5GW2+2pYNs19ytNsGvA/rVJRFbNHMUb0WUhSp/hPd9ApSMZF5imm5llnqo92AEZGvIhl2NdepwFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T1Mk0ipsYHf0XJsZ96cbba02WXnFOk91BMYe5wVTL04=; b=UgaOih6AMR6rueaTnRDWgL9ii1cQm82KIaG5PXbYT65DhuPkXDDilRhSn/+SDvaz2GaYD0mhEx0wpwV3dNCmngOZM2Tri+YFM2x+cP7OgvqT5lhquJJKW4QReEy+ZpM1ckjhGL/Qb/QkCPoWdoGoKEUs5I8Dxrla3uUvt0JCVlOYrfQDrjtgBCy6SCkT2BSXlSjnwqZ4oaSNJmS9CRJvOZgNN7dC0S0NopFqL17tNc9JGgX15p2XHIml2SWa1CVxbrB/sWdcBLp5rQywA+WoonlsygigGOYZZjVWJeN4x0NzhMFG96XIpN5oEWoDFsAeke1Vd2fzD+lu2giKJ40E9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by MW4PR11MB6840.namprd11.prod.outlook.com (2603:10b6:303:222::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Wed, 12 Oct 2022 08:12:26 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::39bf:57b1:4824:d40d]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::39bf:57b1:4824:d40d%6]) with mapi id 15.20.5709.022; Wed, 12 Oct 2022 08:12:26 +0000 From: "Xia, Chenbo" To: "Pei, Andy" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v3 5/8] vdpa/ifc: only configure enabled queue Thread-Topic: [PATCH v3 5/8] vdpa/ifc: only configure enabled queue Thread-Index: AQHYyZPqbmZ+XrFNik+lBRaAI6Mhl64KkUTQ Date: Wed, 12 Oct 2022 08:12:26 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1663308990-621-1-git-send-email-andy.pei@intel.com> <1663308990-621-6-git-send-email-andy.pei@intel.com> In-Reply-To: <1663308990-621-6-git-send-email-andy.pei@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|MW4PR11MB6840:EE_ x-ms-office365-filtering-correlation-id: c274f609-c5f9-4643-4383-08daac297fb9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JsRW5rNbhs3DQyJKGhJY9mf2luHm1/lDdBcAIym1zF8WGDfy090k6bnbdU9ErN+jQv9eTm+F/3ZLXFVloRdb1ni2FAROybLLBm1W3lXzJBkI8/7dPDk9wW3e/hbyXo/ExA8JFMLXZdJMX1A63v5nGr484XNrcQwA63dZYmleOIStiU85PG3bj54JvoDs1gMsqkesp2eGea++TshpFFIubHbjUmxequ3JNkyiOebyZwH04R2YcLZocSeabLsrTUT6ofzTsDUEBpeVUJC6nbJT/OJ5yvrsVjR5VWDRs438KbvMovbHIN8P+8kZuyklvid2bQWL52R/sE2B5OiKD53LCpDicVgqaQxdqiNsNopOSAlv/jIsVSqDzesJsyS7M7xs8MxDoPSnQqMhQTE5GUP+K92WNVzTG6tDrciOwfVjYWINgiS6Wq2/wmBVsC+J2jDUZvWIfXc68gkH3Y0W1PCfibg2kHm9HE15BGHuzT8fUfLwiVMfZbly+bO+kcX0XWPAWTRdu4NT5cYCzzihEQm3N+gqdL31Vh7STADJN6DN28Lr1oq5tJPbaUhJYKnSDy9b3gr0GZXRYk+6satTKgw7OaA3VA7NtkIRcQ93f5KEZdLbxk8KGBe1H2uWadz65VYr9XD+dU4CcfRwHin7n5cbBwaRpmE7AAMDNT7wQsWJabTpjR9O1Gxh3gQ5KJqg+G7EhaGzEGpBrasBL03TByVRFiBRbHHQvr/hLy68bBQAZ0OKpb5vRiUJe+Ivdpy9mtOn3syKXnPQxwONlg6nkQE3LA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(136003)(376002)(366004)(346002)(39860400002)(451199015)(2906002)(38070700005)(26005)(9686003)(8936002)(54906003)(478600001)(110136005)(71200400001)(186003)(55016003)(7696005)(64756008)(66556008)(66476007)(86362001)(316002)(76116006)(53546011)(52536014)(33656002)(66946007)(4326008)(5660300002)(66446008)(8676002)(41300700001)(6506007)(82960400001)(83380400001)(122000001)(38100700002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UFn3Bfud3Ay/2HJBxvO2XxBckkkFWBOwF1iO5s6R/71AQrcfX8kiaDTivcWM?= =?us-ascii?Q?APOn8oVxEMS+zP6LhYmvwFyWOQS9BMHQPN+Gn8v017q8YjwMCStHL3e2ABj2?= =?us-ascii?Q?jmHn/zuDR7/OS9e1AH6tHXzpaC92thjZczOyLnj/i49ZUHwLp/w3gzMTstDU?= =?us-ascii?Q?VICi1AXH2QeUmNJG7tY7CLZ0PYde3cIk1sQ+RVqbeiExFd6mLbGVZMaWnpET?= =?us-ascii?Q?s/PXcYzXH2HYCQ1TQecKqJgBcT1uJuk7+BwcTyDzgkPGBK5r9usvVfujvuzb?= =?us-ascii?Q?oC/irQmpdPXE9+Prc/1ahoeD9JPZMglcyqyuoOWLE/sZVgCo74CtFhJ0khrR?= =?us-ascii?Q?bYtQ4z3ziDCU1CxichhaTd7rNcFjkM3piPqNYjhGcAbQNcMqOMOgNF4PyEgN?= =?us-ascii?Q?FlICrZCZugNOhaY1gv2JbdgQplz5GAHmvjFfDY+g3Wh5eog79p9M6a7/ed1v?= =?us-ascii?Q?vY2uuS2TY0TdW8V7E9ekEsWaPqmK0nXYt8UAw3LEX0kPMD0mtD18aakKnM1S?= =?us-ascii?Q?TvI6l0ewpAKCqIbN/UYqn+lRlZaC3zc6QlqvKXaO4zS+gyuAFBxrZkUOoyqn?= =?us-ascii?Q?KZJWq2KwuryF98y9OShsWk+D6RFO9KumuTeKpA2Dlut17A83PLRRIrFBjwZp?= =?us-ascii?Q?GVA2QUVm6tgEutO1o+3TzNC4Mc06xN9pn6QRKh7FoRB7oXyZwpqNMdAwSLrx?= =?us-ascii?Q?wwEYxGdNYuEMTT9qnyB1KIbeBavyLCUfnWgf25nXXWcfVa7JffN4gowXfnDs?= =?us-ascii?Q?MVJfM6Vwoj/IkYydwfHBTaFag3gX9l6PC0x1mDbNg78IMZVpQ7N0OzS+vVYa?= =?us-ascii?Q?/nq9Lz72LBuhhRaQnHSw1OmD5OSyGD7Jt7HPPFCxCuykOA0r60koU0heh1yV?= =?us-ascii?Q?WdbrcX0tcYrCEEu/a5FR6DVL0Fw1Jzp0pZOhUy10thfn7EbDQv6YJq+LDC6N?= =?us-ascii?Q?Kyc28A5Fx1fnofC8PbGc7g6EeNasauTlmgld+XTcInpiObGZfoqws0HcvyLF?= =?us-ascii?Q?ranfR7pbrlRAB8bQmJK3i7SGycDIcoqkZcVA2JydJMSxwJbtjQ8ZDpkLCHic?= =?us-ascii?Q?YsgpBf9trVK3736WOuO3UpZDUUDfaAdQaJoRGehtEj/4/VAAqDjIAQhpSHMV?= =?us-ascii?Q?lGGVrf/urahbFlxcfffL7pP2mW68cUGIOyO7dWWhgV1OT+5brNvBubatfi/u?= =?us-ascii?Q?p2Nprgq+yGgtbLTMsApAZN0xQaA686cac3SfzJvIGmK7xuVIW+QJvz4KxhoV?= =?us-ascii?Q?c54o47T6DfZxhoE7l3osy8uLvcROHZlwXqiHiX+wBO4JEJFSiFRugpgHEuu5?= =?us-ascii?Q?knKeN31lPVjAUJ/6ID4XjONtZ1RWNlN8eZPG/xaFFmJGVNQB809ivigDRNx1?= =?us-ascii?Q?Oklk6eqiquOCcbFFu46z/uUs+lv2zob5F6PrpU+16BmL5uR23Q60pXdXWaYh?= =?us-ascii?Q?mJxeSKndnpwX83ZO08q44D2560gErCW09Ptg4BwAENT8N9aeFg39XM4jadbm?= =?us-ascii?Q?ALbg1vPB6mSSV+tZ3jvK/mqmws81RLNUarLPot5jea7XSa69XOhk6tRGMwvV?= =?us-ascii?Q?O7R78Opud0vr2Bx8XVeA2HdBDy/MndVIphPPhRZ+?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c274f609-c5f9-4643-4383-08daac297fb9 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 08:12:26.2518 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: N16//dT+r8cUWm1LqtQVxmC98hCGx3B1Jy0k2RfsA80KX6KXNlDksPv1ktYjHDWtPjQ3RZhHzcTCBsggWSwA2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6840 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Pei, Andy > Sent: Friday, September 16, 2022 2:16 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coquelin@redhat.com > Subject: [PATCH v3 5/8] vdpa/ifc: only configure enabled queue >=20 > when configure the hardware queue, we only configure queues which > have been enabled by vhost. Should be capital 'W' and 'When configuring' With this fixed: Reviewed-by: Chenbo Xia >=20 > Signed-off-by: Andy Pei > Signed-off-by: Huang Wei > --- > drivers/vdpa/ifc/base/ifcvf.c | 3 +++ > drivers/vdpa/ifc/ifcvf_vdpa.c | 16 ++++++++++++++-- > 2 files changed, 17 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.= c > index 7efb408..619b034 100644 > --- a/drivers/vdpa/ifc/base/ifcvf.c > +++ b/drivers/vdpa/ifc/base/ifcvf.c > @@ -246,6 +246,9 @@ >=20 > ifcvf_enable_multiqueue(hw); > for (i =3D 0; i < hw->nr_vring; i++) { > + if (!hw->vring[i].enable) > + continue; > + > IFCVF_WRITE_REG16(i, &cfg->queue_select); > io_write64_twopart(hw->vring[i].desc, &cfg->queue_desc_lo, > &cfg->queue_desc_hi); > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.= c > index 376239a..b00afdb 100644 > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > @@ -284,6 +284,8 @@ struct rte_vdpa_dev_info { > rte_vhost_get_negotiated_features(vid, &hw->req_features); >=20 > for (i =3D 0; i < nr_vring; i++) { > + if (!hw->vring[i].enable) > + continue; > rte_vhost_get_vhost_vring(vid, i, &vq); > gpa =3D hva_to_gpa(vid, (uint64_t)(uintptr_t)vq.desc); > if (gpa =3D=3D 0) { > @@ -499,6 +501,8 @@ struct rte_vdpa_dev_info { >=20 > vring.kickfd =3D -1; > for (qid =3D 0; qid < q_num; qid++) { > + if (!hw->vring[qid].enable) > + continue; > ev.events =3D EPOLLIN | EPOLLPRI; > rte_vhost_get_vhost_vring(internal->vid, qid, &vring); > ev.data.u64 =3D qid | (uint64_t)vring.kickfd << 32; > @@ -1058,6 +1062,8 @@ struct rte_vdpa_dev_info { > struct rte_vdpa_device *vdev; > struct internal_list *list; > struct ifcvf_internal *internal; > + struct ifcvf_hw *hw; > + uint16_t i; >=20 > vdev =3D rte_vhost_get_vdpa_device(vid); > list =3D find_internal_resource_by_vdev(vdev); > @@ -1071,11 +1077,17 @@ struct rte_vdpa_dev_info { > rte_atomic32_set(&internal->dev_attached, 1); > update_datapath(internal); >=20 > - if (rte_vhost_host_notifier_ctrl(vid, RTE_VHOST_QUEUE_ALL, true) !=3D > 0) > - DRV_LOG(NOTICE, "vDPA (%s): software relay is used.", > + hw =3D &internal->hw; > + for (i =3D 0; i < hw->nr_vring; i++) { > + if (!hw->vring[i].enable) > + continue; > + if (rte_vhost_host_notifier_ctrl(vid, i, true) !=3D 0) > + DRV_LOG(NOTICE, "vDPA (%s): software relay is used.", > vdev->device->name); > + } >=20 > internal->configured =3D 1; > + DRV_LOG(INFO, "vDPA device %s is configured", vdev->device->name); > return 0; > } >=20 > -- > 1.8.3.1