From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 960C3A00C2; Thu, 3 Nov 2022 03:37:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2CA1440694; Thu, 3 Nov 2022 03:37:41 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 0A38240693; Thu, 3 Nov 2022 03:37:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667443059; x=1698979059; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=9TgFoeOxNXU4I6hG0yVWs4gOngXRnDNYXiu5D74h4Lk=; b=SLhecW9jan788rwfeplpp1QTAH+k93GLbARt34T/zPYVbgC1a3CSxrdv j86Xwedq/Gw1Z9maiOm4ENs/G1mljwWq8M3JE356MEbGPOA5tQbiSFXEN 6Lb7hPTVGe+8tifU6axpbg0r1H6067cWyTHqPDjftDH1AjtnC4qRuq7nN hyAffixUSllRP/SVAA72pbqaAU3jqlW8VIvh7tpKJ4MPO1rQa1gv7lm3L 5nwJ6HqHTWswGWo0WHRDSyLwlXBRJz/6tJ1snutz72ViOYSpY+CUlt3eB U3/EjVA5yg7C80WcDN8om+QV9h2gMQsQMbIXmuS8QPB/a2//duvl5UTZU w==; X-IronPort-AV: E=McAfee;i="6500,9779,10519"; a="310681725" X-IronPort-AV: E=Sophos;i="5.95,235,1661842800"; d="scan'208";a="310681725" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2022 19:37:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10519"; a="634499576" X-IronPort-AV: E=Sophos;i="5.95,235,1661842800"; d="scan'208";a="634499576" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga002.jf.intel.com with ESMTP; 02 Nov 2022 19:37:37 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 2 Nov 2022 19:37:37 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 2 Nov 2022 19:37:37 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 2 Nov 2022 19:37:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NDdxJCnpv7wToKCgWb9tucbt1fv/gqmOFWV/XNIIWxL908V1Oek01A+G371zkBN2Ra7QjtRRBa1QjGP8+YTRtqY9OduWYWoyjQtv9yiXPIP6y71/tsp9qLm6C4/a+OsVDnrBMgDIAAQARH2TWMnKOAS+SAmiUsB8oJhNKWI779Gtssa3PXKE5i3QQPstOk0c5fqOZ8bSUWU5ytS6xhH3VUbT+aAMBLXObjn4GlS0s8U3BR8zuHZ25dCDBp0RmamZM5a8imJf1RvhhcaGOahyhw8r34ATTkE+HoilffPdjiR0oyhWcrBuJOORYzLQG0M4/Xr/tbC5EQwEyxBV28s07w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d9oVxVOB7TLrZ9oX9Jb0fzxylT+9iubzr6e3llxL7kM=; b=oOCmsEnXEf97hzNac7KUIRdJ5kFue+oOys396b3ACU3U+hv5UzZmVcmCWoM0mDnqcqC0peuOc6hFC395xsB6kz6gOd6rQBGILhGFaFmAZhShz9jFsK3YXaqoCSM2tyXD4rt5mgf4YKQFleYKXTCHhLd0AtO17LK2E7EygAERKScsLs5W2Tm/e6zQdqT+m3+YGFDfel9wo72EdQXwRlcDMGoJRzwINWOF4/2/UDEcFOcRQwhBt9g20R90TAf2+iWAFwA2XZay1dFJvEtI1JoK+38N59cW5iD7YrJvrsn1RPUZnlnxbhFZAO7xtX8GsQIXN+W1wHsYSAOPuzfrEKbsKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by IA1PR11MB6324.namprd11.prod.outlook.com (2603:10b6:208:388::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Thu, 3 Nov 2022 02:37:35 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::3c6a:7a7c:129d:aecb]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::3c6a:7a7c:129d:aecb%4]) with mapi id 15.20.5791.022; Thu, 3 Nov 2022 02:37:35 +0000 From: "Xia, Chenbo" To: "Maheshwari, Abhishek" , "maxime.coquelin@redhat.com" , "Wang, Xiao W" CC: "dev@dpdk.org" , "stable@dpdk.org" , "Mandal, Purna Chandra" , "Pei, Andy" Subject: RE: [PATCH v3] vdpa/ifc/base: wait for queue disable before saving q-state Thread-Topic: [PATCH v3] vdpa/ifc/base: wait for queue disable before saving q-state Thread-Index: AQHY7qVLqvgYo8fuM0KwZjtjsGuJjK4sfM4w Date: Thu, 3 Nov 2022 02:37:35 +0000 Message-ID: References: <20221102032215.2108558-1-abhishek.maheshwari@intel.com> <20221102095458.2165448-1-abhishek.maheshwari@intel.com> In-Reply-To: <20221102095458.2165448-1-abhishek.maheshwari@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|IA1PR11MB6324:EE_ x-ms-office365-filtering-correlation-id: f1239924-3fff-4fd3-4a90-08dabd445db2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TC0lS0/6pFidloN3Ail/6UnmelKF7h8yiEr/cMCaeCYvYExhKJu/uj8UXaTNTSXlfjZYL1epZMcChgbSiTfihgTcBr2cu9fHmhMXs7TS2r3rYzc093FqlFDn85LqCP6YP/sB8iq2TRsPOXypzwsxj9XXcTgvjFvqKLPX1a0ly9JaJG50mFM9j1+fDqJwFMLuVQsFrCl+im9fkM0BwXGu4q7R3moPmMO/kFJ0gNfEFKgF9hOLn59Lja0zx6ek80r/YseMugktnqyqxvfOly0AnImKnZ7N9DpNxtwMBSwNc+zedvMh/6Fb63vVdNILtOmAmVi3qv0u30KWHMtxwF97vF0ZJOGsthQQNCDlMvC6tWBMZ1fOj8xl7qvRkDiAufSK0U0/9BkJMG6PzsMBmaerSeSgdPdlKnLTpFgRLhvmqdr1fS2S2Tn40x0z1cqnrgGLQU52kgdEcNt1IwQ1CjliPxz5E2MzytgkJH4dSdgTS+LLffP/zzVLBQGZpPMCqAMH/1XKvFg84xqqfE0+Ez3OyQnDNm8plQH4gAcG2bzuHGLZ+/OeXjayqjyTSSf6shdST5FlD9X59Jj72ZdOMj3hmgO+iL0JJUNQzmqJ2/gjZ/w6pN5l8e/xaDkwMjzURtlcF9qdQfH4Zj3+J2i8B7W3VdJZfQW85nwNSuqY/LN1Z4AM5VJfh9WzwAeJ85AhQ52d/3Qj/WFD1OJ20jDlZRMoDeTIdzG/h2B5xcbiDrdwlX993ilOfhsWW/QuN1VLF9EWVDS6t4H+/wi9FNHxJc5H/Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(396003)(366004)(376002)(136003)(39860400002)(451199015)(82960400001)(122000001)(478600001)(71200400001)(38100700002)(2906002)(83380400001)(26005)(66556008)(64756008)(76116006)(38070700005)(8676002)(55016003)(4326008)(66476007)(66446008)(66946007)(316002)(86362001)(7696005)(41300700001)(6506007)(186003)(6636002)(33656002)(53546011)(52536014)(107886003)(110136005)(9686003)(5660300002)(54906003)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nNCv3Iy+DeXKC+Tj22n0nZEUJxuDfipthDgYhj4/L3fMCGR7MA0Nrx711O2z?= =?us-ascii?Q?fciPVwM9cEFDTVeRdsMsS1qbmzgOghvm293Ot3A6Byyg7eI5Uxg4tzhjje6m?= =?us-ascii?Q?lpx8a9pMkEMuX+51QGrIF1+DEpyIa7TyFN9HVHMdQhGyaFsEXTJ0eWn1/D6t?= =?us-ascii?Q?zOM1D1QVCkuf3/f+fvgUXjzSdN0Gr772ue8WSGXAADMnAE3THz3cahfg16kP?= =?us-ascii?Q?mfYqZlU0YkKlzbgyhLqG3x0Sixah7746et5T9TZg+vCNbvr4HVFUF2TYCHPT?= =?us-ascii?Q?R4rnZ8h9rqUVDs6JA/nNCyNN25KVfWNrebNsmc1w3Mtsftt4HAyWbcE0P0IV?= =?us-ascii?Q?5NJV7YWerElveLWdApa3eKEFB9ZbuFx2G+wbwnhDILTZHs/Q1TeI1jVO/vy7?= =?us-ascii?Q?w7yyVLP3R0ITdUbkKwaDUuhjX5x4NIUfyjhTaMadEOeCfVbVwgGH0lISKybP?= =?us-ascii?Q?ddt7pEucs6ik8hgTME6mTGiSttbJPqkAmVyiF5CqVctVYrOu5wFz098uCNGs?= =?us-ascii?Q?DijDpVhX+ifB6zmqq0tO97lEqE3v7pzDmGR0Et06otOQUO2Zhce9qDDQHYU/?= =?us-ascii?Q?je+KI0Rs3qr/2i1wvhaW8as1FPa6MjqBHasrBQjxPQE1DPrhSYuc+UIcAKKG?= =?us-ascii?Q?0VP7XSJu6W1483sTI7nKc7kXsZYrgoQs2RtMXpzw6aJCjRg3W1iGm2J8WumI?= =?us-ascii?Q?jgd8R7k3Got5iBmlO5/BumSLwT1/rqFyJ/CHNxeTJs5RgHxjWNq+gZVVQ3w/?= =?us-ascii?Q?CprI4OsousrHD9dlwSyPRV9Eb1EBP9WCI7k0evapcRJHpxVF+ZdRhSJ36Q62?= =?us-ascii?Q?SR1/Tdl01aOJXAvh3pcN8WkmTBiLhrwHIuZBTp3CD5bF2fAjhWzGgVYnR/zZ?= =?us-ascii?Q?MyzE2j2JPHXPmFQS/LkkACVn66Rj4d3CnMdgj7o+iqoChkzt5j5CEyOhEgXL?= =?us-ascii?Q?vDEGrxf4zC8s3wkT/owoDHNeq9b+3XcePkBDxUfkU0R5tk8A39RfzvzTvKG8?= =?us-ascii?Q?Os6ADgMftCl2LFYLEMyuEeF5MWago6MpGMXHJaYt+WBsUoAxmYNM9dQzKN7Q?= =?us-ascii?Q?+iu3Y8mG5aq7kpTm+DxK/9ctzvoDhuxh9RrhdSa7JZFRqekfPPbVoSnULVwF?= =?us-ascii?Q?KT2TrYu07uOdQHZoXdHccckmlfIZTu86ZbZnA7IltHstkONNNiAl67xMtMAA?= =?us-ascii?Q?mdIybGKT7J9HbTRcan2XRpyn5OsYGbAR7vNFI07vCJINhmYbOA9SUwBV9G2q?= =?us-ascii?Q?5Qrv5Ns7YzZctBjcWZ3PG0FvH25pcSNAIDbcg6mzcMyLkIzZzYAZo2+iCZZM?= =?us-ascii?Q?CWdLCUF8+Fuu2HyFBiBqm9ycWpZoLHpFdBmtDgw/9ojp6ZgQ9fAC3N63R/Mp?= =?us-ascii?Q?Hlgn8xQc9t4YRyu51YfgkY/ayjJNN7Llokdx112WCxqRtXcuTGmRGlDc2n1w?= =?us-ascii?Q?IWHUtCqbV5wVel7Wo/6ZQ7yxN2xPjlHnM0UtJSXw5HGdt5yb9KXRd1NalI9l?= =?us-ascii?Q?uqaYhTf0w9vE/L4L+htmulb++1cnRhyFiUenDtIQBo3UmCrUNXvJjKiDcrCI?= =?us-ascii?Q?eQn7mxkIzxlb0mzFj8SeafjvEsvyWflGb7vBX4Lu?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1239924-3fff-4fd3-4a90-08dabd445db2 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2022 02:37:35.3581 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: q+8UA9dvrLhxSAfRCYPuFnfDCGfoaJyF7fM3E/C47bG/9XJwH1efwSqCfkgycx6UaAZOH4BV4qlvOO8gClz+Tw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6324 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Maheshwari, Abhishek > Sent: Wednesday, November 2, 2022 5:55 PM > To: maxime.coquelin@redhat.com; Wang, Xiao W > Cc: dev@dpdk.org; stable@dpdk.org; Xia, Chenbo ; > Mandal, Purna Chandra ; Pei, Andy > ; Maheshwari, Abhishek > Subject: [PATCH v3] vdpa/ifc/base: wait for queue disable before saving q= - > state >=20 > Some ifc hardware require synchronization between disabling a queue and > saving queue-state from LM registers. When queue is disabled from vDPA > driver, ifc device stops executing new virtio-cmds and then updates LM > registers with used/avail index. Before saving the queue-state, vDPA > driver should wait until the queue is disabled from backend. >=20 > Fixes: 5d75517beffe ("vdpa/ifc/base: access block device registers") > Cc: andy.pei@intel.com No need to add above next time > Cc: stable@dpdk.org >=20 > Signed-off-by: Abhishek Maheshwari >=20 > --- > v2: > * Fixing the styling issues > * Addressing comment to avoid reading the register again after > exhausting the tries >=20 > v3: > * Fixing warning condition > --- > drivers/vdpa/ifc/base/ifcvf.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) >=20 > diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.= c > index f1e1474447..06996fd5d7 100644 > --- a/drivers/vdpa/ifc/base/ifcvf.c > +++ b/drivers/vdpa/ifc/base/ifcvf.c > @@ -257,6 +257,7 @@ ifcvf_hw_disable(struct ifcvf_hw *hw) > u32 i; > struct ifcvf_pci_common_cfg *cfg; > u32 ring_state; > + int q_disable_try; >=20 > cfg =3D hw->common_cfg; > if (!cfg) { > @@ -275,6 +276,21 @@ ifcvf_hw_disable(struct ifcvf_hw *hw) > continue; > } >=20 > + /* Some ifc hardware require synchronization between disabling > a > + * queue and saving queue-state from LM registers. When queue > is > + * disabled from vDPA driver, ifc device stops executing new > + * virtio-cmds and then updates LM registers with used/avail > + * index. Before saving the queue-state, vDPA driver waits > until > + * the queue is disabled from backend. > + */ > + q_disable_try =3D 10; > + while (q_disable_try-- && IFCVF_READ_REG16(&cfg->queue_enable)) > + msec_delay(10); > + > + if (!q_disable_try) > + WARNINGOUT("Failed Q:%d disable, Saved state invalid\n", > + i); No need to start a new line here. Thanks, Chenbo > + > if (hw->device_type =3D=3D IFCVF_BLK) > ring_state =3D *(u32 *)(hw->lm_cfg + > IFCVF_LM_RING_STATE_OFFSET + > -- > 2.31.1