From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66D62A054F; Thu, 9 Jun 2022 04:27:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09DC840689; Thu, 9 Jun 2022 04:27:09 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 23C9140220 for ; Thu, 9 Jun 2022 04:27:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654741627; x=1686277627; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=GFRo+5LSabIX4bD5guh2sTyEWiVPU0gxwHVtK91m8TI=; b=Mic2Y5UQjJKYgG8iAetVi5RBaL+X6n4h8tO0F3+ViAPO4bzbtRipbdLl uGb/u7zOqhWk+D7zb5wVNE0T9h2onke3uzGkNyipbPZFM4g6rvz39NWrv lHszyq4vWP3A4Bu3mjYzhl2p2GSN7JdSGwwkOEw/Bh0JvPY3F88d/cE6T nv5sfKELbI7z+VGED9PExNma3liuzU5wBBVbX3NdebiHGdSRbXAwBacxM wJuepj9R9kh2ZTMZloFaDlqPy1BtpuYPdaUY68x4f5qMuVinL1EksKCZb as/QnSSwVIoXWIaaL6R8oFRyXbS3/UfyCxqaKVpgMZOntwVjUGs//4nOc g==; X-IronPort-AV: E=McAfee;i="6400,9594,10372"; a="338892129" X-IronPort-AV: E=Sophos;i="5.91,287,1647327600"; d="scan'208";a="338892129" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2022 19:26:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,287,1647327600"; d="scan'208";a="566181705" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga002.jf.intel.com with ESMTP; 08 Jun 2022 19:26:53 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 8 Jun 2022 19:26:52 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 8 Jun 2022 19:26:52 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 8 Jun 2022 19:26:52 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 8 Jun 2022 19:26:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T8M63q+qHaI0BWxKaR7I9VmL24zCHWhLn2yyBl+pw1g6BqM7nrn5BEr8vN/q2TJfQyGlVIpjolucBFE9kVY/RIXqzz4XvSWM+U4Y5P+0Z1NEOKhOo4CYxCmP3UISbCRY4zaEa6yXUw63uKnGev5bnJ2YFgcj6j6cRHiT6U2HK+a1kjx2FRTb6q1o/Mm5PkvG58gILruW2gmLi3exNtmR3AvE/5JjZEM/LkmZVvevbsSfn9KxZFnHMgOdUnMxonTXsdyy0idwuIgvlEQObWD+FcCoEGPT2YkpAjjP09daahAt/m8qCjaWJXwL1wM023GXNahq4GW/OIg17MkfsG/bBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XU4RrPVvV3mnhUt9MQqNEdrPs4fz4ND1YlrsuLt57Qc=; b=AFRmNtiwfYX6TjNSuCw/+XWOnAVt8IYbMXyCkNfXKSzk3Pz5K7OxW7qpkJsaLciw396YS1wEptPz4CqFS2hCPXcO/ywud9Vx2mrmTPEvA+xyfXdoquypYhBwDxwR2OYb9VKDEMdNIWVgIfKD5Cmwhlo5Xzwl8x79adyY7bW+9LSUxCCI2ELnMsiVSEktaAgW34Cyb1dWHo6w/5Z0o851h60VnRs0AWOzIJDnlXyRT2C1Gn2NpyFSj78zqcS+/BHd0UiX4gMtSF3jP1qrjHkh7iTN0hykM3EB7JwOL943pndS+WczK1x9tjwPoVS1Im21XMhzVTH8fHDHAKsV1r38Ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by SN6PR11MB3182.namprd11.prod.outlook.com (2603:10b6:805:bf::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.15; Thu, 9 Jun 2022 02:26:20 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::d4ff:ac50:621a:60e7]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::d4ff:ac50:621a:60e7%7]) with mapi id 15.20.5314.019; Thu, 9 Jun 2022 02:26:20 +0000 From: "Xia, Chenbo" To: Maxime Coquelin , "dev@dpdk.org" , "jasowang@redhat.com" , "david.marchand@redhat.com" , "Matz, Olivier" , "Ma, WenwuX" , "Zhang, Yuying" , "Singh, Aman Deep" Subject: RE: [PATCH v2 6/6] net/vhost: perform SW checksum in Tx path Thread-Topic: [PATCH v2 6/6] net/vhost: perform SW checksum in Tx path Thread-Index: AQHYezZTW5vJMGYo1UypFmW2qXY6eK1GVyIw Date: Thu, 9 Jun 2022 02:26:19 +0000 Message-ID: References: <20220608124946.102623-1-maxime.coquelin@redhat.com> <20220608124946.102623-7-maxime.coquelin@redhat.com> In-Reply-To: <20220608124946.102623-7-maxime.coquelin@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dddc3a6a-978a-42a0-3b34-08da49bf7066 x-ms-traffictypediagnostic: SN6PR11MB3182:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9qfNmOztulcbRzfCUooZ6usxZ67ogiAaea13RB2+cYPNVl8KTZVFSe8TUC29YqYccIPsiBDLtZ53uuZSV6lbPOeif5d5rR55cStOZtqErc3bBT0OFTJP5sXZK9EYf100oHQdtwF4Jnx6hRcxtdxxqCFo3fBeCywIrqVQ8cu1SK/9cXBord0LwafFSgHOt+EkiKWeiWNjzEMXpRkrMtWk3f+vS3MnmqdopZZlw0zM10dagBwwiiFEIFATpzb/mC1y5jW0YFZ1ybrSVEFgr95hG2gH51a6YsYYdTd2373UUiezrt0v8v1E5Yv8JM7CitairKXn1VdigRELuHRDFgR4ZqMdKmumllcntMGE3YzUsq/Eot5koaHRTXoAhlX6M7TG1f8bS3ovu9xHyi2n64fAB03K0ONNnvtiTN01X4TeHAkiFG8qR8Fq1z/jzUdY+w56+JU+RUR+JoR1kDTKsL3zbRZlQmN0j29FQKmntjlspadFeS0k3nls/JwY5E5MMCQFaKRHCEJ2Z1E+zo0cXPspUAqWSkFUpvPgAZSWefAyu6M27ByZfoM+QFpvXLRDIyD1+pB6+aMD7avv28Pq/ob43oBgIRukKzlB9fChQEPYrbgH6L/42Q+Qhp20YBJ79/c3PtFJBMQ9OFDDndriyPE34sCAVt01C9JDVCjGLeSOVDe5yfRL0+pGNYVW9l1YCSV3qRNc7G8uhLl0UWWgy7S0jBV4oI1iekVMMBZ+Airlkcc= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6506007)(38070700005)(83380400001)(66946007)(66446008)(53546011)(186003)(122000001)(38100700002)(508600001)(26005)(82960400001)(921005)(55016003)(5660300002)(52536014)(64756008)(7696005)(8676002)(66556008)(8936002)(110136005)(316002)(76116006)(66476007)(2906002)(86362001)(6636002)(71200400001)(33656002)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ex13Gpz9hWbxOG1Je+9aHYfN7bNl08M/Z9tA3gI2CbNib7HxN0EjoApKq1w8?= =?us-ascii?Q?+LDIJXpzSE1R5hKcu4sOsLYY9JcQCjpB5659MEE9SnEF+G5O5RAZv8KTDqQF?= =?us-ascii?Q?pofpFPWNT6gzbgGVHA6cMSDI9hsqqX49XEARrVfIgTjKzgSCYSglUy8qNmx7?= =?us-ascii?Q?SdVLCrEKuAem8ixJ1xFESG4ov32RXoef4E1qY42I6AVVmrPIe1xs7PeS02st?= =?us-ascii?Q?WGRBKE3Mn4yT4RFLZioY3K8miVWlms+MfMFunsyH/80PeUXDpqT/ZrA4OigV?= =?us-ascii?Q?XW9NxSfRWzResgJiLI7y4cgnanBzCh4pdLQRCFlKlD2u/EnP/CpRjMITgL+d?= =?us-ascii?Q?+139RqNQ7MxdNQ4UvLy1AYem2JfEOVFvXTriP4adsX4/kBaC/f+kZvQZ9LPX?= =?us-ascii?Q?kKkjv3Hok/JY7ltH/hVbyCccG2xIsftt2ntXhOvaFxY2pjj3/gX+znm/Cs8E?= =?us-ascii?Q?43OwmXzuxZtGSCWG5kcMY0XKpwISNwje4GeEq/Z0FKfzjcWhEVqAJSHCB9dj?= =?us-ascii?Q?3Mo485iVV9vgLw4uTM0tSIIwG0A+Mg8JYALYw/w9TKZ8gcRnXkr4A05YVoXP?= =?us-ascii?Q?e0O8HDC/qV/F3FYz5gEDUo6oyNWuABrGimI1y6ApNuTClNgMjTFDjTswUDlV?= =?us-ascii?Q?5qvXpVX2n1RFC9gxiG/DTZsTgBoYhm7PHmQcVNPkG30uHrjDl7eo8DwWZ4Yk?= =?us-ascii?Q?Q5hytwiSS5krdYHM+02pYEa7/FtE1JDcjH3WD+IhMECy+pTJWCi6lI7dH8BK?= =?us-ascii?Q?2ILC0BvjM2yhCEN18WyXyn0XOXOKY01QLt547ZkZOpe4D9MOkxh2C8qUrE2F?= =?us-ascii?Q?iYVEen2ao1gHBtpexrOfSsOr1MWsomGNX7HCGHu+WuIF/934SoHH5qZUJp0u?= =?us-ascii?Q?uU02az+0rfUYVlF81bDNj73EMAgDldq1eMpi927dGcqnVPVOWVlafQCpBskN?= =?us-ascii?Q?nJ2OfWt1y59h9Bly3+9tdC+5YMwxihSoNmNKdHctKwxtusqLEVKra12vKq7q?= =?us-ascii?Q?AuueBynrDpK7CNLZyu+DzmT75fskKkQusWPWb1bhMTteugMX5nFUDLcZUejX?= =?us-ascii?Q?4k7b3s7dP15yRj4FQcF4HnmL/3Tam1srwKbt1J4+zV++4BFui7O9x7rnYhLx?= =?us-ascii?Q?3n4CMbw2XilBVcEHKyx8clah/4iDoUXkOLsoNUSekAHPt3Jc1wPbeEp7kVJc?= =?us-ascii?Q?Ws0tgLhtTHQdD93OCfdtz0FcJngBOW/TyK3QtJY8thiCFlYBB/zG+KmgaD0n?= =?us-ascii?Q?m1+CLnzbx+a6+aG0tKLHqh5obSAJufwtZwAMmMtokLu7iqIhQ04olwGqaNaq?= =?us-ascii?Q?ZsTGY1Bk0tyZLecXSmI4eZzIFd9MQKVo3OVN3ca0u9d8vJwlu8bS/HoSqfET?= =?us-ascii?Q?O3rWQzlool/aM58vzRzXOHSvBfKl0Nd8iZX9LAZ01ECcU/6g/x6TBfzlQGCD?= =?us-ascii?Q?U2ESFscZqkWcRuWMkntau8kqzu/EOjyITWrO+mDIvwoU3NlPBS/YMjh/vtp4?= =?us-ascii?Q?0E0mSsI+1e00jw1RPuywGnX+lgvc3NV7nELRSNN30vZn3Uew90Tj1kIAS7KX?= =?us-ascii?Q?czQCYR8DhmrW4seqHBo3JmYXJKeWJfXMJ1c9/CE/rxK0zw6V8RVEZ3GzcTkm?= =?us-ascii?Q?79Kk+grr0+72E3imfpBdMj3/wJcsZF2oVOI/ucPYXezik/RpUB40BaTBhKCq?= =?us-ascii?Q?NyZwZl0WwfiLZFQUP5+QAJ/6gBH5xQBImpRJr0NAdQzIt5ixuQbZjfIO1vSd?= =?us-ascii?Q?fqOKiQ3ZeA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dddc3a6a-978a-42a0-3b34-08da49bf7066 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2022 02:26:19.9050 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jd9niQ4mO2uNFTsqWRLW6SyWkUaNYNeTY7dhOrQjCfVHOim78Fv5rzp/v2LdPSOtj3+AfguLsUaj+HQuXR9WhQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3182 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Maxime, > -----Original Message----- > From: Maxime Coquelin > Sent: Wednesday, June 8, 2022 8:50 PM > To: dev@dpdk.org; jasowang@redhat.com; Xia, Chenbo = ; > david.marchand@redhat.com; Matz, Olivier ; Ma, > WenwuX ; Zhang, Yuying ; > Singh, Aman Deep > Cc: Maxime Coquelin > Subject: [PATCH v2 6/6] net/vhost: perform SW checksum in Tx path >=20 > Virtio specification supports guest checksum offloading > for L4, which is enabled with VIRTIO_NET_F_GUEST_CSUM > feature negotiation. However, the Vhost PMD does not > advertise Tx checksum offload capabilities. >=20 > Advertising these offload capabilities at the ethdev level > is not enough, because we could still end-up with the > application enabling these offloads while the guest not > negotiating it. >=20 > This patch advertises the Tx checksum offload capabilities, > and introduces a compatibility layer to cover the case > VIRTIO_NET_F_GUEST_CSUM has not been negotiated but the > application does configure the Tx checksum offloads. This > function performs the L4 Tx checksum in SW for UDP and TCP. > Compared to Rx SW checksum, the Tx SW checksum function > needs to compute the pseudo-header checksum, as we cannot > know whether it was done before. >=20 > This patch does not advertise SCTP checksum offloading > capability for now, but it could be handled later if the > need arises. >=20 > Reported-by: Jason Wang > Signed-off-by: Maxime Coquelin > --- > drivers/net/vhost/rte_eth_vhost.c | 62 +++++++++++++++++++++++++++++++ > 1 file changed, 62 insertions(+) >=20 > diff --git a/drivers/net/vhost/rte_eth_vhost.c > b/drivers/net/vhost/rte_eth_vhost.c > index 42f0d52ebc..d75d256040 100644 > --- a/drivers/net/vhost/rte_eth_vhost.c > +++ b/drivers/net/vhost/rte_eth_vhost.c > @@ -92,6 +92,7 @@ struct pmd_internal { > rte_atomic32_t started; > bool vlan_strip; > bool rx_sw_csum; > + bool tx_sw_csum; > }; >=20 > struct internal_list { > @@ -283,8 +284,10 @@ vhost_dev_csum_configure(struct rte_eth_dev *eth_dev= ) > { > struct pmd_internal *internal =3D eth_dev->data->dev_private; > const struct rte_eth_rxmode *rxmode =3D ð_dev->data- > >dev_conf.rxmode; > + const struct rte_eth_txmode *txmode =3D ð_dev->data- > >dev_conf.txmode; >=20 > internal->rx_sw_csum =3D false; > + internal->tx_sw_csum =3D false; >=20 > /* SW checksum is not compatible with legacy mode */ > if (!(internal->flags & RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS)) > @@ -297,6 +300,56 @@ vhost_dev_csum_configure(struct rte_eth_dev *eth_dev= ) > internal->rx_sw_csum =3D true; > } > } > + > + if (!(internal->features & (1ULL << VIRTIO_NET_F_GUEST_CSUM))) { > + if (txmode->offloads & > + (RTE_ETH_TX_OFFLOAD_UDP_CKSUM | > RTE_ETH_TX_OFFLOAD_TCP_CKSUM)) { > + VHOST_LOG(NOTICE, "Tx csum will be done in SW, may > impact performance."); Missing \n With above fixed: Reviewed-by: Chenbo Xia > + internal->tx_sw_csum =3D true; > + } > + } > +} > + > +static void > +vhost_dev_tx_sw_csum(struct rte_mbuf *mbuf) > +{ > + uint32_t hdr_len; > + uint16_t csum =3D 0, csum_offset; > + > + switch (mbuf->ol_flags & RTE_MBUF_F_TX_L4_MASK) { > + case RTE_MBUF_F_TX_L4_NO_CKSUM: > + return; > + case RTE_MBUF_F_TX_TCP_CKSUM: > + csum_offset =3D offsetof(struct rte_tcp_hdr, cksum); > + break; > + case RTE_MBUF_F_TX_UDP_CKSUM: > + csum_offset =3D offsetof(struct rte_udp_hdr, dgram_cksum); > + break; > + default: > + /* Unsupported packet type. */ > + return; > + } > + > + hdr_len =3D mbuf->l2_len + mbuf->l3_len; > + csum_offset +=3D hdr_len; > + > + /* Prepare the pseudo-header checksum */ > + if (rte_net_intel_cksum_prepare(mbuf) < 0) > + return; > + > + if (rte_raw_cksum_mbuf(mbuf, hdr_len, rte_pktmbuf_pkt_len(mbuf) - > hdr_len, &csum) < 0) > + return; > + > + csum =3D ~csum; > + /* See RFC768 */ > + if (unlikely((mbuf->packet_type & RTE_PTYPE_L4_UDP) && csum =3D=3D 0)) > + csum =3D 0xffff; > + > + if (rte_pktmbuf_data_len(mbuf) >=3D csum_offset + 1) > + *rte_pktmbuf_mtod_offset(mbuf, uint16_t *, csum_offset) =3D csum; > + > + mbuf->ol_flags &=3D ~RTE_MBUF_F_TX_L4_MASK; > + mbuf->ol_flags |=3D RTE_MBUF_F_TX_L4_NO_CKSUM; > } >=20 > static void > @@ -423,6 +476,10 @@ eth_vhost_tx(void *q, struct rte_mbuf **bufs, > uint16_t nb_bufs) > } > } >=20 > + if (r->internal->tx_sw_csum) > + vhost_dev_tx_sw_csum(m); > + > + > bufs[nb_send] =3D m; > ++nb_send; > } > @@ -1267,6 +1324,11 @@ eth_dev_info(struct rte_eth_dev *dev, >=20 > dev_info->tx_offload_capa =3D RTE_ETH_TX_OFFLOAD_MULTI_SEGS | > RTE_ETH_TX_OFFLOAD_VLAN_INSERT; > + if (internal->flags & RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS) { > + dev_info->tx_offload_capa |=3D RTE_ETH_TX_OFFLOAD_UDP_CKSUM | > + RTE_ETH_TX_OFFLOAD_TCP_CKSUM; > + } > + > dev_info->rx_offload_capa =3D RTE_ETH_RX_OFFLOAD_VLAN_STRIP; > if (internal->flags & RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS) { > dev_info->rx_offload_capa |=3D RTE_ETH_RX_OFFLOAD_UDP_CKSUM | > -- > 2.35.3