From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28D4EA04FD; Thu, 10 Nov 2022 07:12:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B7577400EF; Thu, 10 Nov 2022 07:12:09 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 5C7AD400D4; Thu, 10 Nov 2022 07:12:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668060726; x=1699596726; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=9gOQkxEM7JErTlV1wUL5AmRikk0RZ5cqglqa16d94Lw=; b=DmEGtS6D1qSOPT82xZ0AAyAB85ti/INUJ33kyvF5c4JiEm/lkr2kC3qz n6oOMIqo27UmfcPwGo7M0Zhsss3veZcMwUZUmscI7qMePkqo3RqaVDm85 E4BcLwDSOKP/MU2viRwci8LBI6Ooc9OLmKTOfl6xqEixxEn/herjagzVp OkSnj8xqM4W/xS1HQNfUQdr59YVWRtoP6I58x7+YknyZ7skcNPebtNCg2 RrWiYV32Hjl0poBabglsGjjhsXGGr6bHJJUib9swZjEQGPaP38MhXf3Ra 2DDV89r30Kkk8YjMjXrCoFX2yfbnM9ps2ZzCpmq1zq5kccJXQKyWIAUEp g==; X-IronPort-AV: E=McAfee;i="6500,9779,10526"; a="375469473" X-IronPort-AV: E=Sophos;i="5.96,152,1665471600"; d="scan'208";a="375469473" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2022 22:12:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10526"; a="742724379" X-IronPort-AV: E=Sophos;i="5.96,152,1665471600"; d="scan'208";a="742724379" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga002.fm.intel.com with ESMTP; 09 Nov 2022 22:12:05 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 9 Nov 2022 22:12:04 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 9 Nov 2022 22:12:04 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 9 Nov 2022 22:12:04 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 9 Nov 2022 22:12:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BqGRrIdqaYyWgr1gY/C9Ke2q4drV3CYiW35L8cRqbq3tR2TBTmMrgOtiqGeJXagJ/ve8fkV89zYevnBPbc2BT8GftnQ/b9A/tSV4BbFdl2Bneq2E8ak1c987jjdMj7AvlNNvM4RMMU/AFITQ2A9W5u3F5M+Cd7xAmeCAkt05SvNmYCmdFMCIp4qyFatnfmHqYdlpmoLQS1/D8el9S0sVWSvFxu7sfKlYFOdc8gpouzq8jjyNZJoBrTWqmC3RGIio3MrhXh9oONMzioc1Avi3jOnXTbnhsKucFSnAVNLIgmA2xtXeG63hEUETKAiBUol4lge92D6BNvnJVfMowBFt3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UE5Vhmm4JpmraC0YOHovXaiG5H9W63qDmElQSnmYYk0=; b=kX/qV/HAZX8d1ZM9AvRfit7JvCfrTuH26KBJxA9WxO7hPtydu9QzeBxRguC9r2EPAHF/yFgSlphD2pNsMlPSmaLUDaVwuPzjrwMKvcjocwz9uyOmxemD7rqB/Ixva1u40SaWs7QZgn+D59V+XpoEfitb5C2nwlQMcMNeM1i2B51D7wPvul1Qxagbu5QpY5aaFVyyylQPd8jazfaMMNix9UbRzn+cS92WlTmdHphs2oE7F39cdsviNMBiRC/ez9GICv2InYuQcC2cuBCLCQdlVDFZw5ebm+T+4mZskw9fHWGlrKKrQpYM8tI0JzM0fNXUP+ZgcH7jR5N9t6TzkIRe6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by PH7PR11MB6835.namprd11.prod.outlook.com (2603:10b6:510:1ee::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.25; Thu, 10 Nov 2022 06:12:02 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::3c6a:7a7c:129d:aecb]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::3c6a:7a7c:129d:aecb%4]) with mapi id 15.20.5791.026; Thu, 10 Nov 2022 06:12:02 +0000 From: "Xia, Chenbo" To: Taekyung Kim , "dev@dpdk.org" CC: "Pei, Andy" , "maxime.coquelin@redhat.com" , "stable@dpdk.org" , "Wang, Xiao W" Subject: RE: [PATCH v5] vdpa/ifc: fix update_datapath error handling Thread-Topic: [PATCH v5] vdpa/ifc: fix update_datapath error handling Thread-Index: AQHY9Lpi8VgpeqppxU+LcpMiKb1yy643rMzg Date: Thu, 10 Nov 2022 06:12:02 +0000 Message-ID: References: <20221110040943.82876-1-kim.tae.kyung@navercorp.com> In-Reply-To: <20221110040943.82876-1-kim.tae.kyung@navercorp.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|PH7PR11MB6835:EE_ x-ms-office365-filtering-correlation-id: 8d61cb92-a9ac-4174-e1a0-08dac2e27bda x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: djFnKUmuw213vZwdqc/73qy+nVH+jZHIwtPzGVHn8IgTp76DabBT7hKCGGRmBWQJunm3tcT16VYM1q3iaZilDvyahkmpZpXSzZQeoUcYcd16/Zj/R8hW93rr+ISk0I1C50BTwjewFm77jHjSKTdifQVcVUCXVjm9RiV/uZVJ6yvZ4AQyc/dbXMuQr4GWzPlbYwlar57JKOopSBvw/5iDfvMWucWQY2IXIBJVtC7CRp9NJwSTnh4t3ortRl5cYHSShuTYRX2vrqNDgBtJIdvw0xI5ptQh1cAw0i5PWynMtNnWm/6fUBPAQiNxsi+yv2FBXAr+N6jjUDNVfKPYMzvivH9UQ5Z+Tlpx7SrwmRYTAZKbS6x9dg0Elh/g1pmacPRnue6CVm/5g4lNjTKlj9WENzH+fvm+mrUxt62qXy9XaZz+HEhJEZiAEYOR8f/NK/SmDMDXePJjmY95ec+FFmSfPDxrLUYOCJJV+7hwdRC7Rfks7UMTKcFgyI9w54hXFKehUXlX71pW0lh4YLheijiFG+MDlRB45OjL9/5HGS+0Ee4fA1MxCmmSQAIQhwaG7cgDpNyxkBuKs6VmWTEO28jz73HP11bQmhmi3z9wHQN3SAm/qKRz3exTTs+JRkvE2wouO57reA4+sTPFEpx2OVqqVOpUJqtng2YZ5MaZzgbFjaSvPKUf5d32Fs9ngYLwRIn/JwO6hOG5FoSRaQ4ZIxoJwoyXg5wDqSd2Fpnz5bSEn/3Z+FoQxlBHLcv5hcP6v5gaw//SwN8D8pwd76zAQZ0Ikg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(39860400002)(396003)(366004)(346002)(376002)(451199015)(15650500001)(66476007)(122000001)(64756008)(55016003)(66556008)(33656002)(71200400001)(316002)(4326008)(8676002)(76116006)(66946007)(41300700001)(52536014)(110136005)(82960400001)(107886003)(8936002)(38100700002)(66446008)(6506007)(5660300002)(7696005)(186003)(53546011)(9686003)(478600001)(83380400001)(38070700005)(86362001)(2906002)(26005)(54906003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PzLNipiCCrbnwyn3Dmh/U9i8Ml4oAIT7Z+Dkh60QgXwMS5yczAHfGP1fwO9G?= =?us-ascii?Q?BHUCopIePkmTdBnEQuv2znPl4kzuZccx5TLcPcXA13/wbzgvhZo14NEdFXA4?= =?us-ascii?Q?sWvXDEZ1diwFzaRuJyP3+Gd/uKJy8YRdR9qE+socey52qsoEA0XG3WNe2Qgk?= =?us-ascii?Q?zM/UZUkkgIm3nvnDPdpVqIAgq1nZd5KMJc/xW837Y1q1h+LkcC5trBxmXhQj?= =?us-ascii?Q?YCenfdtG6UkUk6fJ66spavScGF79ZEq6I+GjUfUdXhT+ryGO3a/A2CwbaM2n?= =?us-ascii?Q?bgRtwxhm21RFvVFXsV/+ynTZdg6PvaZKqdh3GXo3+P4trpsJPNn1xDqhLM8i?= =?us-ascii?Q?YBJvKPFhQSyMht/ZxDsTdUianDP0P0yIVBzBGIOIwvpClLQxZpjvY0ymsnvz?= =?us-ascii?Q?pxSpLjyWheYIo9ZNNCkDkWmREtFvM5XYLi8KcjCb/1kXjJqIajhTXj1xtpx4?= =?us-ascii?Q?w0ZzHpfq54MPDyA+A5KAtXZyBy/73Q9VTJvitGdACzLjID7ZLpm88PlHQu6y?= =?us-ascii?Q?fc3mGRn5pxkRB5GgMLWZl/P2YR5UyWQ0isW349A/vu89TvS8Qpsez3RyN4lT?= =?us-ascii?Q?BRO6HZLr+uexnKtHsavkt8I4RARVOJGggx5OUNUnf+625+desV7St9FNNTFw?= =?us-ascii?Q?xhxM6it5CQlkXW4bOV4cFbgPUBwkQfJGPnBSXIMsEMq/Ox1tue1dP1NB0NMj?= =?us-ascii?Q?UA4taNOZyyhfCdxGoqfONz2qA4OBowP/cCgNV4zABLnNOV5xrdgqUD2Fdesm?= =?us-ascii?Q?s3BRqtX8IiwfK1qpbydjcsojP13lMFaArEOByovDVAt/3uUD+jom0EEnzT/w?= =?us-ascii?Q?46oGmbUe4PLS4M+7idBy+mvQIfeD/bOgWon5iECqITtBH+kezg8TcKKHNUav?= =?us-ascii?Q?uLZcv8s6JtsdcXEwytL6vpKSfCLAFRwgSGQbsDz1Z8f102nQm1sj4+hf6Gpk?= =?us-ascii?Q?GTaZOeMQZhMv0yweX+i0lcNOkhr8soc1VnZyOo+H+UkMvdgIBsLy22AF+g3L?= =?us-ascii?Q?pfxDxjpHxOyRbV87gp8M/SrEwVQ351rFGLvraoV5eYw6t0MBA2o+8HYOvRFJ?= =?us-ascii?Q?gogoUqH14DWMLjLM55DRkENpTnJ4CEmdbvllOaK5bN2HzJnKrImt6SyXXNsk?= =?us-ascii?Q?jeFbER6pwaoJT3oMxUFdBQuydjf68t4KmaXqfwSMvke1+oT80v6Of2WUJlu9?= =?us-ascii?Q?OIwdq0+0HlkTTVVprgAQSvxBHpjsmd0cHHg90JEG+nF2kgQdWJrW1Dr2UH98?= =?us-ascii?Q?SA620TUJUubJVSCCqYXxzJOKOyK7KaBjtkWh17ReKW/lhfQxM4FnO0RS5bD9?= =?us-ascii?Q?21tvKnsc98MCDrTiwK9epjQBDaKGNZ34whwNp6vCZpzzQ7I14U+1CqbLfGp9?= =?us-ascii?Q?igKxNmR3XuJuIy2EnbjKUzy+xAMTJ7yraoDwDPTqfa6r7sQsA3Wb3cWkXZMm?= =?us-ascii?Q?ahGotoZBTcqNH929QBmtoIFvLlSI5bqepzECYpSvuQ50LtHICR7r8etbeEY2?= =?us-ascii?Q?+UIq9zWHZXWs7j/ahDzniD7hM54NgGq2XUbEx33OFqEWFf9sdPAwkDl+3VnT?= =?us-ascii?Q?IQlvjzueDCPdYqUQXcN0Zi3z6LiBX9a5W07yl5uT?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d61cb92-a9ac-4174-e1a0-08dac2e27bda X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2022 06:12:02.2217 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EFRh0OcFYhgoksKEyRlff9bdvzGnLYPtVoAZHcz3AXRWBh5nLq0EwbUBvFLI7fThxnU9fQL+7OeouyoukIPLiw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6835 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Taekyung Kim > Sent: Thursday, November 10, 2022 12:10 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Pei, Andy ; > kim.tae.kyung@navercorp.com; maxime.coquelin@redhat.com; stable@dpdk.org; > Wang, Xiao W > Subject: [PATCH v5] vdpa/ifc: fix update_datapath error handling >=20 > Stop and return the error code when update_datapath fails. > update_datapath prepares resources for the vdpa device. > The driver should not perform any further actions > if update_datapath returns an error. >=20 > Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver") > Cc: stable@dpdk.org >=20 > Signed-off-by: Taekyung Kim > --- > v5: > * Resubmit to patchwork >=20 > v4: > * Add rte_vdpa_unregister_device in ifcvf_pci_probe >=20 > v3: > * Fix coding style >=20 > v2: > * Revert the prepared resources before returning an error > * Rebase to 22.11 rc2 > * Add fixes and cc for backport >=20 > --- > drivers/vdpa/ifc/ifcvf_vdpa.c | 27 +++++++++++++++++++++++---- > 1 file changed, 23 insertions(+), 4 deletions(-) >=20 Thanks Kim for helping on resending. Reviewed-by: Chenbo Xia Will help you add Maxime and Andy's Reviewed-by/Acked-by in commit log When applying. Thanks, Chenbo