From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D500EA0545; Tue, 21 Jun 2022 15:22:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 779A94069C; Tue, 21 Jun 2022 15:22:45 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id B1CBC40151 for ; Tue, 21 Jun 2022 15:22:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655817763; x=1687353763; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=X6a0pVfwb3WN3bHZsUO2uENZztxuYgvZDi3rSOJoMpo=; b=WGCyzRZdOdg0TEWhWIL/zYc3HozAbpcjvZw4lwh3mdGzziNTn0U7PSrC TzkhCsj7TTUdqyjBAWV65U/wTEEXAzaN7GV3fk/vlfwegJpOEQy5ZsCMC qJS7+HDD9WFsZAWDBTzUa9Ss4K6EcBfNjt22whJY5/WovuVZ9ltDvgG4n KEUZ0OQNVB2PRXfI5wG361t56Yl9ZtMvBXCRmCDetDdUle4hRj8lKdm6f kO0hh3beUoC8R3CbbxjJDGD6YfPsxe4icmmkaJ+NQ6zMTicvld33JwO2G CK0NatFyXOr3MxyftJsduik30Y4e6ItT0Xxja9P3GWqwGQQRqG4LYVYkF w==; X-IronPort-AV: E=McAfee;i="6400,9594,10384"; a="344107872" X-IronPort-AV: E=Sophos;i="5.92,209,1650956400"; d="scan'208";a="344107872" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2022 06:22:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,209,1650956400"; d="scan'208";a="689934114" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga002.fm.intel.com with ESMTP; 21 Jun 2022 06:22:42 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 21 Jun 2022 06:22:42 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 21 Jun 2022 06:22:42 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 21 Jun 2022 06:22:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nTohl1jo9ziEkBBXm8Y4QyYcEBXZvuTDJuIcFMpnWWIZZQnHCKAoFfjRmipbqANfgOtz+EcFd4Y2HFvtC20/KJ6GouG5vgGityLjVyWBDWv43FR8VXekDVvE5pIvKr0Krc6uXMqPrLVrR0LpjRcYzalvw0g2BL6aqv0W8g5ySgr/J3MTMnFYMYi9PXqrlvWe/uQa9QwAi3h0f/9BAGUJC20xBlWyP0XNZuKElk3u0c8rwhnKKznXSCIx+OheOVBX1VG6GMEIHJDwJx2k0nuzdpJhXjzWooayv5tlGUOPshdnA4FmEeCPZqQT/Q/24tWWS47rurOV+pi9pqLYlFlc0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CKM1Ucel7niXXKcT46Wqg1HVCXT8VoQLN13K/iauaiY=; b=k5ZBX1hP6fxYCHd3IJI9oHYVOXz+OMIK2o5knYsWSpazjF7b+L+lR40qoxMbDKTLsdU4F/e23KWgMjU1RtR7hs4s1RiwALW4iy40c5+ulDwI6q7QzVlcAQVgGnvhBJ9Etd4B4S4bFTb7VEq/Dk+koLAKSO97jyJmD174vL23a+12FdZ+5/COVYNXKEW/I2v0ZjwZAXOwhNNwSxZUhtOg+vZba+jSnVgFnhHPnuIoeUjeS2My+vq7+pjCDtahc4P8sjjfmq72CA8YnxnQLjj/AJ6IDw0Epjidqc5oUETXsKhUpXmFSX6+TAIm+8hEFGNsXVxe7L3AC3FLGcXRdd7+wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by CO6PR11MB5634.namprd11.prod.outlook.com (2603:10b6:5:35d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Tue, 21 Jun 2022 13:22:38 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::54a0:2dbc:18b7:2aa9]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::54a0:2dbc:18b7:2aa9%7]) with mapi id 15.20.5353.022; Tue, 21 Jun 2022 13:22:38 +0000 From: "Xia, Chenbo" To: "Ding, Xuan" , "maxime.coquelin@redhat.com" CC: "dev@dpdk.org" , "Hu, Jiayu" Subject: RE: [PATCH v2] doc: update async enqueue API usage Thread-Topic: [PATCH v2] doc: update async enqueue API usage Thread-Index: AQHYhUAVzmPsBL5JGU6zosDOW6ZPMq1Z2AIg Date: Tue, 21 Jun 2022 13:22:38 +0000 Message-ID: References: <20220617093413.94960-1-xuan.ding@intel.com> <20220621072131.14756-1-xuan.ding@intel.com> In-Reply-To: <20220621072131.14756-1-xuan.ding@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3e17c34a-44be-453c-164c-08da53891cde x-ms-traffictypediagnostic: CO6PR11MB5634:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BqCN40If+MYv42EN10xyL8+CtFcDUOoc3DP84HsEbBzQjjlvjWrydqQ2AawGF5Qe4zs4bFT0JkQMaBUWXuLpLmur9SYv8QvfEaPFM3qkcOFpsgfQzol7Lz2UO90YVVYXdeuWsVMGFaj8Np2AM64C+10GTJPY96o/0wHHSJjfA0tfDRQW8h2kGQrpwj4EepoebonD/dANTCkfC4B1rRag0C1gRsA4Exn5HnN7i1lNKzZjsbwY2SUM6RevujjCiMq2h3ZXHUR6dJhV5XzYjuUUeBuMd3jgQ5+fsszzurFnBo12UG4/QAHmSysoNfo5/n0SqbBNfjTU2B46730AjCjRVWbl8fzuC1GtLSX9EHD2cP07ycAmf9VoQnCne2n+MDzWptD1u0tlV9RenBNhLHrlomyqO8cvSkasICShonicYplSED3/VQkKuHzAAgJ2qkflk5ey/sdDFd2avee1X+vvs+Rk9tJ+Ih/1JJz5oNjX0Zzd2KAeQSI0h1NQbTZyOKdxjiJxA8oRbIUl+gd5+NGgAFe0cVtPYI4o4hzlMlvHCNGVEcX+p6QyS22RbXte871yYvz4UGYvU+mUASP/FfKLRfMyrHyhUqmLyUGLyezO5SmqC0T8trxAlP4tzeZ8UgWAhYe2liqgZv6c1wAv/y6rwS6bPLlnlSXKueeJOn4YWyTw/fzj2tqQ8o3wXLugMK3N1C2YIu4a3xf/7tSiJNMU3w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(346002)(39860400002)(396003)(136003)(366004)(52536014)(4326008)(8676002)(64756008)(66446008)(66556008)(71200400001)(38070700005)(26005)(66476007)(9686003)(110136005)(55016003)(122000001)(5660300002)(316002)(8936002)(82960400001)(66946007)(86362001)(33656002)(76116006)(54906003)(38100700002)(2906002)(83380400001)(478600001)(15650500001)(53546011)(7696005)(186003)(107886003)(6506007)(41300700001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?08j4w6Wf9Eq8mRERUnNkBgRS918qZiXAcQFdrsb0RdDjsMb7am1RmWn1lT4u?= =?us-ascii?Q?Z6uzyx1m321rF9YXsru8oK9qEGH4nOVWK6X4eNV1le0VDG5pc9aYRBiVlInd?= =?us-ascii?Q?fm6wFPhJknoNpI8xxSp7tUvAOCf9afxeb+1aK2YBGrBfofuyLI4NQGaYmhO+?= =?us-ascii?Q?lBjwb2dI04rzvEoxCdyWVyg6tB3ef+SlmudQg9qcJj/0JqBUhc8gPexcCHZA?= =?us-ascii?Q?9qsuwPV8fDgVsL/wMhO7BEg9puW+M2u8cSlWUIo5oTpLFpiWP/RE9I6hxPRL?= =?us-ascii?Q?jupJmeiWXYXDkx33ggMteXpWDvtL4Mwe5axKONx+1ytSoScBy4tcWFtbJyG6?= =?us-ascii?Q?K+kwwklwk6xw0ZGYRkajbjvBFtR4kIKLiWJ4aDCr9UkmkCFJ2zUaL7zPOlhu?= =?us-ascii?Q?8Rhhm2BRRzXwQwq20gMwl1N4IZapo0cgbjrT/BuU1syuJguSa4imNVXMqtzP?= =?us-ascii?Q?ykj8WFcY5r0w/Lh7mAtmgmZDjkI2X+RjVLNbS5NX9/XT8XfKoxZRDmfiYHP6?= =?us-ascii?Q?/e0WJQLpnbLi2kTOh12yYE5muI3KtNysFVUWFTOiEyfd8TmeTtqHSFWRNSn/?= =?us-ascii?Q?dSO11BIOgMn+RKA7KS6DcDFN7D/mqXDjNk9GnmdPkDcOOvjXf1boH4b8OozM?= =?us-ascii?Q?+9rYaYdc4ZtGUgrlJW1peEilEonghYK61gLFyFQLgq4+jZxFAACbHgfvtxh9?= =?us-ascii?Q?Q1P9PXj1d27D7FBlbQN0cWjcdBiaUJPnxm7+N76mQWVcNbT/K7rSITXt7AT8?= =?us-ascii?Q?qi/tmjdqaeC9jBD9DVMm9AdbXM9ewcStFHUaI+F1kguAr/vFScrl5ilZ+/qr?= =?us-ascii?Q?VzF5iOd2K5kFnq5IKCeSiwFKFj7u4Hx5qY8UobOlj/QqOO9L1GO9w+3hXOsr?= =?us-ascii?Q?8x0IlVFk8QgOVQdPWQ+Fud1j4kKAj6P+V5jLiuTKFo3Y9UkRrTOXLJkDyPHr?= =?us-ascii?Q?6ZL4+Y5Uezj0DIEKVQIqsVcwWDo7FqRRIoZUNmUWfsPaeL+2XiBFt2wbK6XY?= =?us-ascii?Q?d+8FMHs8NgF+knIa+193fgpW2VuT4OBKJO35d2ZT5MAe2ZALGnPSr7CtyCW3?= =?us-ascii?Q?NA170z5G/7NCr76N+gtEjM5kttOJ71R1ObJb67NoLjx3fUkkTi+cxYbK8rEc?= =?us-ascii?Q?N6/TCtwX45WoHJ7QLKw55KQ5FmPm7yEeUPjMP6gQdi4Letd72q42FEEq96Hs?= =?us-ascii?Q?jl1ZxRskwAiRcrKL+Y89GSMaTibcClI0J8DaBC/xzCSO0nK5vkuUm8YcR4lz?= =?us-ascii?Q?Zj1uE3scDJAK314tfwWich3akYxW5wmQNdMfAVIwnUPih3w8PqQBEvxAk2oH?= =?us-ascii?Q?/2CejeIXN/bO735tzx4HcDdwkWiMRzb+hVrcO7HZZY99o2IpsiwfbcE6hc0n?= =?us-ascii?Q?1pWrL3N3PejTscVtVP553VNL8qU7tcGy5ZdUiTdYEHVDDTDOJgbluTCdwopP?= =?us-ascii?Q?tpl0EqvfbPigio+MmMGxf55sDl+s8XltdaoiQ1e3lTuogrq7fuxxBaa5PfEq?= =?us-ascii?Q?p/yabW1qX2qFwf6wDUCSZMs5GsfA4RlbKyEVzevT3W3TNsDxqPEwBQ14jjyr?= =?us-ascii?Q?Y4BZmOxy2LK6kUQXmBWl5trPeVMlJS9V3FO5q1UFVaocvF6rv7nEh4CBc4aR?= =?us-ascii?Q?nFbEPjZsjYOYURdIWEyyXSK5mtGgqqgvr4JCfSXyVoP4UmHuamDlpe/Jq30Z?= =?us-ascii?Q?GHTpXi/A3WzzILTjQdgVL8dQbnin/RnKmWldFCGIxFKQpWcwqAhz33UXrBHc?= =?us-ascii?Q?MeFv3G49Yg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3e17c34a-44be-453c-164c-08da53891cde X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2022 13:22:38.5975 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JbKtOcs21fdwJdA4KlAuIqi8HxJL5RrUCwPP6ZdUNZpuTBWPKulRlDkykyKgPx1I1fGkifW3pjVFkGw6clUMDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR11MB5634 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Xuan, > -----Original Message----- > From: Ding, Xuan > Sent: Tuesday, June 21, 2022 3:22 PM > To: maxime.coquelin@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > > Subject: [PATCH v2] doc: update async enqueue API usage >=20 > From: Xuan Ding >=20 > This patch updates the correct usage for async enqueue APIs. > The rte_vhost_poll_enqueue_completed() needs to be > called in time to notify the guest of completed packets and > avoid packet loss. >=20 > Signed-off-by: Xuan Ding > --- > v2: > * refine doc and commit log > --- > doc/guides/prog_guide/vhost_lib.rst | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/doc/guides/prog_guide/vhost_lib.rst > b/doc/guides/prog_guide/vhost_lib.rst > index cd3f6caa9a..628db3fc38 100644 > --- a/doc/guides/prog_guide/vhost_lib.rst > +++ b/doc/guides/prog_guide/vhost_lib.rst > @@ -480,6 +480,14 @@ the same vring with their own DMA virtual channels. > Besides, the number > of DMA devices is limited. For the purpose of scaling, it's necessary to > support sharing DMA channels among vrings. >=20 > +* Async enqueue API usage > + > + In async enqueue path, rte_vhost_poll_enqueue_completed() needs to be > + called in time to notify the guest of DMA copy completed packets. > + Moreover, calling rte_vhost_submit_enqueue_burst() all the time but > + not poll completed will cause the DMA ring to be full, which will > + result in packet loss eventually. > + This subsection seems cleaner, could you also help to make 'Recommended IOV= A mode in async datapath' as a sub-section? Another patch or not, either works for me. Thanks, Chenbo > Recommended IOVA mode in async datapath > --------------------------------------- >=20 > -- > 2.17.1