From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98F29A04FF; Tue, 24 May 2022 05:10:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 85DED40A84; Tue, 24 May 2022 05:10:27 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id E870E400D6 for ; Tue, 24 May 2022 05:10:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653361825; x=1684897825; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=c/iuZt/UkMswAmvPAJ1HTT3vQ5fjNIKz3jC90aFFalo=; b=iPP7o5QLG7gqCeHUW0pUXGgyuBbtGqWSv1bvTxVflCRL1OihXa9DtuGD DvPeZ/cBFBFUPqJEPrGadDl5ywcRO/OHZfD5V3T6rUzQq4nMdZD15LyGL qdsanmBIFIOcwsDqFLfOeOTWYySTJrBY7InyfLfW7GU/v/VN1iAqRMZPK XOeXmAxrDbFoMhmvUBuv4ZK4/Ugw0CsP2smgmO8sOXQzRNJ1LpCU3x+h6 gEp1wfX0jEJIpFvnFXqf4ipWfw+g5kWR4WDzDHkZ/+mnu/I5eTVUQ6PaY YQsT30CrseFCkaKnpksg6dE+WDzRsrbpi0sszlj2xnTgAaJnp8Ti04gg6 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10356"; a="270990830" X-IronPort-AV: E=Sophos;i="5.91,247,1647327600"; d="scan'208";a="270990830" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2022 20:10:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,247,1647327600"; d="scan'208";a="716991119" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 23 May 2022 20:10:24 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 23 May 2022 20:10:23 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 23 May 2022 20:10:23 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.44) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 23 May 2022 20:10:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TtK0mnrKWMnRX8+HNgR81cbuDnKcne2PfwuNeZwDvWAt7uC5/BQAcQpx9Lf4wr/8lqnYt6Rs35ZAIe/W5Ujmr2BzBF/IahHyFhjnQn/wDqs24uiJ2rynlo3Npe6TTmVYVlSIQws7R2x+V8yooOn/q9lizvdCMKcWCXTv1hEyrkA2GgXByGBFT9UlYoVxMMZL7ifd+cwo5mztESdSSrodFIWZbcPdGwPZ6yZwNk5IM2pVWRMWTSe9neDz2juD4B3bh/Hjj4zQt3/M1bvWu2fg/wnGJ2b+wG//8FFZHfL7Xq/qgbDljhP+NZq8CM47ELls9y2QdwmR8K5QOoCkoidaNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LVueUxiWZ7Ygq3i2xanAL/kmVbX5pbaWYbWjXNzRIF8=; b=JHTfun3hNx/VAiDgpOYBIzIXC7VXlRASy/OcV/+0hBJA76aw2HVtJsKcBR62ofJzDZ/E4hQ98a9tFtXd7E1GX3mFpraOuL+bC34eo7UpMz+Ry2QxP8M8V/+vHuWcMoGq2G5yOxEDeGphWZr3iu0qaFuByDWlHUMm7QocH2nNTuMrGc9oU7evv+aRiBPjXictMb8Ji1gIbMlg5iKBZbmRr4QQCRn9hUOJY55Eqiho6Ho1FRBXnZLta8XNQ8i7kI71IhRw+uXg1FskwjYMmSjTeOkZuGmK+rVHu8AqLD7TklROfAcoBSSB65nQaJWc7gvTb7wnPGO6Uojnh1Psqwk2nA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by BYAPR11MB2677.namprd11.prod.outlook.com (2603:10b6:a02:cd::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Tue, 24 May 2022 03:10:21 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::54e1:e802:17c8:93f]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::54e1:e802:17c8:93f%7]) with mapi id 15.20.5273.023; Tue, 24 May 2022 03:10:21 +0000 From: "Xia, Chenbo" To: "Pei, Andy" , "dev@dpdk.org" CC: "maxime.coquelin@redhat.com" , "Cao, Gang" , "Liu, Changpeng" , "Xu, Rosen" , "Xiao, QimaiX" Subject: RE: [PATCH v9 13/13] vdpa/ifc/base: access correct register for blk device Thread-Topic: [PATCH v9 13/13] vdpa/ifc/base: access correct register for blk device Thread-Index: AQHYbo8ZfXE639WCy0yYggQP8L5jJ60tWkXA Date: Tue, 24 May 2022 03:10:21 +0000 Message-ID: References: <1643093258-47258-2-git-send-email-andy.pei@intel.com> <1653298524-232138-1-git-send-email-andy.pei@intel.com> <1653298524-232138-14-git-send-email-andy.pei@intel.com> In-Reply-To: <1653298524-232138-14-git-send-email-andy.pei@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6ab46168-da41-49c6-4b3b-08da3d32f02f x-ms-traffictypediagnostic: BYAPR11MB2677:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eDGEi5o5MUDXsF20m2uM7lkq8NqjALUn8VMJ4l6iu0lRODWdn2n27RUV+zNbDsDUw+UaWqP6wYK8RbK6hnjyu5isBL2FvNYikOTR2aKtR357tNhwjmGEdADBtNIiSTF/Sagz++C6MPQnkOxGKAHCyfnSNG39hfb6IYRrxxWCjsAChzVkBCXvVlVchWpFdq3N8zUF8qVA0ey0fuG6lOjF7MJx4c+JhwsTHqrKzRHBEKyC4b/JgO1PgZrEfqb8kRT41cp8IHfVaSSaCOr+6+/6iRlx3qVzAKyKRzlfEs87fF/NN8rfwFWPwTkD4ymOw1l8f0OzjRXk4lIzk0NJPVyUZGXiwwcAqoWcgFJOxn0ziLTuY5XiIbdZOcFmCTqxSO92DmfGEcoK7dA2A807IMeZ245WsuUis858jwndd30PZ3CcDpR4XokWhifQ3nqEPqMYDPQ5n7a2zetLdLlCdMCXMlfgZRjDrAAyTJuPcApkdfvgZfu1QuVFCMlfTnEg4vp7TmEMuL7eJgG764KIsdNQ11pFUVRMWo8o+xw601ka1nipc10OxwGETIy5LCe+6R5BVFOtAo72mj1jRablA49kiD4hswMHiGPYONfLl5V9IBRuDH4tYgKxWvMaJg8bghuCO95uxX1TmoVfp9BtDZhgf/7Vuz55aVggBk1VkuewVi/WeRfg3mZdt9MB7TpCKD82cC8GxjBBQ/r1vN54EZHaXFXSNcAej9zQwxAOkhR9VnR6WWwcy1qG2R5Zq+YF0bks x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(107886003)(2906002)(9686003)(26005)(71200400001)(110136005)(82960400001)(316002)(54906003)(186003)(52536014)(8936002)(4326008)(122000001)(38100700002)(38070700005)(55016003)(5660300002)(7696005)(33656002)(508600001)(53546011)(4744005)(6506007)(86362001)(83380400001)(64756008)(76116006)(66446008)(8676002)(66946007)(66476007)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4oM1M26m1eT2+oqMO6A7oaE65zV5YXfrDS+Yg/RialhPbSIq69w7Fqii1slL?= =?us-ascii?Q?hy0u/UDgNg/z6w/6W4o3+GGWedNBMznImdepGIhNsCt0Fs1R6gD2KhaDmhh+?= =?us-ascii?Q?YYRGgRfiNSDGBwodP/BzcQp6rvSQyQjTByzuYSxRXi9DTpSUMctfEBbrkdfp?= =?us-ascii?Q?h1XACPRtQiCmRyioSTL61itWhBhYo/xhyyT7cd2LGMpdXIfrBFX6WEjKWAIQ?= =?us-ascii?Q?1O1yYyCGwgvOtFnslyGzbNQuTDi+i8XqMK1HYlW46ywD0s7M8aPzWqGAbvfw?= =?us-ascii?Q?beVAUBN4FHhXogA070bGqzqqTdc9zAjzPNCKxYX9R3HGh5P2p99jR3C+Wq8M?= =?us-ascii?Q?Avsp5AyUN4MdARYAi3r8F4JgULJVoXyxu3OWGF5DMLngGpOsLtYvuXYR+Am/?= =?us-ascii?Q?FnsW1eRsgruKD7O+BvMg7qrBqBCsu+SBt3wh67AljzZuj5b/48BGSefDRRky?= =?us-ascii?Q?vPIAalLIDthHyb40I1hbQ5bJp77cqzIU700PQ9CwHpu2IALooJC8blBTQr00?= =?us-ascii?Q?9bSxcTdH4wQ4JjkGaLBxcWPAVkjUsh7xq2VaOcUNtE/kIXjaKYv3aE6WVP/+?= =?us-ascii?Q?rC4uuK7z4OUWYrPfxxLyhEAunc8onWUOGWuguBYpxh0rHjkWUJwluRztXC3f?= =?us-ascii?Q?fiFWi1nVpjSN7hSlEfqVn81qt18dvtuYZExiksZI0mcMOPpXpdmkeOxVygqJ?= =?us-ascii?Q?b7m1vLLI53A+m0AnrYLT0xqeDcrdZwdOAyYpDfMVEdTPZfRct/UfSEztOceM?= =?us-ascii?Q?8oQjfpojg+HzGy0nFIUZ/0Z+pPaLQlteIFLDf6GBw3ZMZJt+O4/BqENtk0SV?= =?us-ascii?Q?b0ZQpNFZzrYPGzd3Rzx78N37DJ1FIaFScIY4uqOYWj99Y7j9yXyZWbB8Rmvo?= =?us-ascii?Q?m+CbfOCbbNMVPKRrewq7XTmyoefkKNK+/t3OaVAEvUGmzHhRJ43irmDqKlnk?= =?us-ascii?Q?RrkxmRuxncMH2V1HXquXox2eBNsSyEfzk1yYjiq3W5D9lZSx/xkc8NQ2MqoS?= =?us-ascii?Q?e9NQ7Xo9kf4XJP9TcjkeWmz1ZBCr/NnQWu9ISV0LLaHVSgEsX5Hces1rfsPI?= =?us-ascii?Q?COAa+eiwGzEr3NoQhwg6zRoUr5ADCGir7zy9uOBbvp3idr/TnQopJ25sHhoB?= =?us-ascii?Q?uiZpKzqPRsxq0UR5oDSNWh//3iwZeI6QHgTukDT1uh9TkSmqj3exn4Yy6OQR?= =?us-ascii?Q?IJm0yy3X139zNIiqp3Lt6t3HlYsR7UJaYANMJQpn/yzL7EPZO+PNMnZDw+qe?= =?us-ascii?Q?vMLt9CHsBWkBNRZkiGGbUnsbMS/N2x+3o+hcAvDHKqfAn5z5X3I2WqXtyawy?= =?us-ascii?Q?ECOGr19xgrhGvLz8fseVa0nfDQuJI2qYoaQwxHMxuM2CzMfkyRQ7wwEzElwc?= =?us-ascii?Q?wn1r2FfT7jSDIvCUvK9xkDwPLVqNzXZaFYRVotNO+GdPJIualgFo2LRuAoxj?= =?us-ascii?Q?pmhbgivVBvo+8qyib72FZ9oldATzmTTn0+vS35b83HLpEGQyetkczNqec/98?= =?us-ascii?Q?P+yOR/EaGf/lIcxPbHTSNXdl1W+gWuLOjpajWh663X2PdqY53B4OWUO1VoVG?= =?us-ascii?Q?e2FOBAgvZ5s2CgrvkrNpVu0FSGjDSLrNul9OvJfc/hTNaY6rfOIzZyQ/m5H7?= =?us-ascii?Q?N/xUH3z161OBnod75LwL3Ik0A4pkGQhS24R3jsvj5BsVCtDfrkaqCta5ItDx?= =?us-ascii?Q?pGQ2+/lGo6pZmh8OzvaBV7EW4MAMcxH4ExsvyicmPjg10wfPPn18zOrxA+qI?= =?us-ascii?Q?rZblhRZPNA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ab46168-da41-49c6-4b3b-08da3d32f02f X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2022 03:10:21.3168 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: opFNC3gfwRHO7CCiGu7xioHcFs5cpv9nHSsW5/eKcmSou64kTPyue1kku7rZ3ygo/o+on1Nx5lsnXdK8AZe8kw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2677 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Pei, Andy > Sent: Monday, May 23, 2022 5:35 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coquelin@redhat.com; Cao, > Gang ; Liu, Changpeng ; Xu, > Rosen ; Xiao, QimaiX > Subject: [PATCH v9 13/13] vdpa/ifc/base: access correct register for blk > device >=20 > Register address is different between net and blk device. > We are re-useing most of the code, when register address is re-using With this fixed: Reviewed-by: Chenbo Xia > different, we have to check net and blk device go through > different code. >=20 > Signed-off-by: Andy Pei > --- > drivers/vdpa/ifc/base/ifcvf.c | 34 +++++++++++++++++++++++++++------- > 1 file changed, 27 insertions(+), 7 deletions(-) >=20