From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 187AC424BD; Mon, 30 Jan 2023 08:51:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 05B5E40EE1; Mon, 30 Jan 2023 08:51:43 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id B376640C35 for ; Mon, 30 Jan 2023 08:51:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675065100; x=1706601100; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=aiOe8H8AaLXoPMSrOCemuHBMNiVgagd4s1OMSTvWbNc=; b=B3+DWil0KAVRTvUanZc7/gMh12+l3Y00QuKOM9BsiBu5yoe2PxjAbjnL nNXC76HD2D2Da7CeqgmiYmbZ5zGm193NpHMg9kR2xmfFPSKJXMEjX2RFq glsgFl0VeLSudOPaTZTYs/VyRs3vVhhw5/KaGwqB4OtS1vWvntxIJTBad Az8fkIb+DdH/jELaGw53a7kUyYFkhyeNWyJZHZ6kha5UkAwjR41xFNi+n IAea577ouSSkn/sBb0OfKWlaxvCQ6pp3hLrPUmsTUhYIjPKuWCCU/oxMk b8WVCwAEaBCpy4tQZBLzORwlBDlgHENNkZv5ahX46AT24edaS44/KZpm7 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10605"; a="413717880" X-IronPort-AV: E=Sophos;i="5.97,257,1669104000"; d="scan'208";a="413717880" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2023 23:51:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10605"; a="752723072" X-IronPort-AV: E=Sophos;i="5.97,257,1669104000"; d="scan'208";a="752723072" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 29 Jan 2023 23:51:39 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 29 Jan 2023 23:51:39 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 29 Jan 2023 23:51:38 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 29 Jan 2023 23:51:38 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 29 Jan 2023 23:51:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cPhTamoNg5PhI/9EtBArKb0StI7JAFM4aVCWypzzcevt2wXHPJRbhcUZhMzH1EBO3tsixBhVyiq8zmS5yA4IaxgKOklUY3y/2BZcGahl5sP892+7jy00HLQxsvuBotoMeW88sd1lZmFBl27pHFe8y4iny5Vg9uxBlksVSbWFkV+993DBqa5J8N0FF73q2Oe1lJOj5ommLq/Y2AsoV4DPNzFrDeDhwcPMghWTHBmtMkiNohqHbE1O/O2F6QD7JlVLmGeAgBtbbA49Y9qGat/Phpic6OlS0xHmeg1wE/TrJV25vx4z8v9knCCVZ2O7Zj0/mbxER4pE0gcEfgxCApZxew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BuaemG36Ad3ktcbRIgTX4uS1Jwo0fTG0haiOVjsVWBI=; b=TMO0SMQWsS2o56aoQYRUZZ2+pO8SDr/ib2sqpBOa79dOpQsXecFXVd1NA20nNjUeCc3YpsF47p+W5k35vkJTHiXa4OmDN5G5T5iZ7qsXnh2EpFz+6s9hS/WLhgwWMcw+gB2co1weEvS9Bb9YMajduKdS715znrFVZ90kPnhL0SuqT0Dq3yiyDsYHGqy0YTtWrfoGmIByeGWBqErndQRP+NLGPkOAQAzuPJSgb3mECxF/GZZPev9LOtoDu5y4f99Q8bH4bq7Zt7vC1bZ6tBBTBqusyNIEFxRItSoB0kkug5iJrVGe7nYMPwPqBDWoLq80vgdzPDRpUTk2RJCI0WnT3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by SJ0PR11MB4990.namprd11.prod.outlook.com (2603:10b6:a03:2d8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Mon, 30 Jan 2023 07:51:36 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::c8f8:a3e1:5b23:a9c3]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::c8f8:a3e1:5b23:a9c3%5]) with mapi id 15.20.6043.033; Mon, 30 Jan 2023 07:51:36 +0000 From: "Xia, Chenbo" To: "Coquelin, Maxime" , "dev@dpdk.org" , "david.marchand@redhat.com" , "eperezma@redhat.com" Subject: RE: [PATCH v1 03/21] net/virtio: virtqueue headers alloc refactoring Thread-Topic: [PATCH v1 03/21] net/virtio: virtqueue headers alloc refactoring Thread-Index: AQHZBNRk9xyodLeeA0Kiflb0mL12UK629Zrg Date: Mon, 30 Jan 2023 07:51:36 +0000 Message-ID: References: <20221130155639.150553-1-maxime.coquelin@redhat.com> <20221130155639.150553-4-maxime.coquelin@redhat.com> In-Reply-To: <20221130155639.150553-4-maxime.coquelin@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|SJ0PR11MB4990:EE_ x-ms-office365-filtering-correlation-id: 5aa87775-7c04-43ca-d7c0-08db0296cffc x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Lke4EKBDlrt2z9FC1Q/NhzUY2ZeqBevx6oqC3wWIDJ26b2KolZmeW2LGCuxecyr8HUurPG6OjYTOJWihzHCiKgA8RtU23+mtN2Z/w4JcP6M0ivmc7jaUVF82MBN9YqritdQ5vOxqObf8zracFRbq076XusaXk3N7J/+S6wo+G1nlR7IiKc7UNY29qhu1tCjyGfC+d7tbjHdz2MU2bOa6zmQp/ZCGa24p23rT2uDUXkrKen8HNn/uc5UhMSXrZ4kxxnyJS36ORYgAFKThF9wKmtqapd3+8Cp9yg9QTqJ1ogQymMq/1OTZWhi7I2iH0bD2uJ81IMC++stJJA6IRhnpGcgepU7sTZATep5L65MhbY++P2MzQ7nIGgDZF/ESOju5qMaPqYa7DaPbJ8kk1HcGOQVRsOWOiVecCH2X5+62tuxDk/i+SUn17iiJ9KNDZvTyi2iHYEaN5fvKrVMmI5aZa6o5kQCDOp84QIGfa+fENzktlhp7aTTeN0rB9tlNSYQoSNJBeF5vSFAlaRHfRku2khvHLVEu0h1eow2kbOHqnUWctViOvGdnO5B26JKaogD1WoI+mUuL8lutEtjACdc9yNWxlcJuyARGfZ7yG8PGpuFYIHvbKH6uLkPl8QNNtnrRTMpFbi5T/jC5e57Z5t1MMq1py981RStDOVbEpf2Ha6MiFjyQoFhkDVb4564Fl7Tj8wcOKJJ6yUb8p4y/W3CNAA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(136003)(39860400002)(376002)(366004)(396003)(346002)(451199018)(110136005)(316002)(66946007)(66476007)(8676002)(66556008)(66446008)(76116006)(64756008)(8936002)(52536014)(5660300002)(122000001)(38100700002)(86362001)(38070700005)(33656002)(82960400001)(41300700001)(53546011)(71200400001)(9686003)(26005)(6506007)(186003)(66899018)(55016003)(2906002)(478600001)(7696005)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6QLc2FRpBumoflOpnCV5ndCClDKMcY26VglFe4lSeSqW5NGtOei6AxmD/hLJ?= =?us-ascii?Q?sA0reJAt8nJKUZN6Lphf8LdEFJ2Vynu7TNaYYWxAKOtYteNl4L6+G/0diAAJ?= =?us-ascii?Q?6IfiRLFVEoDXpsMkEaJnA86jeJ5v55UGOBKAWnrmsn5hUXzFiN0j8h9UwN3X?= =?us-ascii?Q?F0lke70Y8aky4yiWjo7m1B4T/fWJhd9PaYAYzbJBCM1uJgAsQG8Fy/L/oSyN?= =?us-ascii?Q?uWaFrT60lY2t0lQx2HoQ5ePCvxSywY3d7lfAjt0rEXixyDdyOereNIfY4NDq?= =?us-ascii?Q?Qp1BZDb2xpum2pQgODwj+h3YY2WP7wIufWhSsUrG77jPBv0rNe+EplUNT6te?= =?us-ascii?Q?1twVks1jxgqpc0YbCKA2XbV3dVgedgiMgm1dMhoSlkTb5k2g96bA7TSWYQ5s?= =?us-ascii?Q?6NGEOGjbEOe+GZDazoC91yFAEzfk7MS0/woc/AG4j0qapB6DDAZJoYdp0S+z?= =?us-ascii?Q?gdNoVwPicA5CJ0painwOiifYANeYTFXwtoMy9aHXqS6Ii23gVxIbdRRUvPen?= =?us-ascii?Q?wYyl4aCmRqRIMDl/kWxcRTox1beixOwixSJcvLXUaDG1DrPtU9qQVbHh2knn?= =?us-ascii?Q?nl5pb17g8p0IvFoW1kzHAg9HZYWsHnStcbgPWl9QxYBwDOvQtTsMI6RNzqqB?= =?us-ascii?Q?R2sCA+Tdeom170dpkNl81nBbDoG7q18IRyzh4utKRMdwF8ofRsL6/JIEyDBQ?= =?us-ascii?Q?3oFroAyFifNuUe1WSBXUNHxit5RD6N9VdQLDkClsEy5G4V7PVhl8gkDbUlX0?= =?us-ascii?Q?R/9cUOdGBKr4nG4S9HV/g1E/Q1k3gXaSIMSQZrN3cquOBiuggJWP+U1JPRrF?= =?us-ascii?Q?Xwis35o1vAAlIWPB40oAKMrXB9fncaGb+KEl1MyJXsDSPr8xYdQq19Q4ukln?= =?us-ascii?Q?cggdBFW9jLzSCAfVAVN5kBYne8BEK5Xtt3vc66okjirhaYeTnD/z7AOkvAow?= =?us-ascii?Q?zwEtv6aouMYVZGpMeqaWrFE5h1kk4KRF4uhrMBIAnVVBEwFNpE0TU6//Qkfl?= =?us-ascii?Q?sh8Wrrf1+SEQSUA9vRxGdxeOvyOtspwYtZ/dkasCt7jfnn5pUpuv0Stu5Fo/?= =?us-ascii?Q?WCfotBE74x2/h6j6RRPO5p30JZ66cowGfh8p0/nEBDBmZ7W9Cs0spyHRj59+?= =?us-ascii?Q?EPv2LGU51gVsIuoIKpkFHw136ALi/V3pP0z0ZhKal0FWgGYC1wYGk+Gd5FS+?= =?us-ascii?Q?xnTqVNllxW4QeRYcCR4cCNEAO9BpWDbsH3YFo/kL+qnId1l49OXz165TNL1Y?= =?us-ascii?Q?BgNlk1s2+mfvt7+MsXKiHvSnQ/badrEh7PPXPLzlVAxi6J8xOZ2tAEvjCJmJ?= =?us-ascii?Q?nclh8ZGdxp0sQwODqrmdVp7F/7iwyKWlhVPJF8QtfiCWfOvUWIYFbQs40kNv?= =?us-ascii?Q?Wd128xBAibgWawRX/8paaUIg4MNkHs+58LfBkYYYpZjqrcALflX5e3uKHxr9?= =?us-ascii?Q?I+h08rX9DtNEg8WV2lK6HsbYlOYPr21caDcNEdFnWoihOs2Jla63RyRBOuMe?= =?us-ascii?Q?5Yw4kWF5n3qxhmnxfYSrhZq1DsxNor4jNM7Ext64PwdyFeOVphy/RjwvmQ55?= =?us-ascii?Q?IPDV2/pMWGBYdnGtIzVtFsVjLGqevYigd0pMdGNt?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5aa87775-7c04-43ca-d7c0-08db0296cffc X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jan 2023 07:51:36.0704 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7QJU/Rt7M7oPjzaeH4KJkNJyvQZF1Czo971J2R2d7dmIbJceMWj1PvAW/c8Ty7q8KDAMfiyt7tquGhbTn4tf2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4990 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Maxime Coquelin > Sent: Wednesday, November 30, 2022 11:56 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.marchand@redhat.com; eperezma@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v1 03/21] net/virtio: virtqueue headers alloc refactoring >=20 > This patch refactors virtqueue initialization by moving > its headers allocation and deallocation in dedicated > function. >=20 > While at it, it renames the memzone metadata and address > pointers in the virtnet_tx and virtnet_ctl structures to > remove redundant virtio_net_ prefix. >=20 > Signed-off-by: Maxime Coquelin > --- > drivers/net/virtio/virtio_cvq.c | 19 ++-- > drivers/net/virtio/virtio_cvq.h | 9 +- > drivers/net/virtio/virtio_ethdev.c | 149 ++++++++++++++++++----------- > drivers/net/virtio/virtio_rxtx.c | 12 +-- > drivers/net/virtio/virtio_rxtx.h | 12 +-- > drivers/net/virtio/virtqueue.c | 8 +- > drivers/net/virtio/virtqueue.h | 13 +-- > 7 files changed, 126 insertions(+), 96 deletions(-) > -- > 2.38.1 Reviewed-by: Chenbo Xia