From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B12CA0545; Thu, 23 Jun 2022 05:03:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D95D4069D; Thu, 23 Jun 2022 05:03:15 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 20E434069C for ; Thu, 23 Jun 2022 05:03:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655953394; x=1687489394; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=8ddyeX6pzMzSlAc9yHc7vbOcGkQaYq17mN5aeMoqKPI=; b=WIJWAVhVSCdL2ALgvk7UxVduH2J2AWKSM26wSkFh23yT0S0Axof9zmf7 Le469lpJX+C4YJ92liJKmvPjXSGBNedAadv34/OiWaznL9eL+EDpLeyjd VEp9gEzOMEVceTfK3R4DpCK3Kzda8wXZTDny66qxSdybpwuBwDXSj5pNq tknL8oecGsupUw+GBRyiDJMaulujRGU0vdyJc6g0c+NSr7Jat03B8l7Uw NtaQPpQkhv1dnplFz0KmSAMMh3Q8cijICZbt4SmWl9R74Mw5KIZCmUTpJ BQksUL5yn+Egs10OQI3/QbWI1SOtHf2aoB+a0d3tTUV+COEoM5LVMxloH w==; X-IronPort-AV: E=McAfee;i="6400,9594,10386"; a="261041449" X-IronPort-AV: E=Sophos;i="5.92,215,1650956400"; d="scan'208";a="261041449" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2022 20:03:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,215,1650956400"; d="scan'208";a="914992604" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 22 Jun 2022 20:03:13 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 22 Jun 2022 20:03:12 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 22 Jun 2022 20:03:12 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 22 Jun 2022 20:03:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NAzYb2tJnueJsc7w+8plIl7Z8a8yQAHnlbWXwjRur5fsTUi1GY29YDqhMzcSl39JjwlJghhHoN2dDng16ApKc0TVbYQwM7Chv21SmtiwcIDYDNuiyiTPAQSwjJWu5JNFMZVIaK+fjeGJNxrESOv/8w2nrTd3WOjK2nmszZZbZpJq5xf0RNXtfd+DKmKovMALwySn2ICdDcINioaUYas5ObXX0dDaV7XIY+ElmIeQc82J3MwuNcfTPy3B6PoHr6ZX1Vo9nQYewajIx+mii0M1rjkOr8rR+HjZkOoLt0ZLkIrLV2fnp6x7PFKGJJdL0d3VxT79QH8EjPLzBVwsJaoRRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xVumaiFpYjFpXRTCWsGOVuPR6Y2nl/kmEmNTtznbwhE=; b=U2synBClneJd2sbYRhnvEOsaPJIGFzdjYMpaRbw3jcVlzCYsg86etLvievoMgzDktn2OvFfFzsk2G1oulCjmntTec7QO6Q2U+FSBFssGnd0QmQ8hN5EvfiC9MpR68WU5rskxQ4xzga/9lg26NaOAL9WNkkAEQZ4IWCpiAxvijxSW9doN793umErJ9sHVqRFq9GskVFyW6kW69WBoxIrZef0Db0fZVm4N2eNaZxqU0HvNukwH4LzU8/BzKQHhA/Cjbtzdena9kTtFjZ8Hp9VonA/lFuO4X8cBicgKjywwd0Y467h0rLma5s9PFMUHwG+n3iUPmvzA/pFfyn0hEzGKJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by BN6PR11MB2050.namprd11.prod.outlook.com (2603:10b6:404:3c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.15; Thu, 23 Jun 2022 03:03:11 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::54a0:2dbc:18b7:2aa9]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::54a0:2dbc:18b7:2aa9%7]) with mapi id 15.20.5353.022; Thu, 23 Jun 2022 03:03:11 +0000 From: "Xia, Chenbo" To: Gaoxiang Liu , "maxime.coquelin@redhat.com" CC: "dev@dpdk.org" Subject: RE: Fw:[PATCH v2] vhost: fix avail idx update error when desc copy failed Thread-Topic: Fw:[PATCH v2] vhost: fix avail idx update error when desc copy failed Thread-Index: AQHYhkS2lKJAUiHdf0W0bTw0iFu8ba1cTchQ Date: Thu, 23 Jun 2022 03:03:10 +0000 Message-ID: References: <3603f2dd.5f97.1818bd20f65.Coremail.gaoxiangliu0@163.com> In-Reply-To: <3603f2dd.5f97.1818bd20f65.Coremail.gaoxiangliu0@163.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dee4191d-04cc-4461-76cf-08da54c4e80a x-ms-traffictypediagnostic: BN6PR11MB2050:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5v4eYwuvrCiSp99V2KS7RsEl61TH3O4RjjN96GR/GUWXkPHmlehxJrDRvaU5m6syHI4uiXbgYwmC8ObM9uQQ5qehjWmKdjAwGqhrTNzNPFwv5XmxrdCrgQWxg9AZKjI+sAWDIxcBxtox9y1g4fGA1bB0Z3zcK6U7zqq/H8DEacrRjqwxTAjxHDWj4pomOPHqpgtojlqRVNyjMlXKjluB4K+xRO4Or/ory7qMsDY6cVLPRfqdEyPKZDzSl6jWmnrLPZipvTWk/yaXkAObtTq3OGFSAYHlvExpwBwFhGrM8rANdMX8UsxSdmxiTZyAe+ieC8VA7AYiORKv53onKO6SIlLAsgo4qqocSyf7UQ+GGaplhUBbhGaBP5EJQYd/iN3r5o4S3KWGTY4SYNenxaertjhjg+LHJZLrHTbQSUEAMDyiyPkpTNsOe/Stj8tfAkXW44rpyuACjXnAR4od10JtIiRKwe63NfYfDVvfgzl3UJzTDa4J2SlJcav089NFH5qM2wdZXhnNHEKZ0DQSwRlOY940yEEj0L7rRxLc5AX3mfvVo71xr4WWTpQTfXQOJIFPsAAqgd4lA8agu00g4XFB3Uk5zGb2PtDINvn9V1/xlljMTNI13S3OLoahLMP01qRNqEcCGRV6O8J02W2tvVCvMaqk5KO+xFndpR/IY92QsDXFLa7+Wq5n6mFNEzXrv69wQMAwktyMhaRq/Vfi9dlrn6m+svN1VkfhI0G7/+1hAf8EmKFw86ATyMgL2ZFvuXWe1+onP3xQrxmNrSrhU0YbzA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(39860400002)(366004)(136003)(346002)(376002)(38100700002)(9686003)(55016003)(7696005)(53546011)(316002)(26005)(41300700001)(110136005)(15650500001)(2906002)(33656002)(8936002)(5660300002)(82960400001)(6506007)(52536014)(478600001)(186003)(71200400001)(8676002)(64756008)(38070700005)(83380400001)(66446008)(4326008)(66946007)(66476007)(86362001)(122000001)(66556008)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?Bp3cx6wiLglPth3op7mtIXvSbMv8CW3O3CvNhpVJXK9pzXUGJxhoGFbryv?= =?iso-8859-1?Q?M7k5jMIbkikwVw2KTauB7YLA+27FQ4dj2eNnSUcOOS+6PXrRuz1qEUpr9N?= =?iso-8859-1?Q?ER9H5NHj5TvdDpHTovBr6FoSIHOqqD7c1EszqObdM0bPsrK4fEdFxxwCu8?= =?iso-8859-1?Q?V0pm6B23IcYAR6H8UqdwC0yRtP+iDlE+MlswRjJQ3yGYZoTM/kmXXFTcR+?= =?iso-8859-1?Q?4XDCVBJL3i31+9I5P3bxliBet5Yrm0wPU2Ek8mXRSPdOXFm4ich3QMf6fd?= =?iso-8859-1?Q?Wf6IE/2WgNMWF41F27FZdzKZakuuNkkF/r0nTIt7Ix+G9LjIUnYkB9P/Xb?= =?iso-8859-1?Q?29SBaLF0ygjyVIHyphp8wDeOzTg4+hPtSZI9GaTHE/luW8bC+sKpKr7Fu6?= =?iso-8859-1?Q?YaJMVTUAzf4lJ5PSGL4/jYV4vBPzHKQbNbLqa+18n6c0ZYfMuQRNTX45Tx?= =?iso-8859-1?Q?pmgH26uzxOT8dVj4CBr9aCUtiBv+7KyVASghpzLrzSWpe6yiUZFqd8ZTr4?= =?iso-8859-1?Q?sLR4jymFlfNCAdSudv8bRaxvpgDmgj+RNubWonhrn3ixwDilXj/pH9VLZZ?= =?iso-8859-1?Q?N8zVUGLjYXpeL8Pn/btxrTwhKhWWNDzDT2dmvR555JiqawB2gkK2WfAhrl?= =?iso-8859-1?Q?Q8tTzV+PhOY2qhcgoy64/aM6q5TbSasIFrjtl5EPZNqX97Mr5REBa+wI+e?= =?iso-8859-1?Q?uNefllOnYklAGw4zaEHhryKadAuGbGthawhqlkLVPGWoCfgl2fOiTRIC7w?= =?iso-8859-1?Q?OZJKw17jhzFMOOfGFr3Bqqf5cFUQPCVvZ4Z95Xkh+S8JGFDF6wGT2VIuCs?= =?iso-8859-1?Q?17NU+MDD3ea1uRo6ybg2HeJxoXpy/ceP+tcPjAJ3rHY5Q07/1cTHKfDX+G?= =?iso-8859-1?Q?ALXeKXu7CwE+kbkGCNDedcKNEWrcbFSGF8iuuIOgsP2qFqDE05cGL2aBpq?= =?iso-8859-1?Q?iSgjPtxU0Yq2Efc5LOydktSWIErLU42j5CENEIsrkUK9H5yKz99iumiIM9?= =?iso-8859-1?Q?55Kbr6tC2nUOuePYV8Ke1CEdxsvXCHoNYDqPyAW7KphqE+U5vrLBQqhu0z?= =?iso-8859-1?Q?xjxM1SZL6fVXklLzhMETStm1XnrZ6r1ksTs+z3sYvlTMtJ5udnqawsXPvD?= =?iso-8859-1?Q?7zRy2ZCMMUwL1sdpBdrQ3wEyCbJeHhrKU5//BpNyNE6lPpTwnuMtvVGn7q?= =?iso-8859-1?Q?swokpbumd5svmmdcFst6AClG5aXp/125WOgCGZEZJu6OeoDFHfhGHcyAST?= =?iso-8859-1?Q?jhY9oqKK99pH3PjfzEkNR8ige6AyVawQ6hcJGh0J82bmhNgrVHdng6jWEl?= =?iso-8859-1?Q?Xy7EuM5ukEvHCSiTZHq5DF1G4UyvJ6kvPFqKnzjIi6Zpb17MLY2diw9Ynv?= =?iso-8859-1?Q?6o7WEDJ3NkXzd31WgFTii+hD0fiBVgeSPSyePmj3PgxiPh2/78YT9k2SSg?= =?iso-8859-1?Q?CRHPlZndkA3W2DLDIfltuSlk8uymMQvt6CaTD+6xh+LQA0xP/P4546lc6q?= =?iso-8859-1?Q?nobX0FLfd6Ptz/6/8znlEgwLYBwY1SjVnCv46JjMXQVRHidTteRoDtrWAO?= =?iso-8859-1?Q?tE2bn5+18Dxmqf+uxZxZoop57wAZAu5FBDr3yCB20y0J+jV106LnqBIqbJ?= =?iso-8859-1?Q?HSVrnpt6Lp/8mxUtWDu8yEp7Ez/J77IG07t+cKznfFy/LUq0MPlgJcfyJg?= =?iso-8859-1?Q?95QcAiEalfjJg3NGWYAO7KtdJl+I616YT6S2U8W50aOYYuqp/S6n++lblH?= =?iso-8859-1?Q?sev+nK+jPxUl9be1E3fnzz7jZ5DFNMqJsovas/TYrqrMOg3+e/bx4xeicX?= =?iso-8859-1?Q?YMqBpV5VlA=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dee4191d-04cc-4461-76cf-08da54c4e80a X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2022 03:03:10.9200 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ogzlwjDnfM4vw/MYu32vVg3cgzs50VblEVhwq5EUWbJUAGMw4tBlyBo9xe0Ku/4MW63B6AOXhercqW8Uh5xHQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB2050 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Gaoxiang, > From: Gaoxiang Liu =20 > Sent: Wednesday, June 22, 2022 10:30 PM > To: Xia, Chenbo ; maxime.coquelin@redhat.com > Cc: dev@dpdk.org > Subject: Fw:[PATCH v2] vhost: fix avail idx update error when desc copy f= ailed >=20 >=20 > Hi, Chen bo, Maxime, > =A0 =A0 =A0Please help to review the patch below. Maxime or I will review it when we have time. But please note that you sent= the patch multiple times and did not update the version. So patchwork show= s multiple patches and we will need to check which one is the latest. This = will of course increase our overhead to review. Please update the version number or update the patchwork next time. This wi= ll also help your patch get reviewed ASAP. Thanks, Chenbo > Thanks. > Gaoxiang. -------- Forwarding messages -------- From: "Gaoxiang Liu" Date: 2022-06-22 09:19:44 To: mailto:maxime.coquelin@redhat.com,chenbo.xia@intel.com Cc: mailto:dev@dpdk.org,liugaoxiang@huawei.com,"Gaoxiang Liu" ,stable@dpdk.org Subject: [PATCH v2] vhost: fix avail idx update error when desc copy failed When copy_desc_to_mbuf function failed, i added 1. And last_avail_idx added i, other than i - 1. It may cause that the first mbuf in mbuf-list is dropped, the second mbuf in mbuf-list is received in the following rx procedure. And The pkt_len of the second mbuf is zero, resulting in segment fault when parsing the mbuf. Fixes: 0fd5608ef97f ("vhost: handle mbuf allocation failure") Cc: mailto:stable@dpdk.org Signed-off-by: Gaoxiang Liu --- v2: * Fixed other idx update errors. --- lib/vhost/virtio_net.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c index 68a26eb17d..eb254e1024 100644 --- a/lib/vhost/virtio_net.c +++ b/lib/vhost/virtio_net.c @@ -2850,11 +2850,11 @@ virtio_dev_tx_split(struct virtio_net *dev, struct = vhost_virtqueue *vq, if (dropped) rte_pktmbuf_free_bulk(&pkts[i - 1], count - i + 1); =20 - vq->last_avail_idx +=3D i; + vq->last_avail_idx +=3D i - dropped; =20 do_data_copy_dequeue(vq); - if (unlikely(i < count)) - vq->shadow_used_idx =3D i; + if (unlikely((i - dropped) < count)) + vq->shadow_used_idx =3D i - dropped; if (likely(vq->shadow_used_idx)) { flush_shadow_used_ring_split(dev, vq); vhost_vring_call_split(dev, vq); --=20 2.32.0