From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5508A0556; Mon, 17 Oct 2022 08:21:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4CCEB40143; Mon, 17 Oct 2022 08:21:15 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 316B1400D7 for ; Mon, 17 Oct 2022 08:21:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665987674; x=1697523674; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=2KDS8DxHdYxo/JT92CFAz4z7C5cOndHKaD4/4E4FzCo=; b=hcpuSJtHCRNcj2NEwKPvkGDmoJWea0eaQNWIMBuLye/L2b4u/4qDd7CB btw2YvgyIO2Wrvj3WLPSA/WPlsgfKUWlH3bkyAxerh3xlHMNZicGLgX1v /XbxHbEiCVjR44w1eP61kbIN6kR/94ABRoTo+0TqCiVfpCHD4JH2uFCMq qsiiIO89YCRf2G+v86tF2rBNqonPKLLIYf5QZBDu1V3LEwKFCTMXoAJwv isicHGs5lJGLA+T+WnXFMkVvK7cQc9ORB/zP/QFUl/8fBE1+cXgR/9DFV HTupYusYm6nHVZh3dLuZlo/+KE9ssFGbVKvPHUtR6GQc9avUUje2qL2UL Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="304458438" X-IronPort-AV: E=Sophos;i="5.95,190,1661842800"; d="scan'208";a="304458438" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2022 23:21:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="717380023" X-IronPort-AV: E=Sophos;i="5.95,190,1661842800"; d="scan'208";a="717380023" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 16 Oct 2022 23:21:13 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 16 Oct 2022 23:21:12 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 16 Oct 2022 23:21:12 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Sun, 16 Oct 2022 23:21:12 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Sun, 16 Oct 2022 23:21:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NgjZzbC+mcn3Fuo3a9HZMXNjoAF+Z14uj2KR7bmF3Z2d6vm/TGm0uePcGafGch9QBD4DPm59r7u7v844lIHrtxYNKnlsXRjdVTxt24njhYthgJO+U/EoVRzSqaCu4/OkacxNRcbHSweRaaa/U62XbHriN8GgpOslhoFCuaEyEaZO4NbAQQIy96vMrLnEvomlKjpoDyan5/fNrcoZ2OG98NedV7Te2QPoMcNhGIT68LLh0N1NRUR2IRBOanw+1YMfi/jozwDnKllT6YEbfbjDDLm246JztJ5L+9npQ11b+Sbp4aFFyIcG2KYzhZvu/0t+EI6px8WYf8u8M7aRfZt9YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=juAFZ8dw/b32iXVr4GWots5m2Pl1YjPKsRHdNX3sJz0=; b=EITBr3s/MYcz4mAF3i+3QDrWHAEMIVgViNqt8N0J7FJ0dUr+zytkuAcKV74WGv4IRasHKfYoRFGn3zuq98qwq4jCSLxkz2PgMviLveReQNr176Q1SAf3/4ss1ib7vShWXw3Q43WlHiaijlV0KWC0ZmEGLeJq6EUdTdf78SAzOkaIXrlK4VFz0L9eQ+/Esxe7Fi/Ohno0tAETfOxbW4dHrUfDktZmf6wKdcveX3FJ2HrHB1vhmQ+8pmzVTwkDn4Y/a3l3WBqtzTHP+4d9EJFEhoG7M9Gei1Jn8clF1F4wuh2fGozCzEpjHLGLVDqY4kg2q2x7GfxqGtvYi1hDnGKmxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by PH0PR11MB4935.namprd11.prod.outlook.com (2603:10b6:510:35::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Mon, 17 Oct 2022 06:21:10 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::39bf:57b1:4824:d40d]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::39bf:57b1:4824:d40d%6]) with mapi id 15.20.5723.030; Mon, 17 Oct 2022 06:21:09 +0000 From: "Xia, Chenbo" To: "Pei, Andy" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v4 2/8] vdpa/ifc: add multi-queue support Thread-Topic: [PATCH v4 2/8] vdpa/ifc: add multi-queue support Thread-Index: AQHY3uB/9NtPwiOuZEOKAu7kv7CRyq4SI3Ag Date: Mon, 17 Oct 2022 06:21:09 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1665650674-291949-1-git-send-email-andy.pei@intel.com> <1665650674-291949-3-git-send-email-andy.pei@intel.com> In-Reply-To: <1665650674-291949-3-git-send-email-andy.pei@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|PH0PR11MB4935:EE_ x-ms-office365-filtering-correlation-id: abdf8382-0604-47ca-3480-08dab007c853 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: G2p/LbTH5JTeOX4t1iubE6Tcmdj4wP0XYIO+70VlfvT77zyihNkcH7RGwA3NOWkKWYP2dZ+GjmVnZIH67iZ10khrBvj4BAotLlgQBKxDPHdaBpPzb5DNm1iWvB8nLvJxYNPZ18yzFc9N30NIQHlh5nYd+P7k9MqHjo89FQo9G44VTYs2u/lZQt5E7wEfvfHPpKm0HNPtSu1cxIc6sz3/1iotMlTkGrSL/qSztHfD2KUYv7L6LM9KjFLpsAn0fi0JkmcIlBYjdU/nmQhL5B9IRhyI1BaRjK/jcUZfU99eDDpsFss5jM3x0GtDC7YfuaWb4w9urbxT+uNtGRq4fHZUX/+heyZ+6RolrHm18hxegGXklR1pjkk1RN1dMKe5Qjh/5LC0Rsl5OrzDJ4Enh5WlTKYqRVCI4RV52Z0ZJ3t+yWxCaXYZV5zviJyUuqf1ZFIkIgZ4D4imNluGYFUEj+Ub/1P0Dj6k8Qm2W+GNFJcrRZ1XCdNVx6ip5v1XlU2jrXHRJvB4s6FFKrnZeykc0TUcrWKcArsuTCJhjDILeukQQfflWWskqm6N7PzQuiPwfn7hUjuw32YNQPqWMZtdh82afVUoPeGscTiV2G8SDgXiy9UEMbE2rhjaD87QJfU3dlqFzHQIuv5pwrVG+DHVgNaI0kkjSWZRPjRPlYaz5BLjeBD3E6JBNVnWxeDY2Z4wuB4RwnO8AqoNCtp79Fw9Nfxk1fNxgEDc+iym3MCEUVN00Lcxw138fkAzpXZz9l6sk2wNqhkn23gYgOo1rTvGzEp2tA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(346002)(39860400002)(136003)(366004)(376002)(451199015)(33656002)(86362001)(38070700005)(122000001)(38100700002)(82960400001)(186003)(55016003)(2906002)(5660300002)(6506007)(7696005)(26005)(53546011)(9686003)(478600001)(83380400001)(316002)(71200400001)(110136005)(54906003)(76116006)(66446008)(64756008)(66946007)(66556008)(8676002)(4326008)(66476007)(41300700001)(52536014)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?v+cAHRaxK5kUp9blK6WRX46I4pGkBO7qAXycH6tIf1gub4UzNaTdJVVDr6zb?= =?us-ascii?Q?FcdBKfUa3r4trtXioizaK8bIGeMEh/OluxWkb43lYC/9sflBBNlPonmNxOrq?= =?us-ascii?Q?sfp18uPeA4mzUUjnaxFGpQ4wGh6AmQN7iEroN/dkGWuecHvkk3b+WD5h3emr?= =?us-ascii?Q?EVESzpggW6dRO5F1mvuaRnKmVx1zXI/xo/bn7/V705Dx3qww3c297FOACCLq?= =?us-ascii?Q?Su2tLr0wdM1VPJPxGXiuLUgkNcJjIWCN+/L1tIDswVIu82cYC75LNBStnnGy?= =?us-ascii?Q?Eiq6cSArWE7e8jbtwUbE9oe26XSsN3ak1M3h5yJMe4tbs0O7gy12n18cH1el?= =?us-ascii?Q?qUF8mNg6N79aHrSgjq3RyOMNQ+poaT/P7TvwCI4nwh1tiO7lMhNEBtBuOPeD?= =?us-ascii?Q?upeMndmWhpFhum2ahADKOw+Fl6YykPt731ftVDg96vxzO837V1MeeliMDPx7?= =?us-ascii?Q?CljmbTUQq+yRaIvZW+o6oT/8GwKJEC2TN5MYlzRUpv4S1sU5JBmLMciJtYQu?= =?us-ascii?Q?hbNFoSCEy+x+9J8YA4ymT5074Fh8qI0AuCRseU/5z7AaQKPG47sF/gKltWQC?= =?us-ascii?Q?9hSo3tnJWNgmlPjJnYLdhksXh264PiUU7IOTpW8FMMu9BwwF5Ki37i1d1LaG?= =?us-ascii?Q?wFejT6b3Dh2wzoqifjIIhkdiQfriE7POqNtCd4fQNUap4TguSjMKucWnLCo0?= =?us-ascii?Q?FZfSWj01a5ElOIKT0r0z9Cplrs/zIv6YkExI+s3lFrU0jYMTPT+BWIuKjzoR?= =?us-ascii?Q?Co5SNA/k0yfZKa97ZDQ9fTUGaf9VwLCUV3E3NPMcMKkXHbEC7QQdVDIYkPox?= =?us-ascii?Q?UrUhKCdCRevk32OLDcKPZnWZ/F1EyB9ApT/lmaqSpJfM566/jdYRJD4Anrjj?= =?us-ascii?Q?OSXmdIPP7dEA1JYJ4GqUIuXpSCl+gu7F/VPJlVj60ZM4W8OCao6ky9SiFTDw?= =?us-ascii?Q?V2Me2Oy5lpbo9GfFMbHWn2jqyCaDr97ZvpFKpTukPVoCUjyLRKF7RDvFXZhy?= =?us-ascii?Q?vdEkud8nqggEriZxOayUHKSI/yCoCT1DSduDN0kSZzzhKCGbhcCGdRiOr02c?= =?us-ascii?Q?LdSso+iJEBqXUDXSL565VwIuBy/gonXnwcegxO1BCDGzi5S6woEUvqQtZzd7?= =?us-ascii?Q?Z7EAToD9TfFGk7FyR+nLKZ4vnpF3McIufdycjXyKZmd1zYCjs0CU8DDDxnJQ?= =?us-ascii?Q?V8UBHgcHxu9j0N/tuJFl2n4PEJo5uweX8xQh9Vu+L9Uyq0aYE6ALAsCzyLB5?= =?us-ascii?Q?im6EMFzAdpkQosxJtnB/dzqUeWyBGCNM6B/LSGSM7nZpmgRwkO8UGbPI8Cir?= =?us-ascii?Q?LkhpgwxcIVL6Bj1Gauv5mxvy7oM2h+h8Ep7aSOB2AsdEFgh9379hV5hBMRDt?= =?us-ascii?Q?D6uTQ3WFj0WqfCriEUCDYJT+0UydQ3bHtbmZb9apz9qBdE7iS9n2jv7gnvNL?= =?us-ascii?Q?U5aHnrqsaG5uwmGgnPCTckhE3Gz/te4e+g8Fab9QtC4+llMaL1sCbyMB8JL7?= =?us-ascii?Q?BL3YYoIWWZqXpHq05hP7ROxBReYTpQ3U0o+hP57mCxW4zIOQBEmlqJV3GAzQ?= =?us-ascii?Q?ncB1Y8F/WJ4KGoLXiTrLS5WkeNPuBxdANPDoxHzS?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: abdf8382-0604-47ca-3480-08dab007c853 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2022 06:21:09.8033 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vGmrK3NndHSJ12XPXNl0OZadEt//b3KyODdPwuhfq22G0kKxrhN086db7daulsPsGbl3UCi9uAPshMNKTAWchQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4935 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Pei, Andy > Sent: Thursday, October 13, 2022 4:44 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coquelin@redhat.com > Subject: [PATCH v4 2/8] vdpa/ifc: add multi-queue support >=20 > Enable VHOST_USER_PROTOCOL_F_MQ feature. > Expose IFCVF_MQ_OFFSET register to enable multi-queue. >=20 > Signed-off-by: Andy Pei > Signed-off-by: Huang Wei > --- > drivers/vdpa/ifc/base/ifcvf.c | 9 +++++++++ > drivers/vdpa/ifc/base/ifcvf.h | 2 ++ > drivers/vdpa/ifc/ifcvf_vdpa.c | 1 + > 3 files changed, 12 insertions(+) >=20 > diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.= c > index f1e1474..81c68c0 100644 > --- a/drivers/vdpa/ifc/base/ifcvf.c > +++ b/drivers/vdpa/ifc/base/ifcvf.c > @@ -90,6 +90,15 @@ > if (!hw->lm_cfg) > WARNINGOUT("HW support live migration not support!\n"); >=20 > + /* For some hardware implementation, for example: > + * the BAR 4 of PF is NULL, while BAR 4 of VF is not. > + * This code makes sure hw->mq_cfg is a valid address. > + */ > + if (hw->mem_resource[4].addr) > + hw->mq_cfg =3D hw->mem_resource[4].addr + IFCVF_MQ_OFFSET; > + else > + hw->mq_cfg =3D NULL; > + > if (hw->common_cfg =3D=3D NULL || hw->notify_base =3D=3D NULL || > hw->isr =3D=3D NULL || hw->dev_cfg =3D=3D NULL) { > DEBUGOUT("capability incomplete\n"); > diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.= h > index ef7697a..d16d9ab 100644 > --- a/drivers/vdpa/ifc/base/ifcvf.h > +++ b/drivers/vdpa/ifc/base/ifcvf.h > @@ -50,6 +50,7 @@ >=20 > #define IFCVF_LM_CFG_SIZE 0x40 > #define IFCVF_LM_RING_STATE_OFFSET 0x20 > +#define IFCVF_MQ_OFFSET 0x28 >=20 > #define IFCVF_LM_LOGGING_CTRL 0x0 >=20 > @@ -149,6 +150,7 @@ struct ifcvf_hw { > u16 *notify_base; > u16 *notify_addr[IFCVF_MAX_QUEUES * 2]; > u8 *lm_cfg; > + u8 *mq_cfg; > struct vring_info vring[IFCVF_MAX_QUEUES * 2]; > u8 nr_vring; > int device_type; > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.= c > index b4389a0..008cf89 100644 > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > @@ -1248,6 +1248,7 @@ struct rte_vdpa_dev_info { > 1ULL << VHOST_USER_PROTOCOL_F_SLAVE_SEND_FD | \ > 1ULL << VHOST_USER_PROTOCOL_F_HOST_NOTIFIER | \ > 1ULL << VHOST_USER_PROTOCOL_F_LOG_SHMFD | \ > + 1ULL << VHOST_USER_PROTOCOL_F_MQ | \ > 1ULL << VHOST_USER_PROTOCOL_F_STATUS) >=20 > #define VDPA_BLK_PROTOCOL_FEATURES \ > -- > 1.8.3.1 Reviewed-by: Chenbo Xia