From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 615A342C57; Thu, 8 Jun 2023 04:10:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E118F410D3; Thu, 8 Jun 2023 04:10:53 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 7E0AB40042 for ; Thu, 8 Jun 2023 04:10:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686190251; x=1717726251; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=Ts8rU6bM2P9fja/Kok+4EVcwHFJf6NlKGa8upHm3dLA=; b=mxGDyJHOxSi7Oa2p3wPv5haLx6ZJASAvnzLzrpnEUTdzLqXZmF2nQIqW 2ZBUUkLbcwOkTD31X6TWBya9FRGySQO5vzaXU1840qeXS++yi0JbR4m0j fHl55hif323dXp4gLS9KHoLut7mEF6QS0gof6ORh8793cSWOm8Da4NwP/ G51QtTPLxK0yfGHI5CfpDDD6EEWGY6/+xyXXlMcaMY7u4+u1zQ/4AZP+3 u7Fh6Yk+Y+WuN4MHUyhS9narIE+Xd4zU++dRxSANU+eqgCpZhrdK652+q pCReznEQtkRtn1DlAxcydUcCu5miOI1SN8AsYMXmCIq0N2Cmnq9jPyDF4 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10734"; a="420733964" X-IronPort-AV: E=Sophos;i="6.00,225,1681196400"; d="scan'208";a="420733964" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2023 19:10:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10734"; a="1039922890" X-IronPort-AV: E=Sophos;i="6.00,225,1681196400"; d="scan'208";a="1039922890" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga005.fm.intel.com with ESMTP; 07 Jun 2023 19:10:50 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 7 Jun 2023 19:10:49 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 7 Jun 2023 19:10:49 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 7 Jun 2023 19:10:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A1znDi846hHMGLHiZqtfdK3GDzHisk2g6l2eFAJXDSxh6W6ojikEeL7s7m3L6yKnYbaPLEy7LaAJYx8mc0Kl6otPGnOjQnDG10M8kLx89HKQwd0Ep0/T+0jpI/TR0LKJ7lYHgIpRGcvXs4btN04b9GQSpwABRh/yyY91Tq175Ib6UBZe1zhTap3DDBkAOlMrq8gPvEoeIGI4PzKalnFGZIWgr0rwO2UKVtzXRQiCpLVW6arE514oQRIWPwkA0dJk6UX3QKgQDc/eXRl5kSV26DGtEtyYIRat61E3/o5sR9vx5fxhFjK4fErN/E9SvQxe5MOlOzFptH5sqqnmVPQ7vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PxxnxfJf/42bVhx/DQvb2icNaZ2LH8EbncJLhPsqNss=; b=fAuJ08LharaP0gLV5AWf0RjQxb/q1vWvim8fukvAmhI1vK0kihgMDDSbCG2yWsn+tq37bCmy0SQQyzCiTNZ8CidVUULIBPVJwx00PxY+18ZC1RVDT8FmCJJ8fYgk2JDbloWhpO28QExgLEF41Jq573DXcSkXwRRiNTYRTVoKZHdehOAZEUn3iqWDpsxknJFXX9ZSe5tp9kUiol0PJ7/ojuyevbsATZmvUtoSLQWfiQ3wtNFjBAHJBc0je/I7AGJ5bL9TBY7gCS4Ra1Rv582RUUaXwX1IRjHA/c5F138IDZUfPmw+cddtKY8jzB7AJPLKAcJaO+brGtkIrKH+M6E93w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by CO1PR11MB4836.namprd11.prod.outlook.com (2603:10b6:303:9d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Thu, 8 Jun 2023 02:10:47 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::e508:44ff:3d34:60bc]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::e508:44ff:3d34:60bc%4]) with mapi id 15.20.6455.030; Thu, 8 Jun 2023 02:10:47 +0000 From: "Xia, Chenbo" To: Maxime Coquelin , "dev@dpdk.org" , "david.marchand@redhat.com" , "mkp@redhat.com" , "fbl@redhat.com" , "jasowang@redhat.com" , "Liang, Cunming" , "Xie, Yongji" , "echaudro@redhat.com" , "eperezma@redhat.com" , "amorenoz@redhat.com" , "lulu@redhat.com" Subject: RE: [PATCH v5 24/26] vhost: add VDUSE device startup Thread-Topic: [PATCH v5 24/26] vhost: add VDUSE device startup Thread-Index: AQHZmE/DevdcrI8+akezxq1aXMcNsq+ALDKQ Date: Thu, 8 Jun 2023 02:10:46 +0000 Message-ID: References: <20230606081852.71003-1-maxime.coquelin@redhat.com> <20230606081852.71003-25-maxime.coquelin@redhat.com> In-Reply-To: <20230606081852.71003-25-maxime.coquelin@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|CO1PR11MB4836:EE_ x-ms-office365-filtering-correlation-id: 19e09127-8c11-4f7c-8baa-08db67c59280 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ruBMtOkteKKCFrNaSQ5WA3Nh+1x1GwyvK3CeFuOqFC7HeNR0wRcLDL5zOwL1XRD7KXFYAr68yqEJY/JHRVez3DINhukfakpfrZG3JE8AjzcTnBvZy+dsf/rU3my5ahVt6/Oh0SEym/FoBNYc6fD1TZwZ1etQ+llAk4V+VFGtV5ZtOty1S/p7435IR4WVodcCEAkXwYlFNy9hdeIDqYSpjkSSzoMdEak2SJRpptL3p1WTb+C00l4QprgQUAhRBCMRZ0F3dknrsmZkJluNs0B+2uZcVF+2gClwLO/bgx6BknkqHCZbrPxdjXHz8j9JwrbMOU/X3YS1Es45Mmc8Bibiyjd87XMZlI2OTdePwYjtMH9Ms2Ftk9qESE0Q6Wc+NfZFuajKWzQKxKrlRBf7wKy8a/ehW33Cnd5Zc9clVDb+tuCPQuN+Qn6hn2/1Ax7QGHRwoA9NGkdgP75dNIo4bkR16JvTnEgcn7Uu3rp4RVqcuMBoV+HAYMPDah8LbImLMZYJfYI8p0nmjuKAmwT8xQHGuAicElpmzf5CRxLhXrihfcoodBtBA0Kwj30rTASdUsCzD+gk+ryWYTobktlaj0Pbr4IIHsfwSoz+Tafvta/Uiq0gqPx4mZSRvNq42ApxON7wnZKNirHw6RMoDTwOPljcDA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(376002)(396003)(346002)(366004)(136003)(451199021)(6506007)(53546011)(9686003)(26005)(7416002)(52536014)(83380400001)(122000001)(86362001)(33656002)(186003)(82960400001)(316002)(55016003)(2906002)(5660300002)(8676002)(38070700005)(8936002)(41300700001)(38100700002)(66476007)(66556008)(76116006)(66446008)(110136005)(66946007)(921005)(64756008)(478600001)(71200400001)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5F93vxr8QDdqSKQvzu6xtJ46hC4raWr8r2pUtywrFKZ9XWTt+BnY4a8YZUNy?= =?us-ascii?Q?i0C6VOLoaJBxZ1MQMplG/Aoqn+uSef7TPps9oorNIclzv4LRLseP0o4rALWF?= =?us-ascii?Q?Wc4b71zq1QxGhSfQzv0riDj+TDx3IkGJfoUQ1bFNM/SZ+PlXFvA8o3VZ6ff8?= =?us-ascii?Q?W2Tj5X1egNLbT+7wIQYRyKX8UveGV+PSBUxsjFsvc+skhxkBbSDz45uuWjQD?= =?us-ascii?Q?1P81dLDir50hrtBmIK7rsj4ttpaxFBOgOGIpk/TlzmUKuvbYufuyg3ebdgaq?= =?us-ascii?Q?Xi33ihhUHSKFzeL+dSVrOiVV/USg56YAj67FwLcFOLd/ebAhlIOJ0kMn0W0U?= =?us-ascii?Q?LtdamU9RzZ/BSKdKxoiDc4cgZoqgv4fpT3eEaG/zHVBnRLc9qFKbrtakMaeG?= =?us-ascii?Q?X+cHFF3WMQP5QRF9WIhGjL1PrFmZQ76SVY2OxecXb2eJ7UhLbq3N4lASJbnN?= =?us-ascii?Q?VBwf9xqknHb1nRWo32V8KPDMNZ0UZzSXiK9rLg50J550+sDt6f/6JH1SAf82?= =?us-ascii?Q?i7EENu3+5HHcJf3GGe0MGpv1y7+v3qkluuRoOAz0EcbT+90pyArVDctiXVsH?= =?us-ascii?Q?SfG6MxajTFTUZwH4sZHAWiKj3FFOWglaHZpT4d5CMeeJz27puboXehjfIMCg?= =?us-ascii?Q?2lTpOTjMCOhP/zbPBXMfYljRCfOxnYPpTMsv98qJfwXvQlJ96cr95AZ710MZ?= =?us-ascii?Q?lk/OqkuTIshBmVpSy0rX+yTfIMbsSXziQfOQPgV+SDo77MODmAH4VsmSvREF?= =?us-ascii?Q?uuk4rM5We1974Ogo5VIdEMfo+N2CLp14B5TDFa/FBNgsSReVMBvQ8/wtG0AC?= =?us-ascii?Q?x+Wk/8in/nA7+BJOdaGkqmENPCxb/rV8QTDlFG44YY1avVl16Sqyw071+cJE?= =?us-ascii?Q?auPOKI+64tgGuDvUnDCzXqMM/IDiHxp32a2gjxo0Lngg7TaYYDxhP6ULQCuf?= =?us-ascii?Q?YR1t1yKN6LjHO3IU177CMJNXB08aFS7xjSCi160kjR1+gxfr0PE8jnYO20Mk?= =?us-ascii?Q?QTfQrOgZ2awDSq52lFoS8PRmCCA/t1x+doKObvaib0caE7olWDbQQ+T/aGsS?= =?us-ascii?Q?301aqHe/v5LRTbqgIF88m4HLXBn1ALQQeFd+dt1Rz5ze4YAGhe908G9b9gfv?= =?us-ascii?Q?Vsv4s1dGewyb6t6sYjqDElNuvVQlj2HMH+JHE5T7OSrutTTZEC0c5btrs/em?= =?us-ascii?Q?FX/6cFgGWLdnkcgB7A9of6JENZXNOoq5uOSU2IUX4v/HYEVyv5kH43b4P0sU?= =?us-ascii?Q?gp03gYpeDeJe5VdBBZnr+OH5zL96Tyv80VDkd5P5AoOQ+lLwpb5ziLAh280F?= =?us-ascii?Q?IhMC79db1S4Xy3AIVwhYGSFLJ4woBpghZwQa7sL+DzwR06RF7IPAxz8zxi79?= =?us-ascii?Q?DCQABSmBWpzYN2+E9zRBGzIHlD4Hq9YbuLozu1F0Sk/EZEOkR24LaP9vK4vS?= =?us-ascii?Q?HDU/A+vD5e1nQ3FwB7o7U1X318eqfd78cwI1+LcXOU6h2mzUzDJsDFHGfF65?= =?us-ascii?Q?if/H/uj3XuzUmZ36GX8fpM5TVYs3cy9LM/yAOqlhw4xL2RQNcC9Qa1e7Ooqb?= =?us-ascii?Q?hoxU5o+6rYM6oFSucUI7jep39MzzVav6821hOsG5?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19e09127-8c11-4f7c-8baa-08db67c59280 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jun 2023 02:10:46.6955 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZFFJgJdTGd0ip1ZSxffYFDpQu4edoRx6ZyyLe7P6iogC0jcepRccxwfGxfPWglkkkWKRp28aT7eOzl6Sjn/qWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4836 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Maxime Coquelin > Sent: Tuesday, June 6, 2023 4:19 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.marchand@redhat.com; mkp@redhat.com; fbl@redhat.com; > jasowang@redhat.com; Liang, Cunming ; Xie, Yongj= i > ; echaudro@redhat.com; eperezma@redhat.com; > amorenoz@redhat.com; lulu@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v5 24/26] vhost: add VDUSE device startup >=20 > This patch adds the device and its virtqueues > initialization once the Virtio driver has set the DRIVER_OK > in the Virtio status register. >=20 > Signed-off-by: Maxime Coquelin > --- > lib/vhost/vduse.c | 126 ++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 126 insertions(+) >=20 > diff --git a/lib/vhost/vduse.c b/lib/vhost/vduse.c > index 110654ec68..ff4c54c321 100644 > --- a/lib/vhost/vduse.c > +++ b/lib/vhost/vduse.c > @@ -141,6 +141,128 @@ static struct vhost_backend_ops vduse_backend_ops = =3D > { > .inject_irq =3D vduse_inject_irq, > }; >=20 > +static void > +vduse_vring_setup(struct virtio_net *dev, unsigned int index) > +{ > + struct vhost_virtqueue *vq =3D dev->virtqueue[index]; > + struct vhost_vring_addr *ra =3D &vq->ring_addrs; > + struct vduse_vq_info vq_info; > + struct vduse_vq_eventfd vq_efd; > + int ret; > + > + vq_info.index =3D index; > + ret =3D ioctl(dev->vduse_dev_fd, VDUSE_VQ_GET_INFO, &vq_info); > + if (ret) { > + VHOST_LOG_CONFIG(dev->ifname, ERR, "Failed to get VQ %u > info: %s\n", > + index, strerror(errno)); > + return; > + } > + > + VHOST_LOG_CONFIG(dev->ifname, INFO, "VQ %u info:\n", index); > + VHOST_LOG_CONFIG(dev->ifname, INFO, "\tnum: %u\n", vq_info.num); > + VHOST_LOG_CONFIG(dev->ifname, INFO, "\tdesc_addr: %llx\n", > vq_info.desc_addr); > + VHOST_LOG_CONFIG(dev->ifname, INFO, "\tdriver_addr: %llx\n", > vq_info.driver_addr); > + VHOST_LOG_CONFIG(dev->ifname, INFO, "\tdevice_addr: %llx\n", > vq_info.device_addr); > + VHOST_LOG_CONFIG(dev->ifname, INFO, "\tavail_idx: %u\n", > vq_info.split.avail_index); > + VHOST_LOG_CONFIG(dev->ifname, INFO, "\tready: %u\n", vq_info.ready); > + > + vq->last_avail_idx =3D vq_info.split.avail_index; > + vq->size =3D vq_info.num; > + vq->ready =3D true; > + vq->enabled =3D vq_info.ready; > + ra->desc_user_addr =3D vq_info.desc_addr; > + ra->avail_user_addr =3D vq_info.driver_addr; > + ra->used_user_addr =3D vq_info.device_addr; > + > + vq->kickfd =3D eventfd(0, EFD_NONBLOCK | EFD_CLOEXEC); > + if (vq->kickfd < 0) { > + VHOST_LOG_CONFIG(dev->ifname, ERR, "Failed to init kickfd for > VQ %u: %s\n", > + index, strerror(errno)); > + vq->kickfd =3D VIRTIO_INVALID_EVENTFD; > + return; > + } > + VHOST_LOG_CONFIG(dev->ifname, INFO, "\tkick fd: %d\n", vq->kickfd); > + > + vq->shadow_used_split =3D rte_malloc_socket(NULL, > + vq->size * sizeof(struct vring_used_elem), > + RTE_CACHE_LINE_SIZE, 0); > + vq->batch_copy_elems =3D rte_malloc_socket(NULL, > + vq->size * sizeof(struct batch_copy_elem), > + RTE_CACHE_LINE_SIZE, 0); > + > + vhost_user_iotlb_rd_lock(vq); > + if (vring_translate(dev, vq)) > + VHOST_LOG_CONFIG(dev->ifname, ERR, "Failed to translate > vring %d addresses\n", > + index); > + > + if (vhost_enable_guest_notification(dev, vq, 0)) > + VHOST_LOG_CONFIG(dev->ifname, ERR, > + "Failed to disable guest notifications on > vring %d\n", > + index); > + vhost_user_iotlb_rd_unlock(vq); > + > + vq_efd.index =3D index; > + vq_efd.fd =3D vq->kickfd; > + > + ret =3D ioctl(dev->vduse_dev_fd, VDUSE_VQ_SETUP_KICKFD, &vq_efd); > + if (ret) { > + VHOST_LOG_CONFIG(dev->ifname, ERR, "Failed to setup kickfd for > VQ %u: %s\n", > + index, strerror(errno)); > + close(vq->kickfd); > + vq->kickfd =3D VIRTIO_UNINITIALIZED_EVENTFD; > + return; > + } > +} > + > +static void > +vduse_device_start(struct virtio_net *dev) > +{ > + unsigned int i, ret; > + > + VHOST_LOG_CONFIG(dev->ifname, INFO, "Starting device...\n"); > + > + dev->notify_ops =3D vhost_driver_callback_get(dev->ifname); > + if (!dev->notify_ops) { > + VHOST_LOG_CONFIG(dev->ifname, ERR, > + "Failed to get callback ops for driver\n"); > + return; > + } > + > + ret =3D ioctl(dev->vduse_dev_fd, VDUSE_DEV_GET_FEATURES, &dev- > >features); > + if (ret) { > + VHOST_LOG_CONFIG(dev->ifname, ERR, "Failed to get > features: %s\n", > + strerror(errno)); > + return; > + } > + > + VHOST_LOG_CONFIG(dev->ifname, INFO, "Negotiated Virtio features: > 0x%" PRIx64 "\n", > + dev->features); > + > + if (dev->features & > + ((1ULL << VIRTIO_NET_F_MRG_RXBUF) | > + (1ULL << VIRTIO_F_VERSION_1) | > + (1ULL << VIRTIO_F_RING_PACKED))) { > + dev->vhost_hlen =3D sizeof(struct virtio_net_hdr_mrg_rxbuf); > + } else { > + dev->vhost_hlen =3D sizeof(struct virtio_net_hdr); > + } > + > + for (i =3D 0; i < dev->nr_vring; i++) > + vduse_vring_setup(dev, i); > + > + dev->flags |=3D VIRTIO_DEV_READY; > + > + if (dev->notify_ops->new_device(dev->vid) =3D=3D 0) > + dev->flags |=3D VIRTIO_DEV_RUNNING; > + > + for (i =3D 0; i < dev->nr_vring; i++) { > + struct vhost_virtqueue *vq =3D dev->virtqueue[i]; > + > + if (dev->notify_ops->vring_state_changed) > + dev->notify_ops->vring_state_changed(dev->vid, i, vq- > >enabled); > + } > +} > + > static void > vduse_events_handler(int fd, void *arg, int *remove __rte_unused) > { > @@ -199,6 +321,10 @@ vduse_events_handler(int fd, void *arg, int *remove > __rte_unused) > strerror(errno)); > return; > } > + > + if (dev->status & VIRTIO_DEVICE_STATUS_DRIVER_OK) > + vduse_device_start(dev); > + > VHOST_LOG_CONFIG(dev->ifname, INFO, "Request %s (%u) handled > successfully\n", > vduse_req_id_to_str(req.type), req.type); > } > -- > 2.40.1 Reviewed-by: Chenbo Xia =20