From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B11E6A0032; Wed, 14 Sep 2022 03:59:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 812BE4021D; Wed, 14 Sep 2022 03:59:25 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id E89F140151 for ; Wed, 14 Sep 2022 03:59:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663120764; x=1694656764; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=N59QaqL6nFkQOVGRAjuTUfYP5nKtzmsiS6mWZ1je5GQ=; b=Lf9X3EPFZ0277gsHQ7AyVjtwLA6FWDVybelFqbZ6iZclQLjUuU1uEKz9 304B2JD/Wz0nTaj8dZLONO4rNlxeGggoK8GDncYAxJpRkimPO+7AssMN3 Hpg+flZYYubNyd6ProqVqWKJ07cyi2AzKgTThnhNnDGbgoYuJoMMUSSU0 k+pjpyC5wgc6lJiVrNs/u3pP53y/SLs6v4/vP+Eyxk/0ZqtYx8Z8yIbQa Gd67CXHQt/9cbc/9EiWNhxNuLZvv2k/o+zZlJIH/QLQLjY8mWdbO6EKoR rhIa634DmBE8OSWhLP9vAWxLBsJmg3kI0eTiGHTjOFfcsecxy0JI6QtBy g==; X-IronPort-AV: E=McAfee;i="6500,9779,10469"; a="295894645" X-IronPort-AV: E=Sophos;i="5.93,313,1654585200"; d="scan'208";a="295894645" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2022 18:59:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,313,1654585200"; d="scan'208";a="945323449" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga005.fm.intel.com with ESMTP; 13 Sep 2022 18:59:13 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 13 Sep 2022 18:59:13 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 13 Sep 2022 18:59:13 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 13 Sep 2022 18:59:13 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.47) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 13 Sep 2022 18:59:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mzoi8IxW39bUV7z96GQ9QSVfvpnTf9gRvNY1BqB91RNSl0TSZjYlwIseV3cENomvkv+TlRGDtKIdTc1NGaU7bVaR9cDh5S1tdv18Vi+d6DIiMIxJH4Xuw7Q8aHxKuXkBibyxHc2IartPfLfTHxKcF8vRKEFQWjFyyZIQcMR96hl8vfpqZv2ypNqIMlbOsQIDb8+AD/MYTUZ1PtV9bPplDXuMAx1xWXcgM6B8RORfJnxPDR5Kt4MblGBHQMPvAVOFBG32syqb12s9kT7BOOh6n4HBXrSQbUqlhK24hj8frn4T6RkDWtmcG4QfShkI38L8TUm19WaNhcFOFITHEvfRfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=osfetmlRV3NSX2UWv6J6iCLNQeak5BT+tzEtO572m3o=; b=gxMy88iHI13q+LN+UdGF2I6p7s2hoC3LnKrn3MPy+jyncMH/Rxnmqt0gmNbSSYo9BepMaigMyKBV81Ej//haQRNBZHKK6b6SuG6AE/e9XeNcZnzVoh5NdsjYxwkXd7u/Ihdnk7+CrlNt9I09N5ltqw3YyLH7Sap+6yoqx+9Epv7EaKzjIZmfK3TdBKWZoPgAixo2CYa1IixlnXK944YTcGYsBg2LSp7SPwYBMxPbtWT1kVQAsn1XoxHzFkriUgWYNfaFaA3tPTYgOM1hniyBNkdd7gaXUGleb5X47gU9xV0giYZq/rEMd0pSWRwpUw6eNNENNPhqeZR+ft4JbDRwWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by BL3PR11MB6436.namprd11.prod.outlook.com (2603:10b6:208:3bc::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Wed, 14 Sep 2022 01:59:05 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::408e:79cb:b715:b8ac]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::408e:79cb:b715:b8ac%4]) with mapi id 15.20.5612.022; Wed, 14 Sep 2022 01:59:05 +0000 From: "Xia, Chenbo" To: "Pei, Andy" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" , Huang Wei Subject: RE: [PATCH v2 5/8] vdpa/ifc: only configure enabled queue Thread-Topic: [PATCH v2 5/8] vdpa/ifc: only configure enabled queue Thread-Index: AQHYw0dZyf/F11SJ80+DAxHv5UgtTK3eMobw Date: Wed, 14 Sep 2022 01:59:05 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1662616458-164613-1-git-send-email-andy.pei@intel.com> <1662616458-164613-6-git-send-email-andy.pei@intel.com> In-Reply-To: <1662616458-164613-6-git-send-email-andy.pei@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|BL3PR11MB6436:EE_ x-ms-office365-filtering-correlation-id: cff9a12a-73ef-4040-a0a0-08da95f4b448 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +8An24KZ61t04lKQUWXASZhn5p0lFZTYQ8d97hwxbszG8pxxFO47ugHMfPyrnljQ8S5fIgC0dkI8AfNI1RGOurRBWTHCLuLeDNPQCIdoj7TMwuV7+ceeIn1QOmkrySGlsDCPc0BH6Myq5B/vbc+sMYgyE+kLUUCmOUJWIncYS43deZ+XG9kNOp/XydGrSWvH+J5wBpFWw679feC/r9dxRg7ywb+J/eld1vOaF06tzFjLelTNERWUvTf85vaUdyjimawWWdXpkRzyStR+yX+Fi7NBiHiuvQU2eiZopM5l0zo44FEBfJ4HXBW4ffHuceExogMb3PGFmFOy+uY6DkmG9dMGNCd37PAMDQR5R/xwCILq6YFly/0R5jZXYRhMDA2XRUA3h6er6lhAYRKNayIfj/x/hxTlgqJoICpI3xKCkLVIrVaX/s03qQPO/bSMgDZAiDlMFk8GyN3UPjJWSqV4fswHDR2EB4wBsxpca6RCYazoD8s7T+vSsD3ce76Z1Oq37BxwYSGzmNp3yFo+PxQVoN8n6NsqZ8co/B5TWlEdJdicsCobZAiqnLB8Sv1V/2A2VhhwM8QJrDl8oFU9o5FPwI7OlBYkQvD+rl2UAidl/6VBweAFW3GegCjxKj0aWKltboMaycAHcgU+KOVmPuJjTfl7eJ6QJAFMNijqLNP8J9wDHrcB9wkR5ElwiXJZ20p/9rtM+QwQeOfjD2dtWICk9AMUnwzcmOkk3kfz6FIUPCLHcJPFRpW/alOLc+auSQgJe8dbwuSZFUUwmtQC/nLsHg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(346002)(366004)(376002)(396003)(39860400002)(451199015)(5660300002)(66476007)(66446008)(64756008)(9686003)(86362001)(4326008)(76116006)(8676002)(7696005)(38100700002)(52536014)(122000001)(478600001)(107886003)(6506007)(66946007)(2906002)(71200400001)(53546011)(83380400001)(33656002)(38070700005)(110136005)(66556008)(26005)(54906003)(41300700001)(316002)(55016003)(82960400001)(186003)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?croirMNjYMIXRxS3K+Et8c/MiGe5nDo7v2emkcN81o8xmNKlC/8QbLW1mlDY?= =?us-ascii?Q?C8Zwx4MQTnTkx1z0pchuhCCCHBJqYOVdkiVfmAzneSrO8NRKOnCOXwDZ3aMW?= =?us-ascii?Q?AHFDhyacG727/M6JV6UB9fvCleGiNUKLT1iCvkccfY3VO3iJdrCAIWZwZjMu?= =?us-ascii?Q?zzr9qxFMd/xYLiGsr+5auXe6eQDogMeMCIuRP4pUEMuKPCsSqozBK2vd7dBf?= =?us-ascii?Q?A18L4BOoxEX4bwyDErwkfYZ0ol7/EbKmrFKdMpdWxEV2dc8KarJ4BXhxyWK1?= =?us-ascii?Q?L0nWZLcuIGN2uKmJVi2WAEcN5HzRYquTAGmIem+8lhJznxnztprkkw6TGDV1?= =?us-ascii?Q?FkW8PLSI/qxgKO54N+M1JM4m78n141Ew26+ujzyAVPPrST6uS7PiBY7HPOHy?= =?us-ascii?Q?ZOvT35XdFfBejCwu1FHxDxWCc7pI2Hcdo9P97YLQxeUNOw/hLrPrVPn0DeJk?= =?us-ascii?Q?3t+BIlFe0YcyTrgGzoiJ2NiaSr0WlMRbx+Fbs8nJ+D5+QeSbzo5COsk2v5kB?= =?us-ascii?Q?xfM8qZU83SEcreTm9NZA7xV+5+6WaVEBIqlG19WibgLqh67C/PHCYLWCmPd1?= =?us-ascii?Q?V8Q2RuvSxvR/Bd83FugM3c5qARKINSjLML4kFzhXhbRcmK/k0kS8zmD9dMXx?= =?us-ascii?Q?chKe4OhcecK9t2GXmtAYCYOygopV883G59lpSqyOvn9nL9rtOE2juQefD7rK?= =?us-ascii?Q?ziSHylv0OfXqOnwod8XQzWM7iasSr1TL4G66yyEI8QNHPv7hNsy6G3zZCDgb?= =?us-ascii?Q?coUtvZ0Iysj4mgJiee/fJn4Xvcnm073FNPu0g/j99shwVmoPEypDVN9vEvst?= =?us-ascii?Q?C4+q6MsMxCE4Cr5F9a7hqcRDV1eGdcoSPqJNPtRwfuRLhBe1MyWmeu4O5dN7?= =?us-ascii?Q?9EApb2ubtuVz9DEaKM3PzA9PM7F3sKtiHTyzcgwfWhsTNkscIG1nmjR7+iAN?= =?us-ascii?Q?oiUlzQ2/8OOXoZdLQPeP9WKMLciXkUw1Z+9T34OejpcPth3DI/xEz+bGkMLu?= =?us-ascii?Q?pElIjrgDwV61ZFd3kc+wGqfRtZfGovbgt4aFYobrgYCSoEnRGj6aZCHO2uRd?= =?us-ascii?Q?c8a4k2lk0IqF7mxubEcUdfF9kfWcfth0cNlCxVxHR9/FVjwtxbmr3KQfJGWi?= =?us-ascii?Q?pvoZ0zZBy5g5m8gB5vsS9Vvf9mOQbkKUeOvvWbPXgaR9WD7bYOLYO3NZyjH4?= =?us-ascii?Q?wcZOZ6vtYC50MTXFFSpKRIUVRuqIw9nXMWBcgdxUKR+sLPViQB844/Hy9jFT?= =?us-ascii?Q?GsHpwbmwa2gpPUXAXRurYJwdXgvl2Fj+5CFS7IB0+HK5sgOBMPqU98HWkYHh?= =?us-ascii?Q?GC3HEJJaznqlkjClbLRMr5N3vQ1lSTCS1XpzcBN731bCuKycM1CrggzrALNc?= =?us-ascii?Q?iXmF5nMiLtLGT/1dnnr8w7Z7d1/csRU+4g5iSJ1BjyBsilDC3YYTq+xoHfnE?= =?us-ascii?Q?vgFcCefdhGjVBNgzTLtNYxtL11q37xZqinW6uptZxyv35a4Ji+DN/mv7B/pS?= =?us-ascii?Q?9srCpB55RsapNDfDkSyx7xse5ujD1YbRaCW4PD7BGH0C2s09pki4dJZ6rEBF?= =?us-ascii?Q?FDytbgRHpHO13bxX5ht2lrbXb/+mWoml5cvf2eDP?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cff9a12a-73ef-4040-a0a0-08da95f4b448 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2022 01:59:05.5095 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +tnou8PZKr4fTo1/KahD8uwIU3O2IRc1gOaEsHMzBJS7F+lFJtEzkwVtWZnd25vk3HY3WI+98Kz2jJAIogN/TQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6436 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Pei, Andy > Sent: Thursday, September 8, 2022 1:54 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coquelin@redhat.com; Huang Wei > Subject: [PATCH v2 5/8] vdpa/ifc: only configure enabled queue >=20 > when configure the hardware queue, we only configure queues which > have been enabled by vhost. >=20 > Signed-off-by: Andy Pei > Signed-off-by: Huang Wei > --- > drivers/vdpa/ifc/base/ifcvf.c | 6 +++++- > drivers/vdpa/ifc/ifcvf_vdpa.c | 16 ++++++++++++++-- > 2 files changed, 19 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.= c > index 0444d74..4875ea1 100644 > --- a/drivers/vdpa/ifc/base/ifcvf.c > +++ b/drivers/vdpa/ifc/base/ifcvf.c > @@ -249,6 +249,9 @@ >=20 > ifcvf_enable_multiqueue(hw); > for (i =3D 0; i < hw->nr_vring; i++) { > + if (!hw->vring[i].enable) > + continue; > + > IFCVF_WRITE_REG16(i, &cfg->queue_select); > io_write64_twopart(hw->vring[i].desc, &cfg->queue_desc_lo, > &cfg->queue_desc_hi); > @@ -283,7 +286,8 @@ > notify_off =3D IFCVF_READ_REG16(&cfg->queue_notify_off); > hw->notify_addr[i] =3D (void *)((u8 *)hw->notify_base + > notify_off * hw->notify_off_multiplier); > - IFCVF_WRITE_REG16(1, &cfg->queue_enable); > + if (hw->vring[i].enable) Seems useless check as it already checked when the for loop starts Thanks, Chenbo > + IFCVF_WRITE_REG16(1, &cfg->queue_enable); > } >=20 > return 0; > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.= c > index 2b42850..48f1a89 100644 > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > @@ -290,6 +290,8 @@ struct rte_vdpa_dev_info { > rte_vhost_get_negotiated_features(vid, &hw->req_features); >=20 > for (i =3D 0; i < nr_vring; i++) { > + if (!hw->vring[i].enable) > + continue; > rte_vhost_get_vhost_vring(vid, i, &vq); > gpa =3D hva_to_gpa(vid, (uint64_t)(uintptr_t)vq.desc); > if (gpa =3D=3D 0) { > @@ -505,6 +507,8 @@ struct rte_vdpa_dev_info { >=20 > vring.kickfd =3D -1; > for (qid =3D 0; qid < q_num; qid++) { > + if (!hw->vring[qid].enable) > + continue; > ev.events =3D EPOLLIN | EPOLLPRI; > rte_vhost_get_vhost_vring(internal->vid, qid, &vring); > ev.data.u64 =3D qid | (uint64_t)vring.kickfd << 32; > @@ -1064,6 +1068,8 @@ struct rte_vdpa_dev_info { > struct rte_vdpa_device *vdev; > struct internal_list *list; > struct ifcvf_internal *internal; > + struct ifcvf_hw *hw; > + uint16_t i; >=20 > vdev =3D rte_vhost_get_vdpa_device(vid); > list =3D find_internal_resource_by_vdev(vdev); > @@ -1077,11 +1083,17 @@ struct rte_vdpa_dev_info { > rte_atomic32_set(&internal->dev_attached, 1); > update_datapath(internal); >=20 > - if (rte_vhost_host_notifier_ctrl(vid, RTE_VHOST_QUEUE_ALL, true) !=3D > 0) > - DRV_LOG(NOTICE, "vDPA (%s): software relay is used.", > + hw =3D &internal->hw; > + for (i =3D 0; i < hw->nr_vring; i++) { > + if (!hw->vring[i].enable) > + continue; > + if (rte_vhost_host_notifier_ctrl(vid, i, true) !=3D 0) > + DRV_LOG(NOTICE, "vDPA (%s): software relay is used.", > vdev->device->name); > + } >=20 > internal->configured =3D 1; > + DRV_LOG(INFO, "vDPA device %s is configured", vdev->device->name); > return 0; > } >=20 > -- > 1.8.3.1