From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA688424BD; Mon, 30 Jan 2023 08:52:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6CB441144; Mon, 30 Jan 2023 08:52:03 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 6B69A410FB for ; Mon, 30 Jan 2023 08:52:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675065121; x=1706601121; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=spZlIdjWphkaxGIN7buXF5QaGn2sUQBxjCNVuWHpo3w=; b=jNctkz+R7cZG4RZTPmX0Y4bgUK3QsIVM62+Nz6rCDLjzbDvUkn48LgpG dAl2twTgHC9Q+U992gY6JFaV2Cf27ObBMxLlfFkA5uFfAYYqLk8KfxtgC /yobk4Ue2yraxSnOcV2qfN/J6dUvFC7F2W+9qBCSn7Qn+GjF7IpwBH1tw 7FCXqmV1kFJaFh6E/gbTXDl23saX/4vnfApXPu+IeGBHYpgE/Lpo6jzwt qtifZhs4NzV9WEOsdi8msSWxSm4DFImwRQ754w/CkGbExOxKEfooWXXN/ d2hsTdLm5dz0yAxG/ytqNy1pJsUJLbAParma/NJHV59QVO7Uci3g0Vh1y Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10605"; a="413717942" X-IronPort-AV: E=Sophos;i="5.97,257,1669104000"; d="scan'208";a="413717942" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2023 23:52:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10605"; a="909405633" X-IronPort-AV: E=Sophos;i="5.97,257,1669104000"; d="scan'208";a="909405633" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP; 29 Jan 2023 23:52:00 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 29 Jan 2023 23:51:59 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 29 Jan 2023 23:51:59 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 29 Jan 2023 23:51:59 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 29 Jan 2023 23:51:58 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O3QIG7DrF10SnbfV7DokldOhZJD2qqG/sUA7wg89QU+nmGROAmMHk/zwY3os1WcChvZN/KX003/gGbhHTcS1X6vxRuF7GycHAjSM8nr6MkTDtf0PVVh2E5LjV89H1J0GRPIAPwR9yz2jaDrFnyZLTVa/KfmYbfeNudR4bgUTjEgG3oGFeZcqyKlfmqtW+Y3iadd+ky+/IqUShtRYWHCEOAIJqx+BMD4Ule+ei429PVFfm9HPf1pQdG4bfTCVIYaSiuLGrZSbIBbAhm5evskbakEKK6YzJIlGA3K3weJlSMOYuAvDy4OQYnsXWEhhR9ElPekTbmOulzKwHW/rHgELWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W/0gAV0P30FqwjCBuoovpICibZoXcjcKLKuyesUV5Jg=; b=jnRVanIXLuX0pDCAgRwgTBV+AykBoZC+8Ea0g4ZJvr0lDiMte6i2VWJP4mkp48qlGu9Oh1bMVSGPdfRDay3yjymQwTtJF3OmxKqh4D8HIjcLN3XahPUDpSTKOGqU/6dfib4Fo+9XgzocMLgv/qes8fgxPl1rLj16hx/WNvOnoNk8h+W+p6sPI5o8S/sfl3MBt7BW/0yf+vA7rLXlBTSOmGpaENrvihSy5Wc4BkLENM+c6E/bvlPuN1AgZI2JPmB8jFlshttvvWKEJPRwwYLhBxE9dLWkaLE9OjtJUpNouyxZwIDyN+QqnhoLsuUPWlc/TZR/TrjRGYOPblN1Fap5AA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by SJ0PR11MB4990.namprd11.prod.outlook.com (2603:10b6:a03:2d8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Mon, 30 Jan 2023 07:51:55 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::c8f8:a3e1:5b23:a9c3]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::c8f8:a3e1:5b23:a9c3%5]) with mapi id 15.20.6043.033; Mon, 30 Jan 2023 07:51:55 +0000 From: "Xia, Chenbo" To: "Coquelin, Maxime" , "dev@dpdk.org" , "david.marchand@redhat.com" , "eperezma@redhat.com" Subject: RE: [PATCH v1 05/21] net/virtio: remove unused fields in Tx queue struct Thread-Topic: [PATCH v1 05/21] net/virtio: remove unused fields in Tx queue struct Thread-Index: AQHZBNRli4fZDyRE0UatsAc0+QBV3q629b7A Date: Mon, 30 Jan 2023 07:51:55 +0000 Message-ID: References: <20221130155639.150553-1-maxime.coquelin@redhat.com> <20221130155639.150553-6-maxime.coquelin@redhat.com> In-Reply-To: <20221130155639.150553-6-maxime.coquelin@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|SJ0PR11MB4990:EE_ x-ms-office365-filtering-correlation-id: 456183a5-1dfa-4121-f5bb-08db0296db94 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ++iKC0Vnr6u2faBo07HD8q90RkdXTTxD28kup4zXStIRd0T7/RAKD02N6m1xJSicHZ23JQuJ5WOAUziaf+MAWQXmOuOaeiBNe43x/egEbxKw4TgTg9R+BkqOkv3KJZuk3PY2pl/L33t/e62NAydq2y5MguHR9q4VA+057nlXjdrjiU9Gr0KRCaBArdCkHj4yi0cKzjBnxOvFQlbqZ8fJ4adzbs/PM91U8zzlAmPUhaKbh2mT/8FVPTYKQHlV9LLlRxHpoH253s4GbGHvK30USuG8m8U+57z7MJT6uPwjnLJ8eRbEkFsuVyd8boarRUUd/FnJ9ZtNT2XVncBYzpykAcNwpCU93YJIzEEzLmVP0YYU08spKvhi4d17ErFJ8i73YW6VeKzfU14yAsRdgZxedXq/vOhE53spNx9z2N1xZvywhQoTwvXYysL6YmtCZ7fGojQZ7J7tMC96ZBCOMRO87/96GOLb/tVDqDXZENvaOModVIHovubxLFXOJjuv609MnJmzPzHixJJVps6Brbfa7NLwrxBjik+9QmODECNaZwve74GD2TtYR3Oh6O422DtFchSVLzpVad665doRKOCYFN0Q7iKI1MlWy5Ya+/scavP0aABv/zgWF55vQjHi7htEmGBB/lvjB4G4sdJfLj6JCRtlx9qzaanXVVCJClqd+MQDm7KWvPxPpux5o5P74DAMvrLlfaGuDV4K6cMD3U/bVw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(136003)(39860400002)(376002)(366004)(396003)(346002)(451199018)(110136005)(316002)(66946007)(66476007)(8676002)(66556008)(66446008)(76116006)(64756008)(8936002)(52536014)(5660300002)(122000001)(38100700002)(86362001)(38070700005)(33656002)(82960400001)(41300700001)(53546011)(71200400001)(9686003)(26005)(6506007)(186003)(55016003)(2906002)(478600001)(7696005)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pf6fjlSZ7bdbKyNUisGOk6AaZF7YjftZP/JdT/MKT97Vz0punfIjn/jUW9gp?= =?us-ascii?Q?2dUGZLDisi69WMiP3pFz2S3g1grCQTuovl5rb2zHKQHPO91oF2Fcm5gFmmei?= =?us-ascii?Q?hg9ePb0Gcft5PDlFdUdcnYU5a5UxhG3vFho1/gzMIIYOSuS8vfcrmBNxXvel?= =?us-ascii?Q?TNKiyqzS6pa3GZ9Meyqsgm2qTTa2uut1GPTsfOmrCmQs/y22G+urxfix3pEX?= =?us-ascii?Q?UuHDcLJn3RO1ypl1+YoKw93jfusXRcsEyGI3uZWGkwGAp7K5IV9wSZyjdH7N?= =?us-ascii?Q?VNiGR5fxAJkjVWOpTUwVZ94/QK1EWBffJ3vk1afPGB1b30SRjWNEogDROsLN?= =?us-ascii?Q?KJ7dRdxr2mzSwpZoFiWEGLkAogBHbVtmpbUP3Wsczt9+AD97wfgTSANItoe9?= =?us-ascii?Q?CW56xg+X+qT+Lcm6Tb4OkHcyd1C/o053nxnryWZRpRZIQp1MnLuaO7b8/fGI?= =?us-ascii?Q?7Pp9tDya6a8qo9HvznX97FlbdJAUBfGF/ghJPAujx/9sh0AcdowTikHUeE1X?= =?us-ascii?Q?JOZotJzWQcBIVBLHiIFF4dv/r5AhP/Z4ybhNAYaovZ6gqE5OTz0W88H6sc4L?= =?us-ascii?Q?1xMPtHrpa7oA5P9z98pSiyQTsxKJtqqROJhIJIUk6WTRJ3Z++50nnJLdGAxa?= =?us-ascii?Q?0C4kalNM/KKsyBwjS8CXSdZhpvGKAQrKBRTI2+fKfDJVIOOD57CQRtCTri9l?= =?us-ascii?Q?pe8xeyWMDpridOLaVKIebOmyt8HkrhKxoi90PNFSf4fzXU6lnqUz0rodh5IO?= =?us-ascii?Q?yBaoJb4BNjYBCgIQbV/YWj+HnGUqx3eAA/hsfcTegKWqxMUXY2JIWY0a59tp?= =?us-ascii?Q?aACst7jqdfIQ4Uv3LVp6SIfovfq9GOUAIAJ6FvbzePw2J+OpfJXx3t8+v5Yd?= =?us-ascii?Q?tlkMtDaIQeEaJq4KpMs5k9TxfB6/cipA62FvZHvsOyOmTWfj5tMlOf0nM3c9?= =?us-ascii?Q?8Qg5uvyH8RbMgIVNkFgK8cS9VdVtknNbLSA5r+m1qumRbfukafBHNht3rEtk?= =?us-ascii?Q?TwPXn80D7yhMogURvxdlFlsqmMzVap3LI6FvdFAc/nVO15sOSyE4TALaG2Tz?= =?us-ascii?Q?ctCxG0uoApC5/VdoEHiLnTqNVrad1ZJIk0qkS2tVDfkTLRggCuE+CaaoGZMj?= =?us-ascii?Q?wtYqWH2C5+fm0WI78AJlQPNfhu59szoL+pzKL3tBA/K9m9FYOUwqFtE5kGF0?= =?us-ascii?Q?x7OnFtghUTaHuQU44ymALC5uUJr2Tc640pEh3AOoaUtf927v4sDSPhb96oiu?= =?us-ascii?Q?xG1U1EascLCE7z8Fut6aF0OSDwTIHgf+ve2EH11Hfbv+TRdYy9p9iBCBe8vK?= =?us-ascii?Q?TFdqiqGQgDctnfn7NWRBMurJ5gb6/M53NlGA3VN9J0C60nzQD3O4NaSIijFY?= =?us-ascii?Q?YH/GJgseLChrtCMmJzN0W9/mdNEihMUKP2KNp59OEICr++YXNyJp2K9Kl2Oy?= =?us-ascii?Q?0QQdKc9dVF06rAU7gOeesUmIJxV1exf1MgY1K9OJRaMr+Q2Tsi56adXbFBVs?= =?us-ascii?Q?xeyQugSto8kDyuuF947kqRDeINz5gxyUrDKNWv1Ml/lVaQDKW3TFbQNm/gDy?= =?us-ascii?Q?3Yu5gfo67rcPCHNsxU2Qk2HhyWKoug5BnIGCXLe5?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 456183a5-1dfa-4121-f5bb-08db0296db94 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jan 2023 07:51:55.5223 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MYi63xB/QDfNtew0KTl6XStRd0mvtFHQVYX6efuIDmgFuVTdbmr+KhMBPbtvs3gEMIOvHjJXV9elmr42rESaeQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4990 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Maxime Coquelin > Sent: Wednesday, November 30, 2022 11:56 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.marchand@redhat.com; eperezma@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v1 05/21] net/virtio: remove unused fields in Tx queue > struct >=20 > The port and queue IDs are not used in virtnet_tx struct, > this patch removes them. >=20 > Signed-off-by: Maxime Coquelin > --- > drivers/net/virtio/virtio_ethdev.c | 1 - > drivers/net/virtio/virtio_rxtx.c | 1 - > drivers/net/virtio/virtio_rxtx.h | 3 --- > 3 files changed, 5 deletions(-) >=20 > diff --git a/drivers/net/virtio/virtio_ethdev.c > b/drivers/net/virtio/virtio_ethdev.c > index 1c68e5a283..a581fae408 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -466,7 +466,6 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t > queue_idx) > rxvq->fake_mbuf =3D fake_mbuf; > } else if (queue_type =3D=3D VTNET_TQ) { > txvq =3D &vq->txq; > - txvq->port_id =3D dev->data->port_id; > txvq->mz =3D mz; > } else if (queue_type =3D=3D VTNET_CQ) { > cvq =3D &vq->cq; > diff --git a/drivers/net/virtio/virtio_rxtx.c > b/drivers/net/virtio/virtio_rxtx.c > index 45c04aa3f8..304403d46c 100644 > --- a/drivers/net/virtio/virtio_rxtx.c > +++ b/drivers/net/virtio/virtio_rxtx.c > @@ -831,7 +831,6 @@ virtio_dev_tx_queue_setup(struct rte_eth_dev *dev, > vq->vq_free_cnt =3D RTE_MIN(vq->vq_free_cnt, nb_desc); >=20 > txvq =3D &vq->txq; > - txvq->queue_id =3D queue_idx; >=20 > tx_free_thresh =3D tx_conf->tx_free_thresh; > if (tx_free_thresh =3D=3D 0) > diff --git a/drivers/net/virtio/virtio_rxtx.h > b/drivers/net/virtio/virtio_rxtx.h > index 97de9eb0a3..9bbcf32f66 100644 > --- a/drivers/net/virtio/virtio_rxtx.h > +++ b/drivers/net/virtio/virtio_rxtx.h > @@ -35,9 +35,6 @@ struct virtnet_tx { > const struct rte_memzone *hdr_mz; /**< memzone to populate hdr. */ > rte_iova_t hdr_mem; /**< hdr for each xmit packet */ >=20 > - uint16_t queue_id; /**< DPDK queue index. */ > - uint16_t port_id; /**< Device port identifier. */ > - > struct virtnet_stats stats; /* Statistics */ >=20 > const struct rte_memzone *mz; /**< mem zone to populate TX ring. > */ > -- > 2.38.1 Reviewed-by: Chenbo Xia