From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B39D1A0547; Wed, 12 Oct 2022 11:36:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64DA642D6E; Wed, 12 Oct 2022 11:36:25 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id C96CB42B6D for ; Wed, 12 Oct 2022 11:36:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665567384; x=1697103384; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=krAtaXZO8IPLXxjDZBmi2s4wU/rwKwXi1v7SSehLT0U=; b=IV1okcR8S4Z+uLC1C5f6M3AIh57htU4neISfAzt/oV0K22XNJ/JxeiPs 81IKmsz0d57S1hyAUWweBIde17z2dUCBqVyKLqVle6D+FFjziSMlDZ6md nj5QenauK+T4s/wqXeUFNZYsioBbmZ+ascooPUa46W2yZ5oy8oc29rRy2 2NzB1qBqlRtQ+ZQR9Ss7YQpwlZTpqwF2860zRLqmj5yg4OiPSvYbKlqI4 N60ArZ1WOxchS/g/1Li9p6w3HfYRrlqoso7n6dQVOjqoILMteulUOs2VI AlI5GTtyjYGSzS9LSQ+s0L4uwpOYNIuB7E1toY/D3ac5RjNvpTbgj6Wd+ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="288015776" X-IronPort-AV: E=Sophos;i="5.95,178,1661842800"; d="scan'208";a="288015776" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2022 02:36:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="769146803" X-IronPort-AV: E=Sophos;i="5.95,178,1661842800"; d="scan'208";a="769146803" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga001.fm.intel.com with ESMTP; 12 Oct 2022 02:36:02 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 12 Oct 2022 02:36:01 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 12 Oct 2022 02:36:01 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 12 Oct 2022 02:36:01 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.41) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 12 Oct 2022 02:36:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PhKMbU44pGeOL324ezoWNDVlQhkd6ovG0BqCSmIfosTMElf6XfmwTdmTXQ6eLrMqKuWYd49ds1GA55NMm8RqO7gjyiXD9iuKQdptcOEswytMsMIB23EDCKaf+ijNEj8icQxqxbyOG99SzFDMAsg3n/EYPEA0Sa+lxbdKAyzwDUL48Ud25H7+kugL/MVAdF9wWbd0X1jcJQid2YuGw64WH6ayMECgXD498JcOOGblBxxGHr4o4taN1Kf+Nr7MFAulvb5N7ontNdpU6Exg6RyUT7GQK74/1VxcNwub+673SqDV/IZIAwUqiuLIYrz8sKq33NfrWSfj752ciC6Kt2TrfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6ajb2rEag6IR47OWzT/d25qMmtN/Wa8gw4+jcC0NkGw=; b=WuN+uedUw7Aj1LUZl+uYSEd0MQBRAquMJB2z6hdeegHoZMHvDUruazwXAHQucc6WcA5xx5DK25zCSYGj59Aiy7SVy5P64YBuyf9mH2mkAdbjHffCSieMrkU9lTY9WWZOxmbxJi/H7slfPir8AlKt8ubp+7lzWywrpFcsHLRGvZXpmCW4Bu2qHdBGFNdHA4Mh7Wal/kcdyWcXBa7qhtYzltKOrlmUE4QbHpdyttvty17MB2qU1SYfFNaHwLjHBgVX1hWxmT+rYCDpIWpqZhs2rBHubTVaVjnTsfcLNG8JcaHro2PS2U1+w92nH3dxvbrBXa8pMIl9sZHUUVied+xVAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by SA0PR11MB4719.namprd11.prod.outlook.com (2603:10b6:806:95::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Wed, 12 Oct 2022 09:35:59 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::39bf:57b1:4824:d40d]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::39bf:57b1:4824:d40d%6]) with mapi id 15.20.5709.022; Wed, 12 Oct 2022 09:35:59 +0000 From: "Xia, Chenbo" To: "Pei, Andy" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v3 8/8] vhost: improve vDPA blk device readiness condition Thread-Topic: [PATCH v3 8/8] vhost: improve vDPA blk device readiness condition Thread-Index: AQHYyZPyPMmG3ois2kyhSUbbYSnxUq4KpnqQ Date: Wed, 12 Oct 2022 09:35:59 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1663308990-621-1-git-send-email-andy.pei@intel.com> <1663308990-621-9-git-send-email-andy.pei@intel.com> In-Reply-To: <1663308990-621-9-git-send-email-andy.pei@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|SA0PR11MB4719:EE_ x-ms-office365-filtering-correlation-id: d5ec704a-d1e6-416a-e129-08daac352c0f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: soyu3W3p4O/z6l+vVdfe2Jws9N5tIViVOE7zS90CoZEfPmNyYAbAjWTWgisgZ1his3hDMVoBmMN4Qm2YcN1Xi+w92V6UeA3yHW7gg480I3PanvpSqBnovJIEi0hEnzVvJX6pXKanRh7hrP0MrZrBicqTvN5VWRgH5G1cddqRml9VE3aBN0AtVarL1GEBR9cZz1DsCjv5ZDWDlCQPCN+KqI93tadVAr5CdBguDzK4EuMBiDFt7rom8vs+339QJeDneoVrVvFv+nzd1KIfZiZtsQ9VdzF68tkBoVqhdiqTS09u40ziyVISwMkwHHTC9oKMZCxjgKid4lgTIw4kCezCGrkCRy9Hc3On8ztTzbisA2K3gizCkNhbahJbLDUyhKKq1bDKiqSLG3NR8PAsQgI/tUIHOlG58dH7J71Y1yKj0g/lQn9iSm9A26h31qNdFAg7zkF7TLOF4KI1K3AaSv3EsErw3argpInORf1BWiyllFDX6v7y7SJZJ+4I+5XJyjQ9XHDvgqj3Dwl5PYvrv3gOjpVQz32OR0jsWm14jxTctrD6P+Y8NuGHjuePWsZS6F0bY4Yz8bWxEkzJu9pn6McZJFb0y0m48+BCZxFPmsEIFOz9fFOz9XoIlsOu1lsMKCTPXOAtomwYPg2yQLbvxFmykdNZVid2Ds6c7qiluD/Rd852wo7QTJyaPwczUZe4pSZZGQFCXu3SQARWWRudQnJZ58rP8zIA2zPF29UjSFGFvRm0OT7tCDIGcuuvCC1PGcl25e89wN1KCBY1wCI8fDbXOw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(396003)(136003)(376002)(366004)(39860400002)(451199015)(2906002)(53546011)(54906003)(33656002)(52536014)(38100700002)(8936002)(7696005)(4326008)(41300700001)(64756008)(76116006)(8676002)(82960400001)(66476007)(110136005)(66556008)(316002)(66446008)(122000001)(5660300002)(66946007)(478600001)(6506007)(55016003)(86362001)(71200400001)(186003)(26005)(38070700005)(83380400001)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/WjAO7E+bh6gr6astQCBCbI17H0b1Ot8GYImvsDyVu4KPbCYSYofCNAw1aVN?= =?us-ascii?Q?zQCo9zO6/GJ2PBRDt47Im9MTikVUn3Xaj1ndt0ip9JCLOng3cWm71dgPruk3?= =?us-ascii?Q?27tQcf5GvT5x2JU6CF9jayUoz1zwjmn45ZCSpCwgPLlvIenEaJKyNlFOv29I?= =?us-ascii?Q?C2ZHw2U7hJ1lByA7eDP+gGosnEFDor3rj7OG0ttd+dHMYhkZobSqpfniUeL4?= =?us-ascii?Q?jK5no01F9K+Uzldz4qF98khqKg79gqFj8qYW1eyU/VO0H2r3gazHPOg0AXqt?= =?us-ascii?Q?MR4cM2CmDidEMJ8bnZE+QQswFIg24ohGIDy6iU1gSBVbuDaSEbad5mempC7j?= =?us-ascii?Q?sdSfpZ+Nr8jRxpH8N3wj6+NkBMis3RqFwGsOkjStmWWr2daRuYzt9bRSV2dm?= =?us-ascii?Q?Y53lUgPihbUFosBYy2JDF2Rk9BJHONupZ+rcofMLRKLQOso8b1Ha2KLI+Wcz?= =?us-ascii?Q?WdM9A5EozgaRHZsoPXHzm8V+rzf0W0IK6exb4B3rHPRm4hcLJ5cwTAn4I7fa?= =?us-ascii?Q?aWjxl1vT+2V3iucJyoinT1ZDTChwoPoym79kPCQE2FdwLOACMbn90vLFF4fI?= =?us-ascii?Q?rMIiqZUslzgqgux8TRKx+NI8R4KIG48KEn7li+74UMX+LRyduIoW2YrEigpT?= =?us-ascii?Q?IAUCoq9M2ELws8HvfLjdYqY+gbP7fRBvtYvHMClYouHO3hFQIf8XMff6D/Vg?= =?us-ascii?Q?tmwMF8bFG2hb8jx2w0g+aRbAe4REwEl/lkzrQ3o+CI8gFOTSPlc0YNBxhkPd?= =?us-ascii?Q?OcQH8J7+ruRwU+E6EGWm16XuVUNXrOiMmZm2JuMwpLquikQumGUs3sU8bX9q?= =?us-ascii?Q?ePkxBUyvIYUGjXeIqQ5oq7OyNH6DqOpBssnjVnbpa9gKe7RrDGHIHNTrSHMo?= =?us-ascii?Q?bxTfD9pCFtZomZAch50eD5w0djrff++7g72IlFr6Y3mm3jWRt9PdQsA5VtJV?= =?us-ascii?Q?5zMxQOEOwHq6Wzeh4jsEYAouo82DvFtuZlsJbSXIfoNIb7sNSY6UKUOem0Pw?= =?us-ascii?Q?fTecnP/6FeoPCuhclJfpgoDDWobjcEa7xs1EUIly67jJWkThSzuyQ23Zl/n/?= =?us-ascii?Q?b0VxxgnCGb+N68sfQJc/2D9uWwHKUZLaZiSmTowJe4JBxie4ScF1zw1+GjU+?= =?us-ascii?Q?rMyAbfvSKTCtQZqaZ4a1RmFRj1sVjYIIrbdTxGBrqXyxFJfNMBjvIVgZbA4q?= =?us-ascii?Q?Vu8Zxf/1t5TjfB9Zy7SGzIycO756r6MEQzHZ2I0VItQaepm4mH7Uk8XhFBlO?= =?us-ascii?Q?ODe0r+9291KQxQXZzCQ7+XYG01CCNn8tjA+LNdLG9hSqUM0RlM5Zpk/+bwB/?= =?us-ascii?Q?4alvGBJpUq0xJ19D1ZRx+e6Nlh+zqdJjqi+PG/hITwZsY8LnBYxCKTxwX3x8?= =?us-ascii?Q?5lcX3Ox1SXDCKUhpPqvQJOmH/NYYt45G0/9HNztt+2fY+lsdLq5BymSAZYvj?= =?us-ascii?Q?xqEYJE90qc2rSuCJ9LSHivPi0L1MDvBHIuClnGJdtSMp+DjNBtrPr3aIFqTe?= =?us-ascii?Q?98p52jyoB1TNC288KvW7yTJy3ile37T0lFh9fRPKAa6nViSUcZIgsT2WCBPR?= =?us-ascii?Q?BIAjPC648y3lotvC6/l0Cj3BjrpnKz/eG4gs+nHd?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5ec704a-d1e6-416a-e129-08daac352c0f X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 09:35:59.8516 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VvRiN4jvNUWOePK/lTpGhO2B0pO034Wxj2AcUdPRKR1gy+HRVogxPzoAoD+I7rwJNyjmWHhtfTFiFfE+plb6qA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4719 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Pei, Andy > Sent: Friday, September 16, 2022 2:17 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coquelin@redhat.com > Subject: [PATCH v3 8/8] vhost: improve vDPA blk device readiness conditio= n >=20 > In the virtio blk vDPA live migration use case, for the target VM, > before the live migration process, QEMU will set call fd to all > queues of vDPA back-end. QEMU and vDPA back-end stand by > until live migration starts. During live migration process, > QEMU sets kick fd and new call fd. However, after the kick fd > is set to the vDPA back-end, the vDPA back-end configures device > and data path starts. The new call fd will cause some kind of > "re-configuration", this kind of "re-configuration" cause IO drop. > After this patch, vDPA back-end configures device after kick fd > and call fd are well set and make sure no IO drops. > This patch only impact virtio blk vDPA device and does not impact > net device. IIUC, this is an improvement for MQ to make sure all call fds are well-set, but previously it only makes sure one is well-set. If I am right, the title and commit message should describe it in better way. Thanks, Chenbo >=20 > Signed-off-by: Andy Pei > Signed-off-by: Huang Wei > --- > lib/vhost/vhost_user.c | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) >=20 > diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c > index 9169cf5..14ff266 100644 > --- a/lib/vhost/vhost_user.c > +++ b/lib/vhost/vhost_user.c > @@ -2983,6 +2983,7 @@ static int is_vring_iotlb(struct virtio_net *dev, > uint32_t vdpa_type =3D 0; > uint32_t request; > uint32_t i; > + uint16_t blk_call_fd; >=20 > dev =3D get_device(vid); > if (dev =3D=3D NULL) > @@ -3210,9 +3211,15 @@ static int is_vring_iotlb(struct virtio_net *dev, > if (!vdpa_dev) > goto out; >=20 > - if (vdpa_type =3D=3D RTE_VHOST_VDPA_DEVICE_TYPE_BLK > - && request !=3D VHOST_USER_SET_VRING_CALL) > - goto out; > + if (vdpa_type =3D=3D RTE_VHOST_VDPA_DEVICE_TYPE_BLK) { > + if (request =3D=3D VHOST_USER_SET_VRING_CALL) { > + blk_call_fd =3D ctx.msg.payload.u64 & > VHOST_USER_VRING_IDX_MASK; > + if (blk_call_fd !=3D dev->nr_vring - 1) > + goto out; > + } else { > + goto out; > + } > + } >=20 > if (!(dev->flags & VIRTIO_DEV_VDPA_CONFIGURED)) { > if (vdpa_dev->ops->dev_conf(dev->vid)) > -- > 1.8.3.1