From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D427FA00BE; Mon, 16 May 2022 15:03:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BAA9540A7D; Mon, 16 May 2022 15:03:59 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id E535840A7A; Mon, 16 May 2022 15:03:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652706237; x=1684242237; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=KLBQSJWbE7yDfgFTahu6bk2XhUMc4SKUcd8XjxNW33A=; b=NpdgLyZFtw7jmPx5g+q2F0a7vpFsSS2QxTij1WGVvJJv6orW2hRvj/Sc gEMRPioNZ8guHARnvfhaPFUCANHbMycrs2HZ8uZqw6u8ujqJT98D3KTwu 1ui1QaRQTb1XnrXkJSmFfW+U8Mta6YUz9orOMFNGeAbKCXUyw1DnjV9vy +P6wgydf+q/cCvJh4B/ae9hAHoHrtPNMcV+jo0/IJ/5jnj8DkNwC2/Bs8 n/2Sqc9nvuqGn5tuqYgkc42XizvFu3KAhIbn/DpQueWp2D97yStPVw2Vr 0+YdCJO8Q+144QFOUcc2c6QI/ffngV1z9fWB4bpe7qIPAv0qKD1ieNuj7 A==; X-IronPort-AV: E=McAfee;i="6400,9594,10348"; a="250718949" X-IronPort-AV: E=Sophos;i="5.91,229,1647327600"; d="scan'208";a="250718949" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2022 06:03:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,229,1647327600"; d="scan'208";a="596507115" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP; 16 May 2022 06:03:34 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 16 May 2022 06:03:33 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 16 May 2022 06:03:33 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 16 May 2022 06:03:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jv3mcM8yqnhcBXRVvJYh+Cv91BeahiAkMzzx8wJKVD1neYJHicyAH0rcyd2Syi6wG5stWs0rwsDD39MugY35d0wB7awrcawMmNjUXnHoVHTdnCE/Ow66/ZJkHXKprxhPNghBaKOhcCvKn6NUcvs9MLtLtcNOF9CvqUZbhTQgmFiyBkhdQA4rkamhVdeYzs67tOUrbU51lEzEY3fXrg1AultV5evneml4v+7vL1qS8zB8Q/arwS9kTwN2WyObcKYTVZtS4VNzy1Cuv5xaLpqa6ZEOMb3629rlBJDBo7x1oBrDWjdIaSlrDp0cEbINARNPVbqeRFqps+qVRTRe4jslJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GA0CEELECIRwZfPI6EUvrRrOTrSeF66CA2JSBywGhD4=; b=WXcIAS1/Ukhe869btLk+QxysIzlnBNWV7wF8z2mnzIKvtKEduWxj3V/SEFuGdKjML8/WodpV/Ddbji4lgryY0fwDs2a0DED7GoIPpRgpwzWfE98/nVjBwt0TTFEtHCxXg6ZGwRC2YJklHCjcw9L5U/AaGFqyRSubW4Nup8qA3Bo/q0vZli3Y/W7cpPuyfDfRmM0I4nVDRHxc0LPfLhpo6D9PqsOnRQY7ITIZsuppTsTMcXEI0g/xmXc7AMs9ayeUwsM/2l/p1011wxCz451yceWn/qQFDqHN89ouOS0KuSNBE2TpQib1YLXKggUcE2m0c/gKaqfohqFqIKGxOf9G6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by MW3PR11MB4713.namprd11.prod.outlook.com (2603:10b6:303:2f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Mon, 16 May 2022 13:03:32 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::54e1:e802:17c8:93f]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::54e1:e802:17c8:93f%7]) with mapi id 15.20.5250.018; Mon, 16 May 2022 13:03:32 +0000 From: "Xia, Chenbo" To: Maxime Coquelin , "dev@dpdk.org" , "jasowang@redhat.com" , "david.marchand@redhat.com" , "olivier.matz@6wind.com" CC: "stable@dpdk.org" , "Li, Xiaoyun" , "Zhang, Yuying" , "Singh, Aman Deep" Subject: RE: [PATCH 1/6] Revert "app/testpmd: modify mac in csum forwarding" Thread-Topic: [PATCH 1/6] Revert "app/testpmd: modify mac in csum forwarding" Thread-Index: AQHYYGrFalVq6LXZVUaSKSoup1PEl60hiT3g Date: Mon, 16 May 2022 13:03:32 +0000 Message-ID: References: <20220505102729.821075-1-maxime.coquelin@redhat.com> <20220505102729.821075-2-maxime.coquelin@redhat.com> In-Reply-To: <20220505102729.821075-2-maxime.coquelin@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 73dd0c41-860c-4d2b-2d26-08da373c7a9f x-ms-traffictypediagnostic: MW3PR11MB4713:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NKvK94hGjKgf2nEGPJ7rtOhmXpg1lNnCkZK6sH9TQ8VLF3CulubCWM+jb7zf+rVRtYSFtiPrFHi9N9quGjir3ihoB11WHeZagFQwjSMTcxRcu6mRKWEMaI9f77xIZeSfJFEy8EZLkOn/Zt6zc6irIk8x/sOD4a8eDRLYNZDBBofWc+1SJPTY6hWjRe8USaMuUCoBBZ+5onyTQb++eJd371WhBbUqOwlaalZ7hzXCqrtrwkOpyqTF9kf8lNRzOrGBi+7eV1zRABF6IA0pIiFZEjCQ1J/SfZMZEDdiVHKwz6b9683Juc5+MjlCtfBfzoDw4xo1n1B2/j/dEzRsHQ+Xzdm1BTQ2wm8j6wtqApB5ghQTjfQLeFD/XDFIlOvF0M1UnVBtqu4PiarnRs+s6vHjXQIgDHf4pzEK2tSrYAZJ3T2Uz5WGcT0MlCEKxgAU6Z21Ng8fXsTBY/pH3d7+htApH4UFikbzg8TGluuackixOZcY2PYQ90YcalqxNZ5GTMGPcDkj+MUZ0xi/u0aZG0WykbRD2wD/HK6o1Vv3R+H1f+agrMh3vxZDp8z2gCfhnTA9wfl1cDq1THF+IcpASrK6HIitXkXLmOcRvhAepYT0IrAKyD7YmnWXZtBCMhW/qxIyquPbI92rEYtTTE12Rh/UkFcOpZqJqnIXx7rcvaDHLPbXKeUb87KEQF5Fuvol0HjzJ7v+mSeL7Phc0twcIuuf1g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(107886003)(8936002)(54906003)(8676002)(6506007)(5660300002)(52536014)(122000001)(26005)(186003)(110136005)(9686003)(316002)(2906002)(33656002)(38100700002)(4326008)(76116006)(86362001)(82960400001)(38070700005)(64756008)(55016003)(53546011)(71200400001)(66946007)(66476007)(83380400001)(7696005)(508600001)(66446008)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yV4lXxvB0eZdoL9PbC+RdHKNpDMIjT1BPMbxa7Bcm0hF3CBzkrqRr0XSZ9jq?= =?us-ascii?Q?DH1tBjdphTRaC8CoONEqGN8k3KAaCpgIi1vjf3fyrZSv/qZhhoYIIkVNe4UC?= =?us-ascii?Q?1glpqtV0vgkcoeACNS3AslDPHA9UXP6TKCsl9QyYlv7LqN/Wo+2Qnszgm+y3?= =?us-ascii?Q?kdeNajh3vvmGrkK5ZFyQ9rgFrQN5UQcUIkZQRhUxqhKPQYb3A4A3JC81ApkN?= =?us-ascii?Q?+IiXXNXU6eswZGF8pm9lvYRCNh0E1+5I9k1aFnSmfnZ6H9ylOlXfMchV8ZA8?= =?us-ascii?Q?bI+l2iIbVbQYBt/luOVQg8KcfGEgoPSn8gwx9NJF8anskUUbGpBkK5eC+kDe?= =?us-ascii?Q?zoKXQZ8Z3tSHOmuN4GK2w4V1CwEDZHSyQsJ7qk2T1bd8XI7gr0id0mDm7i1q?= =?us-ascii?Q?jgLXW4V40kAMCuwpefgXIw0A+HOqCx11qJZUvBW8p620OsjnW+g0p/ZLa5xc?= =?us-ascii?Q?/qN+5/HM5NZ/XY9/FdvgHO4bPiHjEphkqRxnRLhHPDCDC/EFKETf3b9HCy/H?= =?us-ascii?Q?VyzZGZNA7lX6ZyBHZbKWF0o9zo8vmcvkTpCqTq8NGOlLjx8YodUKwFLGUvQ6?= =?us-ascii?Q?p7urQM7+FWZR52mwTF+M1awRHyQc30ktryfJDc5WJbO+GBTmOk5JwxF0+7gt?= =?us-ascii?Q?sj5a1KQEMvALMjVd0iuR45BpXQhenV/yHki77mAWInVpbRHUAK3XKuWroIRG?= =?us-ascii?Q?1LIGCH+lnX/3X3nX4SwRU3bayLT/lQdhSLW4cVZf6nVyPrJbGEjB+eb91O88?= =?us-ascii?Q?gLd95O+o4UbCWGW9BGxGsE/EYqx4r9U9BYahRP2bdE0oH+LAz7Wjjjz+CDEU?= =?us-ascii?Q?L3Y4QgPNzMFZpBeQcqfjfeCBFgPZJxZ8fZfmkwmnGtR6xpdmG0He+jgr3538?= =?us-ascii?Q?HwJp9MbYtmhKfYAN+Zkb7q/+hb8PZD29mhs6XvoK/SbkEH5/2SmM9cr8t38w?= =?us-ascii?Q?NnsPcIc8mBq/f8Tetjk+chEyxLdDgCzcwbuJaA+HG0+o2g0gwJ74vAcKXFkE?= =?us-ascii?Q?MnK3vEzqwBOHmecXv9NY/3aOE2ZaTHDlFsQhaPBRbHj3IL1kU4H3bOkHREwu?= =?us-ascii?Q?6TctFa/zmtOUjhog/kTYQ2fRvpFqNLUoAItZX0OpNmE7wjvvOCcKdUay+jdv?= =?us-ascii?Q?VH+00YdMSOkWRI8jGE5Y6sRrbg2WERoPbVRmdj/NY6WrIvzCT//E1IhauLFG?= =?us-ascii?Q?VPYyvS9LVqukjnc0Zx0Y2tqtHjOU8cFSek9rU0g7riOQgLhw6AVmNX5fW8dN?= =?us-ascii?Q?oTpIUGK8A5+/bFGsw9Klquu0dniluTCWX6MheFLDKlq8EKp+IyFaIsM+lirw?= =?us-ascii?Q?cHexOhrwauWkPTfc9LLBG44q2Vfb7hkFSM17L+wGHmqt2hupbS8ytIAwmRgt?= =?us-ascii?Q?WZsNM0d+D8Ra0fmGL6FU78RRxgOfu2KpEKXlli8K2B/u34NPt0S8a1jL4JEd?= =?us-ascii?Q?4slGVjr8WFi++SjOpgYRGuWLmEL4nSw2p28RWZmWMW93FMMCQYEHDvS+bu/3?= =?us-ascii?Q?pdAfluwmwJy4Dc+pu7K+/9sul2Uz51Jx+Ry2Epf3FRokqVhGnQMKLrlppc+6?= =?us-ascii?Q?5thol+lqud02LV/tzisKJ7j8JD6lBX+2NRbgT4jiSMzrL8uAKF3DX/x4qD27?= =?us-ascii?Q?VykyV1iJ4WKcapgKUyWjFPEs5uZWdXrqUbhvddmPiknJ1Qb6Ju4TDhT0rd3M?= =?us-ascii?Q?Kusmc9kxVHmgDaOBiDcPW1y7Dl9RGpx+s2eNNsMIX0S9ua5qrsLawS0/pfkq?= =?us-ascii?Q?R7/47U5yYg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73dd0c41-860c-4d2b-2d26-08da373c7a9f X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2022 13:03:32.0695 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PI6TWrvUBcSjr9/1HySd3YUMwTB0MwWs/8/oe2WEcp4xQCyf02wMbI5K8T6sB0PMqbKBd9XOLWPdtysNtFcbYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4713 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org + testpmd maintainers > -----Original Message----- > From: Maxime Coquelin > Sent: Thursday, May 5, 2022 6:27 PM > To: dev@dpdk.org; jasowang@redhat.com; Xia, Chenbo = ; > david.marchand@redhat.com; olivier.matz@6wind.com > Cc: stable@dpdk.org; Maxime Coquelin > Subject: [PATCH 1/6] Revert "app/testpmd: modify mac in csum forwarding" >=20 > This patch reverts commit 10f4620f02e1 ("app/testpmd: modify mac in csum > forwarding"), > as the checksum forwarding is expected to only perform > checksum and not also overwritte the source and destination overwrites > MAC addresses. >=20 > Doing so, we can test checksum offloading with real traffic > without breaking broadcast packets. >=20 > Fixes: 10f4620f02e1 ("app/testpmd: modify mac in csum forwarding") > Cc: stable@dpdk.org With above fixed: Acked-by: Chenbo Xia >=20 > Signed-off-by: Maxime Coquelin > --- > app/test-pmd/csumonly.c | 4 ---- > 1 file changed, 4 deletions(-) >=20 > diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c > index cdb1920763..8b6665d6f3 100644 > --- a/app/test-pmd/csumonly.c > +++ b/app/test-pmd/csumonly.c > @@ -894,10 +894,6 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) > * and inner headers */ >=20 > eth_hdr =3D rte_pktmbuf_mtod(m, struct rte_ether_hdr *); > - rte_ether_addr_copy(&peer_eth_addrs[fs->peer_addr], > - ð_hdr->dst_addr); > - rte_ether_addr_copy(&ports[fs->tx_port].eth_addr, > - ð_hdr->src_addr); > parse_ethernet(eth_hdr, &info); > l3_hdr =3D (char *)eth_hdr + info.l2_len; >=20 > -- > 2.35.1