From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A86EA0548; Fri, 9 Sep 2022 02:29:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D09E540DDC; Fri, 9 Sep 2022 02:29:30 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id AC59D40A7E for ; Fri, 9 Sep 2022 02:29:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662683369; x=1694219369; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=gKHuEOzMDjc+dklGDm7embiVVsThmqjVHPTcrBHXgHU=; b=bz3twevWrMxc5IdPFEiLW4hDK8UxXcz3kV9Pdb34ynTBOucKCfBqqK3m xLZv4bvYjK9YwXp8TBBfT9q3iq3FyICtqCbrv1FF3cRHGIuBHu8k5Kdku kRFDOrdqWm2hCNzVUTz3DPKSz/Hj9Odpwonx3VTy9NETWWQTaF3yVCe/i 2Puq+l2PVA9nFQcrf+oeZVm+UnfEmUEXtIObWB+RxgP1Qdkm6gO/MzyN+ M3rD6viWN6lwocgr/xbjHxxgeRHHM20tvl5W5qkf5UQtjqHEPpuMdGUj8 mFmVyf7vwpY86Ynz1Cb7LXGUR7NEepfoxeRAWsr5CCfhHZ22BYMsd5GMI w==; X-IronPort-AV: E=McAfee;i="6500,9779,10464"; a="277094282" X-IronPort-AV: E=Sophos;i="5.93,300,1654585200"; d="scan'208";a="277094282" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2022 17:29:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,300,1654585200"; d="scan'208";a="645320663" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP; 08 Sep 2022 17:29:20 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 8 Sep 2022 17:29:20 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 8 Sep 2022 17:29:19 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 8 Sep 2022 17:29:19 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 8 Sep 2022 17:29:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CB9X+OxsAY3IA2iVMckWEDmVCtbycGhtXSkgYo75VnZW82iUY/9aRD++IGWdOcrOGW3RPW5j7+ybcx7PyKGVdlIadBvPksMMkQMUzYSA1fb4VWpae2+XhTnu3+sqnM7LQTBc7tFsG2bGxTL/UBeiomzVCFfLxnJ1Zk7VoHgRk9q0JbqR9bfK6p3JMwbebamB6kUmPd4PbhGDvP5VcqInrh0Sc+ZVKTM5B/QQYDT2ddVPFEsqg09zyEu1Jzah9r4S4cxzBG+kuTGTHeNaoQx90XN4K07M0c9323WIrwWH6Y+xyP9IHMLBsqCa41i+WpA/UzBxCRd1LPvVilmd3JWF0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PWcHSpOi5ZmmH/VpH0hnvI+iSQwEm6ZpRQ2p+DSBRFc=; b=GiFzNtRvYDaXFKTAKd952iZQ4YBQeWcRaNXc+YQNanMUDAXTmGVFA0K0F6WAAk/u6j9fGvLvk4DCC3m29GXKYaoMSxPiXUgXY1kr2hIRx4ZI9VgiPsY6vG2Hf1VfomBDkhyVGLFsCV/pMZA6KuOu1od7GlkNamcxhWXStRrGam9I8twaQ1q6AzjvycsjPMevKGD1v6l9+05Yvky4IrRhaRl4FBPsBY7k14/K04dfRh4V3ii3XXKm0EDnMkjTqCJcMXQPOLrNw9Kr6Ejkn7OKcQqUllcW152kAmV+KKxKKzN/M23rV604kh6ki98vlCmeUGRC6izquvmY6gCoflE/iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by DM4PR11MB7278.namprd11.prod.outlook.com (2603:10b6:8:10a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Fri, 9 Sep 2022 00:29:11 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::14c4:518d:3a71:23f5]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::14c4:518d:3a71:23f5%4]) with mapi id 15.20.5588.015; Fri, 9 Sep 2022 00:29:11 +0000 From: "Xia, Chenbo" To: "Pei, Andy" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" , Huang Wei Subject: RE: [PATCH v2 1/8] vdpa/ifc: add new device ID Thread-Topic: [PATCH v2 1/8] vdpa/ifc: add new device ID Thread-Index: AQHYw0dYFowsRvois0yCL/hDBSCbxK3Vi5qg Date: Fri, 9 Sep 2022 00:29:11 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1662616458-164613-1-git-send-email-andy.pei@intel.com> <1662616458-164613-2-git-send-email-andy.pei@intel.com> In-Reply-To: <1662616458-164613-2-git-send-email-andy.pei@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cc8969db-4543-49a0-b0ca-08da91fa50fa x-ms-traffictypediagnostic: DM4PR11MB7278:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lHLtSGXMGhPPrpfkv1ebRAJFhX8waCNy+azPxVJXgqvJVpM5OczzNWyIVArtDvF0udcZy3b0f4QptjvgV6W0ZeUSVm5+CjyyQ1pV4RjjlWJS0yjcIUtx5eduuFgLjY3Fmd+xv/OLZcHdh3+R67VCYUijBqGPRNtUX6Mt9gHMLoJqeyflsIFzIw4t2Woh7gw9jQkNtWpB0QPuRgPwTSBP4AQEeZWUGQDkN98jMjzzONIE8SvJC/ljxD+ipoWICgoG/JsQTDaS9ixFakjzEPtlpTjWx9UKrwVjxrKKcygdpAPQzx4X59gHCGPWYnBM9ZSliSjqaoPlz8PfgCzfoBXEKhXbKedWDy7H83fAoh6A32Had46aLXwiboB2MvGYL0tXchnz1X/TokLnx6M5oFq2X95iemmAr+cyp5bTHeSuQzObO3nsgxvhj/ArSFQrG8XRfPjragJ73KTwYu4lNzzPgsxC3Wcs/KBC7AwLwfhdvvYXSz8L8GtDN9zzOpHs2oN/x18QybgjW4u7OT2tas7SmEU/cSaUckiJB0W0mlCHascRfwb/PeuB9NgbeJQlcNfhHdtk0RHUd0PN36y19LxlRF681E7HGn9Qwlvc2xPPa7SjgN+XB4noNUWMxSxITsyzKe7QFCuUrqP7WOYxq6QFShSrVbPDG7UhTL2hwCwMSwHaWkm8gNgVgQ57shzx+0pWqKdd0RBGKkxkl1lJL+TzB2ycGSlq/gs5vUSBOH6HJuintcFp4KeWRizc9QKsc+hqpOv8MtJrORGv3YyVPeRiRA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(376002)(346002)(39860400002)(396003)(366004)(6506007)(9686003)(26005)(38100700002)(122000001)(41300700001)(2906002)(53546011)(7696005)(66556008)(5660300002)(8676002)(64756008)(76116006)(66446008)(66476007)(8936002)(4326008)(33656002)(66946007)(478600001)(71200400001)(316002)(38070700005)(107886003)(54906003)(86362001)(55016003)(186003)(110136005)(52536014)(83380400001)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LijOw1j/rGwLW3D1JQSt4Bp5qTby8SS7FKwUCQCwptpVBptGiQWUKVVVdjtt?= =?us-ascii?Q?awQ7yQrC60VsZ+zggvW/N+SH9hUgs1HTSGemD5kuajwVJxrVYRhFvbdUuvcn?= =?us-ascii?Q?kz47640KHct7kVq4N8DJEKu60+m5H9oNwHjpibA+iZRQl4yu5MYOjAVYdXPW?= =?us-ascii?Q?qiDNt0Vgrfzw2Xoi37x/MfjJRO7uhEWf9OnPaQqKSz3Blf4ufFDAvYWCtUbJ?= =?us-ascii?Q?IogHvLkwuFkQ+8nBAPpO+PspA+oC0wqha6jLgbJgcl+VbkEy34ljtoO0FFp+?= =?us-ascii?Q?8zYAuHaa5Q3CL7AvB16WDsUJFa7dE9LNfBUc5hTDDH/rJ9Qp4YO3zHOtL/IZ?= =?us-ascii?Q?3869OvT6SBMBeBjZRbVna9SOOear8bWFHAw5Y5BkRFRrshnnbwsIFemKg0CY?= =?us-ascii?Q?sE8LhnW4XHbgTqDCGDtOmm8cc3hTzZnWqboMfg2BuQqz87QkuIvuEmphdNmw?= =?us-ascii?Q?sE566CXu/HwAwf/wKVgaG6kdinlMmzBTR+XBKEr+WmVqAAr0y2/D20zEBiRb?= =?us-ascii?Q?iCj0OQyvAv9mgdfAgMU40V8zRWJLv7ZZ0xhM3sfBqlkSMOIVR8B4wi5WwZBT?= =?us-ascii?Q?TYQjZ4EjjTrefthfBYjSYGwx4fukQc6Kg+D2MjQJjEj2QxdgHwjf7uTSi9N+?= =?us-ascii?Q?RNdRUwoj3ukXwnHidj+TIutT36lqMEcftFp6nu/rY4hASzr7EPU5wiKfL9Fr?= =?us-ascii?Q?ZU204pmAJSLo8Yke65N2MzL8h8KOdLd7lPTXBp4WhZKBndV5cT9+L+edrqnM?= =?us-ascii?Q?nG5A1soamU3IMcfAaHE44e2hRrH5qqKpjYFMsX7b2eDucleOg1XR+PGga4uj?= =?us-ascii?Q?xjvcdRMi5l6zXqmXgiOfyxDquW6Rw5d2JXjoGqFGjvm4557DBTv+V+12HqCc?= =?us-ascii?Q?Zrg8k+vfX+Pbrpwyt5jZSmztYyjvyvw4R41mpbv+FQ/0/odKjeYsSltYVnY8?= =?us-ascii?Q?77MGqZHT5ThEomMZwr/iXfAUf4AkMdBaHacxYo4nMNXpKQx2YMWNuVThMXd1?= =?us-ascii?Q?CGbSYXE0GkfyUSym3pWLjtMJ+gbqSdOaJatrWP5waSvjQzfrrGr5zG44rO2H?= =?us-ascii?Q?tvF31kH5sIjvD2QRGR81Pyc0TIr7auN6aXFl0X43nX8JhRS5gc9f516ndh8G?= =?us-ascii?Q?8nD8g9LhRKSYC/fAc0ASOedZWtaniX2FWE2DinDmPpFGY1AMwwYT3WvOzAso?= =?us-ascii?Q?cfvh3HSlpIIQlyran6srXx3wHsLbtfXYDP0PAhRlaWdV6LPa1xKMxkBuIuXT?= =?us-ascii?Q?drQN39qPyLn8ybVfMllJ0eLOav72tzw0xsXBhzHlbgZnl9fagkxWDXhZ6Irm?= =?us-ascii?Q?54dTRxt9zbYWz5B0I5xqajM1Q9u+z2Iai7fAwq3zBeY+Qow/ud9CBrfdZBkY?= =?us-ascii?Q?d/kw97t8DHfDEJXjQ5bYbRDTY+JUglSR58eJvxAaxcgORzLZLdAbr3zge+a8?= =?us-ascii?Q?LAnMH+NbpTvir/alLESeLiiILzW0kt25sC5hF1ChpX4ZXWbPda3hG4Gyi1Sk?= =?us-ascii?Q?mW8/b0At9liLvVM/irk3Q1pYaH6TrLnfvK+BQqdOp425hK4mIisy3+7x14RV?= =?us-ascii?Q?ah/fAXyVHnAfNbPetRq+3LJIDc3JejdahFxzUjF2?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc8969db-4543-49a0-b0ca-08da91fa50fa X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2022 00:29:11.2492 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IEy3ZVFwkMm4a/j4CWS+5nHJex0/BADI8dY/AALvhddOs68TPr3RDOhwOZJqG+Esk1fBnawxvMqkZWVxGRIINA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7278 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Andy, > -----Original Message----- > From: Pei, Andy > Sent: Thursday, September 8, 2022 1:54 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coquelin@redhat.com; Huang Wei > Subject: [PATCH v2 1/8] vdpa/ifc: add new device ID Title could be: add new device ID for legacy network device >=20 > From: Huang Wei >=20 > Add new device id to support IFCVF_NET_TRANSITIONAL_DEVICE_ID (0x1000). >=20 > Signed-off-by: Huang Wei > Signed-off-by: Andy Pei > --- > drivers/vdpa/ifc/base/ifcvf.h | 4 +++- > drivers/vdpa/ifc/ifcvf_vdpa.c | 9 ++++++++- > 2 files changed, 11 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.= h > index 9d95aac..7ede738 100644 > --- a/drivers/vdpa/ifc/base/ifcvf.h > +++ b/drivers/vdpa/ifc/base/ifcvf.h > @@ -12,11 +12,13 @@ > #define IFCVF_BLK 1 >=20 > #define IFCVF_VENDOR_ID 0x1AF4 > -#define IFCVF_NET_DEVICE_ID 0x1041 > +#define IFCVF_NET_MODERN_DEVICE_ID 0x1041 > #define IFCVF_BLK_MODERN_DEVICE_ID 0x1042 > +#define IFCVF_NET_TRANSITIONAL_DEVICE_ID 0x1000 > #define IFCVF_BLK_TRANSITIONAL_DEVICE_ID 0x1001 > #define IFCVF_SUBSYS_VENDOR_ID 0x8086 > #define IFCVF_SUBSYS_DEVICE_ID 0x001A > +#define IFCVF_NET_DEVICE_ID 0x0001 For subsystem device ID, I suggest to add _SUBSYS_, please check all Subsystem device ID and make all the names well-defined. Thanks, Chenbo > #define IFCVF_BLK_DEVICE_ID 0x0002 >=20 > #define IFCVF_MAX_QUEUES 1 > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.= c > index ac42de9..61d0250 100644 > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > @@ -1684,13 +1684,20 @@ struct rte_vdpa_dev_info dev_info[] =3D { > static const struct rte_pci_id pci_id_ifcvf_map[] =3D { > { .class_id =3D RTE_CLASS_ANY_ID, > .vendor_id =3D IFCVF_VENDOR_ID, > - .device_id =3D IFCVF_NET_DEVICE_ID, > + .device_id =3D IFCVF_NET_MODERN_DEVICE_ID, > .subsystem_vendor_id =3D IFCVF_SUBSYS_VENDOR_ID, > .subsystem_device_id =3D IFCVF_SUBSYS_DEVICE_ID, > }, >=20 > { .class_id =3D RTE_CLASS_ANY_ID, > .vendor_id =3D IFCVF_VENDOR_ID, > + .device_id =3D IFCVF_NET_TRANSITIONAL_DEVICE_ID, > + .subsystem_vendor_id =3D IFCVF_SUBSYS_VENDOR_ID, > + .subsystem_device_id =3D IFCVF_NET_DEVICE_ID, > + }, > + > + { .class_id =3D RTE_CLASS_ANY_ID, > + .vendor_id =3D IFCVF_VENDOR_ID, > .device_id =3D IFCVF_BLK_TRANSITIONAL_DEVICE_ID, > .subsystem_vendor_id =3D IFCVF_SUBSYS_VENDOR_ID, > .subsystem_device_id =3D IFCVF_BLK_DEVICE_ID, > -- > 1.8.3.1