From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E106A0548; Fri, 9 Sep 2022 02:29:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A029427F9; Fri, 9 Sep 2022 02:29:35 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id E436D41141 for ; Fri, 9 Sep 2022 02:29:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662683374; x=1694219374; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=m55eLaL0xvCA3GYLwL7GTgoQtu9FgmVBCf9LqURtcXE=; b=D3CslMDatxZG8iEKn0kkXhDitNSw4fLLjOtBhnz2cR7x2jpVALhGcDMh 2+azrXCUi8zqO+zHv4IYkLan+0S3oYBo/et5YNpYfSXDZdt5I8LTpSn16 jGLj38WjRatdz8NEFBUAj8l2hvNbmP3Q4vOaHJxhWJKfnlV4+L3vE/bJf 7vtyy1PffONbvLdHmIeJLexCj5zprxBPzyGE0kv7rPV4/ZBPQoOOkxw1U J4r9b5EMZnXNN9/weJASURiHx66Wo1ppSO+k9TLKEMZu7b1J2dzzL0iWS fAl63IfR/PGMduLADpnz8GSDmSKO9/rSNqIgSoUc25qUR1m6Ye2cvcd7a Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10464"; a="297359452" X-IronPort-AV: E=Sophos;i="5.93,300,1654585200"; d="scan'208";a="297359452" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2022 17:29:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,300,1654585200"; d="scan'208";a="615093245" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga002.jf.intel.com with ESMTP; 08 Sep 2022 17:29:26 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 8 Sep 2022 17:29:26 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 8 Sep 2022 17:29:26 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 8 Sep 2022 17:29:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gF2CS9nq6AkB+OhbdekOLlg0XxHteIJDu23my938bPt6VAjGHMc3Nd0kbaVc8nq0jLv/pP2dmfcNT9OOfY4vhtylMSLOkWBEzsme3JPngcU6YNtWDK3CdrIW0CeZ6i4a5rnbmW3v/SrfYv5w7NQtvkMd35I5S3R5N+aW+WyQhafMj57T4cJYLK/N1Sm4LxKCfFsuzjvb46f2GJSgdDFPgA5+L12WSLVrK/r11zQkqH/7iN9s5OMQZNdAvyTRenZWvka6S+nwlrhPtRoK9eYktOncMgmqyBFmer7vD+hDkanu60QaU7jcc7EaB2zgq9cwKQPt1eK62ecD/RjGwz68GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fv5NtUwg5Gxyws0tlllbVvTEIa7q6zq7+vjNIStWJbM=; b=IPGWdeXK4ELhUU1RRt6aV+9oNmDxcb5NQV7wp2cciPWnbEe+HMaR9jDSPtVmKc+KGEGUy4+72mZ7q+U7wZ46isgentghToXo0oXzmdnAApsw4NOS7RUU/dlco/yvWeyphrvDZgLkyQNvBt0y4veYMaHVRrbeF5xVHkLA+uMCbHzDBDYqzlEbw6CSAopXBY7WX2tvD/w9l4tt/8RHfb+ncXjbB6vtObEXXC2lG+IFHa2fiUXLEGyeV9pJ5QcTCVOSL22G9wu8UlVg3PBJg84CtAr21uxHzopxXReD55fv3RiNgAq3QvaRYBQVrNqGFW/ODSSCx0q57nGFWDCNwV3wpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by DM4PR11MB7278.namprd11.prod.outlook.com (2603:10b6:8:10a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.18; Fri, 9 Sep 2022 00:29:23 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::14c4:518d:3a71:23f5]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::14c4:518d:3a71:23f5%4]) with mapi id 15.20.5588.015; Fri, 9 Sep 2022 00:29:23 +0000 From: "Xia, Chenbo" To: "Pei, Andy" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" , Huang Wei Subject: RE: [PATCH v2 2/8] vdpa/ifc: add multi queue support Thread-Topic: [PATCH v2 2/8] vdpa/ifc: add multi queue support Thread-Index: AQHYw0dWQsoelLYRk02C9OxL21l5Cq3VjXcw Date: Fri, 9 Sep 2022 00:29:23 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1662616458-164613-1-git-send-email-andy.pei@intel.com> <1662616458-164613-3-git-send-email-andy.pei@intel.com> In-Reply-To: <1662616458-164613-3-git-send-email-andy.pei@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: abb77c79-7ae5-4efd-73ab-08da91fa5877 x-ms-traffictypediagnostic: DM4PR11MB7278:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kuFj91UZhx2mqqviBvDjbzZUWFFZfHKblk2wSk/+7nTgaYi2rh0Tj1V+YQn3bj/qZ6qoMVl5p05+7p5roqpI/a5Rq/1FHEemmU4tpHh+lBmI5DJ+7ARlvrBxZ3FR06itCb1C4JwOBp6WTej3xOlFcHNPDvQmVEae0RAZFdTlwjMb0oajB8CteP12RpjBv1hS/wDzCrcQJMUnsbeW3wbvMX1O61Jep+Cx8jzWxr00Fz4TdaV721GURQKIxRezgrpayvpeAqPuVFd5lxusAk8CNVVmZAUEQQih3wYcay0Ti2xG17ShK8ELNykCW5N4qSmcyTM1WhILOT0OWt2/1Un12Wvv0dXLV5a864t74YJmqEmwta9StIa/2AeAxzIkvJxhzqLnpzq915DZkkZkTkSLMVnh1gBroJZLdvoXLTJ47SGYsGUtiQvJ6PiZmLVBr3Ab4HJuextkxz+a8TBP2NeRoKliALDGWKSlRpsY/vGQ8DdxOwz+YF/XfEyq5F0k5SyvJGfmWuzgbPGswHcGpmJmm3ZMLOW3iUIJdGN6H8FIf5ld0Ksngwfo/U4tu2GcKbte7WLh0KXtLAVXlpyqCGCZ347YyNj1jZedXNI87jYOADgigbrH47Ts9AjsFr86qqqoC5lqA1I7zZVnY6dC5CI8svp76WeVofO3XvG0P4v17L1bylxFS/UZyqoq99eXAHLRX1OPRXJZivtBo8BhYFW5UiGdlFHSh2lQ14iGxBxdQiKT6u2lxMaVZGvX7secFJj59fbmhukiqpUui+8g3r0fIw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(376002)(346002)(39860400002)(396003)(366004)(6506007)(9686003)(26005)(38100700002)(122000001)(41300700001)(2906002)(53546011)(7696005)(66556008)(5660300002)(8676002)(64756008)(76116006)(66446008)(66476007)(8936002)(4326008)(33656002)(66946007)(478600001)(71200400001)(316002)(38070700005)(107886003)(54906003)(86362001)(55016003)(186003)(110136005)(52536014)(83380400001)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?j7SBColLrI0cN+YhuaASylNsyqBjU3XnAO0bXXEMZbHQZ8OS9ugN2sjYrhyi?= =?us-ascii?Q?S/nA/wH9X9lAUtLnSszqNdHZ44ObxTGjn/FHxg+Su+vfzvE9asorFs8v0Hun?= =?us-ascii?Q?CJUTbcz6TXK/j/D+zo8UmllU83afFdnpIvYu2maYM9/zkxHvQQmpwg5PNJxN?= =?us-ascii?Q?IfqBWG4BnoQokdUzUWlaYoCm/ZWr6QGfPQjm7JXBbu3vhJajKCauPsmuasyA?= =?us-ascii?Q?dbNobeQvDpuJUeDAoG+333z7KpHi5yNDfFucrztvtZinKRhiwM8wHe4oc2Oa?= =?us-ascii?Q?fn3as/dl/oH4iZzBod4FYLixUwD7mE4QeHtH452qSf4+CFNsGGtNi0HKqV1K?= =?us-ascii?Q?z9cWV6PGNuDr3cf9bMWMxiHH4cuRNtWwQdVh++lYlMdjOZvIL1DYZlgrhYf3?= =?us-ascii?Q?2BBf49ojOZUhr0mZCbs5wRchqe+k3mBGD7JydE0PKSzJ+Lp04k53rmhXfj3R?= =?us-ascii?Q?dpOammMIguhBl6S9mxp0Jh4v4F7wihzPmPq9azZkta7KKqAD/b2QawUTra5e?= =?us-ascii?Q?8vOYnQ/dqmJXz1ffYWlIuUvM7pP1dR2QviqoFygQ1EMY51cwUj1hABU9lOKK?= =?us-ascii?Q?AwgUxEGNJYtj4Wl8yBSC3e4hXqUdmfierKbjahsnEZ+hjeje4X1LsBI9rBah?= =?us-ascii?Q?n35mWesSY5mmQNjmOm4ahNFo3Hr+6tjcITaLZfelJoAbXRNH+TnzJmT/3TIv?= =?us-ascii?Q?oDi+YXAHqRoDRNeWNAGH/tSkfz5dh3urEEjaY5f/HrezSaSaRujDzdca0rZb?= =?us-ascii?Q?Kr/JHFWO7ukQVNlxW24vu7GK+qMGSqfZySDxsDvy+AbqNTBAjF+N2G4hWl6J?= =?us-ascii?Q?58rCsLf9fpa7cfIbTgjAvKok7mpsPy/GiiZPUAMAmy3yA/4GhaOn2n048vLQ?= =?us-ascii?Q?mL6Nus7gox+I6Berxfy2tY6O1ZfXwwzxnzNk6Vf7b0GnZmmoOj04AIJ21QnX?= =?us-ascii?Q?mSX/JHj4Tol0rMUvl5aYVpD88rkmFLoDdaP0ivhDc0Iu1rL2GgTeYUsze4sl?= =?us-ascii?Q?Fxw0Se/spjvyX+jR+/zxmCcSu8OzIAQEYe9JBwq6bQR6Vuu+uIxoPml23Jj3?= =?us-ascii?Q?TNpjdVaR65MZRY7OXNBENoKZsw7vSLVRojfs9X4SkVfsRgMFP9GgAyYaafDj?= =?us-ascii?Q?enuKzbSQo0u5RwaEDhCo6qd6ogAvcisEjmGiPLTtcnDLIfKtBf9Acrxleefz?= =?us-ascii?Q?d3BhYyaJMnwPe2k+mzOamE4Yzn6pKz/twtPq6uB2+LE4CDSYrcjyDqdqlIxs?= =?us-ascii?Q?FvaWvaWzAVQELCBpGh4+nNwZAhUW8P0S2iLnr0J3BEGH1mqR6FIvbz7fPrOM?= =?us-ascii?Q?Rh/4ju4+ep4Ue/VcUeH9XUM9g6A9hrLKYbeMz3fUqh5UN+DGrihIgOhK2aGt?= =?us-ascii?Q?x+o0ghLKu2GDqXdZGCagm1hQM0wc4hhHzatTxTdZHyvlEYkBN4O3zjcnPFQr?= =?us-ascii?Q?N42+FsbkOKu1otA/5uESXmgaAT3KKjJDn+xiXhIEheo6Ew41YvXX6rs4U2ui?= =?us-ascii?Q?rkvDDiuSAyEnYEq1KZv/q2RbhCIAiR+fX5fcnEkMO1ZE/y/Ujx91QoA4HYjW?= =?us-ascii?Q?5nam+4Ig/y06u51+ZGyEdJypHRKQHpnN9Ptyql8a?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: abb77c79-7ae5-4efd-73ab-08da91fa5877 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2022 00:29:23.7796 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IaSeOvq07ipsr2c1m+1Ji8HIMW+q4yYy/6iiyJ/9Bgo5B2Jn1n3Xrg37FyPLqESt3PG90T8HztqN4P2YzT0YKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7278 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Pei, Andy > Sent: Thursday, September 8, 2022 1:54 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coquelin@redhat.com; Huang Wei > Subject: [PATCH v2 2/8] vdpa/ifc: add multi queue support multi-queue >=20 > Enable VHOST_USER_PROTOCOL_F_MQ feature. > ExposeIFCVF_MQ_OFFSET register to enable multi queue. Please rephase it in a better way, at least add a space before IFCVF_MP_OFFSET... >=20 > Signed-off-by: Andy Pei > Signed-off-by: Huang Wei > --- > drivers/vdpa/ifc/base/ifcvf.c | 5 +++++ > drivers/vdpa/ifc/base/ifcvf.h | 2 ++ > drivers/vdpa/ifc/ifcvf_vdpa.c | 1 + > 3 files changed, 8 insertions(+) >=20 > diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.= c > index f1e1474..34c8226 100644 > --- a/drivers/vdpa/ifc/base/ifcvf.c > +++ b/drivers/vdpa/ifc/base/ifcvf.c > @@ -90,6 +90,11 @@ > if (!hw->lm_cfg) > WARNINGOUT("HW support live migration not support!\n"); >=20 > + if (hw->mem_resource[4].addr) > + hw->mq_cfg =3D hw->mem_resource[4].addr + IFCVF_MQ_OFFSET; > + else > + hw->mq_cfg =3D NULL; Could you help me understand the logic here? There are two cases that BAR 4 mmap-able and not mmap-able? Thanks, Chenbo > + > if (hw->common_cfg =3D=3D NULL || hw->notify_base =3D=3D NULL || > hw->isr =3D=3D NULL || hw->dev_cfg =3D=3D NULL) { > DEBUGOUT("capability incomplete\n"); > diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.= h > index 7ede738..ad505f1 100644 > --- a/drivers/vdpa/ifc/base/ifcvf.h > +++ b/drivers/vdpa/ifc/base/ifcvf.h > @@ -50,6 +50,7 @@ >=20 > #define IFCVF_LM_CFG_SIZE 0x40 > #define IFCVF_LM_RING_STATE_OFFSET 0x20 > +#define IFCVF_MQ_OFFSET 0x28 >=20 > #define IFCVF_LM_LOGGING_CTRL 0x0 >=20 > @@ -149,6 +150,7 @@ struct ifcvf_hw { > u16 *notify_base; > u16 *notify_addr[IFCVF_MAX_QUEUES * 2]; > u8 *lm_cfg; > + u8 *mq_cfg; > struct vring_info vring[IFCVF_MAX_QUEUES * 2]; > u8 nr_vring; > int device_type; > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.= c > index 61d0250..2d165c0 100644 > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > @@ -1248,6 +1248,7 @@ struct rte_vdpa_dev_info { > 1ULL << VHOST_USER_PROTOCOL_F_SLAVE_SEND_FD | \ > 1ULL << VHOST_USER_PROTOCOL_F_HOST_NOTIFIER | \ > 1ULL << VHOST_USER_PROTOCOL_F_LOG_SHMFD | \ > + 1ULL << VHOST_USER_PROTOCOL_F_MQ | \ > 1ULL << VHOST_USER_PROTOCOL_F_STATUS) >=20 > #define VDPA_BLK_PROTOCOL_FEATURES \ > -- > 1.8.3.1