From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: "Lipiec, Herakliusz" <herakliusz.lipiec@intel.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH v2 1/3] examples/vhost: update makefile to match meson build system
Date: Tue, 21 Jun 2022 13:12:26 +0000 [thread overview]
Message-ID: <SN6PR11MB35047AC122B94F5121AE01959CB39@SN6PR11MB3504.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220621121315.1173180-1-herakliusz.lipiec@intel.com>
Hi Herakliusz,
> -----Original Message-----
> From: Lipiec, Herakliusz <herakliusz.lipiec@intel.com>
> Sent: Tuesday, June 21, 2022 8:13 PM
> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>;
> Richardson, Bruce <bruce.richardson@intel.com>
> Cc: dev@dpdk.org; Lipiec, Herakliusz <herakliusz.lipiec@intel.com>
> Subject: [PATCH v2 1/3] examples/vhost: update makefile to match meson
> build system
>
> Meson build system creates a vhost binary but Makefile
> and docs reference same as vhost-switch. Updating makefile
> to match meson and the docs accordingly.
>
> Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> V2:
> * Moving relevant doc updates here from second patch as per
> Bruces suggestion.
> ---
> doc/guides/sample_app_ug/vhost.rst | 10 +++++-----
> examples/vhost/Makefile | 2 +-
> 2 files changed, 6 insertions(+), 6 deletions(-)
This patchset seems to have apply failure, please have a check.
Thanks,
Chenbo
>
> diff --git a/doc/guides/sample_app_ug/vhost.rst
> b/doc/guides/sample_app_ug/vhost.rst
> index a6ce4bc8ac..3c3cfdcd2d 100644
> --- a/doc/guides/sample_app_ug/vhost.rst
> +++ b/doc/guides/sample_app_ug/vhost.rst
> @@ -17,10 +17,10 @@ Testing steps
> -------------
>
> This section shows the steps how to test a typical PVP case with this
> -vhost-switch sample, whereas packets are received from the physical NIC
> +dpdk-vhost sample, whereas packets are received from the physical NIC
> port first and enqueued to the VM's Rx queue. Through the guest testpmd's
> default forwarding mode (io forward), those packets will be put into
> -the Tx queue. The vhost-switch example, in turn, gets the packets and
> +the Tx queue. The dpdk-vhost example, in turn, gets the packets and
> puts back to the same physical NIC port.
>
> Build
> @@ -38,7 +38,7 @@ Start the vswitch example
>
> .. code-block:: console
>
> - ./dpdk-vhost-switch -l 0-3 -n 4 --socket-mem 1024 \
> + ./dpdk-vhost -l 0-3 -n 4 --socket-mem 1024 \
> -- --socket-file /tmp/sock0 --client \
> ...
>
> @@ -90,10 +90,10 @@ Then start testpmd for packet forwarding testing.
> Inject packets
> --------------
>
> -While a virtio-net is connected to vhost-switch, a VLAN tag starts with
> +While a virtio-net is connected to dpdk-vhost, a VLAN tag starts with
> 1000 is assigned to it. So make sure configure your packet generator
> with the right MAC and VLAN tag, you should be able to see following
> -log from the vhost-switch console. It means you get it work::
> +log from the dpdk-vhost console. It means you get it work::
>
> VHOST_DATA: (0) mac 52:54:00:00:00:14 and vlan 1000 registered
>
> diff --git a/examples/vhost/Makefile b/examples/vhost/Makefile
> index 975a5dfe40..ea64f02bb0 100644
> --- a/examples/vhost/Makefile
> +++ b/examples/vhost/Makefile
> @@ -2,7 +2,7 @@
> # Copyright(c) 2010-2014 Intel Corporation
>
> # binary name
> -APP = vhost-switch
> +APP = dpdk-vhost
>
> # all source are stored in SRCS-y
> SRCS-y := main.c virtio_net.c
> --
> 2.36.1
next prev parent reply other threads:[~2022-06-21 13:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 11:48 [PATCH " Herakliusz Lipiec
2022-06-07 11:48 ` [PATCH 2/3] doc: update vhost sample app docs Herakliusz Lipiec
2022-06-20 1:56 ` Xia, Chenbo
2022-06-07 11:48 ` [PATCH 3/3] examples/vhost: update vhost usage message Herakliusz Lipiec
2022-06-20 1:59 ` Xia, Chenbo
2022-06-10 12:05 ` [PATCH 1/3] examples/vhost: update makefile to match meson build system Bruce Richardson
2022-06-21 12:11 ` Herakliusz Lipiec
2022-06-21 12:13 ` [PATCH v2 " Herakliusz Lipiec
2022-06-21 12:13 ` [PATCH v2 2/3] doc: update vhost sample app docs Herakliusz Lipiec
2022-06-21 12:13 ` [PATCH v2 3/3] examples/vhost: update vhost usage message Herakliusz Lipiec
2022-06-21 13:12 ` Xia, Chenbo [this message]
2022-06-21 15:20 ` [PATCH v3 1/3] examples/vhost: update makefile to match meson build system Herakliusz Lipiec
2022-06-21 15:20 ` [PATCH v3 2/3] doc: update vhost sample app docs Herakliusz Lipiec
2022-07-01 13:10 ` Xia, Chenbo
2022-07-01 13:53 ` Maxime Coquelin
2022-06-21 15:20 ` [PATCH v3 3/3] examples/vhost: update vhost usage message Herakliusz Lipiec
2022-07-01 13:53 ` Maxime Coquelin
2022-07-01 13:40 ` [PATCH v3 1/3] examples/vhost: update makefile to match meson build system Maxime Coquelin
2022-07-01 13:53 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB35047AC122B94F5121AE01959CB39@SN6PR11MB3504.namprd11.prod.outlook.com \
--to=chenbo.xia@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=herakliusz.lipiec@intel.com \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).