From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57914A00C3; Mon, 26 Sep 2022 04:57:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 43F6F400D7; Mon, 26 Sep 2022 04:57:39 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id D81A4400D5 for ; Mon, 26 Sep 2022 04:57:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664161058; x=1695697058; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AFTx6suwzkNjUpvsm7GcykjXiCBDwJwh+P2000GfGeY=; b=HWRTlsnMvHSzS8T5Hln2/8vgBmWrSo90PgnlmGjpQFcKxXVQNZBfq7qh FMd2hwEgpmCLFqHucq0GPrycQLfmKmYkH3sXoyohTDEmleXOOTleEpnsN WnQiI/i9LYJqQCg4pF3aH4vyv4nj63cjMcVzyvy2rWELX+YT6NZiq7hW0 dQiNklIASTEnD2MXY+6e8w52jmb4riRjgldrOSDBwMySrmwb0tavwr3Xm wB3T/mH9yPxXwkalApaU5GHi9QrEfqxLeaCe4UkOH/N/elttf1dinEXPG LqXt0H3yhUIWskLD+LOjDzLV5k/ENE8Nkyhxla1gybfR1HYuN3Dsqhp0Q w==; X-IronPort-AV: E=McAfee;i="6500,9779,10481"; a="298525901" X-IronPort-AV: E=Sophos;i="5.93,345,1654585200"; d="scan'208";a="298525901" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2022 19:57:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,345,1654585200"; d="scan'208";a="623174795" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga007.fm.intel.com with ESMTP; 25 Sep 2022 19:57:36 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 25 Sep 2022 19:57:36 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 25 Sep 2022 19:57:35 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Sun, 25 Sep 2022 19:57:35 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Sun, 25 Sep 2022 19:57:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a2R2VVuMtP8jUqSJbFshsrCbXyHrDqYZVRcp/03RCY+byD8wrQwzNtjBhIZKLukJL47a9QniMSKhtzpG38n0OyE5YY5Qz2IQT1scMFZlT9dHEq4fGmjh8oWkOP8MJglNwkwwny8z9yJ3noPx3CJGOOxlrEdmwC7HqBzEDVECW1sMKqOqGCeiAiNOBJUo4wYGMsbUo3hHMz/IpbcBREhWBEjcJ36Q5CsRiPfp1By7ezvnPJy0cYQ/WgAk6Q/k+mwS4I3ZGZwNUACTZQbrgmBBSn2X71Lx/cAuuqG6x1Bc2zCn9GmL/krO8G73XIkN1MhnwUR3S2e1ldVtey4KxTDoAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wQJs7IOfJ/hs8uU2fkqXxsxk0ssyMUa7wZ1PVqgZHCo=; b=EYTL107nrkudn3SZ070JGc0A8Ihlw713N/hAiCZy0r5hJruDb27NUuVoG66HSx3kgpAcJbmQtv4x7HtrwcoPXiFXzxpvFjP4myMn8TXkDTi66pvUw9TEqcPTXlZgvc0SBzaobfABwC74NwsL/AQbPs2dZejagukOMHEu3Bp4tPoxkasWEsEWJnFof0Qr8ugUKKH6v7XU7sxvCDIDOhlbvJsz6y4xf2hZ3ntYo+1Tb3c6AFJxEWvzgxRju2+4vIKDH+BL8GljsH+ifRWqnpDbI9clOCYf/9nBZlq5T1E5MCFjbLkd8uFGxLicl5KBdgcaJm1NHk8F8jf5PIw2ACod1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by IA1PR11MB7368.namprd11.prod.outlook.com (2603:10b6:208:420::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 02:57:33 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::408e:79cb:b715:b8ac]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::408e:79cb:b715:b8ac%4]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 02:57:33 +0000 From: "Xia, Chenbo" To: Min Zhou , "david.marchand@redhat.com" , "maxime.coquelin@redhat.com" CC: "dev@dpdk.org" , "maobibo@loongson.cn" Subject: RE: [PATCH v2] vhost: fix build Thread-Topic: [PATCH v2] vhost: fix build Thread-Index: AQHYu4GAKWeJZh931kqDwctM4xllUa3xL5fQ Date: Mon, 26 Sep 2022 02:57:33 +0000 Message-ID: References: <20220829082915.1056865-1-zhoumin@loongson.cn> In-Reply-To: <20220829082915.1056865-1-zhoumin@loongson.cn> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|IA1PR11MB7368:EE_ x-ms-office365-filtering-correlation-id: 0634a181-9c01-4029-2384-08da9f6adc08 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ex/eyCypX1wnni0TE81/R+7z+juHEv1dUECaohE7JKB2Hnf0pbMI3VO/F0FuV2SdMCNm7d2my/FBhjSUJPwKTuo6QHEdX3h9dCtPt1UyK0w6uMVQLK01B6ewW5yZswSfN4WQst3GpDDcHvzqOJQzPAC4o4DsazbbgvpNu86qzRG93mtLigg04YlWxcgXp3JO+bzdymR++v6w65bspEFHLj1FUdU3Fp/O2VAq6UA+VhotTdWeAIjsQX8++VzM9iHwzPXT9Jsr/gyGhAxXOKL8w79wbgk+EJi3SnHrooIkg/5LZKsEQ2+0andh0322w447OfftsKOYwxrRzYR4MfaUdnzlM7/jhrsG5dbj3fDJz4P4c4Bhi+7shpnLrp3xzPbjF3lCZTUkRDgUTDtZ7O2b+MJ3+lH31GmAgNbZZR3dqVmD5S8BweXMwOH8WmrLaq9yUo1df//TQSfGTC7mofKZaPqGcy/Et5yFkH8oZ0JRZaaPpMkgBguqfjxqNSpLiImAi0ZffRQKVLXVoQqQmkcYE3Kus3PxXGEQLf+rfijpoHbyPrNX3AkSadrE5Di+PeQhyRH9Gf8ZM/3EUZsVEMLBiOgmNIPGfXrBGw5KqdrpgxDKR4UR5Q7ZaaoN+lvG41sTfVR/vUkkTsT3DTvh71TJ1folpPgCeNLQpbcl9XTEJdTKgkt5R4NaCEVSIIAXelObTleGCuo8SqkBszVqVeC5qOjywUPqYRzlW9HFfIKcQzi3eJ1AARyyV96/X7Qij1e+YbijDEHj4O9DW/KfhKi/Q0jGrpAlQ7Cjyn2WiMFlCW4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(136003)(346002)(376002)(396003)(39860400002)(451199015)(7696005)(6506007)(9686003)(26005)(186003)(53546011)(122000001)(83380400001)(52536014)(2906002)(5660300002)(8936002)(55016003)(71200400001)(966005)(54906003)(110136005)(66476007)(478600001)(66446008)(66946007)(76116006)(66556008)(8676002)(41300700001)(64756008)(4326008)(316002)(82960400001)(33656002)(38070700005)(86362001)(38100700002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?u+85TeuiXKiXL/zsJlLhSA2UeNsqiC3jv7AvrNXVsyjHvcioOlLkshJ7e2rN?= =?us-ascii?Q?Qj9x0SBelzneuCYQSwi7eV37Og7zdmgjpsG8dlY6ILcVniHDKgznrFtLimPl?= =?us-ascii?Q?OThQr6rnDfGh/MWQdVRcSyLliVOY1l/+zHJ7dBeUPGd+HJnw/jsbuYdhL/zP?= =?us-ascii?Q?ORNHofIIMgQy0WxGOnrTyo52oNsBIlUMFE0jrD/zWkT5r2MogkdCiiWihHlg?= =?us-ascii?Q?3d6dweQN3rsBmg3jdPObuFOaiIRV1r61iK2665ivm76dkcgzXKdzp8JtirIL?= =?us-ascii?Q?Yyd4GcHY8Y8sMVQNYz4Gi+oeVyahG4E/d29YBewumH+YERIavxGx98+OZ/DY?= =?us-ascii?Q?EhukueEmxXvSwZNo4L+44TOVhvOwMVnxAusyvVfefpuvRCWR7y4zs697scq5?= =?us-ascii?Q?pH+LcMzsCreBMGgZegwWgecZlG1P63PK7nASoQzaE7ZL2ZQkjL02LHU61+xq?= =?us-ascii?Q?s5IeWcyDMiR17XoWjs4dkZS2rgXXEkdzv2GCPyE5M7uDr75IT7SA9R2R56re?= =?us-ascii?Q?/vdp8osprIyNdRaayZtbrVXx4Sj/I2sMef5tlR/3ihGL7ScLOPB20fG339GE?= =?us-ascii?Q?yxwi+ZTWZ+vQLwNAZ0WRMghgGnvlJtzMQ5v+w9Axtxefxdv5BeOLC2G/q+a+?= =?us-ascii?Q?TpxGHrdiBSeqQqW4ivaXvcQ2CxJPiPBu0zeAtIrx45QCOx9sv2Ft5GTWV3ko?= =?us-ascii?Q?qR76uyDzuRPtMNKFRPOgcKxE/zr+87VYA+Rj0/td/uVAKnshmo1kUVAt1rVN?= =?us-ascii?Q?8FWa/R6UHT/xBPcRxRh69J8Glad00L4e0uw1RNytJgpvN4T315u5n+0XmP7l?= =?us-ascii?Q?xks8XUW9OUuQ6z9NossTPMq2KZRhaYokY5sE0BGyrclLLzDjvIhy9B8Um/Cg?= =?us-ascii?Q?JyceDMaV3QhCtaqd+YrCjMZGF2xPPoXtS+igFoZmDpC+mHYqKm7gOawFewB1?= =?us-ascii?Q?zaDF1Um78tw+K/qK06Lm4tG07XexGoVv/5y7KPqjw0+6EcSA/t2prxKh0Um6?= =?us-ascii?Q?4cGXYrjq2FSWkSDjn+p8/1hqLFQ19rP4XPoVyzImN2vyGYmoxCy47EAH0Y7K?= =?us-ascii?Q?IJQfmzEPZYUS6WxwzXIlYPXGrVzL7Oh/8EWQG7BesztV3w0gblbsBpxoKiMX?= =?us-ascii?Q?rGyyvqVfFZFI5eu1mpW93lGO0Ok1DRvTgsP88XqlxH0HBgg+frgjsmHP9lnn?= =?us-ascii?Q?wyOeZS4uzL50Auc9aMpDkXqi61oICYad2vDnHH40NvljB7wCAtASJttOhyg8?= =?us-ascii?Q?gP5yIK/QhM21fYYjspsFVSy/QmjhEafDnkyms0pkv0UOms3mg07HCJBylSHK?= =?us-ascii?Q?BxoulPD+aLbYmnGjK91TU+0HUJ81eAIK68gzT40OaJRSveKCJI1VvFOZYR1s?= =?us-ascii?Q?NqFIm1PXz0clU34bS0MtxN7QMipE6MdfYwzNrqRXHw06yo2VhdcyRnk4/W7K?= =?us-ascii?Q?DnP+jUqdBmusmpZv6tsV0ItHpkte3/hO81yMtO9WVe/r4HOBjHsxJ8j/+HvI?= =?us-ascii?Q?BUNeYtW9c9RAvwDDXHk9RIkGW4h7mgq+y6o94+Iv1QS4KhHxn5g1EfG9GcDi?= =?us-ascii?Q?2HQG6pe1eVo2FtJ23T+X9Vl2CTfF0Yp+tcaxGkum?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0634a181-9c01-4029-2384-08da9f6adc08 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2022 02:57:33.2748 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eXG5/l+kdIVGMmDdpAMVZQvR2QyWwv4PRfOUeZHX0L5Pp+PIqMC3juRdqTZDBGC7MnO8BcVIa89MYa5EywvTrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7368 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Min, > -----Original Message----- > From: Min Zhou > Sent: Monday, August 29, 2022 4:29 PM > To: david.marchand@redhat.com; maxime.coquelin@redhat.com; Xia, Chenbo > ; zhoumin@loongson.cn > Cc: dev@dpdk.org; maobibo@loongson.cn > Subject: [PATCH v2] vhost: fix build >=20 > On CentOS 8 or Debian 10.4 systems using gcc 12.1 to cross > compile DPDK, gcc shows a following warning which will cause > build to fail when build is run with -werror: >=20 > In function 'mbuf_to_desc', > inlined from 'vhost_enqueue_async_packed' > at ../lib/vhost/virtio_net.c:1826:6, > inlined from 'virtio_dev_rx_async_packed' > at ../lib/vhost/virtio_net.c:1840:6, > inlined from 'virtio_dev_rx_async_submit_packed.constprop' > at ../lib/vhost/virtio_net.c:1900:7: > ../lib/vhost/virtio_net.c:1161:35: error: 'buf_vec[0].buf_len' may be use= d > uninitialized [-Werror=3Dmaybe-uninitialized] > 1161 | buf_len =3D buf_vec[vec_idx].buf_len; > | ~~~~~~~~~~~~~~~~^~~~~~~~ > ../lib/vhost/virtio_net.c: In function > 'virtio_dev_rx_async_submit_packed.constprop': > ../lib/vhost/virtio_net.c:1838:27: note: 'buf_vec' declared here > 1838 | struct buf_vector buf_vec[BUF_VECTOR_MAX]; > | ^~~~~~~ > cc1: all warnings being treated as errors >=20 > Actually, there are eight places to see the same codes in the file > lib/vhost/virtio_net.c, and all these `buf_vec` arraies are > initialized by sub-function calls under various conditions. >=20 > Although It's hard to understand why gcc just emits warning at one > of the eight places, adding validity checks for array length is > reasonable and can also fix the warning. >=20 > Signed-off-by: David Marchand > Signed-off-by: Min Zhou > --- > lib/vhost/virtio_net.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Just want you to know that your patch is still pending because by accident your fix is almost the same as a previous patch that fixes a real issue but that patch is still in progress: http://patchwork.dpdk.org/project/dpdk/patch/20220802004938.23670-2-cfontan= a@suse.de/ Thanks, Chenbo >=20 > diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c > index 35fa4670fd..99233f1759 100644 > --- a/lib/vhost/virtio_net.c > +++ b/lib/vhost/virtio_net.c > @@ -1153,7 +1153,7 @@ mbuf_to_desc(struct virtio_net *dev, struct > vhost_virtqueue *vq, > struct virtio_net_hdr_mrg_rxbuf tmp_hdr, *hdr =3D NULL; > struct vhost_async *async =3D vq->async; >=20 > - if (unlikely(m =3D=3D NULL)) > + if (unlikely(m =3D=3D NULL || nr_vec =3D=3D 0)) > return -1; >=20 > buf_addr =3D buf_vec[vec_idx].buf_addr; > @@ -2673,6 +2673,9 @@ desc_to_mbuf(struct virtio_net *dev, struct > vhost_virtqueue *vq, > struct vhost_async *async =3D vq->async; > struct async_inflight_info *pkts_info; >=20 > + if (unlikely(nr_vec =3D=3D 0)) > + return -1; > + > buf_addr =3D buf_vec[vec_idx].buf_addr; > buf_iova =3D buf_vec[vec_idx].buf_iova; > buf_len =3D buf_vec[vec_idx].buf_len; > -- > 2.31.1