From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44BB4A057B; Wed, 19 Oct 2022 11:15:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 36983410D1; Wed, 19 Oct 2022 11:15:28 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 1E6A140A8B for ; Wed, 19 Oct 2022 11:15:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666170927; x=1697706927; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=G7FmY7zwGl3LnTzfEdQGaE+E4Xt23wBYXRLJb4c9nm4=; b=RvIaneDzD7G5bGlSRDPRwLwf82+lPIR8/zerdWr1hCpAWJ7z9Qtnqa6X Qps+0YVJWUCyxFPa88mp5znHB1M6LD5FkBQAcKc4RGc5vy0YxrwZlafMG 2RVvxan+yA8rrP03AasCsBf2cjk277Na9keUdIXt9WduuqcX8pmAQpfjO f3v4WiP6sIROcU0Y1XDck4vUBK4OHD/OZH8Y7ddv6WBsaxVpCTmB+4CNG IDKDb0moz7gz9SneydAcrhc6g+hnJ2QEc3DF8vS0oQ2bdo0QJEyv2VOSm 2OXaZLy34UGal9ejUXLGocBwLhbSYxYDp/DaHqLB6KKaRHKi1FDvkbNYo A==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="303972470" X-IronPort-AV: E=Sophos;i="5.95,195,1661842800"; d="scan'208";a="303972470" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 02:15:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="660253495" X-IronPort-AV: E=Sophos;i="5.95,195,1661842800"; d="scan'208";a="660253495" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP; 19 Oct 2022 02:15:07 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct 2022 02:15:06 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct 2022 02:15:06 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 19 Oct 2022 02:15:06 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 19 Oct 2022 02:15:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LRskMwmu8wZ4Z1d59M3ZZKnJPMDejgLOQBTOyLoOy4V2jA8xW3Q3wrS/8qEiYR6YKdCBHOVd5ez1LTYDD9pXJqKV3AOqcGmjSFmhn+kMP7Btgv/AAR2kI4UZbgFln0XwJuSL+LdotWQWH+mMnUwPa9uzz2TD40Wvpr1mWisafkoC9/cRyItk6a0IkW394wPyzecK6RgSTHiPDvMkhUOf0EKUTHTeYAoDX9qbMUkDivdJOldUUF2Eszd1TCrVyHNq4Ia9+Oo02TWroO1eQMAdH1el0ZqnAuSaLq9tuFYcAuLlqrxBC6YFCTlVXOLdCuVP4LV9PTGo/WoobvZt1kYNLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n+ZUkYVbrdIxCEukvs+eEQ1nJ+gMjLGi4WQmckInqzg=; b=X7hNuyjLlc6dl1wADSVVFnhiz+4KCIni0QK+NgzPcINI/rmqlxOWtz4lqskwbD2QKdib2rUKCuHO5Nq4WFhZHpZ6S5zmCiGTHtuQlho16MyB6W6XYKW7N5vYISNnKYkNWkHO+tUmBcD6GDA8Qqp4TLTO4LlRTep5OyqQt7U1Z+GbRTlzwjpyWQFPVj52RI1iHPcSkDZ3PQ3pM18xywYhcEySEhh48D70AFD9Jaa5B5VRw8GUVV6/BlzSgmjyw51VfXhDvg91ufJZbPk9FAI6Z8bqWp9TGZCApr31bbi2o84wv5kjLWCTwBwCQ7F1v3IklbhcaoapyNGlrwP7RofA2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by PH0PR11MB5808.namprd11.prod.outlook.com (2603:10b6:510:129::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Wed, 19 Oct 2022 09:15:04 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::39bf:57b1:4824:d40d]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::39bf:57b1:4824:d40d%6]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022 09:15:04 +0000 From: "Xia, Chenbo" To: "Pei, Andy" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v8 12/12] vhost: improve vDPA blk device configure condition Thread-Topic: [PATCH v8 12/12] vhost: improve vDPA blk device configure condition Thread-Index: AQHY4vFbZwNQQHkQNESA8w735R/+HK4VcJdw Date: Wed, 19 Oct 2022 09:15:04 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1666094871-25721-1-git-send-email-andy.pei@intel.com> <1666094871-25721-13-git-send-email-andy.pei@intel.com> In-Reply-To: <1666094871-25721-13-git-send-email-andy.pei@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|PH0PR11MB5808:EE_ x-ms-office365-filtering-correlation-id: bac39473-8392-4432-b260-08dab1b2689f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DVzb1k8samRkoR6A+VDRH94KopnwbH29BJVrRIz8+yzpmTRI6mopHQfKAcTNvgefrZmG2uGET0Ukhmj6GbIc9YYJKtBEytHYy6IrkfZN4WQgU5couWsK10NfMRO1Mu0VMLmigYqcb+hC4N80vYyHIXbuWOANiU2E/kR6u9wS8lzLOUTKDqnZje39Raet9fPQjoXwPqSn47mLAK8jWSF2K7vuJ7gix4YNIE33msZlLuJ0KodJyRkeWPC3TYjRFqzPXA49sbcYNAYvOi1Dpb5S61tg2idQ/6M2SJzIg5Z7nkTTAe99BGzLXVpH086/cCUev4r2mdv72X3IBfmbDtJT8xdz8UBD+7uaMuE8clKHTU7ImKvwT85f8j+MfYy/oIj19tDzQ4ULfxt4FhXmwF8WgkEX6/2TJ02l62aNJ2mMDeX/27/om6KPcoJs+D5UcyLkyeibFa0EDMmWLwiA65e2w99+fva55zEggY14YvHnQ7qhsBfRRE+/DiPC18hDuc/OuknKs9MdMAWuhak2GtT7hU2rAhzmcOTnXFHFcXGWk2NzReOtXD7xaznmfTBYJutV9M452Id7tPVYBAHc/tys/76kiX6eB9Mnn6xk03LBo+JUxnYYHQ96M5h/vaft26+QvZfwL9RDmOtuIitFCnCY4KVD6N96w0lAPxqdxK0+OQHeZ4wpZ6+dYkuehsghI3Yb/s97Vak8WXrQ34JHsnVgAh4uqOuL37vSsQZ5kAU4RqyHfn4b9NbZSbHMl6/R/8bngaTuQ0GLXo5BhqS6CfsZWw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(346002)(136003)(39860400002)(366004)(396003)(451199015)(110136005)(54906003)(9686003)(316002)(478600001)(66946007)(64756008)(4326008)(66556008)(66476007)(8676002)(66446008)(71200400001)(76116006)(26005)(41300700001)(7696005)(52536014)(53546011)(5660300002)(8936002)(33656002)(186003)(2906002)(83380400001)(6506007)(55016003)(38070700005)(82960400001)(38100700002)(86362001)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?l0e4S3kzPk5m5tJplaZRGVjR8/yax57ov6nGTZgzxjly+75EB1bdZaMXaiNO?= =?us-ascii?Q?z1rFD23NM6N3s7Jwv3OvTHiPJ9M/ZRIFY/0dyMW9E/PJA4mtROKbs1tsl/IL?= =?us-ascii?Q?hmQyE3XoE6x6w8sL1Vs7i8ePzSSaMeHg1sxjtW2HfGKlbUNcvG+gs5aJmdqc?= =?us-ascii?Q?9Ew0gnJMNp03lBfxBUQOTq8RRjbuE2OqmNwPKVo0mLKl4sbbzD0NbpF3lrpP?= =?us-ascii?Q?MERXoTppVPqLg49p9BkAWY0eW2CeFsln8Uv/ZZSDf+FlgADN+DVUa4HF5PVs?= =?us-ascii?Q?Cn410VplSSwO+LO2aUA06IhbGACLRqzGw+QoZOSXAUlb8k9o2qRux8HOFBs/?= =?us-ascii?Q?KspFQSFfSBZXX3/vmsPfL4iPpQTo9X5ILNVRfI8Gd/iSWFPJ4RNOHSIjAkd0?= =?us-ascii?Q?0ehbujV4uyJ5mX7M60SjT5Hwxrdzdm/tavTHkOjblh/7dFbK0zIVoBaBXkPC?= =?us-ascii?Q?she5aE+0nv8lX71DgwHG3KP0ahrsAwdXcvwtGG9m69Wlgf51XMBdY+QYzopz?= =?us-ascii?Q?hgHhWrLgWUJmuZGfdPWylRw24EnwMHtbMeqyg+PJCYLoCGJ5axHLQCyUqWou?= =?us-ascii?Q?Louqb0GP4GzC0aZfwlO40v0taNY7G/Vu9WjBvrkKrF/LYK8TOp+V95twUJzK?= =?us-ascii?Q?MffvumIcDux8GTvDmcJQWi1Pu49SyrLmr5nBWYBvLRiOuoKhUVReuNo7AfS3?= =?us-ascii?Q?fa1OtqQltjAnmMSB8+cTd81JmLh/5jrqN51TQUFaETRW9R2/HKcsUg/v6Z24?= =?us-ascii?Q?StfDhVEFsxJ32/tan0mpoWzR50NNYoYCkSutZHnrylEIbdMtIh6hXJoZfgW/?= =?us-ascii?Q?COakMBnIJq9fGdYt1OxP/BwhNT1hFRjOctvhNWps8BDA5KNdMeb0lnmcT54A?= =?us-ascii?Q?oqCUpaqVLzcvIfUD19xeO/g8QnXoDLUKxhI6oVQglV7xaM7oPW6GwOBtmX/z?= =?us-ascii?Q?yVFTVQ56vh2NB/uazs0WlgHX3QxoetcmYuOlHhA0OOEnWrTVScIwV3ebaw2T?= =?us-ascii?Q?ZLKB8O+/Q+fLQdeYC8gR8mgDWg17X9nLj0LFTKP526N1L3WqWcBiZTlxatBJ?= =?us-ascii?Q?mL19VWxaGaKW1uiiC2+ToR9J4ecAKy57nrN45keTVkXnRP9bPIzzLl8H8VvI?= =?us-ascii?Q?J7tiAR84GfBKn/Jf8a2uoa2VhjM1zYoqj6zKS+PoDr+QNcH0liDkNGJX8gMO?= =?us-ascii?Q?fn6gwJQmBTobMDWuy6vMTtcnoeCMjLCbJTkv1/rjhj65s6iDdKdPIKyf9jH5?= =?us-ascii?Q?qBhkjMoErEl9edNn+MkLUJyeT1xJ/4e1hEzP7AAOJDY3D4jFLugIGB6v8tzn?= =?us-ascii?Q?YtxmZQ6ZsPuID0Ips2crkiRRxPq6yAOyl22I8Io1nyE7yS1UniT/d4HRw6Tk?= =?us-ascii?Q?O6/T5V0qBixmtWK8QyEqjbkXPlFbCBstSB4hp26Pf1R79drOBVyXwgvVf3yo?= =?us-ascii?Q?+coyy6s2lJ/HMJMoIAak9WSrf7TxHD3aP136ASmNqafh0bcAKZCYdkKi2OtL?= =?us-ascii?Q?CAslSZIK2mlXoQoZTHApuQLber03tY8Gp5OsFe4F08Wx1R6ZMiB++ao2GEf5?= =?us-ascii?Q?Tp3AelCPy6jjZBp1sseQbieK3LD2F+hzBcdQVFIC?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bac39473-8392-4432-b260-08dab1b2689f X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2022 09:15:04.3469 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZqeF3jGxVNZYJDn6euV6TUwDHM4pbr7q9ejDhimA5VpkKzFOhQRecwqj6u5GPPPUFH+3XM6ZWqMcIyGRTxQ4ZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5808 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Pei, Andy > Sent: Tuesday, October 18, 2022 8:08 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coquelin@redhat.com > Subject: [PATCH v8 12/12] vhost: improve vDPA blk device configure > condition >=20 > To support multi-queue, configure device > after call fd of all queues are set. >=20 > Signed-off-by: Andy Pei > Signed-off-by: Huang Wei > --- > lib/vhost/vhost_user.c | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) >=20 > diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c > index e0ff79d..9902ae9 100644 > --- a/lib/vhost/vhost_user.c > +++ b/lib/vhost/vhost_user.c > @@ -2972,6 +2972,7 @@ static int is_vring_iotlb(struct virtio_net *dev, > bool handled; > uint32_t request; > uint32_t i; > + uint16_t blk_call_fd; >=20 > dev =3D get_device(vid); > if (dev =3D=3D NULL) > @@ -3181,9 +3182,15 @@ static int is_vring_iotlb(struct virtio_net *dev, > if (!vdpa_dev) > goto out; >=20 > - if (vdpa_dev->type =3D=3D RTE_VHOST_VDPA_DEVICE_TYPE_BLK > - && request !=3D VHOST_USER_SET_VRING_CALL) > - goto out; > + if (vdpa_dev->type =3D=3D RTE_VHOST_VDPA_DEVICE_TYPE_BLK) { > + if (request =3D=3D VHOST_USER_SET_VRING_CALL) { > + blk_call_fd =3D ctx.msg.payload.u64 & > VHOST_USER_VRING_IDX_MASK; > + if (blk_call_fd !=3D dev->nr_vring - 1) > + goto out; > + } else { > + goto out; > + } > + } >=20 > if (!(dev->flags & VIRTIO_DEV_VDPA_CONFIGURED)) { > if (vdpa_dev->ops->dev_conf(dev->vid)) > -- > 1.8.3.1 Reviewed-by: Chenbo Xia