From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA260A0540; Thu, 7 Jul 2022 11:51:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 70A1140A7B; Thu, 7 Jul 2022 11:51:38 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id C7090406B4 for ; Thu, 7 Jul 2022 11:51:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657187496; x=1688723496; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=/QqdXJRPSUflGkXvjqQzbXBtSNALLbDqX7hHrUleRA8=; b=TlBI7k/TOT+AfCljHuGLu0n5lkujVQq5SIwpKv//anpG7vBJXyErrCnQ 9u9AIaS3ER2JCB/BFW25rk1cfqUSfXeFYl4rYeV1VwpRJiUx2vSXxQa34 pjLzrsJ2P5XPvHt1YhoEQS8YQ0yvTBc9j7OcDwP4/voYzusHMH9iqNNty SPLw0+r3iZkhSgFxYDLbzGoDSteZm0N4tGKEsLprOqhuiYVR5kXnrPdmM kxq0/c9U+teDwGcgsG789DbJkL2y426y7CkNhCAoPhGgOHSdVEEZGX8jF nIuxinpkPF8HcuWVY631lpMrdFkSEve1BGUtl/ARw+AXyJKIagIsNQhta Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10400"; a="272776033" X-IronPort-AV: E=Sophos;i="5.92,252,1650956400"; d="scan'208";a="272776033" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2022 02:51:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,252,1650956400"; d="scan'208";a="920526607" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 07 Jul 2022 02:51:35 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 7 Jul 2022 02:51:35 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 7 Jul 2022 02:51:35 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 7 Jul 2022 02:51:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TQhEQB3AMCb2I3Gi1lS0qZtmcaE4yacI60dHcPEbQIK4yfO513lKsNfzRmblyZ1wCdOO5yoF/wJ8b88mlG0CcCGleVeIgtm0BSFvnZFbcdD35tdGQEYwjytuyOHbohSDRpw+r252eYbNzzooU3+SnPEqO7z27/ciq9oVek5OCQH1jn0j37/DkWBX5P/xiDrGJQMczJnYMRmmCVvwSUCqi56Qqj6Rcewbzv1Zr6mdylzvG1imdBq7V9CqYgiQRuK+YqpXo4vjq3EvIei8oTCPil3tRWV5a4kK8q15QAx9DT3X+zCOHd/OyDdcIRNnH7WIXxwfvwxu0ZgulkIfvfPkRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/QqdXJRPSUflGkXvjqQzbXBtSNALLbDqX7hHrUleRA8=; b=mjnfxZlpI0KRz+o5B55h9SwcWcYeWtld2rWcX0R+aTsqestpwRYfJNrxdwcbatFPfdq8N54oBA6yo2H10tVfk3kbGKcevqYMV8YemVuRmeauxnPcqooEusuHi+IpMSMeHGad1XN8ZiGjm6iL85s5lEIIkWbdNbSdKn9cpNMsDPtfO+7paV1779c55eCrL4j/o0iazqINcoEbwM9zDeWR2Uklmd8BXRENTl3DMkFBv1YhfdGMAhodTsqlBals7gRzWanIOHWDM1GytkYlcH40+CWc6WT/sxW21pxm7B/05s/yAI/Oh68EZ8CPLbC+BNq5fZ3Azmfl7z4csNcLhV686w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by MN2PR11MB4269.namprd11.prod.outlook.com (2603:10b6:208:190::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.17; Thu, 7 Jul 2022 09:51:33 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::54a0:2dbc:18b7:2aa9]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::54a0:2dbc:18b7:2aa9%7]) with mapi id 15.20.5417.016; Thu, 7 Jul 2022 09:51:33 +0000 From: "Xia, Chenbo" To: "Ding, Xuan" , "maxime.coquelin@redhat.com" CC: "dev@dpdk.org" , "Hu, Jiayu" , "He, Xingguang" , "Yang, YvonneX" , "Jiang, Cheng1" Subject: RE: [PATCH] vhost: fix unnecessary dirty page logging Thread-Topic: [PATCH] vhost: fix unnecessary dirty page logging Thread-Index: AQHYkc7BBe+kb0BPKUK5yMn5TEBNPa1yqZNg Date: Thu, 7 Jul 2022 09:51:32 +0000 Message-ID: References: <20220707065513.66458-1-xuan.ding@intel.com> In-Reply-To: <20220707065513.66458-1-xuan.ding@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 87769d73-1591-4f5d-3d78-08da5ffe4624 x-ms-traffictypediagnostic: MN2PR11MB4269:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: scVDcNcmyFMRceNBJqYJ74SSN3oVxsIJj7TDcd5xTIGyPYLN5CkbP7QiLB/LyJStELKa+4M/jxyDIPrL+cjco3XxL2FNi7No6RYJwJRtAy4mlyEI3/zE/vd+21FMEA/vfVdEaAtrb8ExJXCWmYGk7YTnNgFWQmFDs9aQNv42rVRtRP8DHZ1Orxlk/uXG/oJwnpVODLOA9W9erMlGdgKCR909JL94FSURRIWI0qwjW7eQyxwLzopNltAMJUmoQKaMrVp9r7i1QD+ZcNOxAsV23XU0xfD5otwKLHHNyK17jflGWxLnYOSKEtDvO+W73tDKK/EEqGC4ajAFH6A4Mn3nzYeSTBYthGJKb7jfXSfiPnkWgHoYO1N2u6TAVI4HR5fwKIQ0LeEYC1U1IX8ikPOMk6Vr9coAl/D2b27BWMGG1BpWx/0vAgv3dkssdXxooH/w31Jkfg5X/+Gc74e1mr421MuXQyvvXwP7oY2UrZVTP/0MEjA6eXzKsFXytdVmpKvwsIJUNrFgaclYnKXdlXru1gunASmzMtnDL4HhhO6DvUnbufuIkA+QEa6b6I0qTXVbB5D+Oe6hxdMN03DHWdeql4r5KtwnCkUwtFDMF6hUx753GIV7qA86PUuE2GNNV1pf5a+re0lmTSaDC1GUalVX1Iz3irRIRhhPYmtNLv4i6r4qYpE8P9rUii8n61VMXeG7ShUSPfq469YYOSs7c4ECSmZzjYnB4oEZfptPsfOtS92QO7jCPqdjjtHeW/4oEWNOndidKUZ5oYIcqdiqhaSRNR88HIDjheA7TGXfkmIvNOEghjNaiH9eQZmszatUdzStqHjl5U2doN1PcsBZ5nH7427OBxsSNdYuORog4ny6PI46M5QWZb9vgohFQe38CIzF x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(346002)(366004)(136003)(39860400002)(396003)(41300700001)(316002)(54906003)(110136005)(2906002)(45080400002)(186003)(38100700002)(64756008)(66446008)(55016003)(66476007)(82960400001)(5660300002)(8936002)(33656002)(8676002)(478600001)(26005)(83380400001)(52536014)(4326008)(9686003)(122000001)(53546011)(966005)(7696005)(71200400001)(107886003)(86362001)(6506007)(38070700005)(66556008)(76116006)(66946007)(14143004); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+hrZkMupu/h3bjsfI24rEjJQRCyHVrTiEtj63CsuOIPWOjAnrQ4b/73LMI9c?= =?us-ascii?Q?IrljD4KfNz/8bhE1ButjWb1T1Q23g3xPzuvPA07LTTOVLCKFXivEwdHR0bKt?= =?us-ascii?Q?ROHHlctOf9vjTS4inyQAZc5WQ91volVuKaVloyKv2ahfkTWxg3ttGX41624R?= =?us-ascii?Q?bswKbe6YzZzk9o/t2CkcXv/Ij5e8WBgIAeRORVchoSTqsB/vytnwBj66UT1o?= =?us-ascii?Q?EjKFZbNvaY8s1j73X36u96Fr+kNE74Mq2IouVHQGx6Gvijgxe3STDQ2Q/uC+?= =?us-ascii?Q?BXNm1AQP0gkHZdx4fXMh+pxZHP6A4mv0o23eWkRV6uVjUQjxxV/cNpM1ncnJ?= =?us-ascii?Q?co9eUANcXveWd6ldx7ZisaKE5shjFd7QQpW+1vznhLKNzxd7w3pTSVO0yOnC?= =?us-ascii?Q?5P1BDknqvmNiRFyrIApLqQniuKAmUubqArw0SvIarXGlVIgRhbiNaMP7sdJL?= =?us-ascii?Q?kjssiprOYEBGeG9RfBtAtc9kdZjC10DRIElna+cqfR+yt4igsdnryzN34a8Z?= =?us-ascii?Q?zqdxzJ7k2M85t2W0ivqQyp4ltgElDz0Kg7y7z081n5BClycl93gSFYnlaqZn?= =?us-ascii?Q?GXRudUPB930CtV0Ed/7ffS5oC9z9Skq/ThzaViN7vHJXPF3bcfro+ZiE0YqZ?= =?us-ascii?Q?FFXpEE8JsKvF9KwzIYnMwYskz6hObGnomXPpYiFuFHL4LFdewmMa6F+mG4QS?= =?us-ascii?Q?Wt/x/3u7l5q7BdipRBjQDDM4GTeLxE2tB2AbbnUzy5KPsP3+HrYzhWimvPfT?= =?us-ascii?Q?Anp5k16whQKVlb7+hvtqHIzVRSM9mNPef9NBvpVY1j5go8i8HLzne/uP/m1c?= =?us-ascii?Q?r75oHebmJw32AgF/otcdutaDhpNCecrGj7pY1rjdXK2Xa+zoAAnulldD2b7D?= =?us-ascii?Q?0YrdBO8B0oW+8QnDj+rJdYOs+swUJbkLxmJ8VlcCyG9x+7GQD2k87FbF7fQu?= =?us-ascii?Q?L7+MtaMo6LuD3qnyhyjajoC/6jpyKoptNoBjBVaFDqp//Dfwd0XcPdnLEJpm?= =?us-ascii?Q?3hOciL4VdBDBzavb2Q31DOmR/hF2LdogfHTI8pbIGsTYX4iFt9c/GYCktkR5?= =?us-ascii?Q?2erWSaKTqoJUhrDeV+9IYQ4Ki2QMI3gRWmfnVYG3BnkbnPG+dYym+2UMg+YQ?= =?us-ascii?Q?QLdkgJNAiC6lt+V30t0MnMIHQyF+lUDdmM6noAUxI/c1ev1Gw7HRn8hdzLJ8?= =?us-ascii?Q?Q7HtR9q5txGn/u+aLv4eX0DBrxzUb4l0vYhPJyn7f4D5etw2dUsVVkJxY/ga?= =?us-ascii?Q?2ujlCDLg9YRwFxeHJ9UrpPJqZ+x5DusScDWIFY7ZXT6hmOdUlDShD/Et9/UR?= =?us-ascii?Q?nIlliZ+WYe1R+S1vKXBj6A2+HTgjBwFKjKPSR8C1l+L6QAu7PkdPAfVTH45l?= =?us-ascii?Q?PTccQt21qt9Uj0tQ/P+oM2vsm4d4X8lTmjO00cQUKlYWebFnSv/iphdyuOqC?= =?us-ascii?Q?IHzwsEf0lAU6LPXjoda38dVCL8bWo0f2NO/TRstuEhALCT3lkbiPiYQAyTv8?= =?us-ascii?Q?zpbCdDHeuu76V+fPnsJ/Zv2wN1cNlRBM5oeNxMnoQbMLNzmo3x9T/ZWpd055?= =?us-ascii?Q?f2SWCQMeEZmZa6k99ITDT0LgIOhiG3oGSSWwrzge?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87769d73-1591-4f5d-3d78-08da5ffe4624 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2022 09:51:32.8989 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AxjcII95vrqjo4WSaz+bLimrWBkgaC8dE80wdXQdjR1tYGCR/tWgJ77kwgjZySNEqS5Cd9vJ/LoTA4GbQxdRCA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4269 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Ding, Xuan > Sent: Thursday, July 7, 2022 2:55 PM > To: maxime.coquelin@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; He, Xingguang > ; Yang, YvonneX ; Jiang, > Cheng1 ; Ding, Xuan > Subject: [PATCH] vhost: fix unnecessary dirty page logging >=20 > From: Xuan Ding >=20 > The dirty page logging is only required in vhost enqueue direction for > live migration. This patch removes the unnecessary dirty page logging > in vhost dequeue direction. Otherwise, it will result in a performance > drop. Some if-else judgements are also optimized to improve performance. >=20 > Fixes: 6d823bb302c7 ("vhost: prepare sync for descriptor to mbuf > refactoring") > Fixes: b6eee3e83402 ("vhost: fix sync dequeue offload") >=20 > Signed-off-by: Xuan Ding > --- Reviewed-by: Chenbo Xia Although it's late in release, we can consider to merge this as I see it im= pacts the performance by 5%: http://inbox.dpdk.org/dev/BYAPR11MB2711F13CDA2B0A4535A6591EFE839@BYAPR11MB2= 711.namprd11.prod.outlook.com/T/#t But also, it will be good to know the performance issue is solved by sharin= g the test results. Thanks, Chenbo