From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D72E0A0032; Fri, 24 Jun 2022 09:51:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5501427FF; Fri, 24 Jun 2022 09:51:22 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id B206F40A82; Fri, 24 Jun 2022 09:51:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656057082; x=1687593082; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=zvXsaDvI4X+EDDe0pEejxxdxkbK6x80nfFOWZx1wSlw=; b=aXhpRFoHujjPJEcAuK4WLI0BSlHfUZ4WRF/Y8B6k6R9hjnKU3r6iLyYb oEif5j332eH3U4WGlBi5V9X0uO+w/XejWbdbJ26E+S0j2FKWbVkCGWjcD 5uTiAoTaBI2czJghYw1psCamNDNmp/sPap1svWcwNVBHUJaKu+OCI3DtM bBmpQ+8mqv33kAF1dX3vSXFBhIOa3WTvW0WFGB2aFVx58m678igfKR+Kl l5OrpOJbMVMW3Hcmf4hteWVVl1dHwG0pSv4GEXi8HRVkd65XFiLy/oeaI KOXKxICSdUnEG+nauX5QainyBmWYjjWPeiVC/cq0Lm+HMzFPEjx4jIZyz w==; X-IronPort-AV: E=McAfee;i="6400,9594,10387"; a="261373803" X-IronPort-AV: E=Sophos;i="5.92,218,1650956400"; d="scan'208";a="261373803" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2022 00:51:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,218,1650956400"; d="scan'208";a="678441239" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by FMSMGA003.fm.intel.com with ESMTP; 24 Jun 2022 00:51:20 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 24 Jun 2022 00:51:20 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 24 Jun 2022 00:51:20 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 24 Jun 2022 00:51:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IsLwD0K+xR4LUnLbJ6O3bEbKc9/jj/XgEKZmwdwr36nWB9ueF9nEOx9AS3H/eCwcUH3u+21Qw6yIlRU8Sbozqs3zwYT6fzN4gHQ+kJd1O9rbflqIxEhYRahd8Vo4szQLdAFECjWJdxcQHIMGWf4uGqlQmfluh+7URrlmYHAecAxNYr06Dk9eDyJ0DvlJel5abEZCzoiDMUr8Fl84VvQP35oCBsccA536HLFdkD3EA8RY/HPrdzaKTHse+6zfud1+rvfxY4m8D5YLnE8a28yHrvt/NTrT4rbVaQHEu/ErJ0o4eB01X3wJVwf1iJzGVrV2VuDlgA+N9CTipWtoQXsphA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z/vuDH6CtSe2HP7M5pGHWL+5ESJz9b0JHiTlOwCIBhU=; b=CFLJ9moOtGNrsfoZjHwQwxZmUIRNk+PwUT0ul09Da8UR/YzRwbIqj4xyFIQcky4AXT4l/YJoij4h3Bb5qciOfoQKSoA5LgzjsIL7bq7/4swrQA5rlrGEZ5ie0tPKdxoSMTAMRwoaSh8m2+KM/jarmTYT05cpq1/XG/Du5dYpkNklkb+ZdiRJC3K7EuBMSVhmnreVbSM1SwSPp+e2y5HUs0M98WUiSaJKLwHKRms/vGWokC+fWvVqGJX7XwSOIRr+/3YwVhMTcxXwekJKZJHC9OuUeqmaqVRmSQrCliYnsFmQVmB+iA0vHlXefYALiIR4KbGLFLtsd4CYAYfTf58InQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by BN7PR11MB2609.namprd11.prod.outlook.com (2603:10b6:406:b1::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.18; Fri, 24 Jun 2022 07:51:18 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::54a0:2dbc:18b7:2aa9]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::54a0:2dbc:18b7:2aa9%7]) with mapi id 15.20.5353.023; Fri, 24 Jun 2022 07:51:17 +0000 From: "Xia, Chenbo" To: "Lipiec, Herakliusz" , "maxime.coquelin@redhat.com" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH v2] doc/prog_guide: fix readability in lib vhost prog guide Thread-Topic: [PATCH v2] doc/prog_guide: fix readability in lib vhost prog guide Thread-Index: AQHYhwiS5D+Ki7ROY0usS+dx+hUtA61eMBUQ Date: Fri, 24 Jun 2022 07:51:17 +0000 Message-ID: References: <20220527173120.30050-1-herakliusz.lipiec@intel.com> <20220623135721.1779466-1-herakliusz.lipiec@intel.com> In-Reply-To: <20220623135721.1779466-1-herakliusz.lipiec@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b5f38c49-5bdf-4d04-000c-08da55b65248 x-ms-traffictypediagnostic: BN7PR11MB2609:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GakgTE4c5dsxrXNUiIRpfQ6Xit1/ULW8ACYrUkGM3VaKdn3mtsM18Jc8YbG8CeuZgvxQwzuAU0WP3i6fke+8mnwgxxqvvjhmjnVnW9Te7mGjgRsUnoyteAy4ygKPC1RbqfNgIumSek2js90CKs75vQXepvlh7AIDmuZzjjt5yBztHFv+86WDnpax1tppMm7HJZ/67fAciJ0xa0xEozPd4ce/N6dgEnpM/v8M/AGvgHnssJelTyCMg8nuI9j9eOyPESn/fZ9DSIxrdG4qegKF62743sGsC2znibBmpXbc0tgWPhD2Tam0+nN27vVWGleUTkFh51/CdcNw15q7bEe7MPVVI9gvWfvLaJvcjoKv3Hjc1fQYltKzwr2zzgPDpbSUh+md0Wsjhr8Qcd+PPaXjCbZ+scUgOm9eumUw28J2fI2dnF8PPO4Lys/p1WB0dZWYSZdSSp6gPW6FINDZikzlX/SWvP1kI/DVnOmwEBpDsElozRKnRnUFZz4kxGk3Zk3bWiFedilM47jU7I/9dtJZ40DeAO7jAFg6cUmLe8StRNs8VDMirDtunSv1OKDNjc1Wd1Ow0PAmupOSXKqpqtyOMg3URPxeqVAyZuagMm7/XEAfhe3gX0QvGk9Qw05kdp6SSnSBw39PBsZcIqJpTQx4NL02B5zjrXvbVzY/q6PI8mNGuIPomWYO7EMrbZmU5VBqJLi/0u6lpm+gHt4FYJIW4xdn/toAH6Bd4HKWEcAEGXlPAA/iVxaF6Ahuv7XlotNTKaFyIQA0UVOHDcBPMjieJT6Refo27ZmAf3n/6ZjBzGw= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(346002)(366004)(396003)(376002)(136003)(478600001)(41300700001)(7696005)(26005)(6506007)(9686003)(186003)(83380400001)(53546011)(122000001)(2906002)(76116006)(8676002)(5660300002)(55016003)(38070700005)(86362001)(54906003)(110136005)(52536014)(316002)(8936002)(66446008)(33656002)(38100700002)(66556008)(66476007)(64756008)(82960400001)(4326008)(71200400001)(66946007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1kecT2nbjUviJe4lZmhxYBcpQ8jeTFDvZKhXLdg5krsQ2vkPic71D/DnOHMt?= =?us-ascii?Q?JDydOvseqpVsIHuwHzTy4FxLUgDTPFF7VeDmWpZJoda+4w2tSo5bukqeWMeq?= =?us-ascii?Q?93sUTpFwWf3niuuKKwbxEmz8Yq8Sjq+ZANhDgYVl3/u2BLKnN3+m8dq6/Gq5?= =?us-ascii?Q?6CwyqabD9EgMRd9zurOqmJqmMmq+hHibNciyDlMSX8GlMTNnevgH7Ul/QP2Q?= =?us-ascii?Q?lMN0iQfJbeAdM61TclbfBfHGAvA/IC4SGnbotJKYf1cC11n9jffNmHVsWm9A?= =?us-ascii?Q?y57Q2567Wpl5hz7TyuQZzlvCQHisBg2AJCErByHvV8JIgqrLxI2Qq6dueiaf?= =?us-ascii?Q?4TDE5svSc/ubvCW3Ml3pMeq0oPC6MJyYeutjBGKUWWgJ40N54i1SEqQ+uQuB?= =?us-ascii?Q?SP70PcJcZpd6hGVqZND9U5qa0m2ZwaN4Bu+aAMrGrT2kYId2RL0D7pPfTM+D?= =?us-ascii?Q?26bpaNYBbjFDwxwUyu7etVOZ15sF43dJHC+MKbVB9l4zkZ3n3P+/GB+NCupx?= =?us-ascii?Q?AP1jH9JKNeU9LyYTRYiJCV5hNTl0N0AXCqiQMsMWgw63vRoPUzeTFRkOm4B3?= =?us-ascii?Q?kCcsdnVeRIppWimYSfVBC13131TmUeXWs6BcfijKsXFVHKm9n9YqpBC56v4u?= =?us-ascii?Q?MlX3fpqcDcIfZiws3I8HQjLvyHZC+1gWmneDB5EBAu3LRxEQlk2LvMyfxz8z?= =?us-ascii?Q?fznqOZ2VDMGygVmt85SSBaB922d7jCqrBUGiF1XhUtjj8jXAs71kcA8sgLF3?= =?us-ascii?Q?Wo2sb08ZWdCsZavoCrIdD/f8hmB/XfDGARxDqK9WQSkkJy+ht+gM2PdsONby?= =?us-ascii?Q?8pTMB9Zwm8t1QnzvldyUXQ33EWCahUioFydU6O6N5GmteAgt0cegMB1gUrED?= =?us-ascii?Q?4CJo5vSrDINGuSmKWOqMeUgTBowUIlAmVKKjYig9N+5e04kY3iXG1t8av8i/?= =?us-ascii?Q?BRtmGGabICpgdmtfQACiSpHOoZ5MftVFItPSreCledvxPxVV1I6IIxnMdlsW?= =?us-ascii?Q?k0rgoR3oh1D1U8jmcFEuXmE9OXHScQC3iqQSZylkygD+SYnhRY52ELkFb+qA?= =?us-ascii?Q?T3VH9e8tPxlJHkfXn9LHElPSBHN4xsbxsArwbJFt4ybLbYksFhCyJqeHndhU?= =?us-ascii?Q?fK8rR57t/V9fpfyxq3sfGs6VVtTto3CYTIuNUQt/tYHBR7h0R8DBruxsI7dF?= =?us-ascii?Q?LW/40OHtNFqt8UNjGlmJDSv4xj8wYHJcKd3YUNVVYYVF8Bj3AH84VDBCJIET?= =?us-ascii?Q?4+hWM25bdF2dA4OvCjJZm2oF2pWvKhD3nbZUkzcoobNM61I6Qr/yCPNDZl5f?= =?us-ascii?Q?HTv4k5uTUdnqspSF1TXA3MB907hJYGCLmLTFlFcIfvF/Ey1plHTmi9Il8ziH?= =?us-ascii?Q?cjJewb5pVsMnIVNTg1PKHfonYR4bb4sbEOGGLA90QBkKepEGbhJ9QlJKu6/f?= =?us-ascii?Q?9Ik2kZTftP8GAipoDgFyWdzwKLS77Ju1CQPMRPtXNrBe5389rlCLBWcQHpn9?= =?us-ascii?Q?jATUCPPlTqQy+swm7HGS9l05WSfUzce6m4+33UsjiD3l1V9BtEhQZFntejRC?= =?us-ascii?Q?kMlOogJs8zQWtx6yWeefqlWpqNo4quvGhx3XA3nx?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5f38c49-5bdf-4d04-000c-08da55b65248 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jun 2022 07:51:17.9049 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RBmj0qQcNPt/0DBnv7oBKIluUJ1bjSP04ZXXykO6eOMv3VEBBCzMxoo78u8U1ZGQXmPttj8kG8v5z+BXDNE3Dw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2609 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Lipiec, Herakliusz > Sent: Thursday, June 23, 2022 9:57 PM > To: maxime.coquelin@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Lipiec, Herakliusz ; > stable@dpdk.org > Subject: [PATCH v2] doc/prog_guide: fix readability in lib vhost prog > guide >=20 > fix grammar issues and readbility in vhost library programmer guide >=20 > Fixes: 768274ebbd5e ("vhost: avoid populate guest memory") > Cc: stable@dpdk.org >=20 > Signed-off-by: Herakliusz Lipiec > --- > doc/guides/prog_guide/vhost_lib.rst | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) >=20 > diff --git a/doc/guides/prog_guide/vhost_lib.rst > b/doc/guides/prog_guide/vhost_lib.rst > index 606edee940..4675347ee5 100644 > --- a/doc/guides/prog_guide/vhost_lib.rst > +++ b/doc/guides/prog_guide/vhost_lib.rst > @@ -351,7 +351,7 @@ vhost-user implementation has two options: >=20 > * The vhost supported features must be exactly the same before and > after the restart. For example, if TSO is disabled and then > enabled, > - nothing will work and issues undefined might happen. > + nothing will work and undefined issues might happen. >=20 > No matter which mode is used, once a connection is established, DPDK > vhost-user will start receiving and processing vhost messages from QEMU. > @@ -382,12 +382,12 @@ Guest memory requirement >=20 > * Memory pre-allocation >=20 > - For non-async data path, guest memory pre-allocation is not a > - must. This can help save of memory. If users really want the guest > memory > - to be pre-allocated (e.g., for performance reason), we can add option > - ``-mem-prealloc`` when starting QEMU. Or, we can lock all memory at > vhost > - side which will force memory to be allocated when mmap at vhost side; > - option --mlockall in ovs-dpdk is an example in hand. > + For non-async data path guest memory pre-allocation is not a > + must but can help save memory. To do this we can add option > + ``-mem-prealloc`` when starting QEMU, or we can lock all memory at > vhost > + side which will force memory to be allocated when it calls mmap > + (option --mlockall in ovs-dpdk is an example in hand). > + >=20 > For async data path, we force the VM memory to be pre-allocated at > vhost > lib when mapping the guest memory; and also we need to lock the memory > to > @@ -395,8 +395,8 @@ Guest memory requirement >=20 > * Memory sharing >=20 > - Make sure ``share=3Don`` QEMU option is given. vhost-user will not wor= k > with > - a QEMU version without shared memory mapping. > + Make sure ``share=3Don`` QEMU option is given. The vhost-user will not > work with > + a QEMU instance without shared memory mapping. >=20 > Vhost supported vSwitch reference > --------------------------------- > -- > 2.36.1 Reviewed-by: Chenbo Xia