From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD474A0556; Mon, 17 Oct 2022 08:24:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C02B44069C; Mon, 17 Oct 2022 08:24:30 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 575BF400D7 for ; Mon, 17 Oct 2022 08:24:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665987869; x=1697523869; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=/D1RQMzMFQIUST/244q9kVYKGmYaslOZtOPLAmRFkUU=; b=NjzxXSHr9103twSpIjIdZoV5YWeTsW9EoO3aZjdE6ZDUnR6UGzcHo8sM EEFcDJ30UrHCweAJW4N/Eze0pv5GKgpmbEupeoMemd0ph4ILdGslfkyiA +5Cb1rnDhG/zLNBHO61t7/MqVU7b7tsTg/6pqyXgwLJIpqD0AxoIfZO38 gbTmhx79zaZhMnoeqbVPoJ+qIpvQsRQ1nqDhGsbCUYp4dUrJL0LIR1RTJ VV451y0Y6eY1TOHDHIscmGtbfpG/8Bwust2r8uKsVScTJXn296PVex9lF OmyZpeOjkM3SDWB91mlQZn/D/8m95gNyHb+71VsJALoIOeBIhyKwyZAJO A==; X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="289007590" X-IronPort-AV: E=Sophos;i="5.95,190,1661842800"; d="scan'208";a="289007590" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2022 23:24:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="659239224" X-IronPort-AV: E=Sophos;i="5.95,190,1661842800"; d="scan'208";a="659239224" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga008.jf.intel.com with ESMTP; 16 Oct 2022 23:24:28 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 16 Oct 2022 23:24:28 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Sun, 16 Oct 2022 23:24:28 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Sun, 16 Oct 2022 23:24:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OLwI5f7JFYpcJMZtt9RgmStG5cL85ode6xVfna5pzuM25oT3OLvjMP3VRAcpk785efBKHtHJ4x9dLJtJ5rnPZGqjdDuZZ6oixEtH6KVru0dnL1U8ARiyKtcWT3I4bZi1rBsN5tys3Ze0d8zFIXzayYPgNSWuiJQQoxYVrwbhEqNrW0FfRd9SlLxdmDxGyxdOc99Gt08HGpGN7igoKfPGlfj0qd/6L6LgIrVkr+Ix1t6gXKnU2b+x6MQ0U1E8MhuTqwAVNLPhBeQzl5he2QUKQrw4q76zfMD4oGzWYpHeKFx6KPh9Bpmc7NhyXh/HX7POJLghRVZTlldPODlD8qhrYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/uV61igbf0larh6foP5MnJRYy1t1iofIJe2Ag6v9ozI=; b=iZ0GgpxPpDZNKl3B0xEeglQ5Ky+5OvEVsCWPZE/h6/XW1TNHSijOr5GgKUnPxq+ldu278kKZAB1TrUr51BsEMxddmB5UBSabOee9UdU+ir7zzTAi5HxNNfPLAnGYE0dnkSYU8KuXODfZoaEvy6QShZgnLZ3oRXZ26YIVoIUhoDPbZkHBmAWZIfEuNIT8jIKZ7CNrp+NLzRn/4UVVQAMY/vxsC6OOKPB06N4AaxbJ3e2tQRbl8QW2FzVyQdo0EC3wTrNBAG5epc+IZ9+bAu0kE11KYBNmu0D2rfe9eBl2ginZtRpAaQqN0Wcoin9NvAzNNqZRrQKJMG2noNY87qIrrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by PH0PR11MB4935.namprd11.prod.outlook.com (2603:10b6:510:35::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Mon, 17 Oct 2022 06:24:25 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::39bf:57b1:4824:d40d]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::39bf:57b1:4824:d40d%6]) with mapi id 15.20.5723.030; Mon, 17 Oct 2022 06:24:25 +0000 From: "Xia, Chenbo" To: "Pei, Andy" , "dev@dpdk.org" CC: "Xu, Rosen" , "Huang, Wei" , "Cao, Gang" , "maxime.coquelin@redhat.com" Subject: RE: [PATCH v4 5/8] vdpa/ifc: only configure enabled queue Thread-Topic: [PATCH v4 5/8] vdpa/ifc: only configure enabled queue Thread-Index: AQHY3uCF1V6MUJszV0uRJgNvhp/5fa4SJGPw Date: Mon, 17 Oct 2022 06:24:25 +0000 Message-ID: References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1665650674-291949-1-git-send-email-andy.pei@intel.com> <1665650674-291949-6-git-send-email-andy.pei@intel.com> In-Reply-To: <1665650674-291949-6-git-send-email-andy.pei@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|PH0PR11MB4935:EE_ x-ms-office365-filtering-correlation-id: 77b7d267-9790-4786-d7f4-08dab0083cb6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: l+VTyhLLp6d0SamB1rPLIvzLtEwS4fuAwLjkiEWQMt6XWQ3WxNQFTbM0oLh7ZOR/gJlTVU6riMhEogS0rpTrUAXHSpw8PvI5JPQlXIxB9OmG5GUMZ8Eussc2wge2lUzESRs8qGWQvj1/C6lND6uBi4VQ6IwH1b4lNjGtPgVqgBWEEQzNgo9kdoushTWt3fDspB0AKzi68F2ixe1UN0/I64zW6yOTiaSD0BFh0Wu+bxPBHJ1xuO5AYgBUxvEGEH+JV2Br4/fycZ+oWZQDj0DDmoG5atQO4YSHGzbRHM8aeoqKNorVSLk4gnYYvywli18cCSwema8Jtt1FFQI/yfxPpFj2+eJbs0iss68ZnfJJz3ZZLCj1mR9vfmYHLdeo7kBHn+QISegS1Kl+J9F93y6m6z2P6nOqlyi8r/l7VAM8N0FcRlDNEInPDJDM4I+wD8BaPZOsGSYvJkcz5nGTW70lVxhyA4fGE9PNEp8PGGp1dcvkhb7jHHutv0lVRZdYavmkpwHylBkYfiIbmK1KJ/EHMSsrVDzvXnvY8IgmV9HyxgwRJfthHoPCDgwaZWotkt4/lzSSXi0FpAhQq3wsmKQ+kudOgkZJ4J9M5c4crWvdNiBfK3oIk/28z6r+DsNW7Etsi5Y52aDMXGYjm6JEbXUpTWxEMPp0gAv1u5GsFWqw+lU/dI4FYfIvIQmMDOK15Siw+CeR2qCuaTeTH24nFtzcQrxQuGVh8eXRUvQO96sAg8jtDsuRxwkRAzL5JJ25fuDhzr7PX+DQfZ58jOBDRrxeZQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(346002)(39860400002)(136003)(366004)(376002)(451199015)(33656002)(86362001)(38070700005)(122000001)(38100700002)(82960400001)(186003)(55016003)(2906002)(5660300002)(6506007)(7696005)(26005)(53546011)(9686003)(478600001)(83380400001)(316002)(71200400001)(110136005)(54906003)(76116006)(66446008)(64756008)(66946007)(66556008)(8676002)(4326008)(66476007)(41300700001)(52536014)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?v5iY52xpDFu8/jNvjqKJuEeStiLDxCw7nrLLKPi1OjGbqsstostu6TCtrc+Y?= =?us-ascii?Q?oCqXYlDNxNI0x7gIZ1civPdATEGXGG7LZSqiga2wxM4K7IhojXFWgxPNocy8?= =?us-ascii?Q?QcLc0rwYnE8KZYXEPuyQcx4AObV3CI0rloYbu6F0NvkO+lVERabQOoz0zMHf?= =?us-ascii?Q?OPJnR+b7fs0P3PG92TOgP1JpjfwGzSeQA8x4v0HB52SNp45uIh2BVRsZSpmu?= =?us-ascii?Q?dMar3LvvJjnZ8+TDv/o9De8Ir0wRyQCirxJmbBlQYHY37hBxV0VE+awFCQ64?= =?us-ascii?Q?7R4euOoQ/1RAam/4sdw1DE5NsYOu9WGPH0i0P+RcI2VvdsjEvSYsx7IxGelF?= =?us-ascii?Q?sk2YHJqGGEzj1PL8fLqn4mCrzR1o9heBD6BfGsyUMIjQROCcz1RKfhseTZjA?= =?us-ascii?Q?GTFHlVARo227+8mb7TK6WdzwlRt3GMg3XmZ7S1xNx2YTQhfAPHAs5lm0mvlk?= =?us-ascii?Q?aHHuuDdSRcDGgIg8xrutQ4S1DBcjAiYHOSWGo774xxELJMEMTH1+EkUd0P1k?= =?us-ascii?Q?lwViBcKaBxSjR7Iq84hiGg+aE8qbCgIZ+hGNLnmGqf0haGvo+SEf/eM9L/7s?= =?us-ascii?Q?9CIaQ23KP8Axp+CQC2VBvpouUYkCn1hn7B+k9mRI9bGt7EihWV/La3n4r6xK?= =?us-ascii?Q?8yB0cSfxZC5piyL3T1dQmOKa8boC+eEWUVjTY6TNooOCUEXkq03f60TpAQ1T?= =?us-ascii?Q?dUagA3SrZk+2nns8U5+Bc69CLl86XmC/oY+URgLJoADBgnrSTtrF1t2N4K4B?= =?us-ascii?Q?2FMS4hxbgeyxrYhO7nWu6MMpUtgk7LpgCoid2UkNUBRvOGoDPi+eDbxABh8R?= =?us-ascii?Q?cnVHs3I7AHMoB+vPXbX2ek+JzbyL7nkwwR1ygxYFMwpxCSLzB7vC5s8FuaB+?= =?us-ascii?Q?XSbDafvLoh6j7+pLCyMM30gTG7g5oyQpP/ar3Q/KvsP/dFO7n7H6Iey+7BK8?= =?us-ascii?Q?CQ+58Yc6ujaIBXDv58CZtZvkEMA8MeNXi2CKl9OtJA6nHmS/g3q+Nf8wNn7Z?= =?us-ascii?Q?+bnKCNEcAMbLvYo+sAZAEfrV3c+lAO4Lf9tRlf3ZPLHh0h7xtom21IAsbQsq?= =?us-ascii?Q?ijkieyylLqlDjo3MnXz+yzBJGWjC8/d309/ubOoiPsb/4Fr2AICilGlwn8Ju?= =?us-ascii?Q?1Lgru6MwpLLXFLa8rnhiumfkwXWusEZT4CrNFxXTknh2/H4nKBQQmbabb3DZ?= =?us-ascii?Q?tTjvdEWBM8KL2nszercaQS34LNrEV8lmSasJRKTNghxDTMoR5Z0gQ+Dwq8QS?= =?us-ascii?Q?0mGDWAP68lUwUWcxaTpfGKQANcq8fw6I5TAUuR4oUplgUWxXyo0QlOzZcIam?= =?us-ascii?Q?U2N+akgwnVlLK05OXMHsbwEL+F7PGCCunhNceNtguA/8Z/jy0Ga0Y+E+ubbD?= =?us-ascii?Q?8mEag9+krFmp6TNo2BsefE+3rlf9DaGNrbENEpnQNhzBjDn+NG/xaBToyc7k?= =?us-ascii?Q?uXQ99cJTRBT762RSdKSYDjQtTW+jKCBAgp4mRLzfxSa3Hr9iggqlNwtjRdPP?= =?us-ascii?Q?wQSL5bqnwL9auFJrwKZNHE1/mfmuVrX91LSi91JnxcNxfC/HGI960jdKFuo+?= =?us-ascii?Q?rvgIvCoWPzmWbxpnX2kmQCuMZfJhDrnp0pJ8GedH?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 77b7d267-9790-4786-d7f4-08dab0083cb6 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2022 06:24:25.0564 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Vur2mKmeyIgos1iTR0bk1fRLPz6jQinsuawofz2sogIxBJbOqopVz87gT2lpJgTXfZglN0ULZhyRI0nGM8i3/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4935 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Pei, Andy > Sent: Thursday, October 13, 2022 4:45 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coquelin@redhat.com > Subject: [PATCH v4 5/8] vdpa/ifc: only configure enabled queue >=20 > When configuring the hardware queue, we only configure queues which > have been enabled by vhost. >=20 > Signed-off-by: Andy Pei > Signed-off-by: Huang Wei > Reviewed-by: Chenbo Xia > --- > drivers/vdpa/ifc/base/ifcvf.c | 3 +++ > drivers/vdpa/ifc/ifcvf_vdpa.c | 16 ++++++++++++++-- > 2 files changed, 17 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.= c > index 60c7017..4d85911 100644 > --- a/drivers/vdpa/ifc/base/ifcvf.c > +++ b/drivers/vdpa/ifc/base/ifcvf.c > @@ -252,6 +252,9 @@ >=20 > ifcvf_enable_mq(hw); > for (i =3D 0; i < hw->nr_vring; i++) { > + if (!hw->vring[i].enable) > + continue; > + > IFCVF_WRITE_REG16(i, &cfg->queue_select); > io_write64_twopart(hw->vring[i].desc, &cfg->queue_desc_lo, > &cfg->queue_desc_hi); > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.= c > index 5a24204..0c3407a 100644 > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > @@ -284,6 +284,8 @@ struct rte_vdpa_dev_info { > rte_vhost_get_negotiated_features(vid, &hw->req_features); >=20 > for (i =3D 0; i < nr_vring; i++) { > + if (!hw->vring[i].enable) > + continue; > rte_vhost_get_vhost_vring(vid, i, &vq); > gpa =3D hva_to_gpa(vid, (uint64_t)(uintptr_t)vq.desc); > if (gpa =3D=3D 0) { > @@ -499,6 +501,8 @@ struct rte_vdpa_dev_info { >=20 > vring.kickfd =3D -1; > for (qid =3D 0; qid < q_num; qid++) { > + if (!hw->vring[qid].enable) > + continue; > ev.events =3D EPOLLIN | EPOLLPRI; > rte_vhost_get_vhost_vring(internal->vid, qid, &vring); > ev.data.u64 =3D qid | (uint64_t)vring.kickfd << 32; > @@ -1058,6 +1062,8 @@ struct rte_vdpa_dev_info { > struct rte_vdpa_device *vdev; > struct internal_list *list; > struct ifcvf_internal *internal; > + struct ifcvf_hw *hw; > + uint16_t i; >=20 > vdev =3D rte_vhost_get_vdpa_device(vid); > list =3D find_internal_resource_by_vdev(vdev); > @@ -1071,11 +1077,17 @@ struct rte_vdpa_dev_info { > rte_atomic32_set(&internal->dev_attached, 1); > update_datapath(internal); >=20 > - if (rte_vhost_host_notifier_ctrl(vid, RTE_VHOST_QUEUE_ALL, true) !=3D > 0) > - DRV_LOG(NOTICE, "vDPA (%s): software relay is used.", > + hw =3D &internal->hw; > + for (i =3D 0; i < hw->nr_vring; i++) { > + if (!hw->vring[i].enable) > + continue; > + if (rte_vhost_host_notifier_ctrl(vid, i, true) !=3D 0) > + DRV_LOG(NOTICE, "vDPA (%s): software relay is used.", > vdev->device->name); > + } >=20 > internal->configured =3D 1; > + DRV_LOG(INFO, "vDPA device %s is configured", vdev->device->name); > return 0; > } >=20 > -- > 1.8.3.1 Reviewed-by: Chenbo Xia