From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C451A0552; Wed, 29 Jun 2022 15:34:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E4AA400D7; Wed, 29 Jun 2022 15:34:49 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id D2DBF40042 for ; Wed, 29 Jun 2022 15:34:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656509688; x=1688045688; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=YAEcDIiTZXwAaSe1SGUl9Qd91C+Ccv4FGzBI0ScVdlE=; b=a6zCA9x/7sqEHwKREDyRo+9McyzFZrSe7RAf/TE0B6llrMUKWW8mAdvU Vgtens/y3s7MV51Ybd43k3QmHjIRCRFuujsFmRNSzCEjPsFtNHaV5G2d6 MF5OSdWvbFa/CSaeZbXU7JSEcXYIUtqN3NHBLx7tthJMgOHFIkK3+lLnE 2kgk3YXIWxhVtgAAfelsFkU1vXByfYz4OA0AA9kpT3yD6GNkRbESAf46q XZECtRx68jEL2NzGiHGevLr1TemqElMSiXtd3/oavUjHFSK+2nKU46U9w +rW1mpW7pxMwUokDgW7o1XCUjfpkV3LGm7c9tcrqMn8xxIEe1ol5AetM4 A==; X-IronPort-AV: E=McAfee;i="6400,9594,10392"; a="280793733" X-IronPort-AV: E=Sophos;i="5.92,231,1650956400"; d="scan'208";a="280793733" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2022 06:34:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,231,1650956400"; d="scan'208";a="693579549" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga002.fm.intel.com with ESMTP; 29 Jun 2022 06:34:46 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 29 Jun 2022 06:34:46 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 29 Jun 2022 06:34:46 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 29 Jun 2022 06:34:46 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 29 Jun 2022 06:34:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZifzrG5k0RKpn+4zCvIevtlc/ZM7+nd7s6QcGe6ewN9xd4p3lGA5DwIf3xBYPgPV0lpHw5tbTjpBvxKcuDzA/H6fJ3JwrRaVKdSUNyuQL/4e7hqhCAMHLNQJA55LZLaMA3iWcbfQDi3sdlGLMEWG108egkw14wgboM68BL1CW31vZvpZdManuFZqI1MAXq3EbMjIWTRmcO5DtQOknUcUcg2m5jBTU//2HxxaZ2g+jyk+xnISEXeqbglmTNFiOAKsLbadlfp2NfYzYW7EZXrs69B/1k1skqWR4iMw7c39xC4ELBZ8T1m5JoWVtOf/QYOVO0bLy8Zsl6O+/uzgDiybhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FL9or1yUJAnlTmuYeBzH8wGdKcf1YqJWhrbOt3ZBG0o=; b=lYyqBEt7f9lMAzvE4XJtG0r4Mg/rm8tiZuSCEGRMMGt3W+SrFhBuuC/ATMglYYJtZaJWvbXfhqiZWGe82ryoGT0GjEn31J77HZcHYHBuI/pMb0sPj+1O2xDk+wUuxQ1VLNpLDt/T5ko3BMwnMNH3dC6ps+WzkfRI9iXxfkp7BaV5UgL5rILIgliW3PD/KQTyR5RBw8yTBv07E/0VNy7zEoLvo/mjDuT+/Y6xvwapsxB3Yuu+IAobIKd5Q7cHr/uJHiSSFLn8dP5Mc3Eb/Hi0RjDjmZQ4lV00EJkOP7rxRqEqXQfyEyeFcn5JzxxKBI9ptdpLsd28j66ZV0tpRX5+eQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by DM6PR11MB2873.namprd11.prod.outlook.com (2603:10b6:5:bd::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.18; Wed, 29 Jun 2022 13:34:27 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::54a0:2dbc:18b7:2aa9]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::54a0:2dbc:18b7:2aa9%7]) with mapi id 15.20.5373.018; Wed, 29 Jun 2022 13:34:27 +0000 From: "Xia, Chenbo" To: David Marchand , "dev@dpdk.org" CC: "maxime.coquelin@redhat.com" , "Wang, YuanX" , "Ding, Xuan" , "ferruh.yigit@xilinx.com" Subject: RE: [PATCH 2/4] vhost: restore device information in log messages Thread-Topic: [PATCH 2/4] vhost: restore device information in log messages Thread-Index: AQHYiggyc20qG58QK0+HHXSdx+5US61mZEpw Date: Wed, 29 Jun 2022 13:34:27 +0000 Message-ID: References: <20220627092728.78214-1-david.marchand@redhat.com> <20220627092728.78214-3-david.marchand@redhat.com> In-Reply-To: <20220627092728.78214-3-david.marchand@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 63626dcd-48a8-41c1-ec33-08da59d41674 x-ms-traffictypediagnostic: DM6PR11MB2873:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rsWV6iZiV9Uqw3Deisy7U5XSU3FdGzY3k3o307qQpn727G+u2NgqGQf9VKQydgac0RpZECturpY+CdJZ89SGTMgkwPp98ayvEIA79IiWDnp8lBnCBKdFch6WYG0V0bMQ9x8NqlTHqmUi3CYZdi1aQuVXg/e76qgt/MeNsh6mCyIymIFrIF6b5jPCcfdMDHFcIpiL2fe0pwvgh2wURMGhN7B+Lxn4SQRbaoTDDsLxkUqCagVHdI/R6lMk7QhHoqGkndEg8WswQCd8+pN5YVrXgBfKgjvjGXvuGtjINFV9xYEBh/j7U/VH+AjcEGcYfWO4ozjRwDyi2PLweMN9dfFqQGvHFDypstAUtSThfsOmObqoAa9fMVnr/0z3KOAT/eV5kmtzruK6Lwkxx7Vet6aPeYzsml8x1W4P2eED8Fu9ht16YrOTcQCRpOh/F4m5a5nZS0h7+TGO1UFnClLOU20jaTJLf8vmNI9mYNl6dP21tgBN/LHkSXN1lSkE+/J0H6Jk8eNuwp4BtzsZLAeS5yan4qzIMnMkEkno6eNmFAMRmpfIUD/r8cnsKX/YFtl3dCMCozQamwO5TpGzo1JqvXQNqdfArTaeMhfeduVoWZpnUx2sNcp2nGyI/bVZpL4qpnP+X8wmMSFxk7vh4loB6Bviw/UYfvG4/XmoqWwKprVFl7RnIyftM65mUSi5y0R7my+5YZCMzI60DTz6P+1DJqCRVXd5Mw81DvgB9J3Ap89rlqcCHZDUiStQxXoaCnx4OgtQADV3CPiHFdbnKsKaY6ImqSEYIn3HQJCXHwngw6xr4k4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(376002)(366004)(136003)(39860400002)(346002)(33656002)(41300700001)(478600001)(38070700005)(82960400001)(66556008)(52536014)(86362001)(8936002)(26005)(4326008)(7696005)(5660300002)(6506007)(64756008)(66946007)(8676002)(76116006)(122000001)(66476007)(66446008)(53546011)(316002)(2906002)(38100700002)(55016003)(83380400001)(71200400001)(9686003)(15650500001)(110136005)(186003)(54906003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?J6C8x1d+SydUzcS6scVF/avVcZg3CcO5vP2A7X9nXTWkFdY1RhhL520WtpMN?= =?us-ascii?Q?T8HzLwUF9lMgR74IqS2WUmB6pdw1j30Xwe84ThB1rU5bsu4ZTft76ge3sfUh?= =?us-ascii?Q?EDBLsxbxDTOk0wNfKjRFCQJApI9rO0K8YXvSejvC92wKbqzU08yQmqBHhaFr?= =?us-ascii?Q?VVkCVTdPxQ0m1/JE9HIrwncQoP6CaISpvKuTX9xDsJ7q6uTVX6cv4VsgnK4F?= =?us-ascii?Q?MplS74xwWhpn/ALRxhIBqEPtQ8doAt7ICOsa30mZjvfcBaa9rwrQqrqcxnzm?= =?us-ascii?Q?PQUPsDHcts1Y5ZgpxthvEwIdFaz1gBOEL2WpI7si8564JRAuTzqswPmIblZ+?= =?us-ascii?Q?4rsa6CW2f5E7bO6uIn+XrgN9F0DtoMPFcBEr9cqKe4Eyw0OoWXI043oD2OmN?= =?us-ascii?Q?3vzSrd1NKUCNh6QQCLgQp4aDhZxMgMv5yUFoeOPWx/iv/zHgKbNAoSIs0V6k?= =?us-ascii?Q?xskbIxi9GMWFvRVf3kpx5bTEl1TAs9chXTw9OwcW9DPx4ytuuAAKP32nj/+z?= =?us-ascii?Q?G2Iwq8ElrRgaycRLfACmmhnoWRqwUtwWlGRB3mnXyrPnupanf8c6h8kLGiko?= =?us-ascii?Q?vto/VL9Y8ZzbgD4mOSJUJWwvaGqkKcRM9D15v3sdCte+zBHNU8Z5iQVBG4bD?= =?us-ascii?Q?Oc/n4JE1hj4DFAGTBGj+OzzcvjnREyb+SUYwkvRqL5DDHGtM+BhpL4FgH0MV?= =?us-ascii?Q?z0mnb7pbGEQhNyQqmyiI6IXGn/vzYtkz+b/5mm5NSbGSjXDPHOgg1WUgy1ql?= =?us-ascii?Q?RPejuKI2Iny+vWtL8Awc7RhpF4Ntu1s0NtWAvsObfuesMUCD1EkLuNU1FHLJ?= =?us-ascii?Q?3+T479vsLPZ91gFd6uyxpDTWiajdBWPi6J+yXkt83OjppL5hDvZCYAXw1ey1?= =?us-ascii?Q?IMWtFZGNGXfuvMt8PhnvKcD6pQOPCSQv7KfZTrwP95WnvhdHiLvTK0aShjct?= =?us-ascii?Q?nH1MR/BuPZ0h5ecyJHtzbpPUPNiMndAefSIjPs48iJ9Zy9m/yrNPyYKNw46S?= =?us-ascii?Q?leGAWGb6d++Q6IdZHhsbhq1rWXUyXYd1mfvXfPYlU04T36IrMufaK1uYLZ0T?= =?us-ascii?Q?glHxUbgdb//ItJ0COn1qRnGOGu1LR10scFf68ETQ0dcht5NE7CLYNBjQXweL?= =?us-ascii?Q?OC3vFwIvXlGjsyIMr3zplHmG6FdysEQeeQBkVG9ToN9uPi7nn7KLLQAg/0Ko?= =?us-ascii?Q?araCi2pam5aQXVLTaHkCRAZKeA2f8lFWDCTomfvu5lErZM/F9DYVSiXEyoz2?= =?us-ascii?Q?gyxvMMC6eS2/zkiQ7H4PgPk1mhaz+Lwt7ooruFjTw1Y4H798LCQ33CWoXRmm?= =?us-ascii?Q?2M4vKlQCCQJiT2pQ1m/nBI6dPpmu22ICCmgJVmPRytU6Rm83mvh8y6p3x4yn?= =?us-ascii?Q?JjoOUHLmS27yplWBxlflxhyPnXxu24ta1GPVTMC8lNIOaWVdVHbbdAi25Gwy?= =?us-ascii?Q?7lba4go73qiTD/9aXcXh8vFGTEqywxJuq5twh9yh10781uuHVp4FJfpt+rSV?= =?us-ascii?Q?Qw5fNcfdUIM8D5C3cz1Uqj+uSnvHD2zIQVCi7IwaBWA2t2mvNIY8ICBF7nKB?= =?us-ascii?Q?9+jGal1tLXgveh2JMD5c0N1MpNZQxn9KYjoUJIIC?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63626dcd-48a8-41c1-ec33-08da59d41674 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2022 13:34:27.0421 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 02Eye5aEQzVVKgYrAzm0ecZa7bvFLtTuOaZaLh1tPWrRkFrjGcfm3LfCCmu77xPcRIY6Et/XcPGr4uGXkYjlGw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2873 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi David, > -----Original Message----- > From: David Marchand > Sent: Monday, June 27, 2022 5:27 PM > To: dev@dpdk.org > Cc: maxime.coquelin@redhat.com; Xia, Chenbo ; Wang, > YuanX ; Ding, Xuan > Subject: [PATCH 2/4] vhost: restore device information in log messages >=20 > device information in the log messages was dropped. >=20 > Fixes: 52ade97e3641 ("vhost: fix physical address mapping") Should we add cc-stable tag in this case as it's 22.03 commit? Last time when I asked Ferruh, he said although now we don't maintain non-LTS release, we should still add this tag. Not sure this changed or not. For the patch: Reviewed-by: Chenbo Xia >=20 > Signed-off-by: David Marchand > --- > lib/vhost/vhost_user.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) >=20 > diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c > index 2b9a3b69fa..f324f822d6 100644 > --- a/lib/vhost/vhost_user.c > +++ b/lib/vhost/vhost_user.c > @@ -144,7 +144,8 @@ async_dma_map(struct virtio_net *dev, bool do_map) > return; >=20 > /* DMA mapping errors won't stop > VHOST_USER_SET_MEM_TABLE. */ > - VHOST_LOG_CONFIG(ERR, "DMA engine map failed\n"); > + VHOST_LOG_CONFIG(ERR, "(%s) DMA engine map > failed\n", > + dev->ifname); > } > } >=20 > @@ -160,7 +161,8 @@ async_dma_map(struct virtio_net *dev, bool do_map) > if (rte_errno =3D=3D EINVAL) > return; >=20 > - VHOST_LOG_CONFIG(ERR, "DMA engine unmap failed\n"); > + VHOST_LOG_CONFIG(ERR, "(%s) DMA engine unmap > failed\n", > + dev->ifname); > } > } > } > @@ -945,7 +947,8 @@ add_one_guest_page(struct virtio_net *dev, uint64_t > guest_phys_addr, > dev->max_guest_pages * sizeof(*page), > RTE_CACHE_LINE_SIZE); > if (dev->guest_pages =3D=3D NULL) { > - VHOST_LOG_CONFIG(ERR, "cannot realloc guest_pages\n"); > + VHOST_LOG_CONFIG(ERR, "(%s) cannot realloc > guest_pages\n", > + dev->ifname); > rte_free(old_pages); > return -1; > } > -- > 2.36.1